Re: svn commit: r252514 - head/sbin/swapon

2013-07-02 Thread Alexey Dokuchaev
On Tue, Jul 02, 2013 at 05:34:35PM +, Xin LI wrote: > New Revision: 252514 > URL: http://svnweb.freebsd.org/changeset/base/252514 > > Log: > Plug a memory leak. Is MFC to stable/[89] applicable? If yes, can it be scheduled? ;-) ./danfe ___ svn-s

Re: svn commit: r252516 - head/usr.sbin/bsnmpd/modules/snmp_hast

2013-07-02 Thread Mikolaj Golub
On Tue, Jul 02, 2013 at 11:40:50PM +0200, Jilles Tjoelker wrote: > > +hastResourceWorkerPid OBJECT-TYPE > > +SYNTAX INTEGER > > +MAX-ACCESS read-write > > I think MAX-ACCESS should be read-only here. The process ID is assigned > when the worker process is created and it makes no sense

svn commit: r252540 - head/usr.sbin/bsnmpd/modules/snmp_hast

2013-07-02 Thread Mikolaj Golub
Author: trociny Date: Wed Jul 3 05:54:23 2013 New Revision: 252540 URL: http://svnweb.freebsd.org/changeset/base/252540 Log: hastResourceWorkerPid is read-only. Submitted by: jilles MFC after:3 days Modified: head/usr.sbin/bsnmpd/modules/snmp_hast/BEGEMOT-HAST-MIB.txt Modified: h

Re: RAND_MAX broken

2013-07-02 Thread Bruce Evans
On Wed, 3 Jul 2013, Andrey Chernov wrote: On 02.07.2013 20:33, Bruce Evans wrote: I checked the values returned by rand(). The ACM part works as intended, so it never returns RAND_MAX. It also never returns 0. So the distribution of values in the documented range [0, RAND_MAX] is very non-un

Re: should_yield problem [Was: svn commit: r251322 - head/sys/kern]

2013-07-02 Thread Bruce Evans
On Tue, 2 Jul 2013, Andriy Gapon wrote: on 02/07/2013 20:52 Attilio Rao said the following: I was just pointing out that the real bug is not in the subtraction itself but on the hogticks comparison. This is because hogticks is not an absolute measurement but it represents really a ticks differe

Re: svn commit: r252346 - head/share/man/man9

2013-07-02 Thread Julian Elischer
On 7/3/13 12:00 AM, John Baldwin wrote: On 6/29/13 6:37 AM, Julian Elischer wrote: On 6/29/13 9:16 PM, Julian Elischer wrote: thanks! -If the owner is not currently actually running then the spin step is skipped. +then a thread attempting to acquire the mutex will spin rather than yielding +

Re: svn commit: r252527 - head/sys/ufs/ffs

2013-07-02 Thread Bruce Evans
On Tue, 2 Jul 2013, Kirk McKusick wrote: Log: Make better use of metadata area by avoiding using it for data blocks that no should no longer immediately follow their indirect blocks. I use the following changes for allocation at the start of cylinder group. They seem to be related. % diff -

svn commit: r252528 - head/sys/fs/nfsclient

2013-07-02 Thread Rick Macklem
Author: rmacklem Date: Wed Jul 3 00:19:03 2013 New Revision: 252528 URL: http://svnweb.freebsd.org/changeset/base/252528 Log: A problem with the old NFS client where large writes to large files would sometimes result in a corrupted file was reported via email. This problem appears to have b

Re: svn commit: r252516 - head/usr.sbin/bsnmpd/modules/snmp_hast

2013-07-02 Thread Jilles Tjoelker
On Tue, Jul 02, 2013 at 06:54:39PM +, Mikolaj Golub wrote: > Author: trociny > Date: Tue Jul 2 18:54:39 2013 > New Revision: 252516 > URL: http://svnweb.freebsd.org/changeset/base/252516 > Log: > Add a mib for worker process ID. > MFC after: 3 days > Modified: > head/usr.sbin/bsnmpd/

svn commit: r252527 - head/sys/ufs/ffs

2013-07-02 Thread Kirk McKusick
Author: mckusick Date: Tue Jul 2 21:07:08 2013 New Revision: 252527 URL: http://svnweb.freebsd.org/changeset/base/252527 Log: Make better use of metadata area by avoiding using it for data blocks that no should no longer immediately follow their indirect blocks. MFC after:2 weeks Mo

svn commit: r252526 - head/share/man/man4

2013-07-02 Thread Eitan Adler
Author: eadler Date: Tue Jul 2 20:25:58 2013 New Revision: 252526 URL: http://svnweb.freebsd.org/changeset/base/252526 Log: Remove extranious '.' Submitted by: swild...@dragonflybsd.org Modified: head/share/man/man4/oce.4 Modified: head/share/man/man4/oce.4

Re: RAND_MAX broken

2013-07-02 Thread Andrey Chernov
On 02.07.2013 20:33, Bruce Evans wrote: > I checked the values returned by rand(). The ACM part works as > intended, so it never returns RAND_MAX. It also never returns 0. So > the distribution of values in the documented range [0, RAND_MAX] is > very non-uniform. It is uniform in [1, RAND_MAX

svn commit: r252523 - head/sbin/mdconfig

2013-07-02 Thread Xin LI
Author: delphij Date: Tue Jul 2 19:42:47 2013 New Revision: 252523 URL: http://svnweb.freebsd.org/changeset/base/252523 Log: When listing with -f, skip all memory disks that are not vnode-backed. Noticed by: kevlo MFC after:3 days Modified: head/sbin/mdconfig/mdconfig.c Modifie

svn commit: r252522 - head/sys/arm/conf

2013-07-02 Thread Andrew Turner
Author: andrew Date: Tue Jul 2 19:35:04 2013 New Revision: 252522 URL: http://svnweb.freebsd.org/changeset/base/252522 Log: Enable VFP on Raspberry Pi. This has worked as of r251712. Modified: head/sys/arm/conf/RPI-B Modified: head/sys/arm/conf/RPI-B

svn commit: r252516 - head/usr.sbin/bsnmpd/modules/snmp_hast

2013-07-02 Thread Mikolaj Golub
Author: trociny Date: Tue Jul 2 18:54:39 2013 New Revision: 252516 URL: http://svnweb.freebsd.org/changeset/base/252516 Log: Add a mib for worker process ID. MFC after:3 days Modified: head/usr.sbin/bsnmpd/modules/snmp_hast/BEGEMOT-HAST-MIB.txt head/usr.sbin/bsnmpd/modules/snmp_ha

svn commit: r252515 - head/sys/ufs/ffs

2013-07-02 Thread Pedro F. Giffuni
Author: pfg Date: Tue Jul 2 18:45:37 2013 New Revision: 252515 URL: http://svnweb.freebsd.org/changeset/base/252515 Log: Style fix: spaces. Cleanup the incomplete revert. Reported by: bde MFC after:4 weeks Modified: head/sys/ufs/ffs/ffs_vfsops.c Modified: head/sys/ufs/ffs/f

Re: should_yield problem [Was: svn commit: r251322 - head/sys/kern]

2013-07-02 Thread Andriy Gapon
on 02/07/2013 20:59 Ed Maste said the following: > On 2 July 2013 12:48, Andriy Gapon wrote: >> I am not sure if the originally reported problem was also caused by >> should_yield() or if it was something else. But in either case I think that >> we >> should fix should_yield. Perhaps (ticks - c

Re: should_yield problem [Was: svn commit: r251322 - head/sys/kern]

2013-07-02 Thread Andriy Gapon
on 02/07/2013 20:52 Attilio Rao said the following: > I was just pointing out that the real bug is not in the subtraction > itself but on the hogticks comparison. > This is because hogticks is not an absolute measurement but it > represents really a ticks difference. > In my opinion we should defin

Re: should_yield problem [Was: svn commit: r251322 - head/sys/kern]

2013-07-02 Thread Ed Maste
On 2 July 2013 12:48, Andriy Gapon wrote: > I am not sure if the originally reported problem was also caused by > should_yield() or if it was something else. But in either case I think that > we > should fix should_yield. Perhaps (ticks - curthread->td_swvoltick) should be > cast to unsigned be

Re: should_yield problem [Was: svn commit: r251322 - head/sys/kern]

2013-07-02 Thread Attilio Rao
On Tue, Jul 2, 2013 at 7:24 PM, Andriy Gapon wrote: > on 02/07/2013 20:12 Attilio Rao said the following: >> While "ticks" is signed it is used as an unsigned int. >> td_swvolticks is always derived by ticks, which again will always be >> used as an unisgned and then the subtractions among the 2 w

svn commit: r252514 - head/sbin/swapon

2013-07-02 Thread Xin LI
Author: delphij Date: Tue Jul 2 17:34:34 2013 New Revision: 252514 URL: http://svnweb.freebsd.org/changeset/base/252514 Log: Plug a memory leak. Modified: head/sbin/swapon/swapon.c Modified: head/sbin/swapon/swapon.c ==

Re: should_yield problem [Was: svn commit: r251322 - head/sys/kern]

2013-07-02 Thread Andriy Gapon
on 02/07/2013 20:12 Attilio Rao said the following: > While "ticks" is signed it is used as an unsigned int. > td_swvolticks is always derived by ticks, which again will always be > used as an unisgned and then the subtractions among the 2 will be > consistent. So returning to my example where tic

svn commit: r252513 - head/gnu/usr.bin/patch

2013-07-02 Thread David E. O'Brien
Author: obrien Date: Tue Jul 2 17:17:42 2013 New Revision: 252513 URL: http://svnweb.freebsd.org/changeset/base/252513 Log: Properly handle input lines containing NUL characters such that pgets() accurately fills the read buffer. Callers of pgets() still mis-process the buffer contents i

Re: should_yield problem [Was: svn commit: r251322 - head/sys/kern]

2013-07-02 Thread Attilio Rao
On Tue, Jul 2, 2013 at 6:48 PM, Andriy Gapon wrote: > on 03/06/2013 20:36 Konstantin Belousov said the following: >> Author: kib >> Date: Mon Jun 3 17:36:43 2013 >> New Revision: 251322 >> URL: http://svnweb.freebsd.org/changeset/base/251322 >> >> Log: >> Be more generous when donating the curr

svn commit: r252512 - head/gnu/usr.bin/patch

2013-07-02 Thread David E. O'Brien
Author: obrien Date: Tue Jul 2 17:09:57 2013 New Revision: 252512 URL: http://svnweb.freebsd.org/changeset/base/252512 Log: Make it so that 'patch < FUBAR' and 'patch -i FUBAR' operate the same. The former makes a copy of stdin, but was not accurately putting the content of stdin into a

svn commit: r252511 - in head/sys: net netinet6

2013-07-02 Thread Hiroki Sato
Author: hrs Date: Tue Jul 2 16:58:15 2013 New Revision: 252511 URL: http://svnweb.freebsd.org/changeset/base/252511 Log: - Allow ND6_IFF_AUTO_LINKLOCAL for IFT_BRIDGE. An interface with IFT_BRIDGE is initialized with !ND6_IFF_AUTO_LINKLOCAL && !ND6_IFF_ACCEPT_RTADV regardless of net.in

should_yield problem [Was: svn commit: r251322 - head/sys/kern]

2013-07-02 Thread Andriy Gapon
on 03/06/2013 20:36 Konstantin Belousov said the following: > Author: kib > Date: Mon Jun 3 17:36:43 2013 > New Revision: 251322 > URL: http://svnweb.freebsd.org/changeset/base/251322 > > Log: > Be more generous when donating the current thread time to the owner of > the vnode lock while iter

svn commit: r252510 - head/sys/netinet

2013-07-02 Thread Hiroki Sato
Author: hrs Date: Tue Jul 2 16:39:12 2013 New Revision: 252510 URL: http://svnweb.freebsd.org/changeset/base/252510 Log: Fix a panic when leaving MC group in a kernel with VIMAGE enabled. in_leavegroup() is called from an asynchronous task, and igmp_change_state() requires that curvnet is s

Re: RAND_MAX broken

2013-07-02 Thread Bruce Evans
On Tue, 2 Jul 2013, Andrey Chernov wrote: On 02.07.2013 11:39, Bruce Evans wrote: The bugs are a little different than I said above. There is no overflow problem and no problem with invalid values being produces, since the algorithm from ACM is careful to do everything with 32 bit signed integ

Re: svn commit: r252346 - head/share/man/man9

2013-07-02 Thread John Baldwin
On 6/29/13 6:37 AM, Julian Elischer wrote: > On 6/29/13 9:16 PM, Julian Elischer wrote: >> thanks! >> >> >>> -If the owner is not currently actually running then the spin step is >>> skipped. >>> +then a thread attempting to acquire the mutex will spin rather than >>> yielding >>> +the processor. >

Re: RAND_MAX broken

2013-07-02 Thread Andrey Chernov
On 02.07.2013 11:39, Bruce Evans wrote: > The bugs are a little different than I said above. There is no overflow > problem and no problem with invalid values being produces, since the > algorithm from ACM is careful to do everything with 32 bit signed > integers without causing overflow. The alg

svn commit: r252508 - head/sbin/devd

2013-07-02 Thread Alan Somers
Author: asomers Date: Tue Jul 2 14:48:39 2013 New Revision: 252508 URL: http://svnweb.freebsd.org/changeset/base/252508 Log: Explicitly include to fix compilation with libc++. It is implicitly included by libstdc++. Reported By: Oliver Hartmann Approved by: gibbs (co-mentor, implicit

svn commit: r252506 - head/sbin/dhclient

2013-07-02 Thread Bruce M Simpson
Author: bms Date: Tue Jul 2 13:24:37 2013 New Revision: 252506 URL: http://svnweb.freebsd.org/changeset/base/252506 Log: When acquiring a lease, record the value of the BOOTP siaddr field contained in the DHCP offer, and write it out to the lease file as an unquoted value of the "next-serve

svn commit: r252505 - head/sys/conf

2013-07-02 Thread Glen Barber
Author: gjb Date: Tue Jul 2 10:36:57 2013 New Revision: 252505 URL: http://svnweb.freebsd.org/changeset/base/252505 Log: - Update newvers.sh to include svn revision in uname(1) if the system has svnliteversion. - If svnliteversion is not found, look for svnversion in /usr/bin and /usr

svn commit: r252504 - in head: share/man/man4 sys/modules/cc sys/modules/cc/cc_cdg sys/netinet/cc

2013-07-02 Thread Lawrence Stewart
Author: lstewart Date: Tue Jul 2 08:44:56 2013 New Revision: 252504 URL: http://svnweb.freebsd.org/changeset/base/252504 Log: Import an implementation of the CAIA Delay-Gradient (CDG) congestion control algorithm, which is based on the 2011 v0.1 patch release and described in the paper "Rev

svn commit: r252503 - head/contrib/llvm/lib/Target/ARM

2013-07-02 Thread Andrew Turner
Author: andrew Date: Tue Jul 2 08:04:41 2013 New Revision: 252503 URL: http://svnweb.freebsd.org/changeset/base/252503 Log: Work around an ARM EABI issue where clang would sometimes incorrectly align the stack in a leaf function that uses TLS. The issue is, when using TLS, the function i

RAND_MAX broken (was: Re: svn commit: r252484 - head/sys/ufs/ffs)

2013-07-02 Thread Bruce Evans
On Tue, 2 Jul 2013, Bruce Evans wrote: ... Also, random(9) is internally broken on 64-bit arches. It shouldn't exist. It is not random() at all, but just rand() with the clamp to RAND_MAX removed. Its linear congruential generator is suboptimal for 64 bits, and other parts of its algorithm ar

svn commit: r252502 - head/sys/kern

2013-07-02 Thread Mateusz Guzik
Author: mjg Date: Tue Jul 2 07:36:04 2013 New Revision: 252502 URL: http://svnweb.freebsd.org/changeset/base/252502 Log: Fix receiving fd over unix socket broken in r247740. If n fds were passed, it would receive the first one n times. Reported by: Shawn Webb , koobs, gleb Tested b

svn commit: r252501 - in head/sys/dev/usb: . quirk

2013-07-02 Thread Hiroki Sato
Author: hrs Date: Tue Jul 2 07:35:57 2013 New Revision: 252501 URL: http://svnweb.freebsd.org/changeset/base/252501 Log: Add Planex MZK-UE150N. Submitted by: Yusuke Tanaka MFC after:3 days Modified: head/sys/dev/usb/quirk/usb_quirk.c head/sys/dev/usb/usbdevs Modified: head/sys/

svn commit: r252500 - head/sys/powerpc/wii

2013-07-02 Thread Rui Paulo
Author: rpaulo Date: Tue Jul 2 07:17:56 2013 New Revision: 252500 URL: http://svnweb.freebsd.org/changeset/base/252500 Log: Fix indentation. Submitted by: jmallet Modified: head/sys/powerpc/wii/wii_ipcreg.h Modified: head/sys/powerpc/wii/wii_ipcreg.h ===

svn commit: r252499 - head/sys/powerpc/wii

2013-07-02 Thread Rui Paulo
Author: rpaulo Date: Tue Jul 2 06:59:37 2013 New Revision: 252499 URL: http://svnweb.freebsd.org/changeset/base/252499 Log: Add register definitions for the Wii IPC system. Modified: head/sys/powerpc/wii/wii_ipcreg.h Modified: head/sys/powerpc/wii/wii_ipcreg.h ==