Re: svn commit: r250432 - head/usr.bin/split

2013-05-10 Thread Eitan Adler
On 10 May 2013 13:05, Benjamin Kaduk wrote: > This check relies on signed integer overflow, which is undefined behavior. > Furthermore, even if one assumes a non-evil compiler and two's complement > representation, this check fails for pattlen == 10. > 10**9 is representable as both a signed and

svn commit: r250495 - head/sys/amd64/amd64

2013-05-10 Thread Rui Paulo
Author: rpaulo Date: Sat May 11 01:31:51 2013 New Revision: 250495 URL: http://svnweb.freebsd.org/changeset/base/250495 Log: Fix several standard extended feature bits. Submitted by: Oliver Pinter Modified: head/sys/amd64/amd64/identcpu.c Modified: head/sys/amd64/amd64/identcpu.c =

svn commit: r250487 - head/sys/x86/cpufreq

2013-05-10 Thread Hiren Panchasara
Author: hiren Date: Fri May 10 22:43:27 2013 New Revision: 250487 URL: http://svnweb.freebsd.org/changeset/base/250487 Log: Adding a detach method to p4tcc driver. PR: 118739 Submitted by: Dan Lukes (earlier version) Reviewed by: jhb Approved by: sbruno (mentor) MFC after:1

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread John Baldwin
On Friday, May 10, 2013 2:51:20 pm Marcel Moolenaar wrote: > > On May 10, 2013, at 9:11 AM, John Baldwin wrote: > > > On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote: > >>> > >>> 2) vnode locks from a local filesystem that report a LOR with a "devfs" > >>> vnode. Typical reports ar

svn commit: r250477 - head/usr.bin/calendar/calendars

2013-05-10 Thread Xin LI
Author: delphij Date: Fri May 10 20:02:15 2013 New Revision: 250477 URL: http://svnweb.freebsd.org/changeset/base/250477 Log: REST IN PEACE Alexander Botero-Lowry Born June 2, 1986 in Austin, Texas Died August 24, 2012 in San Francisco, California Thank you for your co

Re: svn commit: r250463 - head/usr.sbin/mergemaster

2013-05-10 Thread Garrett Cooper
On Fri, May 10, 2013 at 12:32 PM, Eitan Adler wrote: ... > Yes, sorry for not including the PR number. No worries :). Thanks for the fix! -Garrett ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsu

Re: svn commit: r250463 - head/usr.sbin/mergemaster

2013-05-10 Thread Eitan Adler
On 10 May 2013 15:09, Garrett Cooper wrote: > On Fri, May 10, 2013 at 10:42 AM, Eitan Adler wrote: >> Author: eadler >> Date: Fri May 10 17:42:13 2013 >> New Revision: 250463 >> URL: http://svnweb.freebsd.org/changeset/base/250463 >> >> Log: >> Permit relative paths with mergemaster -m >> >>

Re: svn commit: r250463 - head/usr.sbin/mergemaster

2013-05-10 Thread Garrett Cooper
On Fri, May 10, 2013 at 10:42 AM, Eitan Adler wrote: > Author: eadler > Date: Fri May 10 17:42:13 2013 > New Revision: 250463 > URL: http://svnweb.freebsd.org/changeset/base/250463 > > Log: > Permit relative paths with mergemaster -m > > Reviewed by: dim, brooks > MFC after:3 days > > M

Re: svn commit: r250379 - in head/usr.sbin/bsnmpd/modules: . snmp_hast

2013-05-10 Thread Pawel Jakub Dawidek
On Thu, May 09, 2013 at 01:05:35PM +0300, Mikolaj Golub wrote: > On Thu, May 09, 2013 at 11:22:43AM +0300, Konstantin Belousov wrote: > > Why do you need libl.a ? If only for yywrap(), then re-implementing > > it for the module seems to be trivial. > > Yes, it is like so. Thanks! I am now consider

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread Marcel Moolenaar
On May 10, 2013, at 9:11 AM, John Baldwin wrote: > On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote: >>> >>> 2) vnode locks from a local filesystem that report a LOR with a "devfs" >>> vnode. Typical reports are either "ufs" -> "devfs" or in some cases >>> "ufs" -> "devfs" -> "ufs"

svn commit: r250469 - head/bin/dd

2013-05-10 Thread Eitan Adler
Author: eadler Date: Fri May 10 18:43:36 2013 New Revision: 250469 URL: http://svnweb.freebsd.org/changeset/base/250469 Log: Make dd's signal handler async safe. PR: bin/75258 Submitted by: "Oleg V. Nauman" Arrival Date: Sun Dec 19 14:50:21 GMT 2004 Reviewed by: mjg, jhb

svn commit: r250466 - in head/sys: netinet netinet6

2013-05-10 Thread Michael Tuexen
Author: tuexen Date: Fri May 10 18:09:38 2013 New Revision: 250466 URL: http://svnweb.freebsd.org/changeset/base/250466 Log: Honor the net.inet6.ip6.v6only sysctl variable and the IPV6_V6ONLY socket option for SCTP sockets in the same way as for UDP or TCP sockets. MFC after: 2 weeks M

Re: svn commit: r250462 - head/usr.bin/lockf

2013-05-10 Thread Mateusz Guzik
On Fri, May 10, 2013 at 05:30:30PM +, Eitan Adler wrote: > Author: eadler > Date: Fri May 10 17:30:29 2013 > New Revision: 250462 > URL: http://svnweb.freebsd.org/changeset/base/250462 > > Log: > Add option to lockf to avoid creating a file if it does not exist. > Patch seems to be incom

svn commit: r250463 - head/usr.sbin/mergemaster

2013-05-10 Thread Eitan Adler
Author: eadler Date: Fri May 10 17:42:13 2013 New Revision: 250463 URL: http://svnweb.freebsd.org/changeset/base/250463 Log: Permit relative paths with mergemaster -m Reviewed by: dim, brooks MFC after:3 days Modified: head/usr.sbin/mergemaster/mergemaster.sh Modified: head/usr.s

svn commit: r250462 - head/usr.bin/lockf

2013-05-10 Thread Eitan Adler
Author: eadler Date: Fri May 10 17:30:29 2013 New Revision: 250462 URL: http://svnweb.freebsd.org/changeset/base/250462 Log: Add option to lockf to avoid creating a file if it does not exist. PR: bin/170775 Submitted by: Matthew Story Reviewed by: scottl MFC after:1 week Modi

Re: svn commit: r250432 - head/usr.bin/split

2013-05-10 Thread Benjamin Kaduk
On Fri, May 10, 2013 at 12:23 AM, Eitan Adler wrote: > Modified: head/usr.bin/split/split.c > > == > --- head/usr.bin/split/split.c Fri May 10 03:49:05 2013(r250431) > +++ head/usr.bin/split/split.c Fri May 10 0

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread Alfred Perlstein
On 5/10/13 8:46 AM, Marcel Moolenaar wrote: And all I did is to allow someone (= Juniper) to not print the LOR for this well-known and mostly ignored case that is impacting our ability to keep witness enabled. And the reason I had to do that is that this is a long-standing LOR that isn't being a

svn commit: r250460 - in head: share/examples/ppi share/misc sys/cam/ctl sys/cam/scsi sys/dev/aic7xxx sys/dev/cp sys/dev/ctau sys/dev/cx sys/dev/hptmv sys/dev/isci/scil sys/dev/nsp sys/dev/sfxge/co...

2013-05-10 Thread Eitan Adler
Author: eadler Date: Fri May 10 16:41:26 2013 New Revision: 250460 URL: http://svnweb.freebsd.org/changeset/base/250460 Log: Fxi a bunch of typos. PR: misc/174625 Submitted by: Jeremy Chadwick Modified: head/share/examples/ppi/ppilcd.c head/share/misc/pci_vendors head/sys/cam/ct

svn commit: r250459 - head/share/syscons/fonts

2013-05-10 Thread Eitan Adler
Author: eadler Date: Fri May 10 16:30:39 2013 New Revision: 250459 URL: http://svnweb.freebsd.org/changeset/base/250459 Log: Add the letter 'q' to the font iso05-8x16.fnt PR: 72585 PR: 169797 Submitted by: Takefu Submitted by: Satoshi KImura Modified: head/share/syscons/fonts

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread John Baldwin
On Friday, May 10, 2013 11:46:54 am Marcel Moolenaar wrote: > > > > 2) vnode locks from a local filesystem that report a LOR with a "devfs" > > vnode. Typical reports are either "ufs" -> "devfs" or in some cases > > "ufs" -> "devfs" -> "ufs". As with 1), I would much rather tag the > > off

Re: svn commit: r250220 - head/sys/kern

2013-05-10 Thread John Baldwin
On Thursday, May 09, 2013 11:05:46 pm Bruce Evans wrote: > On Mon, 6 May 2013, John Baldwin wrote: > > > On Saturday, May 04, 2013 4:47:43 am Bruce Evans wrote: > >>> Log: > >>> Fix FIONREAD on regular files. The computed result was being ignored and > >>> it was being passed down to VOP_IOCTL(

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread Marcel Moolenaar
On May 10, 2013, at 6:52 AM, John Baldwin wrote: >>> >>> The way to fix this is to implement LK_NOWITNESS on a per-lock basis >>> into lockmgr, propagate the same concept to the vn_lock() (which >>> should be basically done automatically) and finally identify the >>> false-positive case and comm

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread David Chisnall
On 10 May 2013, at 10:12, Eitan Adler wrote: > I don't remember any recent tool which uses that cast > to remove errors. clang -Wunused-result gcc -Wunused-result David ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/list

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread Eitan Adler
On 10 May 2013 10:08, David Chisnall wrote: > On 10 May 2013, at 10:01, Eitan Adler wrote: > >> I thought style(9) disliked the leading (void) but I could be wrong. > > The cast to (void) tells the compiler that you are ignoring the return > result. Without it, you will introduce new warnings a

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread David Chisnall
On 10 May 2013, at 10:01, Eitan Adler wrote: > I thought style(9) disliked the leading (void) but I could be wrong. The cast to (void) tells the compiler that you are ignoring the return result. Without it, you will introduce new warnings and break the build on certain compiler versions with

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread Eitan Adler
On 10 May 2013 09:36, Alexey Dokuchaev wrote: > Of course. But my question was about dropping the cast, not adding new > option. Adding a new option should have resulted in the following diff: > > - (void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n"); > + (void)fprintf(st

Re: svn commit: r250411 - in head/sys: conf kern sys

2013-05-10 Thread John Baldwin
On Thursday, May 09, 2013 4:56:33 pm Marcel Moolenaar wrote: > > On May 9, 2013, at 9:46 AM, Attilio Rao wrote: > > > On Thu, May 9, 2013 at 6:28 PM, Marcel Moolenaar wrote: > >> Author: marcel > >> Date: Thu May 9 16:28:18 2013 > >> New Revision: 250411 > >> URL: http://svnweb.freebsd.org/ch

svn commit: r250453 - head/etc

2013-05-10 Thread Eitan Adler
Author: eadler Date: Fri May 10 13:57:44 2013 New Revision: 250453 URL: http://svnweb.freebsd.org/changeset/base/250453 Log: Bring /etc/protocols up to date. PR: conf/175397 Submitted by: ak Modified: head/etc/protocols Modified: head/etc/protocols ==

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread Alexey Dokuchaev
On Fri, May 10, 2013 at 08:43:37AM -0400, Eitan Adler wrote: > On 10 May 2013 03:42, Alexey Dokuchaev wrote: > > On Fri, May 10, 2013 at 03:42:48AM +, Eitan Adler wrote: > >> New Revision: 250430 > >> URL: http://svnweb.freebsd.org/changeset/base/250430 > >> > >> (void) setlocale(LC_CTYP

svn commit: r250451 - in head: sbin/dmesg usr.bin/split

2013-05-10 Thread Eitan Adler
Author: eadler Date: Fri May 10 12:49:16 2013 New Revision: 250451 URL: http://svnweb.freebsd.org/changeset/base/250451 Log: Bump .Dd for recent content change. Reported by: delphij Modified: head/sbin/dmesg/dmesg.8 head/usr.bin/split/split.1 Modified: head/sbin/dmesg/dmesg.8 ===

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread Eitan Adler
On 10 May 2013 03:42, Alexey Dokuchaev wrote: > On Fri, May 10, 2013 at 03:42:48AM +, Eitan Adler wrote: >> New Revision: 250430 >> URL: http://svnweb.freebsd.org/changeset/base/250430 >> >> @@ -79,15 +80,20 @@ main(int argc, char *argv[]) >> kvm_t *kd; >> size_t buflen, bufpos; >>

Re: svn commit: r250431 - head/usr.bin/xargs

2013-05-10 Thread smckay
On Fri 10/05/13 17:50 , Juli Mallett jmall...@freebsd.org sent: > Eitan, > > Are other changes coming to xargs for which these style changes make > sense? If not, I'd say that style changes which only adjust vertical > whitespace, especially those which mostly add vertical whitespace at

svn commit: r250444 - head/sys/dev/ath

2013-05-10 Thread Adrian Chadd
Author: adrian Date: Fri May 10 10:06:45 2013 New Revision: 250444 URL: http://svnweb.freebsd.org/changeset/base/250444 Log: Make sure the holding descriptor and link pointer are both freed during a non-loss reset. When the drain functions are called, the holding descriptor and link point

svn commit: r250443 - head/usr.sbin/ctladm

2013-05-10 Thread Jaakko Heinonen
Author: jh Date: Fri May 10 09:58:32 2013 New Revision: 250443 URL: http://svnweb.freebsd.org/changeset/base/250443 Log: Check the return value of sbuf_finish(). MFC after:1 week Modified: head/usr.sbin/ctladm/ctladm.c Modified: head/usr.sbin/ctladm/ctladm.c

svn commit: r250442 - head/sys/net80211

2013-05-10 Thread Adrian Chadd
Author: adrian Date: Fri May 10 09:37:58 2013 New Revision: 250442 URL: http://svnweb.freebsd.org/changeset/base/250442 Log: Fix a VAP BSS node reference in the HT code to actually take a reference before using said node. The "blessed" way here is to take a node reference before referenci

svn commit: r250441 - head/sys/dev/netmap

2013-05-10 Thread Luigi Rizzo
Author: luigi Date: Fri May 10 08:46:10 2013 New Revision: 250441 URL: http://svnweb.freebsd.org/changeset/base/250441 Log: another minor bugfix in the memory allocator, this time in the free routine. Modified: head/sys/dev/netmap/netmap_mem2.c Modified: head/sys/dev/netmap/netmap_mem2.c ===

Re: svn commit: r250431 - head/usr.bin/xargs

2013-05-10 Thread Juli Mallett
Eitan, Are other changes coming to xargs for which these style changes make sense? If not, I'd say that style changes which only adjust vertical whitespace, especially those which mostly add vertical whitespace at the start of functions with no local variables (which is one of the most archaic an

Re: svn commit: r250430 - head/sbin/dmesg

2013-05-10 Thread Alexey Dokuchaev
On Fri, May 10, 2013 at 03:42:48AM +, Eitan Adler wrote: > New Revision: 250430 > URL: http://svnweb.freebsd.org/changeset/base/250430 > > @@ -79,15 +80,20 @@ main(int argc, char *argv[]) > kvm_t *kd; > size_t buflen, bufpos; > long pri; > - int all, ch; > + int ch, c