Re: svn commit: r230600 - head/lib/libutil

2012-01-26 Thread Bruce Evans
On Thu, 26 Jan 2012, Guy Helmer wrote: Log: Make the comments consistent (capitalization, punctuation, and format). Requested by bde Thanks. Sorry I never got around to replying to your mail that contained a patch for this. It seemed complete and correct. Bruce _

svn commit: r230605 - in head/sys: fs/nfsclient nfsclient

2012-01-26 Thread Rick Macklem
Author: rmacklem Date: Fri Jan 27 02:46:12 2012 New Revision: 230605 URL: http://svn.freebsd.org/changeset/base/230605 Log: A problem with respect to data read through the buffer cache for both NFS clients was reported to freebsd-fs@ under the subject "NFS corruption in recent HEAD" on Nov.

svn commit: r230602 - head/sys/dev/sound/pci

2012-01-26 Thread Pedro F. Giffuni
Author: pfg Date: Thu Jan 26 21:43:11 2012 New Revision: 230602 URL: http://svn.freebsd.org/changeset/base/230602 Log: Minor cleanups to the csa snd driver. Remove unneeded temporary variable (data) to better match the OSS code. Remove some unused constants and type definitions. Test

Re: svn commit: r230545 - head/sys/boot/forth

2012-01-26 Thread Andriy Gapon
on 26/01/2012 13:54 Andriy Gapon said the following: > on 26/01/2012 12:48 Doug Barton said the following: >> On 01/25/2012 13:35, Andriy Gapon wrote: >>> on 25/01/2012 22:52 Doug Barton said the following: On 01/25/2012 11:22, Andriy Gapon wrote: > Besides, 'Safe Boot' seems to be already

svn commit: r230601 - head/lib/libutil

2012-01-26 Thread Guy Helmer
Author: ghelmer Date: Thu Jan 26 20:40:22 2012 New Revision: 230601 URL: http://svn.freebsd.org/changeset/base/230601 Log: Consensus between bde and pjd seemed to be that if the function names are lined up, then any * after a long type should appear after the type instead of being in front o

svn commit: r230600 - head/lib/libutil

2012-01-26 Thread Guy Helmer
Author: ghelmer Date: Thu Jan 26 20:35:01 2012 New Revision: 230600 URL: http://svn.freebsd.org/changeset/base/230600 Log: Make the comments consistent (capitalization, punctuation, and format). Requested by bde Modified: head/lib/libutil/libutil.h Modified: head/lib/libutil/libutil.h

svn commit: r230599 - head/lib/libutil

2012-01-26 Thread Guy Helmer
Author: ghelmer Date: Thu Jan 26 20:33:08 2012 New Revision: 230599 URL: http://svn.freebsd.org/changeset/base/230599 Log: Restore the parenthesis that are necessary around the constant values. Requested by bde. Modified: head/lib/libutil/libutil.h Modified: head/lib/libutil/libutil.h =

svn commit: r230598 - head/sys/net

2012-01-26 Thread Kip Macy
Author: kmacy Date: Thu Jan 26 20:02:40 2012 New Revision: 230598 URL: http://svn.freebsd.org/changeset/base/230598 Log: A flowtable entry can continue referencing an llentry indefinitely if the entry is repeatedly referenced within its timeout window. This change clears the LLE_VALID flag w

svn commit: r230594 - head/share/man/man4

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 19:11:08 2012 New Revision: 230594 URL: http://svn.freebsd.org/changeset/base/230594 Log: - Rewrite paragraphs about preemption. - Avoid word combination "carp interface". Prodded by: az Modified: head/share/man/man4/carp.4 Modified: head/share/man/m

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread Mark Murray
David Schultz writes: > > Although current version with current kernel flags works, I forget > > it is implementation defined in general and not always equal to > > sizeof(int), f.e. with gcc --short-enums. I'll remade it with > > #defines, thanx again. > > Why complicate things with atomics at all

svn commit: r230593 - head/share/man/man4

2012-01-26 Thread Kenneth D. Merry
Author: ken Date: Thu Jan 26 18:18:47 2012 New Revision: 230593 URL: http://svn.freebsd.org/changeset/base/230593 Log: Remove the blank line between the license and .Dd Prompted by: brueffer MFC after:1 week Modified: head/share/man/man4/xnb.4 Modified: head/share/man/man4/xnb.4

svn commit: r230592 - in head/sys: conf dev/mps dev/mps/mpi modules/mps

2012-01-26 Thread Kenneth D. Merry
Author: ken Date: Thu Jan 26 18:17:21 2012 New Revision: 230592 URL: http://svn.freebsd.org/changeset/base/230592 Log: Bring in the LSI-supported version of the mps(4) driver. This involves significant changes to the mps(4) driver, but is not a complete rewrite. Some of the changes i

svn commit: r230591 - head/tools/regression/sbin/mdconfig

2012-01-26 Thread Edward Tomasz Napierala
Author: trasz Date: Thu Jan 26 18:16:16 2012 New Revision: 230591 URL: http://svn.freebsd.org/changeset/base/230591 Log: More mdconfig(8) tests. Modified: head/tools/regression/sbin/mdconfig/mdconfig.test Modified: head/tools/regression/sbin/mdconfig/mdconfig.test ===

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread Andrey Chernov
On Thu, Jan 26, 2012 at 12:52:43PM -0500, David Schultz wrote: > Why complicate things with atomics at all? A race might result in > arc4random(9) being seeded multiple times, but that's harmless. Multiply seeding in line is harmless, just waste of time and resources. Other case is one missing se

svn commit: r230590 - in head: sbin/camcontrol sys/cam sys/cam/scsi sys/sys usr.sbin/mptutil

2012-01-26 Thread Kenneth D. Merry
Author: ken Date: Thu Jan 26 18:09:28 2012 New Revision: 230590 URL: http://svn.freebsd.org/changeset/base/230590 Log: Add CAM infrastructure to allow reporting when a drive's long read capacity data changes. cam_ccb.h:Add a new advanced information type, CDAI_TYPE_RCAPLONG,

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread Stefan Farfeleder
On Thu, Jan 26, 2012 at 06:34:13PM +0100, Stefan Farfeleder wrote: > > The type of an enumerator actually is `int', so it should be fine. Please ignore that, I misread the diff. Stefan ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread Stefan Farfeleder
On Thu, Jan 26, 2012 at 11:32:38AM -0500, John Baldwin wrote: > On Thursday, January 26, 2012 10:56:27 am Andrey Chernov wrote: > > > On Thu, Jan 26, 2012 at 08:39:07AM -0500, John Baldwin wrote: > > > > atomic_cmpset_int(&iniseed_state, ARC4_ENTER_NONE, > ARC4_ENTER_HAVE); > > > >

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread David Schultz
On Thu, Jan 26, 2012, Andrey Chernov wrote: > On Thu, Jan 26, 2012 at 11:32:38AM -0500, John Baldwin wrote: > > On Thursday, January 26, 2012 10:56:27 am Andrey Chernov wrote: > > > > On Thu, Jan 26, 2012 at 08:39:07AM -0500, John Baldwin wrote: > > > > > atomic_cmpset_int(&iniseed_st

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread Andrey Chernov
> On Thu, Jan 26, 2012 at 11:32:38AM -0500, John Baldwin wrote: > > Atomics don't operate on enums. You'll need to make it an int and just use > > #define's for the 3 states. --- sys/libkern.h.old 2012-01-16 07:15:12.0 +0400 +++ sys/libkern.h 2012-01-26 21:40:21.0 +0400 @

svn commit: r230589 - head/share/man/man4

2012-01-26 Thread Kenneth D. Merry
Author: ken Date: Thu Jan 26 17:28:33 2012 New Revision: 230589 URL: http://svn.freebsd.org/changeset/base/230589 Log: Start sentences on a new line, and fix a few other nits. Prompted by: gjb MFC after:1 week Modified: head/share/man/man4/xnb.4 Modified: head/share/man/man4/xnb.

svn commit: r230588 - in head: share/man/man4 sys/dev/ciss

2012-01-26 Thread Sean Bruno
Author: sbruno Date: Thu Jan 26 17:04:17 2012 New Revision: 230588 URL: http://svn.freebsd.org/changeset/base/230588 Log: Update PCI IDs for ciss controllers that are supported by this driver. Submitted by: scott.ben...@hp.com Obtained from:Yahoo! Inc and HP MFC after:1 week

Re: svn commit: r230572 - in head/sys/dev: ixgbe netmap

2012-01-26 Thread Alan Cox
On 01/26/2012 03:55, Luigi Rizzo wrote: Author: luigi Date: Thu Jan 26 09:55:16 2012 New Revision: 230572 URL: http://svn.freebsd.org/changeset/base/230572 Log: ixgbe changes: - remove experimental code for disabling CRC - use the correct constant for conversion between interrupt rate

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread Andrey Chernov
On Thu, Jan 26, 2012 at 11:32:38AM -0500, John Baldwin wrote: > On Thursday, January 26, 2012 10:56:27 am Andrey Chernov wrote: > > > On Thu, Jan 26, 2012 at 08:39:07AM -0500, John Baldwin wrote: > > > > atomic_cmpset_int(&iniseed_state, ARC4_ENTER_NONE, > ARC4_ENTER_HAVE); > > > >

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread John Baldwin
On Thursday, January 26, 2012 10:56:27 am Andrey Chernov wrote: > > On Thu, Jan 26, 2012 at 08:39:07AM -0500, John Baldwin wrote: > > > atomic_cmpset_int(&iniseed_state, ARC4_ENTER_NONE, ARC4_ENTER_HAVE); > > > break; > > Updated version (I hope, final): > > --- sys/libkern.h

svn commit: r230587 - in head: share/man/man4 sys/dev/xen/blkback sys/dev/xen/netback sys/kern sys/xen/interface/io

2012-01-26 Thread Kenneth D. Merry
Author: ken Date: Thu Jan 26 16:35:09 2012 New Revision: 230587 URL: http://svn.freebsd.org/changeset/base/230587 Log: Xen netback driver rewrite. share/man/man4/Makefile, share/man/man4/xnb.4, sys/dev/xen/netback/netback.c, sys/dev/xen/netback/netback_unit_tests.c: Rewrote

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread Andrey Chernov
> On Thu, Jan 26, 2012 at 08:39:07AM -0500, John Baldwin wrote: > > atomic_cmpset_int(&iniseed_state, ARC4_ENTER_NONE, > > ARC4_ENTER_HAVE); > > break; Updated version (I hope, final): --- sys/libkern.h.old 2012-01-16 07:15:12.0 +0400 +++ sys/libkern.h 201

Re: svn commit: r230516 - in head/sys: fs/nfsclient nfsclient

2012-01-26 Thread Rick Macklem
Bruce Evans wrote: > On Wed, 25 Jan 2012, Rick Macklem wrote: > > > Bruce Evans wrote: > >> On Tue, 24 Jan 2012, Rick Macklem wrote: > >> > >>> Bruce Evans wrote: > On Wed, 25 Jan 2012, Rick Macklem wrote: > > > Log: > > If a mount -u is done to either NFS client that switches i

Re: svn commit: r230583 - head/sys/kern

2012-01-26 Thread Gleb Smirnoff
Bruce, On Thu, Jan 26, 2012 at 11:53:57PM +1100, Bruce Evans wrote: B> > Log: B> > Although aio_nbytes is size_t, later is is signed to B> > casted types: to ssize_t in filesystem code and to B> > int in buf code, thus supplying a negative argument B> > leads to kernel panic later. B> B> An

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread Andrey Chernov
On Thu, Jan 26, 2012 at 08:39:07AM -0500, John Baldwin wrote: > What is the purpose of the atomics? Doing atomic_load/atomic_store > is just as racy as if you had not used atomics at all. Thanx for a hint. Protecting comparison itself isn't essential as protecting variable consitency because r

Re: svn commit: r230541 - head/usr.sbin/daemon

2012-01-26 Thread Guy Helmer
On Jan 26, 2012, at 4:51 AM, Doug Barton wrote: > On 01/25/2012 06:50, Guy Helmer wrote: >> Author: ghelmer >> Date: Wed Jan 25 14:50:12 2012 >> New Revision: 230541 >> URL: http://svn.freebsd.org/changeset/base/230541 >> >> Log: >> Revert 229667: After some discussion of this change, it seems

Re: svn commit: r230230 - head/sys/dev/random

2012-01-26 Thread John Baldwin
On Wednesday, January 25, 2012 10:39:50 pm Andrey Chernov wrote: > On Thu, Jan 26, 2012 at 07:03:05AM +0400, Andrey Chernov wrote: > > On Wed, Jan 25, 2012 at 07:16:41PM +, Mark Murray wrote: > > > I thought you were going to do this as a function? It would be > > > slightly neater to do it tha

Re: svn commit: r230516 - in head/sys: fs/nfsclient nfsclient

2012-01-26 Thread Bruce Evans
On Wed, 25 Jan 2012, Rick Macklem wrote: Bruce Evans wrote: On Tue, 24 Jan 2012, Rick Macklem wrote: Bruce Evans wrote: On Wed, 25 Jan 2012, Rick Macklem wrote: Log: If a mount -u is done to either NFS client that switches it from TCP to UDP and the rsize/wsize/readdirsize is greater th

Re: svn commit: r230583 - head/sys/kern

2012-01-26 Thread Bruce Evans
On Thu, 26 Jan 2012, Gleb Smirnoff wrote: Log: Although aio_nbytes is size_t, later is is signed to casted types: to ssize_t in filesystem code and to int in buf code, thus supplying a negative argument leads to kernel panic later. And supplying a large positive argument leads to undefined

svn commit: r230585 - head/sys/dev/sound/pci/hda

2012-01-26 Thread Alexander Motin
Author: mav Date: Thu Jan 26 12:09:04 2012 New Revision: 230585 URL: http://svn.freebsd.org/changeset/base/230585 Log: Press some more info into the PCM device name: - add "+HP" in case of headphones redirection; - add device type for analog devices, if all pins have the same. As resu

Re: svn commit: r230584 - head/sys/netinet6

2012-01-26 Thread Maxim Konovalov
On Thu, 26 Jan 2012, 12:04-, Gleb Smirnoff wrote: > Author: glebius > Date: Thu Jan 26 12:04:19 2012 > New Revision: 230584 > URL: http://svn.freebsd.org/changeset/base/230584 > > Log: > Remove casts from inet6 address testing macros, thus preserving > qualifier from original argument. > >

svn commit: r230584 - head/sys/netinet6

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 12:04:19 2012 New Revision: 230584 URL: http://svn.freebsd.org/changeset/base/230584 Log: Remove casts from inet6 address testing macros, thus preserving qualifier from original argument. Obtained from:NetBSD, r. 1.67 Submitted by: maxim Modifie

svn commit: r230583 - head/sys/kern

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 11:59:48 2012 New Revision: 230583 URL: http://svn.freebsd.org/changeset/base/230583 Log: Although aio_nbytes is size_t, later is is signed to casted types: to ssize_t in filesystem code and to int in buf code, thus supplying a negative argument leads to ke

Re: svn commit: r230545 - head/sys/boot/forth

2012-01-26 Thread Andriy Gapon
on 26/01/2012 12:48 Doug Barton said the following: > On 01/25/2012 13:35, Andriy Gapon wrote: >> on 25/01/2012 22:52 Doug Barton said the following: >>> On 01/25/2012 11:22, Andriy Gapon wrote: I have this crazy idea that we should remove the 'Safe Boot' and "ACPI' options from the

svn commit: r230581 - head/share/man/man9

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 11:08:55 2012 New Revision: 230581 URL: http://svn.freebsd.org/changeset/base/230581 Log: List supported ioctl commands instead of old one. Modified: head/share/man/man9/ifnet.9 Modified: head/share/man/man9/ifnet.9 ===

svn commit: r230580 - head/share/man/man4

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 10:53:39 2012 New Revision: 230580 URL: http://svn.freebsd.org/changeset/base/230580 Log: Don't mention no longer supported ioctl commands. Modified: head/share/man/man4/tap.4 Modified: head/share/man/man4/tap.4 ===

svn commit: r230579 - head/share/man/man4

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 10:51:41 2012 New Revision: 230579 URL: http://svn.freebsd.org/changeset/base/230579 Log: Remove a block that contatined some outdated misinformation on how addresses are configured, as well as obviousness that Ethernet interface may run arp(4). Modified:

Re: svn commit: r230541 - head/usr.sbin/daemon

2012-01-26 Thread Doug Barton
On 01/25/2012 06:50, Guy Helmer wrote: > Author: ghelmer > Date: Wed Jan 25 14:50:12 2012 > New Revision: 230541 > URL: http://svn.freebsd.org/changeset/base/230541 > > Log: > Revert 229667: After some discussion of this change, it seems it is > better to leave the pidfile open where it was. A

Re: svn commit: r230545 - head/sys/boot/forth

2012-01-26 Thread Doug Barton
On 01/25/2012 13:35, Andriy Gapon wrote: > on 25/01/2012 22:52 Doug Barton said the following: >> On 01/25/2012 11:22, Andriy Gapon wrote: >>> I have this crazy idea that we should remove the 'Safe Boot' and "ACPI' >>> options >>> from the default boot menu (on platforms where they are present). >

svn commit: r230578 - head/share/man/man4

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 10:48:17 2012 New Revision: 230578 URL: http://svn.freebsd.org/changeset/base/230578 Log: Remove a commented out old block inherited from inet.4. The text there was so much outdated that it required a complete rewrite even for inet.4, not mentioning inet6.4.

svn commit: r230577 - head/share/man/man4

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 10:43:40 2012 New Revision: 230577 URL: http://svn.freebsd.org/changeset/base/230577 Log: - Remove no longer supported ioctl cmds. - Fix name of SIOCSIFADDR. Modified: head/share/man/man4/netintro.4 Modified: head/share/man/man4/netintro.4 =

svn commit: r230576 - head/share/man/man4

2012-01-26 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 26 10:42:25 2012 New Revision: 230576 URL: http://svn.freebsd.org/changeset/base/230576 Log: Update information on setting and retreiving inet4 addresses. Modified: head/share/man/man4/inet.4 Modified: head/share/man/man4/inet.4 =

svn commit: r230574 - head/sys/dev/sound/pci/hda

2012-01-26 Thread Alexander Motin
Author: mav Date: Thu Jan 26 10:30:50 2012 New Revision: 230574 URL: http://svn.freebsd.org/changeset/base/230574 Log: Fix typo in r230571. Submitted by: trasz Modified: head/sys/dev/sound/pci/hda/hdacc.c Modified: head/sys/dev/sound/pci/hda/hdacc.c =

svn commit: r230572 - in head/sys/dev: ixgbe netmap

2012-01-26 Thread Luigi Rizzo
Author: luigi Date: Thu Jan 26 09:55:16 2012 New Revision: 230572 URL: http://svn.freebsd.org/changeset/base/230572 Log: ixgbe changes: - remove experimental code for disabling CRC - use the correct constant for conversion between interrupt rate and EITR values (the previous values were

svn commit: r230571 - head/sys/dev/sound/pci/hda

2012-01-26 Thread Alexander Motin
Author: mav Date: Thu Jan 26 09:45:14 2012 New Revision: 230571 URL: http://svn.freebsd.org/changeset/base/230571 Log: Add another bunch of CODEC IDs. Modified: head/sys/dev/sound/pci/hda/hdac.c head/sys/dev/sound/pci/hda/hdac.h head/sys/dev/sound/pci/hda/hdacc.c Modified: head/sys/dev/s