svn commit: r209192 - head/usr.bin/wtmpcvt

Author: ed Date: Tue Jun 15 04:47:16 2010 New Revision: 209192 URL: http://svn.freebsd.org/changeset/base/209192 Log: err() takes a printf format. Submitted by: Pawel Worach Spotted by: clang Modified: head/usr.bin/wtmpcvt/wtmpcvt.c Modified: head/usr.bin/wtmpcvt/wtmpcvt.c =

svn commit: r209191 - in head/sys/fs: nfsclient nfsserver

Author: rmacklem Date: Tue Jun 15 00:25:04 2010 New Revision: 209191 URL: http://svn.freebsd.org/changeset/base/209191 Log: Add MODULE_DEPEND() macros to the experimental NFS client and server so that the modules will load when kernels are built with none of the NFS* configuration options sp

svn commit: r209190 - head/usr.sbin/tzsetup

Author: emaste Date: Mon Jun 14 23:51:35 2010 New Revision: 209190 URL: http://svn.freebsd.org/changeset/base/209190 Log: Use literal format strings. Found by clang. Modified: head/usr.sbin/tzsetup/tzsetup.c Modified: head/usr.sbin/tzsetup/tzsetup.c =

svn commit: r209189 - head/sys/dev/usb/wlan

Author: jkim Date: Mon Jun 14 23:01:50 2010 New Revision: 209189 URL: http://svn.freebsd.org/changeset/base/209189 Log: Fix typos that broke duration calculations on protection frames. A similar fix was done for ral(4) long ago and it must be copy-and-paste bugs. Found by: clang Mod

svn commit: r209188 - head/sys/cam/scsi

Author: ken Date: Mon Jun 14 22:02:18 2010 New Revision: 209188 URL: http://svn.freebsd.org/changeset/base/209188 Log: For the target port groups structures, don't allocate the initial element. This makes things easier for target implementations to calculate how many elements they need to al

svn commit: r209187 - head/sys/geom/gate

Author: pjd Date: Mon Jun 14 21:58:55 2010 New Revision: 209187 URL: http://svn.freebsd.org/changeset/base/209187 Log: 'unit' can be negative, so use signed type for it. Found by: Coverity Prevent CID: 3731 MFC after:3 days Modified: head/sys/geom/gate/g_gate.c Modi

svn commit: r209186 - head/sys/geom/gate

Author: pjd Date: Mon Jun 14 21:56:24 2010 New Revision: 209186 URL: http://svn.freebsd.org/changeset/base/209186 Log: BIO_DELETE contains range we want to delete and doesn't provide any useful data, so there is no need to copy it to userland. MFC after:3 days Modified: head/sys/ge

svn commit: r209185 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:46:48 2010 New Revision: 209185 URL: http://svn.freebsd.org/changeset/base/209185 Log: Correct various log messages. Submitted by: Mikolaj Golub MFC after:3 days Modified: head/sbin/hastd/hastd.c head/sbin/hastd/secondary.c Modified: head/sbin/ha

svn commit: r209184 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:44:58 2010 New Revision: 209184 URL: http://svn.freebsd.org/changeset/base/209184 Log: Fix typos. MFC after:3 days Modified: head/sbin/hastd/ebuf.c Modified: head/sbin/hastd/ebuf.c ==

svn commit: r209183 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:44:20 2010 New Revision: 209183 URL: http://svn.freebsd.org/changeset/base/209183 Log: Initialize gctl_seq for synchronization requests. Reported by: hiro...@soupacific.com Analysed by: Mikolaj Golub Tested by:hiro...@soupacific.com, Mikolaj Golub

svn commit: r209182 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:41:22 2010 New Revision: 209182 URL: http://svn.freebsd.org/changeset/base/209182 Log: Plug memory leak. Found by: Coverity Prevent CID: 7057 MFC after:3 days Modified: head/sbin/hastd/secondary.c Modified: head/sbin/hastd/secondary.c

svn commit: r209181 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:37:25 2010 New Revision: 209181 URL: http://svn.freebsd.org/changeset/base/209181 Log: Plug memory leak. Found by: Coverity Prevent CID: 7056 MFC after:3 days Modified: head/sbin/hastd/primary.c Modified: head/sbin/hastd/primary.c ===

svn commit: r209180 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:33:18 2010 New Revision: 209180 URL: http://svn.freebsd.org/changeset/base/209180 Log: Plug memory leak. Found by: Coverity Prevent CID: 7051 MFC after:3 days Modified: head/sbin/hastd/nv.c Modified: head/sbin/hastd/nv.c =

svn commit: r209179 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:25:20 2010 New Revision: 209179 URL: http://svn.freebsd.org/changeset/base/209179 Log: Plug memory leaks. Found by: Coverity Prevent CID: 7052, 7053, 7054, 7055 MFC after:3 days Modified: head/sbin/hastd/metadata.c Modified: head/sbin

svn commit: r209178 - head/sys/netinet

Author: tuexen Date: Mon Jun 14 21:25:07 2010 New Revision: 209178 URL: http://svn.freebsd.org/changeset/base/209178 Log: * Fix a bug where the length of the ASCONF-ACK was calculated wrong due to using an uninitialized variable. * Fix a bug where a NULL pointer was dereferenced when inter

svn commit: r209177 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:18:58 2010 New Revision: 209177 URL: http://svn.freebsd.org/changeset/base/209177 Log: Remove macros that are not really needed. The idea was to have them in case we grow more descriptors, but I'll reconsider readding them once we get there. Passing (a = b)

svn commit: r209175 - head/sbin/hastd

Author: pjd Date: Mon Jun 14 21:01:13 2010 New Revision: 209175 URL: http://svn.freebsd.org/changeset/base/209175 Log: Eliminate dead code. Found by: Coverity Prevent CID: 5158 MFC after:3 days Modified: head/sbin/hastd/hast_proto.c Modified: head/sbin/hastd/hast_pr

svn commit: r209174 - in head/sys/amd64: acpica amd64

Author: jkim Date: Mon Jun 14 20:08:26 2010 New Revision: 209174 URL: http://svn.freebsd.org/changeset/base/209174 Log: Fix ACPI suspend/resume on amd64, which was broken since r208833. We need actual storage for FPU state to save and restore. Modified: head/sys/amd64/acpica/acpi_wakeup.c

svn commit: r209173 - head/sys/vm

Author: alc Date: Mon Jun 14 19:54:19 2010 New Revision: 209173 URL: http://svn.freebsd.org/changeset/base/209173 Log: Eliminate checks for a page having a NULL object in vm_pageout_scan() and vm_pageout_page_stats(). These checks were recently introduced by the first page locking commit, r

svn commit: r209172 - head/usr.sbin/sysinstall

Author: marcel Date: Mon Jun 14 19:39:20 2010 New Revision: 209172 URL: http://svn.freebsd.org/changeset/base/209172 Log: Further unbreak powerpc & sparc64. Modified: head/usr.sbin/sysinstall/disks.c Modified: head/usr.sbin/sysinstall/disks.c =

svn commit: r209171 - head/tools/build/mk

Author: ed Date: Mon Jun 14 19:10:30 2010 New Revision: 209171 URL: http://svn.freebsd.org/changeset/base/209171 Log: Add Clang to OptionalObsoleteFiles.inc. This means you can now deinstall Clang by running make delete-old with WITHOUT_CLANG set. Modified: head/tools/build/mk/Optional

svn commit: r209169 - head/sys/dev/iwn

Author: bschmidt Date: Mon Jun 14 18:26:10 2010 New Revision: 209169 URL: http://svn.freebsd.org/changeset/base/209169 Log: Fix TX retry rate handling. tx->linkq is an index to a rate table beginning with the highest available rate. Currently we always use 54m for the first retry no matter w

Re: svn commit: r209153 - head/lib/clang

On Mon, 14 Jun 2010 19:26:09 +0200 Ulrich Spörlein wrote: > On Mon, 14.06.2010 at 06:23:47 +, Ed Schouten wrote: > > Author: ed > > Date: Mon Jun 14 06:23:47 2010 > > New Revision: 209153 > > URL: http://svn.freebsd.org/changeset/base/209153 > > > > Log: > > Unbreak Clang on PowerPC. > >

Re: svn commit: r209153 - head/lib/clang

Hello Ulrich, * Ulrich Spörlein wrote: > What about clang compiled using clang -O2? Ie., does clang bootstrap > correctly on PPC and this is a genuine gcc 4.2.1 bug? Well, Clang on PowerPC has some serious issues related to varargs, if I remember correctly. I don't think it's likely that a Clang

svn commit: r209168 - head/share/man/man9

Author: jh Date: Mon Jun 14 17:31:46 2010 New Revision: 209168 URL: http://svn.freebsd.org/changeset/base/209168 Log: Update vfs_busy(9) and vfs_unbusy(9) manual pages to better match the current behaviour of the functions. Discussed with: attilio Modified: head/share/man/man9/vf

Re: svn commit: r209153 - head/lib/clang

On Mon, 14.06.2010 at 06:23:47 +, Ed Schouten wrote: > Author: ed > Date: Mon Jun 14 06:23:47 2010 > New Revision: 209153 > URL: http://svn.freebsd.org/changeset/base/209153 > > Log: > Unbreak Clang on PowerPC. > > It seems GCC 4.2.1 on PowerPC miscompiles Clang, causing it to crash >

svn commit: r209162 - head/sys/boot/i386/pxeldr

Author: rdivacky Date: Mon Jun 14 17:02:19 2010 New Revision: 209162 URL: http://svn.freebsd.org/changeset/base/209162 Log: Pass the -N flag to linked via -Wl. Approved by: ed (mentor) Modified: head/sys/boot/i386/pxeldr/Makefile Modified: head/sys/boot/i386/pxeldr/Makefile ===

svn commit: r209161 - head/sys/arm/include

Author: raj Date: Mon Jun 14 16:05:21 2010 New Revision: 209161 URL: http://svn.freebsd.org/changeset/base/209161 Log: Temporarily bring back the ARM bootinfo (and make tinderbox happy). BI will be eliminated for good when powerpc transition to FDT is complete. Added: - copied unchang

svn commit: r209160 - in head/contrib/wpa/src: drivers l2_packet

Author: rpaulo Date: Mon Jun 14 15:52:50 2010 New Revision: 209160 URL: http://svn.freebsd.org/changeset/base/209160 Log: Remove unused files. Deleted: head/contrib/wpa/src/drivers/Apple80211.h head/contrib/wpa/src/drivers/MobileApple80211.c head/contrib/wpa/src/drivers/MobileApple80211.h

Re: svn commit: r209119 - head/sys/sys

On Mon, 14 Jun 2010, John Baldwin wrote: On Monday 14 June 2010 9:50:10 am m...@freebsd.org wrote: [bde wrote] BTW, one reason I liked BSD code more than gnu code is that it didn't use so many macros. Macros should only exist when they are not just syntactic sugar, like DPCPU_SUM() and unlike

svn commit: r209159 - in head/usr.sbin/wpa: . hostapd wpa_supplicant

Author: rpaulo Date: Mon Jun 14 15:38:30 2010 New Revision: 209159 URL: http://svn.freebsd.org/changeset/base/209159 Log: Update for hostapd & wpa_supplicant 0.6.10. Deleted: head/usr.sbin/wpa/l2_packet.c head/usr.sbin/wpa/wpa_supplicant/driver_wired.c Modified: head/usr.sbin/wpa/hostapd/

svn commit: r209158 - in head/contrib/wpa: hostapd hostapd/doc src/common src/crypto src/drivers src/eap_common src/eap_peer src/eap_server src/eapol_supp src/hlr_auc_gw src/l2_packet src/radius sr...

Author: rpaulo Date: Mon Jun 14 15:37:48 2010 New Revision: 209158 URL: http://svn.freebsd.org/changeset/base/209158 Log: MFV hostapd & wpa_supplicant 0.6.10. Added: head/contrib/wpa/hostapd/Makefile - copied unchanged from r209140, vendor/wpa/dist/hostapd/Makefile head/contrib/wpa/hos

Re: svn commit: r209119 - head/sys/sys

On Monday 14 June 2010 9:50:10 am m...@freebsd.org wrote: > > BTW, one reason I liked BSD code more than gnu code is that it didn't > > use so many macros. Macros should only exist when they are not just > > syntactic sugar, like DPCPU_SUM() and unlike CPU_FOREACH(). > > As a style question, I do

Re: svn commit: r209119 - head/sys/sys

> BTW, one reason I liked BSD code more than gnu code is that it didn't > use so many macros.  Macros should only exist when they are not just > syntactic sugar, like DPCPU_SUM() and unlike CPU_FOREACH(). As a style question, I do understand (generally) why too many macros make the code confusing.

Re: svn commit: r209119 - head/sys/sys

On Sunday 13 June 2010 9:41:38 am Lawrence Stewart wrote: > On 06/13/10 20:10, Pawel Jakub Dawidek wrote: > > On Sun, Jun 13, 2010 at 02:39:55AM +, Lawrence Stewart wrote: > >> Author: lstewart > >> Date: Sun Jun 13 02:39:55 2010 > >> New Revision: 209119 > >> URL: http://svn.freebsd.org/change

Re: svn commit: r209119 - head/sys/sys

On Sun, 13 Jun 2010, Lawrence Stewart wrote: On 06/13/10 20:10, Pawel Jakub Dawidek wrote: On Sun, Jun 13, 2010 at 02:39:55AM +, Lawrence Stewart wrote: Log: Add a utility macro to simplify calculating an aggregate sum from a DPCPU counter variable. Sponsored by:FreeBSD

svn commit: r209157 - head/games/random

Author: uqs Date: Mon Jun 14 13:03:25 2010 New Revision: 209157 URL: http://svn.freebsd.org/changeset/base/209157 Log: random(6): avoid dead assignments Found by: clang static analyzer Modified: head/games/random/random.c head/games/random/randomize_fd.c Modified: head/games/rando

Re: svn commit: r209119 - head/sys/sys

On Sun, 13 Jun 2010, Gabor Kovesdan wrote: +/* + * Utility macros. + */ +#define DPCPU_SUM(n, var, sum) \ +do { \ + (sum) = 0; \ + u_int i;\ + CPU_FOREACH(i)

Re: svn commit: r209119 - head/sys/sys

On Mon, Jun 14, 2010 at 08:34:15PM +1000, Lawrence Stewart wrote: > On 06/14/10 18:52, Kostik Belousov wrote: > >On Mon, Jun 14, 2010 at 11:52:49AM +1000, Lawrence Stewart wrote: > >>On 06/13/10 20:10, Pawel Jakub Dawidek wrote: > >>>On Sun, Jun 13, 2010 at 02:39:55AM +, Lawrence Stewart wrote:

Re: svn commit: r209119 - head/sys/sys

On 06/14/10 18:52, Kostik Belousov wrote: On Mon, Jun 14, 2010 at 11:52:49AM +1000, Lawrence Stewart wrote: On 06/13/10 20:10, Pawel Jakub Dawidek wrote: On Sun, Jun 13, 2010 at 02:39:55AM +, Lawrence Stewart wrote: [snip] Modified: head/sys/sys/pcpu.h ===

Re: svn commit: r209119 - head/sys/sys

On Mon, Jun 14, 2010 at 11:52:49AM +1000, Lawrence Stewart wrote: > On 06/13/10 20:10, Pawel Jakub Dawidek wrote: > >On Sun, Jun 13, 2010 at 02:39:55AM +, Lawrence Stewart wrote: > [snip] > >> > >>Modified: head/sys/sys/pcpu.h > >>

svn commit: r209156 - head/sys/dev/ath

Author: bschmidt Date: Mon Jun 14 08:24:00 2010 New Revision: 209156 URL: http://svn.freebsd.org/changeset/base/209156 Log: sc_lastrs is also used in case the sending station is not known, for example in a split IBSS scenario. Therefore always assign sc_lastrs. This removes a hack I committe

Re: svn commit: r209119 - head/sys/sys

On Mon, Jun 14, 2010 at 11:52:49AM +1000, Lawrence Stewart wrote: > Given that the DPCPU variable name space is flat and variable names have > to be unique, perhaps something like the following would address the > concerns raised? > > #define DPCPU_SUM(n, var, sum)

svn commit: r209155 - in head/sys: amd64/amd64 i386/i386

Author: mav Date: Mon Jun 14 07:38:53 2010 New Revision: 209155 URL: http://svn.freebsd.org/changeset/base/209155 Log: Fix bug introduced in SVN rev 194985. When calling pic_assign_cpu() for pre-bound IRQs during boot, submit there LAPIC ID, same as in other places, not CPU ID. Modified:

svn commit: r209154 - in head/sys: dev/pci kern x86/x86

Author: mav Date: Mon Jun 14 07:10:37 2010 New Revision: 209154 URL: http://svn.freebsd.org/changeset/base/209154 Log: Virtualize pci_remap_msi_irq() call from general MSI code. It allows MSI (FSB interrupts) to be used by non-PCI devices, such as HPET. Modified: head/sys/dev/pci/pci.c he