svn commit: r349564 - head/stand/efi/libefi

2019-06-30 Thread Toomas Soome
Author: tsoome Date: Sun Jun 30 20:15:02 2019 New Revision: 349564 URL: https://svnweb.freebsd.org/changeset/base/349564 Log: Clean efihttp pointer-sign warnings The Http protocol structure is using unsigned char strings, Use type casts where needed. Modified: head/stand/efi/libefi/efi

svn commit: r349565 - head/stand/efi/libefi

2019-06-30 Thread Toomas Soome
Author: tsoome Date: Sun Jun 30 20:18:31 2019 New Revision: 349565 URL: https://svnweb.freebsd.org/changeset/base/349565 Log: efihttp: comparison of integers of different signs message.HeaderCount is UINTN (unsigned int), so should be i. Modified: head/stand/efi/libefi/efihttp.c Modifie

svn commit: r349566 - head/stand/efi/libefi

2019-06-30 Thread Toomas Soome
Author: tsoome Date: Sun Jun 30 20:21:27 2019 New Revision: 349566 URL: https://svnweb.freebsd.org/changeset/base/349566 Log: efihttp: mark unused arguments with __unused we do have __unused, lets use it. Modified: head/stand/efi/libefi/efihttp.c Modified: head/stand/efi/libefi/efihttp.

svn commit: r349613 - head/stand/efi/libefi

2019-07-02 Thread Toomas Soome
Author: tsoome Date: Tue Jul 2 20:32:35 2019 New Revision: 349613 URL: https://svnweb.freebsd.org/changeset/base/349613 Log: efihttp: mac and err can be used uninitialized While there, also check if mac != NULL, and use pointer compare for ipv4 and dns. Modified: head/stand/efi/libefi

svn commit: r350656 - in head/stand/efi: include libefi

2019-08-06 Thread Toomas Soome
Author: tsoome Date: Tue Aug 6 20:13:28 2019 New Revision: 350656 URL: https://svnweb.freebsd.org/changeset/base/350656 Log: loader.efi: efilib.h and libefi.c were left out of 350654 And this is second followup for 350654 Modified: head/stand/efi/include/efilib.h head/stand/efi/libefi

svn commit: r350654 - in head/stand/efi: boot1 gptboot libefi loader

2019-08-06 Thread Toomas Soome
Author: tsoome Date: Tue Aug 6 19:27:27 2019 New Revision: 350654 URL: https://svnweb.freebsd.org/changeset/base/350654 Log: loader.efi: replace HandleProtocol() with OpenProtocol() The HandleProtocol() is deprecated interface and we should use OpenProtocol() instead. Moreover, in some f

svn commit: r350655 - head/stand/efi/boot1

2019-08-06 Thread Toomas Soome
Author: tsoome Date: Tue Aug 6 20:08:01 2019 New Revision: 350655 URL: https://svnweb.freebsd.org/changeset/base/350655 Log: loader.efi: boot1.c was left out of 350654 Followup for 350654. Modified: head/stand/efi/boot1/boot1.c Modified: head/stand/efi/boot1/boot1.c ===

svn commit: r350772 - in head: cddl/contrib/opensolaris/lib/libzfs/common stand/efi/boot1 stand/i386/gptzfsboot stand/i386/zfsboot stand/libsa/zfs sys/cddl/boot/zfs sys/cddl/contrib/opensolaris/uts...

2019-08-08 Thread Toomas Soome
Author: tsoome Date: Thu Aug 8 18:08:13 2019 New Revision: 350772 URL: https://svnweb.freebsd.org/changeset/base/350772 Log: loader: support com.delphix:removing We should support removing vdev from boot pool. Update loader zfs reader to support com.delphix:removing. Reviewed by: a

svn commit: r350825 - head/stand/libsa/zfs

2019-08-09 Thread Toomas Soome
Author: tsoome Date: Fri Aug 9 19:09:05 2019 New Revision: 350825 URL: https://svnweb.freebsd.org/changeset/base/350825 Log: loader: add error check for vdev_indirect calls We can error out due to memory allocation errors, we can not recover from those and need to get out. Modified: h

svn commit: r347219 - head/stand/common

2019-05-07 Thread Toomas Soome
Author: tsoome Date: Tue May 7 07:46:40 2019 New Revision: 347219 URL: https://svnweb.freebsd.org/changeset/base/347219 Log: loader: use safer DPRINTF body for non-debug case Modified: head/stand/common/bcache.c Modified: head/stand/common/bcache.c ==

svn commit: r347220 - head/stand/common

2019-05-07 Thread Toomas Soome
Author: tsoome Date: Tue May 7 08:14:30 2019 New Revision: 347220 URL: https://svnweb.freebsd.org/changeset/base/347220 Log: loader: bcache code does not need to check argument for free() Modified: head/stand/common/bcache.c Modified: head/stand/common/bcache.c =

svn commit: r347223 - head/stand/common

2019-05-07 Thread Toomas Soome
Author: tsoome Date: Tue May 7 10:01:45 2019 New Revision: 347223 URL: https://svnweb.freebsd.org/changeset/base/347223 Log: command_bcache() does not use argv Therefore mark argv __unused. Modified: head/stand/common/bcache.c Modified: head/stand/common/bcache.c ==

svn commit: r347388 - in head/stand: efi/libefi i386/libi386

2019-05-09 Thread Toomas Soome
Author: tsoome Date: Thu May 9 10:37:57 2019 New Revision: 347388 URL: https://svnweb.freebsd.org/changeset/base/347388 Log: loader: implement proper 8 char tab stops The current console code is printing out 8 spaces for tab, calculate the amount of spaces based on tab stops. Modified:

svn commit: r347389 - head/stand/common

2019-05-09 Thread Toomas Soome
Author: tsoome Date: Thu May 9 11:04:10 2019 New Revision: 347389 URL: https://svnweb.freebsd.org/changeset/base/347389 Log: loader: ptable_print() needs two tabs sometimes Since the partition/slice names do vary in length, check the length of the fixed part of the line against 3 * 8, if

svn commit: r347391 - in head/stand: efi/libefi i386/libi386

2019-05-09 Thread Toomas Soome
Author: tsoome Date: Thu May 9 12:14:52 2019 New Revision: 347391 URL: https://svnweb.freebsd.org/changeset/base/347391 Log: loader: no-TERM_EMU is broken now If TERM_EMU is not defined, we do not have curx variable. Use conout mode for efi and expose get_pos() for i386. Modified: hea

svn commit: r347393 - in head/stand: common i386/libi386

2019-05-09 Thread Toomas Soome
Author: tsoome Date: Thu May 9 13:12:43 2019 New Revision: 347393 URL: https://svnweb.freebsd.org/changeset/base/347393 Log: loader: use DPRINTF in biosdisk.c and define safe DPRINTF r345066 did miss biosdisk.c. Also define DPRINTF as ((void)0) for case we do not want debug printouts.

svn commit: r347553 - head/stand/common

2019-05-13 Thread Toomas Soome
Author: tsoome Date: Mon May 13 22:17:11 2019 New Revision: 347553 URL: https://svnweb.freebsd.org/changeset/base/347553 Log: loader: fix memory handling errors in module.c file_loadraw(): check for file_alloc() and strdup() results. we leak 'name'. mod_load() does leak 'filename'.

svn commit: r348352 - head/stand/libsa/zfs

2019-05-29 Thread Toomas Soome
Author: tsoome Date: Wed May 29 07:24:10 2019 New Revision: 348352 URL: https://svnweb.freebsd.org/changeset/base/348352 Log: loader: zfs_alloc and zfs_free should use panic The zfs alloc and free code print out the error and get stuck in infinite loop; use panic() instead. Modified: he

svn commit: r348353 - head/stand/efi/boot1

2019-05-29 Thread Toomas Soome
Author: tsoome Date: Wed May 29 07:32:43 2019 New Revision: 348353 URL: https://svnweb.freebsd.org/changeset/base/348353 Log: boot1.efi should also provide Calloc boot1.efi does provide Malloc and Free, we also need Calloc. Modified: head/stand/efi/boot1/boot1.c Modified: head/stand/efi

svn commit: r348354 - head/stand/libsa/zfs

2019-05-29 Thread Toomas Soome
Author: tsoome Date: Wed May 29 07:33:51 2019 New Revision: 348354 URL: https://svnweb.freebsd.org/changeset/base/348354 Log: loader: malloc+memset is calloc in spa_create Replace malloc + memset pair with calloc. Modified: head/stand/libsa/zfs/zfsimpl.c Modified: head/stand/libsa/zfs/z

svn commit: r348748 - head/stand/common

2019-06-06 Thread Toomas Soome
Author: tsoome Date: Thu Jun 6 16:27:05 2019 New Revision: 348748 URL: https://svnweb.freebsd.org/changeset/base/348748 Log: loader: disk_open() should honor D_PARTNONE The D_PARTNONE is documented to make it possible to open raw MBR partition, but the current disk_open() does not really

svn commit: r341224 - stable/12/stand/libsa

2018-11-29 Thread Toomas Soome
Author: tsoome Date: Thu Nov 29 12:12:42 2018 New Revision: 341224 URL: https://svnweb.freebsd.org/changeset/base/341224 Log: MFC r339651,339992-339993,340026 libsa: re-send ACK for older data packets in tftp libsa: tftp should not read past file end libsa: tftp should use calloc libs

svn commit: r341225 - stable/12/stand/common

2018-11-29 Thread Toomas Soome
Author: tsoome Date: Thu Nov 29 13:01:21 2018 New Revision: 341225 URL: https://svnweb.freebsd.org/changeset/base/341225 Log: MFC: r340240: loader: ptable_open() check for ptable_cd9660read result is wrong The ptable_*read() functions return NULL on read errors (and partition table clos

svn commit: r341226 - in stable/12/stand: common i386/libi386

2018-11-29 Thread Toomas Soome
Author: tsoome Date: Thu Nov 29 13:37:44 2018 New Revision: 341226 URL: https://svnweb.freebsd.org/changeset/base/341226 Log: MFC r340215: oader: always set media size from partition. The disk access is validated by using partition table definitions, therefore we have no need for if sta

svn commit: r341227 - stable/12/stand/i386/libi386

2018-11-29 Thread Toomas Soome
Author: tsoome Date: Thu Nov 29 13:44:37 2018 New Revision: 341227 URL: https://svnweb.freebsd.org/changeset/base/341227 Log: MFC r339658: loader: biosdisk interface should be able to cope with 4k sectors The 4kn support in current bios specific biosdisk.c is broken, as the code is only

svn commit: r341228 - stable/12/stand/i386/libi386

2018-11-29 Thread Toomas Soome
Author: tsoome Date: Thu Nov 29 13:54:07 2018 New Revision: 341228 URL: https://svnweb.freebsd.org/changeset/base/341228 Log: MFC r339959: loader: issue edd probe before legacy ah=08 and detect no media while probing for drives, use int13 extended info before standard one and provide wo

svn commit: r341229 - stable/12/stand/i386/libi386

2018-11-29 Thread Toomas Soome
Author: tsoome Date: Thu Nov 29 13:55:57 2018 New Revision: 341229 URL: https://svnweb.freebsd.org/changeset/base/341229 Log: MFC r340049: loader: biosdisk should check if the media is present The bd_print/bd_open/bd_strategy need to make sure the device does have media, before getting

svn commit: r341230 - stable/12/stand/i386/loader

2018-11-29 Thread Toomas Soome
Author: tsoome Date: Thu Nov 29 13:58:41 2018 New Revision: 341230 URL: https://svnweb.freebsd.org/changeset/base/341230 Log: MFC r340047: loader: do not probe floppy devices for zfs Floppy devices do not have enough space for ZFS pool. Modified: stable/12/stand/i386/loader/main.c Dire

svn commit: r341231 - head/stand/common

2018-11-29 Thread Toomas Soome
Author: tsoome Date: Thu Nov 29 14:21:01 2018 New Revision: 341231 URL: https://svnweb.freebsd.org/changeset/base/341231 Log: loader: command_bcache() should print unsigned values All bcache counters are unsigned. Modified: head/stand/common/bcache.c Modified: head/stand/common/bcache.c

svn commit: r341328 - in head/stand/i386: libi386 loader

2018-11-30 Thread Toomas Soome
Author: tsoome Date: Fri Nov 30 08:01:11 2018 New Revision: 341328 URL: https://svnweb.freebsd.org/changeset/base/341328 Log: loader: create separate lists for fd, cd and hd, merge bioscd with biosdisk Create unified block IO implementation in BIOS version, like it is done in UEFI side.

svn commit: r341329 - head/stand/efi/libefi

2018-11-30 Thread Toomas Soome
Author: tsoome Date: Fri Nov 30 08:42:14 2018 New Revision: 341329 URL: https://svnweb.freebsd.org/changeset/base/341329 Log: loader.efi: fix EFI getchar() for multiple consoles This fix is ported from illumos (issue #9970), the analysis and initial implementation was done by John Levon.

svn commit: r341438 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-12-03 Thread Toomas Soome
Author: tsoome Date: Mon Dec 3 19:35:21 2018 New Revision: 341438 URL: https://svnweb.freebsd.org/changeset/base/341438 Log: zfs: we can boot from dataset with large_dnode enabled loader has been supporting large_dnode for some time, no need to block the feature for boot dataset. Re

svn commit: r342151 - head/stand/libsa/zfs

2018-12-16 Thread Toomas Soome
Author: tsoome Date: Sun Dec 16 08:58:14 2018 New Revision: 342151 URL: https://svnweb.freebsd.org/changeset/base/342151 Log: loader: zfs reader should not probe partitionless disks First of all, normal setups can not boot such pools as the tools do not support installing boot programs.

svn commit: r342161 - head/stand/libsa/zfs

2018-12-16 Thread Toomas Soome
Author: tsoome Date: Mon Dec 17 07:43:29 2018 New Revision: 342161 URL: https://svnweb.freebsd.org/changeset/base/342161 Log: loader: zfs reader should not probe partitionless disks (UEFI case) With r342151 I did fix the BIOS version of zfs_probe_dev() from accessing the whole disk, but t

svn commit: r342617 - stable/12/stand/efi/libefi

2018-12-30 Thread Toomas Soome
Author: tsoome Date: Sun Dec 30 09:05:02 2018 New Revision: 342617 URL: https://svnweb.freebsd.org/changeset/base/342617 Log: MFC r341329: loader.efi: fix EFI getchar() for multiple consoles This fix is ported from illumos (issue #9970), the analysis and initial implementation was done

svn commit: r307865 - head/sys/boot/zfs

2016-10-24 Thread Toomas Soome
Author: tsoome Date: Mon Oct 24 16:28:54 2016 New Revision: 307865 URL: https://svnweb.freebsd.org/changeset/base/307865 Log: loader should boot pre-feature flags pools. The feature flags chek is missing the corner case where we have valid pool version, but feature flags are not enabled -

svn commit: r335125 - head/stand/libsa

2018-06-14 Thread Toomas Soome
Author: tsoome Date: Thu Jun 14 08:58:10 2018 New Revision: 335125 URL: https://svnweb.freebsd.org/changeset/base/335125 Log: libsa: cstyle cleanup for open/close/read/write sources Modified: head/stand/libsa/close.c head/stand/libsa/open.c head/stand/libsa/read.c head/stand/libsa/write

svn commit: r335126 - head/stand/libsa

2018-06-14 Thread Toomas Soome
Author: tsoome Date: Thu Jun 14 09:06:53 2018 New Revision: 335126 URL: https://svnweb.freebsd.org/changeset/base/335126 Log: libsa: f_rabuf could be NULL It is possible that we will not get RA buffer from open(), therefore we must validate RA. Modified: head/stand/libsa/read.c Modifi

svn commit: r335127 - head/stand/libsa

2018-06-14 Thread Toomas Soome
Author: tsoome Date: Thu Jun 14 09:10:34 2018 New Revision: 335127 URL: https://svnweb.freebsd.org/changeset/base/335127 Log: libsa: remobe unneeded check before free() free() is checking for NULL, remove duplicate check. Modified: head/stand/libsa/close.c Modified: head/stand/libsa/clo

svn commit: r335148 - head/stand/libsa

2018-06-14 Thread Toomas Soome
Author: tsoome Date: Thu Jun 14 16:11:50 2018 New Revision: 335148 URL: https://svnweb.freebsd.org/changeset/base/335148 Log: libsa: open() should use NULL instead of typecasted 0 Modified: head/stand/libsa/open.c Modified: head/stand/libsa/open.c

svn commit: r345631 - stable/12/stand/libsa

2019-03-28 Thread Toomas Soome
Author: tsoome Date: Thu Mar 28 08:38:31 2019 New Revision: 345631 URL: https://svnweb.freebsd.org/changeset/base/345631 Log: MFC: r344248,r344387 cd9660: dirmatch fails to unmatch when name is prefix for directory record Loader does fail to properly match the file name in directory re

svn commit: r345998 - head/stand/common

2019-04-07 Thread Toomas Soome
Author: tsoome Date: Sun Apr 7 11:48:41 2019 New Revision: 345998 URL: https://svnweb.freebsd.org/changeset/base/345998 Log: loader: malloc+bzero is calloc Replace malloc+bzero in module.c with calloc. MFC after:1w Modified: head/stand/common/module.c Modified: head/stand/comm

svn commit: r345999 - head/stand/common

2019-04-07 Thread Toomas Soome
Author: tsoome Date: Sun Apr 7 11:50:41 2019 New Revision: 345999 URL: https://svnweb.freebsd.org/changeset/base/345999 Log: loader: file_addmodule should check for memory allocation strdup() can return NULL. MFC after:1w Modified: head/stand/common/module.c Modified: head/sta

svn commit: r346000 - head/stand/common

2019-04-07 Thread Toomas Soome
Author: tsoome Date: Sun Apr 7 11:55:11 2019 New Revision: 346000 URL: https://svnweb.freebsd.org/changeset/base/346000 Log: loader: remove pointer checks before free() in module.c free() does check for NULL argument, remove duplicate checks. MFC after:1w Modified: head/stand/c

svn commit: r346001 - head/stand/common

2019-04-07 Thread Toomas Soome
Author: tsoome Date: Sun Apr 7 12:10:19 2019 New Revision: 346001 URL: https://svnweb.freebsd.org/changeset/base/346001 Log: loader: file_addmetadata() should check for memory allocation malloc() can return NULL. MFC after:1w Modified: head/stand/common/module.c Modified: head

svn commit: r346002 - head/stand/common

2019-04-07 Thread Toomas Soome
Author: tsoome Date: Sun Apr 7 12:20:17 2019 New Revision: 346002 URL: https://svnweb.freebsd.org/changeset/base/346002 Log: loader: mod_loadkld() error: we previously assumed 'last_file' could be null The last_file variable is used to reset the loadaddr variable back to original value;

svn commit: r346007 - head/stand/common

2019-04-07 Thread Toomas Soome
Author: tsoome Date: Sun Apr 7 13:36:17 2019 New Revision: 346007 URL: https://svnweb.freebsd.org/changeset/base/346007 Log: loader: add file_remove() function to undo file_insert_tail(). 346002 did miss the fact that we do not only undo the loadaddr, but also we need to remove the inser

svn commit: r346008 - head/stand/efi/loader

2019-04-07 Thread Toomas Soome
Author: tsoome Date: Sun Apr 7 14:07:28 2019 New Revision: 346008 URL: https://svnweb.freebsd.org/changeset/base/346008 Log: loader: command_lsefi: ret can be used uninitialized MFC after:1w Modified: head/stand/efi/loader/main.c Modified: head/stand/efi/loader/main.c =

svn commit: r346759 - in head/stand: . common efi/loader i386/loader

2019-04-26 Thread Toomas Soome
and/common/vdisk.c == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/stand/common/vdisk.c Fri Apr 26 17:58:44 2019(r346759) @@ -0,0 +1,417 @@ +/*- + * Copyright 2019 To

svn commit: r346969 - head/stand/i386/zfsboot

2019-04-30 Thread Toomas Soome
Author: tsoome Date: Tue Apr 30 17:45:22 2019 New Revision: 346969 URL: https://svnweb.freebsd.org/changeset/base/346969 Log: zfsboot: to detect disk size, use GPT information first If we do have GPT on disk, read the disk size from it and do not call int13. Since int13 does report b

svn commit: r347142 - head/stand/common

2019-05-04 Thread Toomas Soome
Author: tsoome Date: Sun May 5 06:38:47 2019 New Revision: 347142 URL: https://svnweb.freebsd.org/changeset/base/347142 Log: loader: validate sectorsize argument in disk_open() The bug and patch is reported against 11.2, but it is good idea to have the check in place for all versions.

svn commit: r347179 - stable/12/stand/common

2019-05-06 Thread Toomas Soome
Author: tsoome Date: Mon May 6 08:32:49 2019 New Revision: 347179 URL: https://svnweb.freebsd.org/changeset/base/347179 Log: MFC r347142: loader: validate sectorsize argument in disk_open() The bug and patch is reported against 11.2, but it is good idea to have the check in place fo

svn commit: r347182 - stable/11/stand/common

2019-05-06 Thread Toomas Soome
Author: tsoome Date: Mon May 6 08:55:23 2019 New Revision: 347182 URL: https://svnweb.freebsd.org/changeset/base/347182 Log: MFC r347142: loader: validate sectorsize argument in disk_open() The bug and patch is reported against 11.2, but it is good idea to have the check in place fo

svn commit: r304025 - head/share/misc

2016-08-12 Thread Toomas Soome
) @@ -312,6 +312,7 @@ theraven [label="David Chisnall\ntherave thompsa [label="Andrew Thompson\nthom...@freebsd.org\n2005/05/25"] ticso [label="Bernd Walter\nti...@freebsd.org\n2002/01/31"] tijl [label="Tijl Coosemans\nt...@freebsd.org\n2010/07/16"] +tsoome [labe

svn commit: r304317 - head/sys/boot/efi/boot1

2016-08-17 Thread Toomas Soome
Author: tsoome Date: Wed Aug 17 21:29:57 2016 New Revision: 304317 URL: https://svnweb.freebsd.org/changeset/base/304317 Log: boot1.efi Free() should check for NULL to provide consistent behavior with libstand Free(). Reviewed by: imp Approved by: imp (mentor) Differential Revision:

svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/zf...

2016-08-17 Thread Toomas Soome
const uint32_t *ipend = ip + (size / sizeof (uint32_t)); @@ -77,7 +78,8 @@ fletcher_4_native(const void *buf, uint6 } static void -fletcher_4_byteswap(const void *buf, uint64_t size, zio_cksum_t *zcp) +fletcher_4_byteswap(const void *buf, uint64_t size, +const void *ctx_template __unu

Re: svn commit: r304187 - in head: . share/man/man4 sys/conf sys/dev/mcd sys/modules sys/modules/mcd

2016-08-19 Thread Toomas Soome
> On 19. aug 2016, at 10:39, Konstantin Belousov wrote: > > On Thu, Aug 18, 2016 at 09:28:57PM -0600, Warner Losh wrote: >> On Thu, Aug 18, 2016 at 12:50 AM, Julian Elischer wrote: >>> On 16/08/2016 4:54 AM, John Baldwin wrote: On Monday, August 15, 2016 08:38:02 PM John Baldwin wrot

Re: svn commit: r304187 - in head: . share/man/man4 sys/conf sys/dev/mcd sys/modules sys/modules/mcd

2016-08-19 Thread Toomas Soome
> On 19. aug 2016, at 12:24, Konstantin Belousov wrote: > > On Fri, Aug 19, 2016 at 11:50:35AM +0300, Toomas Soome wrote: >> >>> On 19. aug 2016, at 10:39, Konstantin Belousov wrote: >>> >>> On Thu, Aug 18, 2016 at 09:28:57PM -0600, Warner Losh wr

svn commit: r304532 - in head/sys/boot: common efi/loader/arch/amd64 fdt

2016-08-20 Thread Toomas Soome
Author: tsoome Date: Sat Aug 20 16:23:19 2016 New Revision: 304532 URL: https://svnweb.freebsd.org/changeset/base/304532 Log: loader is filling fixed length command_errbuf with sprintf() and is trusting strings provided by user/config files. This update is replacing sprintf with snprintf for

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

2016-08-22 Thread Toomas Soome
> On 22. aug 2016, at 11:09, Andriy Gapon wrote: > > On 22/08/2016 10:20, Andriy Gapon wrote: >> This commit breaks boot process for me and in a quite weird way. >> I don't have a serial console, so a couple of screenshots. >> This is what happens with this change: >> https://people.freebsd.org/

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

2016-08-22 Thread Toomas Soome
> On 22. aug 2016, at 17:19, Warner Losh wrote: > > On Mon, Aug 22, 2016 at 3:44 AM, Toomas Soome wrote: >> I do suspect the size difference there is partially due to ficl, in illumos >> (ficl 4): >> >> -rw-r--r-- 1 tsoome staff 132508 aug 22 09:18 l

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

2016-08-23 Thread Toomas Soome
> On 22. aug 2016, at 17:56, Toomas Soome wrote: > > >> On 22. aug 2016, at 17:19, Warner Losh wrote: >> >> On Mon, Aug 22, 2016 at 3:44 AM, Toomas Soome wrote: >>> I do suspect the size difference there is partially due to ficl, in illumos >>

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

2016-08-23 Thread Toomas Soome
> On 23. aug 2016, at 11:22, Andriy Gapon wrote: > > On 22/08/2016 17:56, Toomas Soome wrote: >> Actually I only now realized I was comparing apples with oranges… I forgot >> the fbsd builds 32bit version in ficl32, this one is 64bit. and yes the 32bit >> versi

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

2016-08-23 Thread Toomas Soome
> On 23. aug 2016, at 14:29, Slawa Olhovchenkov wrote: > > On Tue, Aug 23, 2016 at 11:05:47AM +0300, Toomas Soome wrote: > >> >>> On 22. aug 2016, at 17:56, Toomas Soome wrote: >>> >>> >>>> On 22. aug 2016, at 17:19, Warner Losh

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

2016-08-23 Thread Toomas Soome
> On 23. aug 2016, at 15:16, Slawa Olhovchenkov wrote: > > On Tue, Aug 23, 2016 at 03:00:32PM +0300, Toomas Soome wrote: > >> >>> On 23. aug 2016, at 14:29, Slawa Olhovchenkov wrote: >>> >>> On Tue, Aug 23, 2016 at 11:05:47AM +0300, Toomas Soom

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

2016-08-23 Thread Toomas Soome
> On 23. aug 2016, at 15:36, Slawa Olhovchenkov wrote: > > On Tue, Aug 23, 2016 at 03:26:04PM +0300, Toomas Soome wrote: > >>> Main trouble (by kib@) is 640KB real mode limit. >>> Separated heap don't soled this. >>> May be solution is early swi

svn commit: r304753 - head/sys/cddl/boot/zfs

2016-08-24 Thread Toomas Soome
Author: tsoome Date: Wed Aug 24 16:30:15 2016 New Revision: 304753 URL: https://svnweb.freebsd.org/changeset/base/304753 Log: Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointer The issue was introduced with adding support for salted checksums, and was revealed by bh

svn commit: r304754 - head/sys/boot/userboot/userboot

2016-08-24 Thread Toomas Soome
Author: tsoome Date: Wed Aug 24 16:40:29 2016 New Revision: 304754 URL: https://svnweb.freebsd.org/changeset/base/304754 Log: Bug 212038 - svn commit: r304321 broken bhyve zvol VM bhyveload hang 100% WCPU As the support for large blocks was enabled in loader zfs code, the heap in userboot

svn commit: r304850 - head/lib/libstand

2016-08-26 Thread Toomas Soome
Author: tsoome Date: Fri Aug 26 14:58:57 2016 New Revision: 304850 URL: https://svnweb.freebsd.org/changeset/base/304850 Log: Unused variables and cstyle fix for loader dosfs Reviewed by: imp, allanjude Approved by: imp (mentor), allanjude (mentor) Differential Revision:https:

svn commit: r344248 - head/stand/libsa

2019-02-18 Thread Toomas Soome
Author: tsoome Date: Mon Feb 18 08:26:18 2019 New Revision: 344248 URL: https://svnweb.freebsd.org/changeset/base/344248 Log: cd9660: dirmatch fails to unmatch when name is prefix for directory record Loader does fail to properly match the file name in directory record and does open file

svn commit: r344268 - head/stand/common

2019-02-18 Thread Toomas Soome
Author: tsoome Date: Mon Feb 18 20:29:19 2019 New Revision: 344268 URL: https://svnweb.freebsd.org/changeset/base/344268 Log: loader: ptable_close() should check its argument If the passed in table is NULL, just return. Modified: head/stand/common/part.c Modified: head/stand/common/part

svn commit: r344387 - head/stand/libsa

2019-02-20 Thread Toomas Soome
Author: tsoome Date: Wed Feb 20 21:07:09 2019 New Revision: 344387 URL: https://svnweb.freebsd.org/changeset/base/344387 Log: loader: really fix cd9660 dirmatch The cd9660_open() does pass whole path to dirmatch() and we need to compare only the current path component, not full path.

svn commit: r351837 - head/stand/ficl

2019-09-05 Thread Toomas Soome
Author: tsoome Date: Thu Sep 5 09:04:48 2019 New Revision: 351837 URL: https://svnweb.freebsd.org/changeset/base/351837 Log: ficl: add uIsGreater word For some reason we have u< but not u>, fix it. Modified: head/stand/ficl/words.c Modified: head/stand/ficl/words.c

svn commit: r351865 - head/stand/ficl/softwords

2019-09-05 Thread Toomas Soome
Author: tsoome Date: Thu Sep 5 15:06:30 2019 New Revision: 351865 URL: https://svnweb.freebsd.org/changeset/base/351865 Log: ficl: add xemit word While emit will output one byte on screen, the xemit will output xchar. See: http://forth-standard.org/standard/xchar/XEMIT Modified: he

svn commit: r351881 - head/sys/teken

2019-09-05 Thread Toomas Soome
Author: tsoome Date: Thu Sep 5 18:07:40 2019 New Revision: 351881 URL: https://svnweb.freebsd.org/changeset/base/351881 Log: Adjust teken to allow build as part of loader Building for loader needs specific headers. Modified: head/sys/teken/teken.c Modified: head/sys/teken/teken.c =

svn commit: r351900 - in head/stand: . efi/include efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/i386 forth i386/libi386 lua

2019-09-05 Thread Toomas Soome
Author: tsoome Date: Thu Sep 5 22:15:50 2019 New Revision: 351900 URL: https://svnweb.freebsd.org/changeset/base/351900 Log: loader: use teken teminal emulator for x86 and uefi Replace mini cons25 emulator with teken, this does enable us proper console terminal for loader and will make i

svn commit: r351959 - head/stand/efi/libefi

2019-09-06 Thread Toomas Soome
Author: tsoome Date: Fri Sep 6 19:30:23 2019 New Revision: 351959 URL: https://svnweb.freebsd.org/changeset/base/351959 Log: loader.efi: UEFI text mode background colors are only using 3 bits Need to mask background colors to pass allowed value. Modified: head/stand/efi/libefi/efi_conso

svn commit: r352032 - in head/stand: . i386/loader

2019-09-08 Thread Toomas Soome
Author: tsoome Date: Sun Sep 8 19:39:45 2019 New Revision: 352032 URL: https://svnweb.freebsd.org/changeset/base/352032 Log: loader: --gc-sections needs sections to work with --gc-sections is not really useful unless we generate sections with -ffunction-sections -fdata-sections Whil

svn commit: r352037 - head/stand/i386/zfsloader

2019-09-08 Thread Toomas Soome
Author: tsoome Date: Sun Sep 8 19:54:28 2019 New Revision: 352037 URL: https://svnweb.freebsd.org/changeset/base/352037 Log: remove leftover zfsloader directory It really is empty. Deleted: head/stand/i386/zfsloader/ ___ svn-src-all@freebsd.or

svn commit: r352195 - in head/stand/i386: libi386 loader

2019-09-10 Thread Toomas Soome
Author: tsoome Date: Tue Sep 10 21:53:42 2019 New Revision: 352195 URL: https://svnweb.freebsd.org/changeset/base/352195 Log: loader: vidconsole should set LINES and COLUMNS Set LINES and COLUMNS based on terminal dimensions. Modified: head/stand/i386/libi386/vidconsole.c head/stand/i3

svn commit: r352240 - in stable/11/stand/ficl: . softwords

2019-09-11 Thread Toomas Soome
Author: tsoome Date: Thu Sep 12 06:20:20 2019 New Revision: 352240 URL: https://svnweb.freebsd.org/changeset/base/352240 Log: MFC r351865, r351837: ficl: add xemit word ficl: add uIsGreater word (needed for xemit) We need xemit to support userboot.so loading images from CURRENT. Modifi

svn commit: r352241 - in stable/12/stand/ficl: . softwords

2019-09-11 Thread Toomas Soome
Author: tsoome Date: Thu Sep 12 06:26:22 2019 New Revision: 352241 URL: https://svnweb.freebsd.org/changeset/base/352241 Log: MFC r351865, r351837: ficl: add xemit word ficl: add uIsGreater word (needed for xemit) We need xemit to support userboot.so loading images from CURRENT. Modifi

svn commit: r352420 - head/stand/forth

2019-09-16 Thread Toomas Soome
Author: tsoome Date: Mon Sep 16 20:26:53 2019 New Revision: 352420 URL: https://svnweb.freebsd.org/changeset/base/352420 Log: loader_4th: scan_buffer can leave empty string on stack When the file processing is done, we will have string with lenght 0 in stack and we will attempt to alloca

svn commit: r352421 - head/stand/libsa

2019-09-16 Thread Toomas Soome
Author: tsoome Date: Mon Sep 16 20:28:08 2019 New Revision: 352421 URL: https://svnweb.freebsd.org/changeset/base/352421 Log: loader: Malloc(0) should return NULL. We really should not allocate anything with size 0. Modified: head/stand/libsa/zalloc_malloc.c Modified: head/stand/libsa/z

svn commit: r352439 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 09:47:35 2019 New Revision: 352439 URL: https://svnweb.freebsd.org/changeset/base/352439 Log: loader: factor out guard location setup from Realloc To simplify and make it easier to read, use ga_Bytes field from guard structure. Modified: head/stand/libsa

svn commit: r352443 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 11:35:53 2019 New Revision: 352443 URL: https://svnweb.freebsd.org/changeset/base/352443 Log: loader: cstyle cleanup libsa zalloc sources Clean up libstand zalloc* sources. Note that it is not 100% whitespace cleanup. I also reduced block in znalloc and zf

svn commit: r352444 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 13:07:02 2019 New Revision: 352444 URL: https://svnweb.freebsd.org/changeset/base/352444 Log: loader: stand.h should define reallocf as Reallocf Use the same approach as other zalloc functions. Modified: head/stand/libsa/stand.h Modified: head/stand/libsa

svn commit: r352445 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 13:15:27 2019 New Revision: 352445 URL: https://svnweb.freebsd.org/changeset/base/352445 Log: loader: add memalign() to libsa Implement memalign(size_t alignment, size_t size) to allocate aligned memory. Modified: head/stand/libsa/stand.h head/stand/libs

svn commit: r352446 - head/stand/efi/libefi

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 13:50:25 2019 New Revision: 352446 URL: https://svnweb.freebsd.org/changeset/base/352446 Log: loader.efi: efipart needs to use ioalign UEFI specification 2.7A, EFI_BLOCK_IO_PROTOCOL, page 566. The ioalign property does define the alignment of data buffer

svn commit: r352451 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 16:16:46 2019 New Revision: 352451 URL: https://svnweb.freebsd.org/changeset/base/352451 Log: loader: revert r352421 As insisted by kib, malloc(0) is quite legal. Modified: head/stand/libsa/zalloc_malloc.c Modified: head/stand/libsa/zalloc_malloc.c ==

svn commit: r352454 - head/stand/forth

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 18:05:33 2019 New Revision: 352454 URL: https://svnweb.freebsd.org/changeset/base/352454 Log: loader: provide u> and xemit words if needed We have external interpreter (userboot.so) which may be lagging behind with updates and may be missing u> xemit words.

svn commit: r352548 - head/stand/libsa

2019-09-19 Thread Toomas Soome
Author: tsoome Date: Fri Sep 20 05:22:34 2019 New Revision: 352548 URL: https://svnweb.freebsd.org/changeset/base/352548 Log: loader: fix typo in zalloc. Modified: head/stand/libsa/zalloc.c Modified: head/stand/libsa/zalloc.c ==

svn commit: r352599 - head/stand/forth

2019-09-22 Thread Toomas Soome
Author: tsoome Date: Sun Sep 22 16:10:25 2019 New Revision: 352599 URL: https://svnweb.freebsd.org/changeset/base/352599 Log: loader_4th: menu items need to reset color attribute, not switch to white Forth menu kernel and BE entries, instead of resetting the color attribute, are switching

svn commit: r352601 - head/stand/lua

2019-09-22 Thread Toomas Soome
Author: tsoome Date: Sun Sep 22 17:39:20 2019 New Revision: 352601 URL: https://svnweb.freebsd.org/changeset/base/352601 Log: loader_lua: lua color changes should end with reset The color change should have reset sequence, not switch to white. Modified: head/stand/lua/color.lua head/st

svn commit: r352669 - in head/stand: efi/libefi i386/libi386

2019-09-25 Thread Toomas Soome
Author: tsoome Date: Wed Sep 25 07:09:25 2019 New Revision: 352669 URL: https://svnweb.freebsd.org/changeset/base/352669 Log: loader: add teken.fg_color and teken.bg_color variables Add settable variables to control teken default color attributes. The supported colors are 0-7 or basic col

svn commit: r352670 - in head/stand: efi/libefi i386/libi386

2019-09-25 Thread Toomas Soome
Author: tsoome Date: Wed Sep 25 07:36:35 2019 New Revision: 352670 URL: https://svnweb.freebsd.org/changeset/base/352670 Log: loader: fix indentation in efi_console and vidconsole Remove extra tab. Reported by: yuripv Modified: head/stand/efi/libefi/efi_console.c head/stand/i386/

svn commit: r352680 - head/sys/kern

2019-09-25 Thread Toomas Soome
Author: tsoome Date: Wed Sep 25 13:21:07 2019 New Revision: 352680 URL: https://svnweb.freebsd.org/changeset/base/352680 Log: kernel: terminal_init() should check for teken colors from kenv Check for teken.fg_color and teken.bg_color and prepare the color attributes accordingly. When

svn commit: r352681 - in head/sys/dev/vt: . hw/fb

2019-09-25 Thread Toomas Soome
Author: tsoome Date: Wed Sep 25 13:24:31 2019 New Revision: 352681 URL: https://svnweb.freebsd.org/changeset/base/352681 Log: vt: use colors from terminal emulator Instead of hardcoded colors, use terminal state. This also means, we need to record the pointer to terminal state with vtbuf.

svn commit: r352739 - head/sys/dev/vt/hw/fb

2019-09-26 Thread Toomas Soome
Author: tsoome Date: Thu Sep 26 07:14:54 2019 New Revision: 352739 URL: https://svnweb.freebsd.org/changeset/base/352739 Log: vt: use proper return value check with TUNABLE_INT_FETCH The TUNABLE_INT_FETCH is macro around getenv_int() and we will get return value 0 or 1 for failure or succ

svn commit: r352740 - head/sys/kern

2019-09-26 Thread Toomas Soome
Author: tsoome Date: Thu Sep 26 07:19:26 2019 New Revision: 352740 URL: https://svnweb.freebsd.org/changeset/base/352740 Log: kernel terminal should initialize fg and bg variables before calling TUNABLE_INT_FETCH We have two ways to check if kenv variable exists - either we check return

  1   2   3   4   5   6   >