svn commit: r352898 - head/tests/sys/kern

2019-09-30 Thread Eric van Gyzen
Author: vangyzen Date: Mon Sep 30 14:05:44 2019 New Revision: 352898 URL: https://svnweb.freebsd.org/changeset/base/352898 Log: Fix coredump_phnum_test when kern.compress_user_cores != 0 If `kern.compress_user_cores` is non-zero, decompress the core file. Use `sysctl -f` to restore pre

svn commit: r367059 - head/sys/ddb

2020-10-26 Thread Eric van Gyzen
Author: vangyzen Date: Mon Oct 26 16:42:53 2020 New Revision: 367059 URL: https://svnweb.freebsd.org/changeset/base/367059 Log: db_search_symbol: prevent pollution from bogus symbols The kernel will never map the first page, so any symbols in that range cannot refer to addresses. Some th

svn commit: r356705 - head/sys/fs/nfs

2020-01-13 Thread Eric van Gyzen
Author: vangyzen Date: Mon Jan 13 21:49:27 2020 New Revision: 356705 URL: https://svnweb.freebsd.org/changeset/base/356705 Log: Add missing comma in nfsv4_errstr Reported by: Coverity CID: 1412243 Sponsored by: Dell EMC Isilon Modified: head/sys/fs/nfs/nfsv4_errstr.h Modif

svn commit: r356706 - head/sbin/savecore

2020-01-13 Thread Eric van Gyzen
Author: vangyzen Date: Mon Jan 13 22:01:37 2020 New Revision: 356706 URL: https://svnweb.freebsd.org/changeset/base/356706 Log: savecore: include time zone in info.N file This helps with event correlation when machines are distributed across multiple time zones. Format the time with

svn commit: r356708 - head/usr.sbin/fstyp

2020-01-13 Thread Eric van Gyzen
Author: vangyzen Date: Mon Jan 13 22:33:48 2020 New Revision: 356708 URL: https://svnweb.freebsd.org/changeset/base/356708 Log: fstyp hammer: use strlcpy Use strlcpy to guarantee NUL termination. Due to this, there is no need for strncmp; simply use strcmp. Reported by: Coverity

svn commit: r356709 - head/usr.sbin/fstyp

2020-01-13 Thread Eric van Gyzen
Author: vangyzen Date: Mon Jan 13 22:36:29 2020 New Revision: 356709 URL: https://svnweb.freebsd.org/changeset/base/356709 Log: fstyp hammer2: remove dead code best_i will always be >= 0, so remove code to test otherwise. Reported by: Coverity CID: 1412244 MFC after:2

svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 st...

2020-05-12 Thread Eric van Gyzen
Author: vangyzen Date: Tue May 12 15:22:40 2020 New Revision: 360964 URL: https://svnweb.freebsd.org/changeset/base/360964 Log: Remove tests for obsolete compilers in the build system Assume gcc is at least 6.4, the oldest xtoolchain in the ports tree. Assume clang is at least 6, which wa

Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

2020-05-13 Thread Eric van Gyzen
> Why is this marked for MFC? FreeBSD 12 uses base GCC 4.2.1 on some platforms. You’re right, this won’t be MFC’d. My client is configured to add the MFC by default, and I failed to remove it. Eric ___ svn-src-all@freebsd.org mailing list https://li

svn commit: r361559 - head/lib/libifconfig

2020-05-27 Thread Eric van Gyzen
Author: vangyzen Date: Wed May 27 18:26:10 2020 New Revision: 361559 URL: https://svnweb.freebsd.org/changeset/base/361559 Log: libifconfig: remove redundant NULL check Submitted by: puneeth_kumar.jotha...@emc.com Reported by: Coverity Sponsored by: Dell EMC Isilon Modified: head/li

svn commit: r361605 - head/share/mk

2020-05-28 Thread Eric van Gyzen
Author: vangyzen Date: Thu May 28 21:56:31 2020 New Revision: 361605 URL: https://svnweb.freebsd.org/changeset/base/361605 Log: Revert part of r360964 ports/devel/linux_libusb builds FreeBSD libusb with GCC 4.8.5 from devel/linux-c7-devtools. Restore the tests for older GCC in bsd.sys.

svn commit: r361606 - head

2020-05-28 Thread Eric van Gyzen
Author: vangyzen Date: Thu May 28 22:05:33 2020 New Revision: 361606 URL: https://svnweb.freebsd.org/changeset/base/361606 Log: Add an UPDATING entry for r360964 Reported by: rpokala Sponsored by: Dell EMC Isilon Modified: head/UPDATING Modified: head/UPDATING ===

Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

2020-05-28 Thread Eric van Gyzen
On 5/25/20 3:37 AM, Tijl Coosemans wrote: On Tue, 12 May 2020 15:22:41 + (UTC) Eric van Gyzen wrote: Author: vangyzen Date: Tue May 12 15:22:40 2020 New Revision: 360964 URL: https://svnweb.freebsd.org/changeset/base/360964 Log: Remove tests for obsolete compilers in the build system

Re: svn commit: r361699 - head/sys/kern

2020-06-01 Thread Eric van Gyzen
void vfs_oexport_conv(const struct oexport_args *oexp, struct export_args *exp) { bcopy(oexp, exp, sizeof(*oexp)); - exp->ex_numsecflavors = 0; + if (exp->ex_flags & MNT_EXPORTED) { + exp->ex_numsecflavors = 1; + exp->ex_secflavors[0] = AUTH_SYS

svn commit: r362119 - in head/sys: amd64/amd64 i386/i386

2020-06-12 Thread Eric van Gyzen
Author: vangyzen Date: Fri Jun 12 21:10:45 2020 New Revision: 362119 URL: https://svnweb.freebsd.org/changeset/base/362119 Log: FPU init: Do potentially blocking operations before disabling interrupts In particular, uma_zcreate creates sysctl oids, which locks an sx lock, which uses IPIs

svn commit: r362120 - in head/sys: amd64/amd64 i386/i386

2020-06-12 Thread Eric van Gyzen
Author: vangyzen Date: Fri Jun 12 21:12:26 2020 New Revision: 362120 URL: https://svnweb.freebsd.org/changeset/base/362120 Log: FPU: make xsave_area_desc static ...because it can be. Reviewed by: cem kib MFC after:2 weeks Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r362121 - in head/sys: amd64/amd64 i386/i386

2020-06-12 Thread Eric van Gyzen
Author: vangyzen Date: Fri Jun 12 21:17:56 2020 New Revision: 362121 URL: https://svnweb.freebsd.org/changeset/base/362121 Log: FPU init: allocate initial state from UMA to ensure alignment The Intel Instruction Set Reference says this about the XSAVE instruction: Use of a destinat

svn commit: r362126 - head/sys/vm

2020-06-12 Thread Eric van Gyzen
Author: vangyzen Date: Fri Jun 12 21:53:08 2020 New Revision: 362126 URL: https://svnweb.freebsd.org/changeset/base/362126 Log: Honor db_pager_quit in some vm_object ddb commands These can be rather verbose. MFC after:2 weeks Sponsored by: Dell EMC Isilon Modified: head/sys/vm

svn commit: r365845 - head/lib/libpmc/pmu-events

2020-09-17 Thread Eric van Gyzen
Author: vangyzen Date: Thu Sep 17 18:24:51 2020 New Revision: 365845 URL: https://svnweb.freebsd.org/changeset/base/365845 Log: Fix additional memory leak in process_mapfile Additional Coverity detected memory leak fix. Submitted by: bret_ketc...@dell.com Reported by: Coverity Rev

svn commit: r365886 - in head/sys: dev/fb dev/ksyms dev/vt/hw/fb fs/tmpfs kern vm

2020-09-18 Thread Eric van Gyzen
Author: vangyzen Date: Fri Sep 18 16:48:08 2020 New Revision: 365886 URL: https://svnweb.freebsd.org/changeset/base/365886 Log: vm_ooffset_t is now unsigned vm_ooffset_t is now unsigned. Remove some tests for negative values, or make other adjustments accordingly. Reported by: Cover

svn commit: r365890 - head/sys/amd64/amd64

2020-09-18 Thread Eric van Gyzen
Author: vangyzen Date: Fri Sep 18 20:53:40 2020 New Revision: 365890 URL: https://svnweb.freebsd.org/changeset/base/365890 Log: amd64 pmap_pkru_same: prev_ppr was always NULL Fix the logic so it works as it appears. Reported by: Coverity Reviewed by: kib MFC after:2 weeks S

svn commit: r366345 - in head: contrib/netbsd-tests/usr.bin/grep usr.bin/grep

2020-10-01 Thread Eric van Gyzen
Author: vangyzen Date: Thu Oct 1 21:48:22 2020 New Revision: 366345 URL: https://svnweb.freebsd.org/changeset/base/366345 Log: zgrep: fix exit status with multiple files zgrep should exit with success when given multiple files and the pattern is found in at least one file. Prior to this

svn commit: r366346 - head/contrib/netbsd-tests/lib/libc/sys

2020-10-01 Thread Eric van Gyzen
Author: vangyzen Date: Thu Oct 1 21:52:57 2020 New Revision: 366346 URL: https://svnweb.freebsd.org/changeset/base/366346 Log: fix setitimer test for returned it_value An old it_value of {4,3} is valid. Allow it. Reviewed by: bdrewery MFC after:2 weeks Sponsored by: Dell EMC

svn commit: r366914 - head/sys/dev/ntb/test

2020-10-21 Thread Eric van Gyzen
Author: vangyzen Date: Wed Oct 21 17:11:57 2020 New Revision: 366914 URL: https://svnweb.freebsd.org/changeset/base/366914 Log: ntb_tool: ubuf is too small to hold a human readable 64 bit value ubuf buffer is too small. It should be 18 if a NULL is not needed, or 19 to hold the NULL termi

Re: svn commit: r362681 - in head: contrib/bc contrib/bc/gen contrib/bc/include contrib/bc/locales contrib/bc/manuals contrib/bc/src contrib/bc/src/bc contrib/bc/src/dc contrib/bc/src/history contrib/

2020-06-27 Thread Eric van Gyzen
On 6/27/20 8:11 AM, John Baldwin wrote: On 6/27/20 5:02 AM, Stefan Eßer wrote: Author: se Date: Sat Jun 27 12:02:01 2020 New Revision: 362681 URL: https://svnweb.freebsd.org/changeset/base/362681 Log: Import new 2-clause BSD licenced implementation of the bc and dc commands Hmm, I didn't s

svn commit: r363220 - in head/contrib/ofed: infiniband-diags/src libibumad libibverbs libibverbs/examples libmlx5 librdmacm/examples opensm/opensm

2020-07-15 Thread Eric van Gyzen
Author: vangyzen Date: Wed Jul 15 13:17:16 2020 New Revision: 363220 URL: https://svnweb.freebsd.org/changeset/base/363220 Log: Fix Coverity issues in OFED read_ibdiag_config NULL deref read_ibdiag_config mem leak ib_mad_inv_field_str Missing comma in a string array initialization pri

svn commit: r363221 - head/contrib/ofed/libibverbs/examples

2020-07-15 Thread Eric van Gyzen
Author: vangyzen Date: Wed Jul 15 13:26:15 2020 New Revision: 363221 URL: https://svnweb.freebsd.org/changeset/base/363221 Log: Fix style in r363220 Apply the style change Kostik suggested in the review. Reported by: kib MFC after:2 weeks X-MFC with: r363220 Sponsored by:

Re: svn commit: r363607 - head/sys/vm

2020-07-28 Thread Eric van Gyzen
On 7/27/20 9:25 AM, Mark Johnston wrote: + + /* +* We may be attempting to free the page as part of the handling for an +* I/O error, in which case the page was xbusied by a different thread. +*/ + vm_page_xbusy_claim(m); I've just noticed that vm_page_xbusy_

svn commit: r363866 - head/lib/libdevinfo

2020-08-04 Thread Eric van Gyzen
Author: vangyzen Date: Tue Aug 4 21:05:53 2020 New Revision: 363866 URL: https://svnweb.freebsd.org/changeset/base/363866 Log: devinfo: fix memory leak on error paths Refactor to create devinfo_free_dev(). Call it to plug a memory leak on two error paths in devinfo_init_devices().

svn commit: r363867 - head/lib/libdevinfo

2020-08-04 Thread Eric van Gyzen
Author: vangyzen Date: Tue Aug 4 21:09:36 2020 New Revision: 363867 URL: https://svnweb.freebsd.org/changeset/base/363867 Log: devinfo: add man page links Add man page links for all functions in devinfo(3). Reported by: vim MFC after:2 weeks Sponsored by: Dell EMC Isilon Mod

svn commit: r343671 - head/lib/msun

2019-02-01 Thread Eric van Gyzen
Author: vangyzen Date: Fri Feb 1 23:15:54 2019 New Revision: 343671 URL: https://svnweb.freebsd.org/changeset/base/343671 Log: libm: squelch -Woverflow from gcc6 Sponsored by: Dell EMC Isilon Modified: head/lib/msun/Makefile Modified: head/lib/msun/Makefile

svn commit: r343672 - head/libexec/rtld-elf/i386

2019-02-01 Thread Eric van Gyzen
Author: vangyzen Date: Fri Feb 1 23:16:59 2019 New Revision: 343672 URL: https://svnweb.freebsd.org/changeset/base/343672 Log: rtld: pacify -Wmaybe-uninitialized from gcc6 Sponsored by: Dell EMC Isilon Modified: head/libexec/rtld-elf/i386/reloc.c Modified: head/libexec/rtld-elf/i386/re

svn commit: r353111 - head/sys/sys

2019-10-04 Thread Eric van Gyzen
Author: vangyzen Date: Fri Oct 4 21:39:11 2019 New Revision: 353111 URL: https://svnweb.freebsd.org/changeset/base/353111 Log: Add CTLFLAG_STATS to all COUNTER_U64* sysctl OIDs CTLFLAG_STATS identifies a sysctl OID as statistical or informational, as opposed to a configurable/tunable OID

svn commit: r353112 - head/sys/kern

2019-10-04 Thread Eric van Gyzen
Author: vangyzen Date: Fri Oct 4 21:43:43 2019 New Revision: 353112 URL: https://svnweb.freebsd.org/changeset/base/353112 Log: Add CTLFLAG_STATS to some vfs sysctl OIDs Add CTLFLAG_STATS to the following OIDs: vfs.altbufferflushes vfs.recursiveflushes vfs.barrierwrites vfs.flush

svn commit: r353113 - head/sys/ufs/ffs

2019-10-04 Thread Eric van Gyzen
Author: vangyzen Date: Fri Oct 4 21:44:52 2019 New Revision: 353113 URL: https://svnweb.freebsd.org/changeset/base/353113 Log: Add CTLFLAG_STATS to several debug.softdep sysctl OIDs Refer to r353111. MFC after:2 weeks Sponsored by: Dell EMC Isilon Modified: head/sys/ufs/ffs/f

svn commit: r353114 - head/sys/x86/x86

2019-10-04 Thread Eric van Gyzen
Author: vangyzen Date: Fri Oct 4 21:46:11 2019 New Revision: 353114 URL: https://svnweb.freebsd.org/changeset/base/353114 Log: Make the hw.intrs sysctl OID read-only The handler ignores the new value, so make the OID read-only. I found this while working on r353111. MFC after:

svn commit: r353305 - head/tests/sys/kern

2019-10-08 Thread Eric van Gyzen
Author: vangyzen Date: Tue Oct 8 13:43:05 2019 New Revision: 353305 URL: https://svnweb.freebsd.org/changeset/base/353305 Log: Fix problems in the kern_maxfiles__increase test ATF functions such as ATF_REQUIRE do not work correctly in child processes. Use plain C functions to report erro

svn commit: r353344 - head/sys/dev/ioat

2019-10-09 Thread Eric van Gyzen
Author: vangyzen Date: Wed Oct 9 12:14:10 2019 New Revision: 353344 URL: https://svnweb.freebsd.org/changeset/base/353344 Log: Add CTLFLAG_STATS to the dev.ioat.N.stats sysctl OIDs Refer to r353111. MFC after:2 weeks Sponsored by: Dell EMC Isilon Modified: head/sys/dev/ioat/i

svn commit: r353448 - head/tests/sys/kern

2019-10-11 Thread Eric van Gyzen
Author: vangyzen Date: Fri Oct 11 21:23:46 2019 New Revision: 353448 URL: https://svnweb.freebsd.org/changeset/base/353448 Log: coredump_phnum_test: handle full file system gracefully Skip the test if the file system is full. That's out of scope of this test. MFC after:1 week

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-20 Thread Eric van Gyzen
+ sz = asprintf(&buf, M_TEMP, "%s-%s-%s", uuid, if_name(ifp), + jailname); + if (sz < 0) { + /* Fall back to a random mac address. */ I was wondering if it would be valuable to give this fall back something like: printf("%s: unable to create fixe

svn commit: r360233 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src lib/libc/stdlib/jemalloc

2020-04-23 Thread Eric van Gyzen
Author: vangyzen Date: Thu Apr 23 23:57:43 2020 New Revision: 360233 URL: https://svnweb.freebsd.org/changeset/base/360233 Log: Update jemalloc to version 5.2.1 Revert r354606 to restore r354605. Apply one line from jemalloc commit d01b425e5d1e1 in hash_x86_128() to fix the build wit

svn commit: r360328 - in head/sys: kern sys x86/x86

2020-04-25 Thread Eric van Gyzen
Author: vangyzen Date: Sun Apr 26 00:41:29 2020 New Revision: 360328 URL: https://svnweb.freebsd.org/changeset/base/360328 Log: Fix handling of NMIs from unknown sources (BMC, hypervisor) Release kernels have no KDB backends enabled, so they discard an NMI if it is not due to a hardware f

svn commit: r354548 - in head/sys: amd64/amd64 i386/i386

2019-11-08 Thread Eric van Gyzen
Author: vangyzen Date: Fri Nov 8 16:30:55 2019 New Revision: 354548 URL: https://svnweb.freebsd.org/changeset/base/354548 Log: vmm: pass M_WAITOK to uma_zalloc when allocating FPU save area Submitted by: patrick.sulliv...@dell.com Reviewed by: markj MFC after:2 weeks Sponsored b

svn commit: r354624 - head/usr.bin/tip/tip

2019-11-11 Thread Eric van Gyzen
Author: vangyzen Date: Mon Nov 11 17:41:52 2019 New Revision: 354624 URL: https://svnweb.freebsd.org/changeset/base/354624 Log: tip/cu: check for EOF on input on the local side If cu reads an EOF on the input side, it goes into a tight loop sending a garbage byte to the remote. With this

svn commit: r355369 - stable/12/usr.bin/tip/tip

2019-12-03 Thread Eric van Gyzen
Author: vangyzen Date: Tue Dec 3 22:57:10 2019 New Revision: 355369 URL: https://svnweb.freebsd.org/changeset/base/355369 Log: MFC r354624 tip/cu: check for EOF on input on the local side If cu reads an EOF on the input side, it goes into a tight loop sending a garbage byte to the r

svn commit: r355370 - stable/11/usr.bin/tip/tip

2019-12-03 Thread Eric van Gyzen
Author: vangyzen Date: Tue Dec 3 22:59:55 2019 New Revision: 355370 URL: https://svnweb.freebsd.org/changeset/base/355370 Log: MFC r354624 tip/cu: check for EOF on input on the local side If cu reads an EOF on the input side, it goes into a tight loop sending a garbage byte to the r

Re: svn commit: r355436 - in head/sys: amd64/amd64 x86/x86

2019-12-06 Thread Eric van Gyzen
> On Dec 6, 2019, at 4:36 AM, Ed Maste wrote: > > On Thu, 5 Dec 2019 at 21:43, Scott Long wrote: >> >> Author: scottl >> Date: Fri Dec 6 02:43:05 2019 >> New Revision: 355436 >> URL: https://svnweb.freebsd.org/changeset/base/355436 >> >> Log: >> Move the mds, irbs, and ssb mitigation knobs

svn commit: r355593 - head/sbin/fsck_ffs

2019-12-10 Thread Eric van Gyzen
Author: vangyzen Date: Tue Dec 10 20:04:08 2019 New Revision: 355593 URL: https://svnweb.freebsd.org/changeset/base/355593 Log: fsck_ffs: fix some memory leaks found by Coverity. Reported by: Coverity CID: 1380549 1380550 1380551 MFC after:1 week Sponsored by: Dell EMC I

svn commit: r339225 - head/sys/dev/e1000

2018-10-07 Thread Eric van Gyzen
Author: vangyzen Date: Mon Oct 8 01:28:46 2018 New Revision: 339225 URL: https://svnweb.freebsd.org/changeset/base/339225 Log: em/igb: Do not print link state messages These messages are totally redundant with the iflib messages. They're also not very useful, since they don't include th

svn commit: r339917 - head/sys/kern

2018-10-30 Thread Eric van Gyzen
Author: vangyzen Date: Tue Oct 30 14:54:15 2018 New Revision: 339917 URL: https://svnweb.freebsd.org/changeset/base/339917 Log: Always stop the scheduler when entering kdb Set curthread->td_stopsched when entering kdb via any vector. Previously, it was only set when entering via panic, so

svn commit: r340084 - in vendor/expat/dist: . doc examples lib tests tests/benchmark xmlwf

2018-11-02 Thread Eric van Gyzen
Author: vangyzen Date: Fri Nov 2 22:10:07 2018 New Revision: 340084 URL: https://svnweb.freebsd.org/changeset/base/340084 Log: Vendor import of expat 2.2.6 Sponsored by: Dell EMC Isilon Added: vendor/expat/dist/AUTHORS (contents, props changed) vendor/expat/dist/Makefile.am (conte

svn commit: r340085 - vendor/expat/2.2.6

2018-11-02 Thread Eric van Gyzen
Author: vangyzen Date: Fri Nov 2 22:12:30 2018 New Revision: 340085 URL: https://svnweb.freebsd.org/changeset/base/340085 Log: Tag expat 2.2.6 Sponsored by: Dell EMC Isilon Added: vendor/expat/2.2.6/ - copied from r340084, vendor/expat/dist/

svn commit: r340127 - in head: contrib/expat contrib/expat/doc contrib/expat/examples contrib/expat/lib contrib/expat/tests contrib/expat/tests/benchmark contrib/expat/xmlwf lib/libexpat

2018-11-04 Thread Eric van Gyzen
Author: vangyzen Date: Sun Nov 4 16:08:59 2018 New Revision: 340127 URL: https://svnweb.freebsd.org/changeset/base/340127 Log: Update expat to 2.2.6 Update contrib/expat by merging from the vendor branch. Update expat_config.h manually, using make -C /usr/ports/textproc/expat2 c

svn commit: r340257 - head/sys/netinet6

2018-11-08 Thread Eric van Gyzen
Author: vangyzen Date: Thu Nov 8 19:50:23 2018 New Revision: 340257 URL: https://svnweb.freebsd.org/changeset/base/340257 Log: in6_ifattach_linklocal: handle immediate removal of the new LLA If another thread immediately removes the link-local address added by in6_update_ifa(), in6ifa_if

svn commit: r340328 - head

2018-11-10 Thread Eric van Gyzen
Author: vangyzen Date: Sat Nov 10 19:09:48 2018 New Revision: 340328 URL: https://svnweb.freebsd.org/changeset/base/340328 Log: Update comment about 'universe' disk usage It's 167 GB now (or 81 GB with ZFS lz4). MFC after:2 weeks Sponsored by: Dell EMC Isilon Modified: head/Ma

svn commit: r340345 - head/usr.sbin/periodic/etc/daily

2018-11-10 Thread Eric van Gyzen
Author: vangyzen Date: Sun Nov 11 00:39:20 2018 New Revision: 340345 URL: https://svnweb.freebsd.org/changeset/base/340345 Log: Fix daily mailq script for Postfix and daily_show_success="NO" Exit with a zero status when Postfix reports "Mail queue is empty" so this section won't appear in

svn commit: r340409 - head/sys/kern

2018-11-13 Thread Eric van Gyzen
Author: vangyzen Date: Tue Nov 13 20:48:05 2018 New Revision: 340409 URL: https://svnweb.freebsd.org/changeset/base/340409 Log: Make no assertions about lock state when the scheduler is stopped. Change the assert paths in rm, rw, and sx locks to match the lock and unlock paths. I did thi

svn commit: r340446 - in stable/12/sys/dev: amdsmn amdtemp

2018-11-14 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 14 21:31:26 2018 New Revision: 340446 URL: https://svnweb.freebsd.org/changeset/base/340446 Log: MFC r340425 (by cem) amdsmn(4)/amdtemp(4): Attach to Ryzen 2 hostbridges As reported, tested, and patch supplied by Johannes. There may be future work to

svn commit: r340447 - stable/12/sys/dev/amdtemp

2018-11-14 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 14 22:05:20 2018 New Revision: 340447 URL: https://svnweb.freebsd.org/changeset/base/340447 Log: MFC r340426 (by cem) amdtemp(4): Fix temperature reporting on AMD 2990WX Update the AMD family 17h temperature reporting based on AMD Tech Doc 56255 OSRR, s

svn commit: r308293 - head/usr.bin/fortune/datfiles

2016-11-04 Thread Eric van Gyzen
Author: vangyzen Date: Fri Nov 4 15:11:51 2016 New Revision: 308293 URL: https://svnweb.freebsd.org/changeset/base/308293 Log: Fix grammar in a fortune. Modified: head/usr.bin/fortune/datfiles/fortunes Modified: head/usr.bin/fortune/datfiles/fortunes

svn commit: r308340 - head/usr.bin/ncal

2016-11-05 Thread Eric van Gyzen
Author: vangyzen Date: Sat Nov 5 14:08:14 2016 New Revision: 308340 URL: https://svnweb.freebsd.org/changeset/base/308340 Log: ncal: fix a reference to an out-of-scope stack buffer PR: 214237 Submitted by: Jonathan de Boyne Pollard MFC after:3 days Sponsored by: Dell EM

svn commit: r308342 - head/usr.bin/fortune/datfiles

2016-11-05 Thread Eric van Gyzen
Author: vangyzen Date: Sat Nov 5 15:01:41 2016 New Revision: 308342 URL: https://svnweb.freebsd.org/changeset/base/308342 Log: Fix sorting after r308293, using the ../tools/do_sort script. Is this a pointy-hat offense? Reported by: jhb Modified: head/usr.bin/fortune/datfiles/fortu

svn commit: r308824 - head/usr.bin/locale

2016-11-18 Thread Eric van Gyzen
Author: vangyzen Date: Sat Nov 19 02:09:58 2016 New Revision: 308824 URL: https://svnweb.freebsd.org/changeset/base/308824 Log: locale: fix display of "grouping" and "mon_grouping" values The "grouping" and "mon_grouping" values are arrays of one-byte integers, not arrays of ASCII charact

svn commit: r308904 - head/lib/libc/locale

2016-11-20 Thread Eric van Gyzen
Author: vangyzen Date: Sun Nov 20 20:13:22 2016 New Revision: 308904 URL: https://svnweb.freebsd.org/changeset/base/308904 Log: Fix error reporting from wcstof() When wcstof() skipped initial space and then parsing failed, it set endptr to the first non-space character. Fix it to correct

svn commit: r309329 - stable/10/usr.bin/locale

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 18:11:35 2016 New Revision: 309329 URL: https://svnweb.freebsd.org/changeset/base/309329 Log: MFC r308824 locale: fix display of "grouping" and "mon_grouping" values The "grouping" and "mon_grouping" values are arrays of one-byte integers, not arrays

svn commit: r309330 - stable/11/usr.bin/locale

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 18:26:22 2016 New Revision: 309330 URL: https://svnweb.freebsd.org/changeset/base/309330 Log: MFC r308824 locale: fix display of "grouping" and "mon_grouping" values The "grouping" and "mon_grouping" values are arrays of one-byte integers, not arrays

svn commit: r309331 - head/usr.bin/locale

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 18:34:40 2016 New Revision: 309331 URL: https://svnweb.freebsd.org/changeset/base/309331 Log: Include limits.h for CHAR_MAX This was needed on stable/10. Apparently, sys/param.h supplies CHAR_MAX on head. Include limits.h anyway, for consistency, and be

svn commit: r309333 - stable/11/lib/libc/locale

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 20:47:54 2016 New Revision: 309333 URL: https://svnweb.freebsd.org/changeset/base/309333 Log: MFC r308904 Fix error reporting from wcstof() When wcstof() skipped initial space and then parsing failed, it set endptr to the first non-space character.

svn commit: r309334 - stable/10/lib/libc/locale

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 20:48:44 2016 New Revision: 309334 URL: https://svnweb.freebsd.org/changeset/base/309334 Log: MFC r308904 Fix error reporting from wcstof() When wcstof() skipped initial space and then parsing failed, it set endptr to the first non-space character.

svn commit: r309335 - stable/11/usr.bin/ncal

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 20:51:14 2016 New Revision: 309335 URL: https://svnweb.freebsd.org/changeset/base/309335 Log: MFC r308340 ncal: fix a reference to an out-of-scope stack buffer PR: 214237 Submitted by: Jonathan de Boyne Pollard Sponsored by: Dell EMC Mod

svn commit: r309336 - stable/10/usr.bin/ncal

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 20:51:51 2016 New Revision: 309336 URL: https://svnweb.freebsd.org/changeset/base/309336 Log: MFC r308340 ncal: fix a reference to an out-of-scope stack buffer PR: 214237 Submitted by: Jonathan de Boyne Pollard Sponsored by: Dell EMC Mod

svn commit: r309337 - in stable/11: sys/netinet usr.sbin/arp

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 21:53:06 2016 New Revision: 309337 URL: https://svnweb.freebsd.org/changeset/base/309337 Log: MFC r306577 r306652 306830 Add GARP retransmit capability A single gratuitous ARP (GARP) is always transmitted when an IPv4 address is added to an interface

svn commit: r309340 - in stable/10: sys/netinet usr.sbin/arp

2016-11-30 Thread Eric van Gyzen
Author: vangyzen Date: Wed Nov 30 22:20:23 2016 New Revision: 309340 URL: https://svnweb.freebsd.org/changeset/base/309340 Log: MFC r306577 r306652 306830 Add GARP retransmit capability A single gratuitous ARP (GARP) is always transmitted when an IPv4 address is added to an interface

svn commit: r309364 - head/usr.bin/locale

2016-12-01 Thread Eric van Gyzen
Author: vangyzen Date: Thu Dec 1 16:54:02 2016 New Revision: 309364 URL: https://svnweb.freebsd.org/changeset/base/309364 Log: locale: fix buffer management Also, handle signed and unsigned chars, and more gracefully handle invalid input. Submitted by: bde in response to r309331 M

Re: svn commit: r309331 - head/usr.bin/locale

2016-12-01 Thread Eric van Gyzen
On 11/30/2016 18:19, Bruce Evans wrote: > On Wed, 30 Nov 2016, Eric van Gyzen wrote: > >> Log: >> Include limits.h for CHAR_MAX >> >> This was needed on stable/10. Apparently, sys/param.h supplies CHAR_MAX >> on head. Include limits.h anyway, for c

svn commit: r309367 - head/usr.bin/locale

2016-12-01 Thread Eric van Gyzen
Author: vangyzen Date: Thu Dec 1 17:36:31 2016 New Revision: 309367 URL: https://svnweb.freebsd.org/changeset/base/309367 Log: locale: enable more warnings; fix them Do not set WARNS, so it gets the current default of 6. Fix the warnings by sprinkling static, const, or strdup. Make som

svn commit: r309460 - in head: lib/libc/sys share/man/man3 sys/kern

2016-12-02 Thread Eric van Gyzen
Author: vangyzen Date: Sat Dec 3 01:14:21 2016 New Revision: 309460 URL: https://svnweb.freebsd.org/changeset/base/309460 Log: thr_set_name(): silently truncate the given name as needed Instead of failing with ENAMETOOLONG, which is swallowed by pthread_set_name_np() anyway, truncate the

svn commit: r333430 - in head/lib/libc: sys tests/iconv

2018-05-09 Thread Eric van Gyzen
(r333429) +++ head/lib/libc/sys/clock_nanosleep.c Wed May 9 20:12:59 2018 (r333430) @@ -1,7 +1,6 @@ /* * Copyright (c) 2017 Eric van Gyzen * Copyright (c) 2014 The FreeBSD Foundation. - * All rights reserved. * * Portions of this software were developed by Konstantin Belousov

Re: svn commit: r333859 - head/sys/kern

2018-05-21 Thread Eric van Gyzen
On 05/19/2018 00:09, Matt Macy wrote: > @@ -1663,16 +1655,18 @@ static int > umtxq_sleep_pi(struct umtx_q *uq, struct umtx_pi *pi, uint32_t owner, > const char *wmesg, struct abs_timeout *timo, bool shared) > { > - struct umtxq_chain *uc; > struct thread *td, *td1; > struct u

svn commit: r305620 - head/usr.sbin/etcupdate

2016-09-08 Thread Eric van Gyzen
Author: vangyzen Date: Thu Sep 8 15:53:49 2016 New Revision: 305620 URL: https://svnweb.freebsd.org/changeset/base/305620 Log: etcupdate: preserve the metadata of the destination file When using diff3 to perform a three-way merge, etcupdate lost the destination file's metadata. The metad

svn commit: r306346 - head/sys/kern

2016-09-26 Thread Eric van Gyzen
Author: vangyzen Date: Mon Sep 26 15:30:30 2016 New Revision: 306346 URL: https://svnweb.freebsd.org/changeset/base/306346 Log: Make no assertions about mutex state when the scheduler is stopped. This changes the assert path to match the lock and unlock paths. MFC after:1 week Sp

svn commit: r306567 - head/sys/dev/lmc

2016-10-01 Thread Eric van Gyzen
Author: vangyzen Date: Sat Oct 1 22:21:10 2016 New Revision: 306567 URL: https://svnweb.freebsd.org/changeset/base/306567 Log: lmc(4): fix the build without the bpf device "make buildkernel" now works with and without "device bpf". Reported by: Dave Mischler MFC after:3 days

svn commit: r306568 - head/include

2016-10-01 Thread Eric van Gyzen
Author: vangyzen Date: Sat Oct 1 22:34:38 2016 New Revision: 306568 URL: https://svnweb.freebsd.org/changeset/base/306568 Log: Add the __printflike attribute to the declaration of dprintf(3) MFC after:3 days Sponsored by: Dell EMC Modified: head/include/stdio.h Modified: head/inc

svn commit: r306569 - head/include

2016-10-01 Thread Eric van Gyzen
Author: vangyzen Date: Sat Oct 1 23:08:26 2016 New Revision: 306569 URL: https://svnweb.freebsd.org/changeset/base/306569 Log: Add the __printflike attribute to the declaration of vdprintf(3) I intended to add this in r306568. MFC after:3 days Sponsored by: Dell EMC Modified:

svn commit: r306577 - head/sys/netinet

2016-10-01 Thread Eric van Gyzen
Author: vangyzen Date: Sun Oct 2 01:42:45 2016 New Revision: 306577 URL: https://svnweb.freebsd.org/changeset/base/306577 Log: Add GARP retransmit capability A single gratuitous ARP (GARP) is always transmitted when an IPv4 address is added to an interface, and that is usually sufficient

svn commit: r328552 - head/sys/netinet6

2018-01-29 Thread Eric van Gyzen
Author: vangyzen Date: Mon Jan 29 16:12:26 2018 New Revision: 328552 URL: https://svnweb.freebsd.org/changeset/base/328552 Log: ND6: Set the correct state for new neighbor cache entries Restore state 6. Many of the UNH tests end up exercising this state, where we have a new neighbor cach

Re: ps output line length (was: svn commit: r314685 - head/bin/ps)

2018-01-29 Thread Eric van Gyzen
On 01/29/2018 12:08, John Baldwin wrote: > On Sunday, January 28, 2018 10:22:56 AM Mike Karels wrote: >> Recently, I was investigating an issue with top on -current while doing >> a "make buildworld", and ran "ps axu|more" for comparison. To my surprise, >> I got only a few very long lines of outp

svn commit: r328897 - stable/11/sys/netinet6

2018-02-05 Thread Eric van Gyzen
Author: vangyzen Date: Mon Feb 5 18:56:34 2018 New Revision: 328897 URL: https://svnweb.freebsd.org/changeset/base/328897 Log: MFC r328552 ND6: Set the correct state for new neighbor cache entries Restore state 6. Many of the UNH tests end up exercising this state, where we have a

Re: svn commit: r328933 - head/usr.bin/find

2018-02-06 Thread Eric van Gyzen
On 02/06/2018 09:41, Alex Richardson wrote: > +#if HAVE_STRUCT_STAT_ST_BIRTHTIME > else if (plan->flags & F_TIME_A) > ft = entry->fts_statp->st_atim; > else if (plan->flags & F_TIME_B) > ft = entry->fts_statp->st_birthtim; > +#endif Did you intend to put st_

svn commit: r329053 - head/sys/netinet6

2018-02-08 Thread Eric van Gyzen
Author: vangyzen Date: Fri Feb 9 00:13:05 2018 New Revision: 329053 URL: https://svnweb.freebsd.org/changeset/base/329053 Log: Fix ICMPv6 redirects icmp6_redirect_input() validates that a redirect packet came from the current gateway for the respective destination. To do this, it compar

svn commit: r329181 - head/sys/netinet6

2018-02-12 Thread Eric van Gyzen
Author: vangyzen Date: Mon Feb 12 19:49:20 2018 New Revision: 329181 URL: https://svnweb.freebsd.org/changeset/base/329181 Log: Update the MTU in affected routes when IPv6 RA changes the MTU ip6_calcmtu() only looks at the interface MTU if neither the TCP hostcache nor the route provides

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Eric van Gyzen
On 02/13/2018 13:43, Ed Maste wrote: > On 13 February 2018 at 14:23, Ian Lepore wrote: >> On Tue, 2018-02-13 at 19:17 +, Ed Maste wrote: >>> Author: emaste >>> Date: Tue Feb 13 19:17:48 2018 >>> New Revision: 329237 >>> URL: https://svnweb.freebsd.org/changeset/base/329237 >>> >>> Log: >>> l

svn commit: r329581 - stable/11/sys/netinet6

2018-02-19 Thread Eric van Gyzen
Author: vangyzen Date: Mon Feb 19 15:54:26 2018 New Revision: 329581 URL: https://svnweb.freebsd.org/changeset/base/329581 Log: MFC r329053 Fix ICMPv6 redirects icmp6_redirect_input() validates that a redirect packet came from the current gateway for the respective destination. To d

svn commit: r329582 - stable/11/sys/netinet6

2018-02-19 Thread Eric van Gyzen
Author: vangyzen Date: Mon Feb 19 15:56:33 2018 New Revision: 329582 URL: https://svnweb.freebsd.org/changeset/base/329582 Log: MFC r329181 Update the MTU in affected routes when IPv6 RA changes the MTU ip6_calcmtu() only looks at the interface MTU if neither the TCP hostcache nor th

svn commit: r325764 - head/sys/sys

2017-11-13 Thread Eric van Gyzen
Author: vangyzen Date: Mon Nov 13 16:53:36 2017 New Revision: 325764 URL: https://svnweb.freebsd.org/changeset/base/325764 Log: Add __BEGIN_DECLS and __END_DECLS to This allows C++ programs to call _umtx_op(). MFC after:3 days Sponsored by: Dell EMC Modified: head/sys/sys/umt

svn commit: r325766 - head/lib/libc/sys

2017-11-13 Thread Eric van Gyzen
Author: vangyzen Date: Mon Nov 13 17:46:38 2017 New Revision: 325766 URL: https://svnweb.freebsd.org/changeset/base/325766 Log: Fix formatting of _umtx_op(2) Do not use macros in the -width of a .Bl, since mandoc does not support them. Fix issues reported by igor and mandoc -Tlint.

svn commit: r325904 - stable/11/sys/sys

2017-11-16 Thread Eric van Gyzen
Author: vangyzen Date: Thu Nov 16 21:45:10 2017 New Revision: 325904 URL: https://svnweb.freebsd.org/changeset/base/325904 Log: MFC r325764 Add __BEGIN_DECLS and __END_DECLS to This allows C++ programs to call _umtx_op(). Sponsored by: Dell EMC Modified: stable/11/sys/sys/umtx

svn commit: r325905 - stable/11/lib/libc/sys

2017-11-16 Thread Eric van Gyzen
Author: vangyzen Date: Thu Nov 16 21:47:41 2017 New Revision: 325905 URL: https://svnweb.freebsd.org/changeset/base/325905 Log: MFC r325766 Fix formatting of _umtx_op(2) Do not use macros in the -width of a .Bl, since mandoc does not support them. Fix issues reported by igor and m

svn commit: r338656 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-09-13 Thread Eric van Gyzen
Author: vangyzen Date: Thu Sep 13 17:56:48 2018 New Revision: 338656 URL: https://svnweb.freebsd.org/changeset/base/338656 Log: Set zfs_arc_meta_strategy to metadata only The previous default of "balanced" appears to have caused pathological behavior, including very poor performance and 1

svn commit: r338688 - head/sbin/reboot

2018-09-14 Thread Eric van Gyzen
Author: vangyzen Date: Fri Sep 14 18:12:30 2018 New Revision: 338688 URL: https://svnweb.freebsd.org/changeset/base/338688 Log: Fix "fasthalt" to halt instead of reboot fasthalt has behaved like reboot, instead of like halt, since r228408 (2011, 10.0-RELEASE). Fix it. One wonders if any

Re: svn commit: r338829 - head/sys/kern

2018-09-20 Thread Eric van Gyzen
On 9/20/18 8:32 AM, Mateusz Guzik wrote: fd: prevent inlining of _fdrop thorough kern_descrip.c fdrop is used in several places in the file and almost never has to call _fdrop. Thus inlining it is a pure waste of space. -int +int __noinline _fdrop(struct file *fp, struct th

<    1   2   3   4   >