svn commit: r281785 - in head: share/man/man9 sys/kern

Author: vangyzen Date: Mon Apr 20 20:03:26 2015 New Revision: 281785 URL: https://svnweb.freebsd.org/changeset/base/281785 Log: Always send log(9) messages to the message buffer. It is truer to the semantics of logging for messages to *always* go to the message buffer, where they can even

svn commit: r281787 - head/sbin/dmesg

Author: vangyzen Date: Mon Apr 20 20:07:39 2015 New Revision: 281787 URL: https://svnweb.freebsd.org/changeset/base/281787 Log: dmesg: accommodate message buffer growth between the sysctl calls Allocate 12.5% extra space to avoid ENOMEM when the message buffer is growing steadily. Re

Re: svn commit: r281922 - head/usr.bin/nfsstat

On 04/24/2015 10:33, John Baldwin wrote: > On Friday, April 24, 2015 02:31:31 PM Sergey Kandaurov wrote: >> On 24 April 2015 at 10:58, Edward Tomasz Napierala wrote: >>> Author: trasz >>> Date: Fri Apr 24 07:57:59 2015 >>> New Revision: 281922 >>> URL: https://svnweb.freebsd.org/changeset/base/281

Re: svn commit: r282672 - head/etc/rc.d

On 05/11/2015 15:37, Devin Teske wrote: > >> On May 11, 2015, at 12:18 PM, Brooks Davis > > wrote: >> >> On Sun, May 10, 2015 at 03:45:48PM -0400, John Baldwin wrote: >>> On May 8, 2015, at 19:36, Xin LI >>> > wrote: Author: del

Re: svn commit: r283136 - head/sys/netinet

On 05/20/2015 02:33, Lawrence Stewart wrote: > On 05/20/15 14:24, Hiren Panchasara wrote: >> On 05/20/15 at 02:13P, Lawrence Stewart wrote: >>> Hi Hiren, >>> >>> On 05/20/15 11:08, Hiren Panchasara wrote: Author: hiren Date: Wed May 20 01:08:01 2015 New Revision: 283136 URL: https://svnwe

Re: svn commit: r283136 - head/sys/netinet

On 05/21/2015 16:03, Hiren Panchasara wrote: > On 05/21/15 at 03:27P, Lawrence Stewart wrote: >> On 05/20/15 23:19, Eric van Gyzen wrote: >>> On 05/20/2015 02:33, Lawrence Stewart wrote: >>>> On 05/20/15 14:24, Hiren Panchasara wrote: >>>>> On 05/20/15

svn commit: r279857 - head/share/misc

[label="Michael Tuexen\ntuexen@Fr tychon [label="Tycho Nightingale\ntyc...@freebsd.org\n2014/01/21"] ume [label="Hajimu UMEMOTO\n...@freebsd.org\n2000/02/26"] uqs [label="Ulrich Spoerlein\n...@freebsd.org\n2010/01/28"] +vangyzen [label="Eric van Gyzen\nvangy...

svn commit: r280792 - head/sys/kern

Author: vangyzen Date: Sat Mar 28 21:21:40 2015 New Revision: 280792 URL: https://svnweb.freebsd.org/changeset/base/280792 Log: Clean up some cosmetic nits in kern_umtx.c, found during recent work in this area and by the Clang static analyzer. Remove some dead assignments. Fix a typo

svn commit: r280793 - head/usr.sbin/pmcstat

Author: vangyzen Date: Sat Mar 28 21:28:22 2015 New Revision: 280793 URL: https://svnweb.freebsd.org/changeset/base/280793 Log: pmcstat.8: fix -a flag description; improve -m flag to match The -a flag reads a file saved by -O, not -o. The -m flag requires the -R flag. Copy that paragr

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

>> Now as to the >> >> -1 -> NOCPU >> >> This is like pulling on a string on your sweater.. the only sensible >> solution that >> I could come up with after chatting with Lawrence is to add >> #include >> to everyone that uses the callout.h and does not have it already… (putting >> it into cal

svn commit: r349278 - head/usr.sbin/bhyve

Author: vangyzen Date: Fri Jun 21 18:57:33 2019 New Revision: 349278 URL: https://svnweb.freebsd.org/changeset/base/349278 Log: bhyve: Fix vtscsi maximum segment config The seg_max value reported to the guest should be two less than the host's maximum, in order to leave room for the reque

svn commit: r349285 - head/sys/dev/virtio/scsi

Author: vangyzen Date: Sat Jun 22 01:20:45 2019 New Revision: 349285 URL: https://svnweb.freebsd.org/changeset/base/349285 Log: VirtIO SCSI: validate seg_max on attach Until r349278, bhyve presented a seg_max to the guest that was too large. Detect this case and clamp it to the virtqueue

svn commit: r349677 - in head: sys/kern tools/test/callout_free

eBSD$ + +KMOD= callout_free +SRCS= callout_free.c + +.include Added: head/tools/test/callout_free/callout_free.c == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/tools/test/callout_free/callout_free.c Wed Jul 3 19:22:44 2019

svn commit: r349690 - stable/12/usr.sbin/bhyve

Author: vangyzen Date: Wed Jul 3 19:50:22 2019 New Revision: 349690 URL: https://svnweb.freebsd.org/changeset/base/349690 Log: MFC r349278 bhyve: Fix vtscsi maximum segment config The seg_max value reported to the guest should be two less than the host's maximum, in order to leave r

svn commit: r349691 - stable/12/sys/dev/virtio/scsi

Author: vangyzen Date: Wed Jul 3 19:52:24 2019 New Revision: 349691 URL: https://svnweb.freebsd.org/changeset/base/349691 Log: MFC r349285 VirtIO SCSI: validate seg_max on attach Until head r349278 (stable/12 r349690), bhyve presented a seg_max to the guest that was too large. Det

svn commit: r349693 - stable/11/sys/dev/virtio/scsi

Author: vangyzen Date: Wed Jul 3 19:54:56 2019 New Revision: 349693 URL: https://svnweb.freebsd.org/changeset/base/349693 Log: MFC r349285 VirtIO SCSI: validate seg_max on attach Until head r349278 (stable/12 r349690), bhyve presented a seg_max to the guest that was too large. Det

svn commit: r349834 - head/sys/dev/vt

Author: vangyzen Date: Mon Jul 8 13:46:26 2019 New Revision: 349834 URL: https://svnweb.freebsd.org/changeset/base/349834 Log: Ignore kern.vt.splash_cpu without graphics When the system has no graphical console, such as bhyve in common configurations, ignore kern.vt.splash_cpu, instead o

svn commit: r350043 - in head: share/man/man5 sys/kern

Author: vangyzen Date: Tue Jul 16 15:51:09 2019 New Revision: 350043 URL: https://svnweb.freebsd.org/changeset/base/350043 Log: Adds signal number format to kern.corefile Add format capability to core file names to include signal that generated the core. This can help various validation w

svn commit: r350050 - stable/12/sys/dev/vt

Author: vangyzen Date: Tue Jul 16 16:05:42 2019 New Revision: 350050 URL: https://svnweb.freebsd.org/changeset/base/350050 Log: MFC r349834 Ignore kern.vt.splash_cpu without graphics When the system has no graphical console, such as bhyve in common configurations, ignore kern.vt.spla

svn commit: r350056 - stable/11/sys/dev/vt

Author: vangyzen Date: Tue Jul 16 16:49:11 2019 New Revision: 350056 URL: https://svnweb.freebsd.org/changeset/base/350056 Log: MFC r349834 Ignore kern.vt.splash_cpu without graphics When the system has no graphical console, such as bhyve in common configurations, ignore kern.vt.spla

svn commit: r350620 - head/contrib/netbsd-tests/lib/libpthread

Author: vangyzen Date: Mon Aug 5 22:59:35 2019 New Revision: 350620 URL: https://svnweb.freebsd.org/changeset/base/350620 Log: Relax time constraint in pthread_cond_timedwait unit test pthread_cond_timedwait() should wait _at least_ until the timeout, but it might appear to wait longer d

svn commit: r301532 - head/usr.sbin/newsyslog

Author: vangyzen Date: Mon Jun 6 22:54:08 2016 New Revision: 301532 URL: https://svnweb.freebsd.org/changeset/base/301532 Log: newsyslog: Eliminate unnecessary sleep(10) when -R and -s are specified After going through the signal work list, during which do_sigwork() is called and essenti

svn commit: r301926 - stable/10/usr.sbin/newsyslog

Author: vangyzen Date: Wed Jun 15 14:11:49 2016 New Revision: 301926 URL: https://svnweb.freebsd.org/changeset/base/301926 Log: MFC r301532 newsyslog: Eliminate unnecessary sleep(10) when -R and -s are specified After going through the signal work list, during which do_sigwork() is c

svn commit: r301927 - stable/9/usr.sbin/newsyslog

Author: vangyzen Date: Wed Jun 15 14:12:22 2016 New Revision: 301927 URL: https://svnweb.freebsd.org/changeset/base/301927 Log: MFC r301532 newsyslog: Eliminate unnecessary sleep(10) when -R and -s are specified After going through the signal work list, during which do_sigwork() is c

svn commit: r302014 - head/sys/dev/ntb/if_ntb

Author: vangyzen Date: Sat Jun 18 23:18:04 2016 New Revision: 302014 URL: https://svnweb.freebsd.org/changeset/base/302014 Log: Fix if_ntb interface setup to include IFF_MULTICAST. This allows IPv6 link local addresses (and other IPv6 functionality) to work. PR: 210355 Subm

svn commit: r302787 - head/cddl/contrib/opensolaris/cmd/zpool

Author: vangyzen Date: Wed Jul 13 21:27:10 2016 New Revision: 302787 URL: https://svnweb.freebsd.org/changeset/base/302787 Log: zpool(8): update Hot Spares section to mention zfsd(8) Reviewed and reworded by: asomers MFC after:3 days Sponsored by: Dell Inc. Modified: head/cdd

svn commit: r302938 - stable/11/cddl/contrib/opensolaris/cmd/zpool

Author: vangyzen Date: Sat Jul 16 15:52:14 2016 New Revision: 302938 URL: https://svnweb.freebsd.org/changeset/base/302938 Log: MFC r302787 zpool(8): update Hot Spares section to mention zfsd(8) Approved by: re (gjb) Modified: stable/11/cddl/contrib/opensolaris/cmd/zpool/zpool.8 Di

svn commit: r340994 - in head/sys: amd64/ia32 mips/mips powerpc/powerpc

Author: vangyzen Date: Mon Nov 26 20:50:55 2018 New Revision: 340994 URL: https://svnweb.freebsd.org/changeset/base/340994 Log: Prevent kernel stack disclosure in getcontext/swapcontext Expand r338982 to cover freebsd32 interfaces on amd64, mips, and powerpc. MFC after:2 days Sec

svn commit: r340995 - in head/sys: arm/arm arm64/arm64 riscv/riscv

Author: vangyzen Date: Mon Nov 26 20:52:53 2018 New Revision: 340995 URL: https://svnweb.freebsd.org/changeset/base/340995 Log: Prevent kernel stack disclosure in signal delivery On arm64 and riscv platforms, sendsig() failed to zero the signal frame before copying it out to userspace. Z

svn commit: r340996 - in head/sys: amd64/amd64 amd64/ia32 i386/i386 kern

Author: vangyzen Date: Mon Nov 26 20:56:05 2018 New Revision: 340996 URL: https://svnweb.freebsd.org/changeset/base/340996 Log: Remove superfluous bzero in getcontext/swapcontext/sendsig We zero the whole structure; we don't need to zero the __spare__ field again. Remove trailing white

svn commit: r341086 - stable/12/sys/netinet6

Author: vangyzen Date: Tue Nov 27 19:40:07 2018 New Revision: 341086 URL: https://svnweb.freebsd.org/changeset/base/341086 Log: MFC r340257 in6_ifattach_linklocal: handle immediate removal of the new LLA If another thread immediately removes the link-local address added by in6_update

svn commit: r341087 - stable/11/sys/netinet6

Author: vangyzen Date: Tue Nov 27 19:40:18 2018 New Revision: 341087 URL: https://svnweb.freebsd.org/changeset/base/341087 Log: MFC r340257 in6_ifattach_linklocal: handle immediate removal of the new LLA If another thread immediately removes the link-local address added by in6_update

svn commit: r341090 - stable/12

Author: vangyzen Date: Tue Nov 27 19:44:04 2018 New Revision: 341090 URL: https://svnweb.freebsd.org/changeset/base/341090 Log: MFC r340328 Update comment about 'universe' disk usage It's 167 GB now (or 81 GB with ZFS lz4). Sponsored by: Dell EMC Isilon Modified: stable/12/Make

svn commit: r341092 - stable/12/usr.sbin/periodic/etc/daily

Author: vangyzen Date: Tue Nov 27 19:45:24 2018 New Revision: 341092 URL: https://svnweb.freebsd.org/changeset/base/341092 Log: MFC r340345 Fix daily mailq script for Postfix and daily_show_success="NO" Exit with a zero status when Postfix reports "Mail queue is empty" so this sectio

svn commit: r341099 - stable/12/sys/kern

Author: vangyzen Date: Tue Nov 27 22:32:34 2018 New Revision: 341099 URL: https://svnweb.freebsd.org/changeset/base/341099 Log: MFC r340409 Make no assertions about lock state when the scheduler is stopped. Change the assert paths in rm, rw, and sx locks to match the lock and unlock

svn commit: r341100 - stable/11/sys/kern

Author: vangyzen Date: Tue Nov 27 22:33:58 2018 New Revision: 341100 URL: https://svnweb.freebsd.org/changeset/base/341100 Log: MFC r340409 Make no assertions about lock state when the scheduler is stopped. Change the assert paths in rm, rw, and sx locks to match the lock and unlock

svn commit: r341146 - in stable/12/sys: amd64/ia32 mips/mips powerpc/powerpc

Author: vangyzen Date: Wed Nov 28 15:31:05 2018 New Revision: 341146 URL: https://svnweb.freebsd.org/changeset/base/341146 Log: MFC r340994 Prevent kernel stack disclosure in getcontext/swapcontext Expand r338982 to cover freebsd32 interfaces on amd64, mips, and powerpc. Security:

svn commit: r341147 - in stable/12/sys: arm/arm arm64/arm64 riscv/riscv

Author: vangyzen Date: Wed Nov 28 15:34:46 2018 New Revision: 341147 URL: https://svnweb.freebsd.org/changeset/base/341147 Log: MFC r340995 Prevent kernel stack disclosure in signal delivery On arm64 and riscv platforms, sendsig() failed to zero the signal frame before copying it out

svn commit: r341149 - in releng/12.0/sys: amd64/ia32 mips/mips powerpc/powerpc

Author: vangyzen Date: Wed Nov 28 16:20:04 2018 New Revision: 341149 URL: https://svnweb.freebsd.org/changeset/base/341149 Log: MFS r341146 MFC r340994 Prevent kernel stack disclosure in getcontext/swapcontext Expand r338982 to cover freebsd32 interfaces on amd64, mips, and powerp

svn commit: r341153 - in releng/12.0/sys: arm/arm arm64/arm64 riscv/riscv

Author: vangyzen Date: Wed Nov 28 16:58:35 2018 New Revision: 341153 URL: https://svnweb.freebsd.org/changeset/base/341153 Log: MFS r341147 MFC r340995 Prevent kernel stack disclosure in signal delivery On arm64 and riscv platforms, sendsig() failed to zero the signal frame befo

svn commit: r341165 - in stable/11/sys: amd64/ia32 mips/mips powerpc/powerpc

Author: vangyzen Date: Wed Nov 28 21:19:58 2018 New Revision: 341165 URL: https://svnweb.freebsd.org/changeset/base/341165 Log: MFC r340994 Prevent kernel stack disclosure in getcontext/swapcontext Expand r338982 to cover freebsd32 interfaces on amd64, mips, and powerpc. Security:

svn commit: r341166 - in stable/11/sys: arm/arm arm64/arm64 riscv/riscv

Author: vangyzen Date: Wed Nov 28 21:20:51 2018 New Revision: 341166 URL: https://svnweb.freebsd.org/changeset/base/341166 Log: MFC r340995 Prevent kernel stack disclosure in signal delivery On arm64 and riscv platforms, sendsig() failed to zero the signal frame before copying it out

svn commit: r341277 - head/lib/libthr/thread

Author: vangyzen Date: Fri Nov 30 03:01:32 2018 New Revision: 341277 URL: https://svnweb.freebsd.org/changeset/base/341277 Log: _thr_setthreaded() cannot fail; change return type to void Also remove logic to avoid unnecessary stores to the global variable. Thread creation and destruction

svn commit: r341278 - head/lib/libthr/thread

Author: vangyzen Date: Fri Nov 30 03:02:49 2018 New Revision: 341278 URL: https://svnweb.freebsd.org/changeset/base/341278 Log: Use _thr_isthreaded() and _thr_setthreaded() wrappers ...instead of directly using the global variable. MFC after:2 weeks Sponsored by: Dell EMC Isilon

svn commit: r341281 - head/sys/vm

Author: vangyzen Date: Fri Nov 30 04:18:31 2018 New Revision: 341281 URL: https://svnweb.freebsd.org/changeset/base/341281 Log: Add assertions and comment to vm_object_vnode() Reviewed by: kib MFC after:2 weeks Sponsored by: Dell EMC Isilon Differential Revision:https://r

svn commit: r341282 - in head/sys: kern vm

Author: vangyzen Date: Fri Nov 30 04:59:43 2018 New Revision: 341282 URL: https://svnweb.freebsd.org/changeset/base/341282 Log: Include path for tmpfs objects in vm.objects sysctl This applies the fix in r283924 to the vm.objects sysctl added by r283624 so the output will include the vnod

svn commit: r341353 - in head: sys/arm/arm sys/arm64/arm64 sys/riscv/riscv tests/sys/kern

(r341353) @@ -0,0 +1,115 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2018 Eric van Gyzen + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistribut

svn commit: r341354 - head/tests/sys/kern

Author: vangyzen Date: Fri Nov 30 23:47:57 2018 New Revision: 341354 URL: https://svnweb.freebsd.org/changeset/base/341354 Log: Maybe make gcc happy According to Jenkins, the GCC architectures were unhappy because: sigaltstack.c:82: warning: missing initializer sigaltstack.c:

svn commit: r341507 - head/sys/net/altq

Author: vangyzen Date: Tue Dec 4 23:46:43 2018 New Revision: 341507 URL: https://svnweb.freebsd.org/changeset/base/341507 Log: altq: remove ALTQ3_COMPAT code This code has apparently never compiled on FreeBSD since its introduction in 2004 (r130365). It has certainly not compiled sinc

svn commit: r341508 - in head/sys: conf net/altq

Author: vangyzen Date: Tue Dec 4 23:53:42 2018 New Revision: 341508 URL: https://svnweb.freebsd.org/changeset/base/341508 Log: altq: manual cleanup after r341507 Remove a file that became practically empty. Fix indentation. Like r341507, I do not plan to MFC, but anyone else can.

svn commit: r306652 - head/usr.sbin/arp

Author: vangyzen Date: Mon Oct 3 19:02:22 2016 New Revision: 306652 URL: https://svnweb.freebsd.org/changeset/base/306652 Log: Update arp(4) to document the net.link.ether.inet.garp_rexmit_count sysctl. Submitted by: David A. Bright Requested by: markj Reviewed by: markj, badger MF

Re: svn commit: r306652 - head/usr.sbin/arp

On 10/03/2016 14:11, Bruce Simpson wrote: > On 03/10/16 20:02, Eric van Gyzen wrote: >> Author: vangyzen >> Date: Mon Oct 3 19:02:22 2016 >> New Revision: 306652 >> URL: https://svnweb.freebsd.org/changeset/base/306652 >> >>

svn commit: r306830 - head/usr.sbin/arp

Author: vangyzen Date: Fri Oct 7 22:17:25 2016 New Revision: 306830 URL: https://svnweb.freebsd.org/changeset/base/306830 Log: Additional cleanup of the arp(4) man page after r306652 Submitted by: David A. Bright Requested by: wblock Reviewed by: wblock MFC after:23 days Spon

svn commit: r306844 - stable/11/sys/dev/lmc

Author: vangyzen Date: Sat Oct 8 13:49:40 2016 New Revision: 306844 URL: https://svnweb.freebsd.org/changeset/base/306844 Log: lmc(4): fix the build without the bpf device Reported by: Dave Mischler Sponsored by: Dell EMC Modified: stable/11/sys/dev/lmc/if_lmc.c Directory Properties

svn commit: r306845 - stable/11/include

Author: vangyzen Date: Sat Oct 8 14:07:34 2016 New Revision: 306845 URL: https://svnweb.freebsd.org/changeset/base/306845 Log: MFC r306568, r306569 Add the __printflike attribute to the declarations of dprintf(3) and vdprintf(3). Sponsored by: Dell EMC Modified: stable/11/include

svn commit: r306846 - stable/10/include

Author: vangyzen Date: Sat Oct 8 14:10:45 2016 New Revision: 306846 URL: https://svnweb.freebsd.org/changeset/base/306846 Log: MFC r306568, r306569 Add the __printflike attribute to the declarations of dprintf(3) and vdprintf(3). Sponsored by: Dell EMC Modified: stable/10/include

Re: svn commit: r306346 - head/sys/kern

On 10/04/2016 15:56, Gleb Smirnoff wrote: > Eric, > > E> @@ -924,7 +924,7 @@ __mtx_assert(const volatile uintptr_t *c > E> { > E>const struct mtx *m; > E> > E> - if (panicstr != NULL || dumping) > E> + if (panicstr != NULL || dumping || SCHEDULER_STOPPED()) > E>return; > > I

svn commit: r307587 - stable/11/sys/kern

Author: vangyzen Date: Wed Oct 19 00:14:20 2016 New Revision: 307587 URL: https://svnweb.freebsd.org/changeset/base/307587 Log: MFC r306346 Make no assertions about mutex state when the scheduler is stopped. This changes the assert path to match the lock and unlock paths. Sponsore

svn commit: r307588 - stable/10/sys/kern

Author: vangyzen Date: Wed Oct 19 00:14:22 2016 New Revision: 307588 URL: https://svnweb.freebsd.org/changeset/base/307588 Log: MFC r306346 Make no assertions about mutex state when the scheduler is stopped. This changes the assert path to match the lock and unlock paths. Sponsore

Re: svn commit: r307727 - head/share/man/man4

On 10/21/2016 09:28, hiren panchasara wrote: > On 10/21/16 at 11:29P, Michael Tuexen wrote: >> Author: tuexen >> Date: Fri Oct 21 11:29:25 2016 >> New Revision: 307727 >> URL: https://svnweb.freebsd.org/changeset/base/307727 >> >> Log: >> Document the TCP sysctl variables insecure_rst and insecur

svn commit: r307895 - svnadmin/conf

Author: vangyzen Date: Tue Oct 25 03:26:00 2016 New Revision: 307895 URL: https://svnweb.freebsd.org/changeset/base/307895 Log: Add David Bright (dab) as a src committer, with me as his mentor. Approved by: core Modified: svnadmin/conf/access svnadmin/conf/mentors Modified: svnadmin/

Re: svn commit: r306577 - head/sys/netinet

On 10/29/2016 11:50, Hans Petter Selasky wrote: > On 10/02/16 03:42, Eric van Gyzen wrote: >> +if (callout_reset(&ia->ia_garp_timer, (1 << ia->ia_garp_count) * hz, >> +garp_rexmit, ia) == 0) { >> +ifa_ref(ifa); >> +} > > H

Re: svn commit: r306577 - head/sys/netinet

On 10/30/16 4:44 AM, Kubilay Kocak wrote: On 2/10/2016 12:42 PM, Eric van Gyzen wrote: Author: vangyzen Date: Sun Oct 2 01:42:45 2016 New Revision: 306577 URL: https://svnweb.freebsd.org/changeset/base/306577 Log: Add GARP retransmit capability Thanks for this David & Eric I presume

svn commit: r334238 - head/sys/kern

Author: vangyzen Date: Sat May 26 14:01:44 2018 New Revision: 334238 URL: https://svnweb.freebsd.org/changeset/base/334238 Log: kdb_trap: Fix use of uninitialized data In some cases, other_cpus was used without being initialized. Thankfully, it was harmless. Reported by: Coverity

svn commit: r334239 - head/sys/dev/hyperv/netvsc

Author: vangyzen Date: Sat May 26 14:14:56 2018 New Revision: 334239 URL: https://svnweb.freebsd.org/changeset/base/334239 Log: if_hn: fix use of uninitialized variable omcast was used without being initialized in the non-multicast case. The only effect was that the interface's multicast

svn commit: r334240 - head/sys/kern

Author: vangyzen Date: Sat May 26 14:23:11 2018 New Revision: 334240 URL: https://svnweb.freebsd.org/changeset/base/334240 Log: kern_cpuset: fix small leak on error path The "mask" was leaked on some error paths. Reported by: Coverity CID: 1384683 Sponsored by: Dell EMC

Re: svn commit: r334104 - in head/sys: netinet sys

On 05/23/2018 23:47, Gleb Smirnoff wrote: On Thu, May 24, 2018 at 06:44:20AM +0200, Mateusz Guzik wrote: M> I fundamentally disagree with this part. M> M> If a known value of a given field is needed for assertion purposes, you M> can add (possibly conditional) code setting this specific value. It

svn commit: r334265 - head/usr.sbin/tcpdrop

Author: vangyzen Date: Mon May 28 01:58:49 2018 New Revision: 334265 URL: https://svnweb.freebsd.org/changeset/base/334265 Log: tcpdrop: ensure NUL termination of a string strncpy did not guarantee NUL termination of the "stack" string. Use strlcpy instead. While I'm here, avoid unnecess

svn commit: r334267 - head/lib/libprocstat

Author: vangyzen Date: Mon May 28 02:10:35 2018 New Revision: 334267 URL: https://svnweb.freebsd.org/changeset/base/334267 Log: libprocstat: fix memory leak Free the rlimits array on the happy path in procstat_getrlimit_core(). Reported by: Coverity CID: 1373328 Sponsored

svn commit: r334268 - head/lib/libc/gen

Author: vangyzen Date: Mon May 28 02:31:49 2018 New Revision: 334268 URL: https://svnweb.freebsd.org/changeset/base/334268 Log: fts_stat: fix buffer overrun on error path Reported by: Coverity CID: 1375582 MFC after:1 week Sponsored by: Dell EMC Modified: head/lib/lib

svn commit: r334269 - head/sys/dev/drm

Author: vangyzen Date: Mon May 28 02:34:38 2018 New Revision: 334269 URL: https://svnweb.freebsd.org/changeset/base/334269 Log: drm: fix memory leak on error path Reported by: Coverity CID: 1368753 MFC after:3 days Sponsored by: Dell EMC Modified: head/sys/dev/drm/drm

svn commit: r334270 - head/usr.bin/logger

Author: vangyzen Date: Mon May 28 02:40:06 2018 New Revision: 334270 URL: https://svnweb.freebsd.org/changeset/base/334270 Log: logger: fix memory leak and use-after-free This one call to getaddrinfo() did not adhere to the common idiom of storing the result into a second res0 variable, w

svn commit: r334271 - head/usr.sbin/bhyve

Author: vangyzen Date: Mon May 28 03:05:01 2018 New Revision: 334271 URL: https://svnweb.freebsd.org/changeset/base/334271 Log: bhyve: fix small memory leak in virtio console Reported by: Coverity CID: 1363284 Sponsored by: Dell EMC Modified: head/usr.sbin/bhyve/pci_virtio_

svn commit: r334272 - head/usr.sbin/bhyve

Author: vangyzen Date: Mon May 28 03:09:09 2018 New Revision: 334272 URL: https://svnweb.freebsd.org/changeset/base/334272 Log: bhyve: guarantee NUL termination Use strlcpy to guarantee NUL termination of the path to a virtio console socket. Reported by: Coverity CID: 136

svn commit: r334273 - head/sys/cam/nvme

Author: vangyzen Date: Mon May 28 03:14:36 2018 New Revision: 334273 URL: https://svnweb.freebsd.org/changeset/base/334273 Log: cam nvme: fix array overrun Fix a classic array overrun where the index could be one past the end. Reported by: Coverity CID: 1356596 MFC after:

svn commit: r334306 - in head: lib/libc/stdlib share/man/man3

Author: vangyzen Date: Tue May 29 01:16:00 2018 New Revision: 334306 URL: https://svnweb.freebsd.org/changeset/base/334306 Log: Cross-reference abort2(2) from a few man pages I didn't know abort2 existed until it was mentioned on a mailing list. Mention it in related pages so others can f

svn commit: r334308 - in head: lib/libc/stdlib share/man/man3

Author: vangyzen Date: Tue May 29 02:41:32 2018 New Revision: 334308 URL: https://svnweb.freebsd.org/changeset/base/334308 Log: Bump the date on man pages in r334306 It seems a shame to ruin the patina of the June 4, 1993 date on abort.3, especially since it still matched the date of th

Re: svn commit: r334345 - head/lib/libpmc

On 05/29/2018 13:26, Matt Macy wrote: > if (pmc_pmu_pmcallocate(ctrname, &pmc_config) == 0) { > if (PMC_CALL(PMCALLOCATE, &pmc_config) < 0) > return (errno); ^^ spec_copy is still leaked here. > + free(spec_copy); >

Re: svn commit: r334347 - head/lib/libpmc

On 05/29/2018 14:07, Matt Macy wrote: > if (pmc_pmu_pmcallocate(ctrname, &pmc_config) == 0) { > - if (PMC_CALL(PMCALLOCATE, &pmc_config) < 0) > - return (errno); > - free(spec_copy); > + if (PMC_CALL(PMCALLOCATE, &pmc_config) < 0) { > +

svn commit: r334351 - head/lib/libpmc

Author: vangyzen Date: Tue May 29 20:30:46 2018 New Revision: 334351 URL: https://svnweb.freebsd.org/changeset/base/334351 Log: pmc_annotate: adhere to the API If the 'mode' parameter was invalid, pmc_annotate() would return EINVAL instead of setting errno and returning -1. Sponsored

Re: svn commit: r334545 - in head/sys: contrib/zstd/lib/freebsd kern netinet/libalias sys

On 06/02/2018 17:20, Mateusz Guzik wrote: > +#ifdef _KERNEL > +#define malloc(size, type, flags) ({\ > + void *_malloc_item; \ > + size_t _size = (size); \ > + if (__bui

svn commit: r334669 - head/sys/sys

Author: vangyzen Date: Tue Jun 5 20:34:11 2018 New Revision: 334669 URL: https://svnweb.freebsd.org/changeset/base/334669 Log: Make Coverity more happy with r334545 Coverity complains about: if (((flags) & M_WAITOK) || _malloc_item != NULL) saying: The expression

Re: svn commit: r334669 - head/sys/sys

On 06/05/2018 15:53, Ian Lepore wrote: > On Tue, 2018-06-05 at 20:34 +0000, Eric van Gyzen wrote: >> Author: vangyzen >> Date: Tue Jun  5 20:34:11 2018 >> New Revision: 334669 >> URL: https://svnweb.freebsd.org/changeset/base/334669 >> >> Log: >

svn commit: r335206 - head/cddl/contrib/opensolaris/cmd/zfs

Author: vangyzen Date: Fri Jun 15 15:28:31 2018 New Revision: 335206 URL: https://svnweb.freebsd.org/changeset/base/335206 Log: Fix markup in zfs(8); no content change Sponsored by: Dell EMC Modified: head/cddl/contrib/opensolaris/cmd/zfs/zfs.8 Modified: head/cddl/contrib/opensolaris/cm

svn commit: r303519 - head/share/man/man9

Author: vangyzen Date: Fri Jul 29 21:12:48 2016 New Revision: 303519 URL: https://svnweb.freebsd.org/changeset/base/303519 Log: Fix two return types in the cpuset(9) and bitset(9) man pages The *_FFS() and *_COUNT() functions return int, not size_t. MFC after:3 days Sponsored by:

svn commit: r303520 - head/usr.bin/cpuset

Author: vangyzen Date: Fri Jul 29 21:18:20 2016 New Revision: 303520 URL: https://svnweb.freebsd.org/changeset/base/303520 Log: Fix markup for -j in cpuset(1) synopsis MFC after:3 days Sponsored by: Dell Inc. Modified: head/usr.bin/cpuset/cpuset.1 Modified: head/usr.bin/cpuset/cpu

svn commit: r303620 - stable/11/share/man/man9

Author: vangyzen Date: Mon Aug 1 16:24:46 2016 New Revision: 303620 URL: https://svnweb.freebsd.org/changeset/base/303620 Log: MFC r303519 Fix two return types in the cpuset(9) and bitset(9) man pages The *_FFS() and *_COUNT() functions return int, not size_t. Approved by: re (g

svn commit: r303624 - stable/11/usr.bin/cpuset

Author: vangyzen Date: Mon Aug 1 16:39:40 2016 New Revision: 303624 URL: https://svnweb.freebsd.org/changeset/base/303624 Log: MFC r303520 Fix markup for -j in cpuset(1) synopsis Approved by: re (kib) Sponsored by: Dell Inc. Modified: stable/11/usr.bin/cpuset/cpuset.1 Directory

svn commit: r303788 - in head: sys/dev/pci usr.sbin/pciconf

Author: vangyzen Date: Fri Aug 5 23:23:48 2016 New Revision: 303788 URL: https://svnweb.freebsd.org/changeset/base/303788 Log: Fix some logic in PCIe HotPlug; display EI status The interpretation of the Electromechanical Interlock Status was inverted, so we disengaged the EI if a card wa

svn commit: r303835 - in stable/11: sys/dev/pci usr.sbin/pciconf

Author: vangyzen Date: Mon Aug 8 15:07:38 2016 New Revision: 303835 URL: https://svnweb.freebsd.org/changeset/base/303835 Log: MFC r303788 Fix some logic in PCIe HotPlug; display EI status The interpretation of the Electromechanical Interlock Status was inverted, so we disengaged th

Re: svn commit: r304046 - in head: sbin/ipfw sys/conf sys/modules sys/modules/ipfw_nat64 sys/netinet sys/netinet6 sys/netpfil/ipfw/nat64

On 08/13/16 11:09 AM, Andrey V. Elsukov wrote: > Author: ae > Date: Sat Aug 13 16:09:49 2016 > New Revision: 304046 > URL: https://svnweb.freebsd.org/changeset/base/304046 > > Log: > Add ipfw_nat64 module that implements stateless and stateful NAT64. Thanks for contributing this. When you get

svn commit: r304246 - head/sys/dev/pci

Author: vangyzen Date: Wed Aug 17 01:24:34 2016 New Revision: 304246 URL: https://svnweb.freebsd.org/changeset/base/304246 Log: PCIe HotPlug: Detect bridges that are not really HotPlug capable Some devices report that they have an MRL when they actually do not. Since they always report t

svn commit: r304433 - stable/11/sys/dev/pci

Author: vangyzen Date: Thu Aug 18 21:47:00 2016 New Revision: 304433 URL: https://svnweb.freebsd.org/changeset/base/304433 Log: MFC r304246 PCIe HotPlug: Detect bridges that are not really HotPlug capable Some devices report that they have an MRL when they actually do not. Since the

svn commit: r304434 - releng/11.0/sys/dev/pci

Author: vangyzen Date: Thu Aug 18 22:01:52 2016 New Revision: 304434 URL: https://svnweb.freebsd.org/changeset/base/304434 Log: MFC r304433 PCIe HotPlug: Detect bridges that are not really HotPlug capable Some devices report that they have an MRL when they actually do not. Since the

Re: svn commit: r303988 - head/lib/libc/gen

On 08/24/2016 15:01, Ed Schouten wrote: > 2016-08-24 21:53 GMT+02:00 Bryan Drewery : >> Is it possible to cause the use of these old prototypes to print a >> warning and note that they are deprecated/unsafe? > > That's a good question. In theory, we could annotate these functions > with __attribut

Re: svn commit: r303988 - head/lib/libc/gen

On 08/24/2016 15:16, Bryan Drewery wrote: > On 8/24/16 1:12 PM, Eric van Gyzen wrote: >> On 08/24/2016 15:01, Ed Schouten wrote: >>> 2016-08-24 21:53 GMT+02:00 Bryan Drewery : >>>> Is it possible to cause the use of these old prototypes to print a >>>>

Re: svn commit: r304815 - in head: lib lib/libifc share/examples/libifc share/mk

On 08/25/2016 15:20, Kristof Provost wrote: > On 25 Aug 2016, at 22:14, John Baldwin wrote: >> On Thursday, August 25, 2016 07:40:25 PM Kristof Provost wrote: >>> Author: kp >>> Date: Thu Aug 25 19:40:25 2016 >>> New Revision: 304815 >>> URL: https://svnweb.freebsd.org/changeset/base/304815 >>> >>>

Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec

> On Feb 26, 2019, at 10:17 PM, Warner Losh wrote: > > > > On Tue, Feb 26, 2019, 6:50 AM Alexey Dokuchaev > wrote: > On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote: > > > Author: sjg > > > Date: Tue Feb 26 06:17:23 2019 > > > New Revision: 344567 >

URLs in the PR field of commit logs

(I apologize for the massive cross-post. There was no obvious place to announce this.) I plan to change the Subversion commit hooks to accept URLs in the PR field of commit logs. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236229 If you anticipate specific problems this might

URLs in the PR field of commit logs

(I apologize for the massive cross-post. There was no obvious place to announce this.) I plan to change the Subversion commit hooks to accept URLs in the PR field of commit logs. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236229 If you anticipate specific problems this might

  1   2   3   4   >