svn commit: r349154 - in head: sys/dev/random tests/sys/devrandom

2019-06-17 Thread Conrad Meyer
Author: cem Date: Mon Jun 17 20:29:13 2019 New Revision: 349154 URL: https://svnweb.freebsd.org/changeset/base/349154 Log: random(4): Fortuna: allow increased concurrency Add experimental feature to increase concurrency in Fortuna. As this diverges slightly from canonical Fortuna, and du

svn commit: r349176 - head/sys/dev/random

2019-06-18 Thread Conrad Meyer
Author: cem Date: Tue Jun 18 18:50:58 2019 New Revision: 349176 URL: https://svnweb.freebsd.org/changeset/base/349176 Log: random(4): Fix a regression in short AES mode reads In r349154, random device reads of size < 16 bytes (AES block size) were accidentally broken to loop forever. Cor

svn commit: r349253 - in head: . release/picobsd/bridge release/picobsd/qemu share/man/man4 sys/amd64/conf sys/arm/conf sys/arm64/conf sys/conf sys/i386/conf sys/mips/conf sys/mips/mediatek sys/pow...

2019-06-20 Thread Conrad Meyer
Author: cem Date: Fri Jun 21 00:16:30 2019 New Revision: 349253 URL: https://svnweb.freebsd.org/changeset/base/349253 Log: sys: Remove DEV_RANDOM device option Remove 'device random' from kernel configurations that reference it (most). Replace perhaps mistaken 'nodevice random' in two MIP

svn commit: r349254 - head

2019-06-20 Thread Conrad Meyer
Author: cem Date: Fri Jun 21 00:33:45 2019 New Revision: 349254 URL: https://svnweb.freebsd.org/changeset/base/349254 Log: Fixup UPDATING text for r349253 Requested by: delphij Modified: head/UPDATING Modified: head/UPDATING ==

svn commit: r349256 - head/libexec/rc/rc.d

2019-06-20 Thread Conrad Meyer
Author: cem Date: Fri Jun 21 02:37:54 2019 New Revision: 349256 URL: https://svnweb.freebsd.org/changeset/base/349256 Log: rc.d/motd: Update motd more robustly Use appropriate fsyncs to persist the rewritten /etc/motd file, when a rewrite is performed. Reported by: Jonathan Walton

Re: svn commit: r349151 - in head: lib/libufs stand/libsa sys/conf sys/dev/iscsi sys/dev/iscsi_initiator sys/dev/liquidio sys/dev/usb/net sys/fs/ext2fs sys/fs/nandfs sys/geom/part sys/geom/raid sys/ke

2019-06-22 Thread Conrad Meyer
Hi Xin Li, On Mon, Jun 17, 2019 at 12:49 PM Xin LI wrote: > > Author: delphij > Date: Mon Jun 17 19:49:08 2019 > New Revision: 349151 > URL: https://svnweb.freebsd.org/changeset/base/349151 > > Log: > Separate kernel crc32() implementation to its own header (gsb_crc32.h) and > rename the sour

Re: svn commit: r349231 - in head/sys: kern sys ufs/ufs

2019-06-28 Thread Conrad Meyer
To this end, __result_use_check can help ensure no unchecked callers are missed when panics are downgraded to errors. (In OneFS, the macro has the imo more memorable name “__must_check”. Cheers, Conrad On Thu, Jun 27, 2019 at 23:48 Scott Long wrote: > > > > On Jun 27, 2019, at 3:09 PM, Konstant

Re: svn commit: r349589 - in head: sbin/mount sys/sys sys/ufs/ffs

2019-07-01 Thread Conrad Meyer
Hi, Maybe the sense of the flag should be reversed? Ie, add a “trusted” flag and default to untrusted. I have two reasons in mind. The first is that a new default-off option is easy to forget, and a missed security feature may be worse than a missed mount-time performance enhancement. The second

Re: svn commit: r349391 - head/sys/kern

2019-07-14 Thread Conrad Meyer
Hi Alan, This change restores the possible overflow beyond IO_SEQMAX that the removed conditional prevented. On Tue, Jun 25, 2019 at 12:44 PM Alan Somers wrote: > > Author: asomers > Date: Tue Jun 25 19:44:22 2019 > New Revision: 349391 > URL: https://svnweb.freebsd.org/changeset/base/349391 > >

svn commit: r350184 - in head: libexec/rc/rc.d release/picobsd/tinyware/login share/man/man5 usr.bin/login

2019-07-20 Thread Conrad Meyer
Author: cem Date: Sat Jul 20 20:56:31 2019 New Revision: 350184 URL: https://svnweb.freebsd.org/changeset/base/350184 Log: motd: Generate from template to /var/run Update login(1), its manual pages, similar utilities, and motd.5 to refer to the new location. Suggested by: delphij@ (r

Re: svn commit: r350184 - in head: libexec/rc/rc.d release/picobsd/tinyware/login share/man/man5 usr.bin/login

2019-07-21 Thread Conrad Meyer
On Sun, Jul 21, 2019 at 3:52 AM Dimitry Andric wrote: > On 20 Jul 2019, at 22:56, Conrad Meyer wrote: > > Author: cem > > Date: Sat Jul 20 20:56:31 2019 > > New Revision: 350184 > > URL: https://svnweb.freebsd.org/changeset/base/350184 > > > > Log: > &

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-24 Thread Conrad Meyer
Hi Philip, Sorry I'm late to the party. Unless I am mistaken, most of these are *not* overflows or vulnerabilities of any sort. On Wed, Jul 10, 2019 at 10:42 AM Philip Paeps wrote: > > Author: philip > Date: Wed Jul 10 17:42:04 2019 > New Revision: 349890 > URL: https://svnweb.freebsd.org/chang

svn commit: r350624 - in head/sys/dev: amdsmn amdtemp

2019-08-05 Thread Conrad Meyer
Author: cem Date: Tue Aug 6 03:54:27 2019 New Revision: 350624 URL: https://svnweb.freebsd.org/changeset/base/350624 Log: amdtemp(4), amdsmn(4): Attach to Ryzen 3 (Zen 2) hostbridges PR: 239607 Reported by: "drclaw" Modified: head/sys/dev/amdsmn/amdsmn.c head/sys/dev/amdtemp/amd

svn commit: r350691 - in head: share/man/man9 sys/kern sys/sys

2019-08-07 Thread Conrad Meyer
Author: cem Date: Wed Aug 7 19:23:07 2019 New Revision: 350691 URL: https://svnweb.freebsd.org/changeset/base/350691 Log: sbuf(9): Add NOWAIT dynamic buffer extension mode The goal is to avoid some kinds of low-memory deadlock when formatting heap-allocated buffers. Reviewed by: va

svn commit: r350692 - head/sys/kern

2019-08-07 Thread Conrad Meyer
Author: cem Date: Wed Aug 7 19:25:56 2019 New Revision: 350692 URL: https://svnweb.freebsd.org/changeset/base/350692 Log: sbuf(9): Refactor sbuf_newbuf into sbuf_new Code flow was somewhat difficult to read due to the combination of multiple return sites and the 4x possible dynamic const

svn commit: r350693 - in head: share/man/man9 sys/kern sys/sys

2019-08-07 Thread Conrad Meyer
Author: cem Date: Wed Aug 7 19:27:14 2019 New Revision: 350693 URL: https://svnweb.freebsd.org/changeset/base/350693 Log: sbuf(9): Add sbuf_nl_terminate() API The API is used to gracefully terminate text line(s) with a single \n. If the formatted buffer was empty or already ended in \n,

svn commit: r350694 - in head: share/man/man9 sys/dev/fdc sys/geom sys/geom/cache sys/geom/concat sys/geom/eli sys/geom/gate sys/geom/journal sys/geom/label sys/geom/linux_lvm sys/geom/mirror sys/g...

2019-08-07 Thread Conrad Meyer
4) @@ -345,7 +345,8 @@ void g_reset_bio(struct bio *); void * g_read_data(struct g_consumer *cp, off_t offset, off_t length, int *error); int g_write_data(struct g_consumer *cp, off_t offset, void *ptr, off_t length); int g_delete_data(struct g_consumer *cp, off_t offset, off_t length); -void g

svn commit: r350713 - head/sys/kern

2019-08-07 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 00:42:29 2019 New Revision: 350713 URL: https://svnweb.freebsd.org/changeset/base/350713 Log: ddb(4): Add 'sysctl' command Implement `sysctl` in `ddb` by overriding `SYSCTL_OUT`. When handling the req, we install custom ddb in/out handlers. The out handler p

Re: svn commit: r350714 - head/share/man/man9

2019-08-07 Thread Conrad Meyer
Thanks Li-Wen Hsu! On Wed, Aug 7, 2019 at 5:51 PM Li-Wen Hsu wrote: > > Author: lwhsu > Date: Thu Aug 8 00:51:17 2019 > New Revision: 350714 > URL: https://svnweb.freebsd.org/changeset/base/350714 > > Log: > Follow r350693 to add a link for sbuf_nl_terminate(9) > > Sponsored by: The FreeBSD

svn commit: r350715 - head/sys/kern

2019-08-07 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 01:37:41 2019 New Revision: 350715 URL: https://svnweb.freebsd.org/changeset/base/350715 Log: Fix !DDB kernel configurations after r350713 KDB is standard and the kdb_active variable is always available. So, de-conditionalize inclusion of sys/kdb.h in kern_sy

Re: svn commit: r350315 - in head/sys: kern sys

2019-08-07 Thread Conrad Meyer
Hi Rick, Coverity reports that the following portion of vn_generic_copy_file_range() is deadcode (CID 1403974), and it is: On Wed, Jul 24, 2019 at 10:46 PM Rick Macklem wrote: > > Author: rmacklem > Date: Thu Jul 25 05:46:16 2019 > New Revision: 350315 > URL: https://svnweb.freebsd.org/changeset

svn commit: r350739 - in head: share/mk sys/conf

2019-08-07 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 03:27:46 2019 New Revision: 350739 URL: https://svnweb.freebsd.org/changeset/base/350739 Log: Disable useless -Wformat-zero-length It is part of -Wformat, which is enabled by -Wall. Empty format strings are well defined and it is perfectly reasonable to expec

svn commit: r350740 - head/share/mk

2019-08-07 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 04:29:46 2019 New Revision: 350740 URL: https://svnweb.freebsd.org/changeset/base/350740 Log: r350739 try #2 For some inexplicable reason, C++ compilers reject the -Wno- flag, and also (ab)use CWARNFLAGS. Reported by: imp Modified: head/share/mk/bsd.s

svn commit: r350752 - in vendor/zstd/dist: . doc examples lib lib/common lib/compress lib/decompress lib/dictBuilder lib/legacy programs tests tests/fuzz tests/regression zlibWrapper

2019-08-08 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 15:30:49 2019 New Revision: 350752 URL: https://svnweb.freebsd.org/changeset/base/350752 Log: import zstd 1.4.1 Added: vendor/zstd/dist/tests/bigdict.c (contents, props changed) vendor/zstd/dist/tests/fuzz/simple_compress.c (contents, props changed) vendor

svn commit: r350753 - vendor/zstd/1.4.1

2019-08-08 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 15:32:53 2019 New Revision: 350753 URL: https://svnweb.freebsd.org/changeset/base/350753 Log: tag zstd 1.4.1 Added: vendor/zstd/1.4.1/ - copied from r350752, vendor/zstd/dist/ ___ svn-src-all@freebsd.org mailing lis

svn commit: r350754 - in vendor/zstd/dist: . contrib/largeNbDicts contrib/seekable_format contrib/seekable_format/examples doc lib lib/compress lib/decompress lib/legacy programs tests

2019-08-08 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 15:37:56 2019 New Revision: 350754 URL: https://svnweb.freebsd.org/changeset/base/350754 Log: import zstd 1.4.2 Added: vendor/zstd/dist/contrib/seekable_format/examples/seekable_decompression_mem.c (contents, props changed) vendor/zstd/dist/lib/compress/zstd

svn commit: r350755 - vendor/zstd/1.4.2

2019-08-08 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 15:38:57 2019 New Revision: 350755 URL: https://svnweb.freebsd.org/changeset/base/350755 Log: tag zstd 1.4.2 Added: vendor/zstd/1.4.2/ - copied from r350754, vendor/zstd/dist/ ___ svn-src-all@freebsd.org mailing lis

svn commit: r350760 - in head: lib/libzstd sys/conf sys/contrib/zstd sys/contrib/zstd/contrib/largeNbDicts sys/contrib/zstd/contrib/seekable_format sys/contrib/zstd/contrib/seekable_format/examples...

2019-08-08 Thread Conrad Meyer
Author: cem Date: Thu Aug 8 16:54:22 2019 New Revision: 350760 URL: https://svnweb.freebsd.org/changeset/base/350760 Log: Update to Zstandard 1.4.2 The full release notes for 1.4.1 (skipped) and 1.4.2 can be found on Github: https://github.com/facebook/zstd/releases/tag/v1.4.1 h

Re: svn commit: r350778 - head/sys/contrib/zstd/lib/common

2019-08-08 Thread Conrad Meyer
Thanks Warner for noticing and fixing this. I've sent the patch upstream to hopefully be addressed there as well: https://github.com/facebook/zstd/pull/1713 Best, Conrad On Thu, Aug 8, 2019 at 1:09 PM Warner Losh wrote: > > Author: imp > Date: Thu Aug 8 20:09:36 2019 > New Revision: 350778 >

svn commit: r350813 - head/tools/tools/crypto

2019-08-08 Thread Conrad Meyer
Author: cem Date: Fri Aug 9 02:11:47 2019 New Revision: 350813 URL: https://svnweb.freebsd.org/changeset/base/350813 Log: tools/tools/crypto: cryptokeytest: Fix build with newer OpenSSL Also, drag into this decade. Modified: head/tools/tools/crypto/cryptokeytest.c Modified: head/tools/

svn commit: r350843 - head

2019-08-10 Thread Conrad Meyer
Author: cem Date: Sat Aug 10 18:22:22 2019 New Revision: 350843 URL: https://svnweb.freebsd.org/changeset/base/350843 Log: .gitignore: Add LINT kernel configurations generated into SRCDIR Modified: head/.gitignore Modified: head/.gitignore

svn commit: r347229 - in head: lib/libsbuf lib/libsbuf/tests share/man/man9 sys/kern sys/sys

2019-05-07 Thread Conrad Meyer
Author: cem Date: Tue May 7 17:47:20 2019 New Revision: 347229 URL: https://svnweb.freebsd.org/changeset/base/347229 Log: device_printf: Use sbuf for more coherent prints on SMP device_printf does multiple calls to printf allowing other console messages to be inserted between the device

Re: svn commit: r347229 - in head: lib/libsbuf lib/libsbuf/tests share/man/man9 sys/kern sys/sys

2019-05-07 Thread Conrad Meyer
One correction On Tue, May 7, 2019 at 10:47 AM Conrad Meyer wrote: > Author: cem > Date: Tue May 7 17:47:20 2019 > New Revision: 347229 > URL: https://svnweb.freebsd.org/changeset/base/347229 > > Log: > device_printf: Use sbuf for more coherent prints on SMP > >

svn commit: r347235 - head/lib/libsbuf

2019-05-07 Thread Conrad Meyer
Author: cem Date: Tue May 7 21:15:11 2019 New Revision: 347235 URL: https://svnweb.freebsd.org/changeset/base/347235 Log: Fix libsbuf sbuf_printf_drain symbol version (Introduced incorrectly in r347229 earlier today.) As pointed out by kevans, 1.6 should be used for FreeBSD 13, like r

svn commit: r347238 - head/sys/amd64/vmm

2019-05-07 Thread Conrad Meyer
Author: cem Date: Wed May 8 00:40:08 2019 New Revision: 347238 URL: https://svnweb.freebsd.org/changeset/base/347238 Log: vmm(4): Pass through RDSEED feature bit to guests Reviewed by: jhb Approved by: #bhyve (jhb) MFC after:2 leapseconds Sponsored by: Dell EMC Isilon Differe

svn commit: r347239 - head/sys/dev/random

2019-05-07 Thread Conrad Meyer
Author: cem Date: Wed May 8 00:45:16 2019 New Revision: 347239 URL: https://svnweb.freebsd.org/changeset/base/347239 Log: random: x86 driver: Prefer RDSEED over RDRAND when available Per https://software.intel.com/en-us/blogs/2012/11/17/the-difference-between-rdrand-and-rdseed , RDRAN

Re: svn commit: r347066 - in head: sbin/fsck_ffs sys/ufs/ufs

2019-05-07 Thread Conrad Meyer
Hi Kirk, Coverity points out that namlen may be used uninitialized in the following sequence (CID 1401317): On Fri, May 3, 2019 at 2:54 PM Kirk McKusick wrote: > > Author: mckusick > Date: Fri May 3 21:54:14 2019 > New Revision: 347066 > URL: https://svnweb.freebsd.org/changeset/base/347066 > >

Re: svn commit: r346645 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src sys

2019-05-07 Thread Conrad Meyer
Hi Tycho, On Wed, Apr 24, 2019 at 1:31 PM Tycho Nightingale wrote: > > Author: tychon > Date: Wed Apr 24 20:30:45 2019 > New Revision: 346645 > URL: https://svnweb.freebsd.org/changeset/base/346645 > > Log: > LinuxKPI should use bus_dma(9) to be compatible with an IOMMU > > Reviewed by: hsel

Re: svn commit: r347221 - head/sys/net

2019-05-07 Thread Conrad Meyer
Hi Marius, This change seems to break LINT-NOIP tinderbox builds; one reference to tcp_lro_free() is covered by #if defined(INET) || defined(INET6), but the one added in iflib_rx_structures_free() is not. On Tue, May 7, 2019 at 1:28 AM Marius Strobl wrote: > > Author: marius > Date: Tue May 7 0

Re: svn commit: r347239 - head/sys/dev/random

2019-05-08 Thread Conrad Meyer
Unfortunately, no real knob for it. I have proposed disabling the warning in https://reviews.freebsd.org/D20195 . Sorry about the noise. Best, Conrad On Wed, May 8, 2019 at 2:08 AM Michael Tuexen wrote: > > On 8. May 2019, at 02:45, Conrad Meyer wrote: > > > > Author: cem

svn commit: r347329 - head/sys/dev/random

2019-05-08 Thread Conrad Meyer
Author: cem Date: Wed May 8 14:54:32 2019 New Revision: 347329 URL: https://svnweb.freebsd.org/changeset/base/347329 Log: random(4): Don't complain noisily when an entropy source is slow Mjg@ reports that RDSEED (r347239) causes a lot of logspam from this printf, and I don't feel that it

svn commit: r347467 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 21:55:11 2019 New Revision: 347467 URL: https://svnweb.freebsd.org/changeset/base/347467 Log: netdump: Don't store sensitive key data we don't need Prior to this revision, struct diocskerneldump_arg (and struct netdump_conf with embedded diocskerneldump_arg be

svn commit: r347473 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 23:12:59 2019 New Revision: 347473 URL: https://svnweb.freebsd.org/changeset/base/347473 Log: netdump: Ref the interface we're attached to Serialize netdump configuration / deconfiguration, and discard our configuration when the affiliated interface goes away

svn commit: r347471 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 23:10:22 2019 New Revision: 347471 URL: https://svnweb.freebsd.org/changeset/base/347471 Log: netdump: Fix boot-time configuration typo Boot-time netdump configuration is much more useful if one can configure the client and gateway addresses. Fix trivial typo

svn commit: r347546 - head/sys/dev/random

2019-05-13 Thread Conrad Meyer
Author: cem Date: Mon May 13 19:35:35 2019 New Revision: 347546 URL: https://svnweb.freebsd.org/changeset/base/347546 Log: Fortuna: Fix false negatives in is_random_seeded() (1) We may have had sufficient entropy to consider Fortuna seeded, but the random_fortuna_seeded() function would p

svn commit: r347555 - in head: . sys/kern

2019-05-13 Thread Conrad Meyer
Author: cem Date: Mon May 13 23:37:44 2019 New Revision: 347555 URL: https://svnweb.freebsd.org/changeset/base/347555 Log: Revert r346292 (permit_nonrandom_stackcookies) We have a better, more comprehensive knob for this now: kern.random.initial_seeding.bypass_before_seeding=1. Reque

svn commit: r347639 - head/sys/x86/x86

2019-05-15 Thread Conrad Meyer
Author: cem Date: Thu May 16 01:32:54 2019 New Revision: 347639 URL: https://svnweb.freebsd.org/changeset/base/347639 Log: x86: Correctly identify bhyve hypervisor Spotted after a similar report by Olivier Cochard-Labbé. Sponsored by: Dell EMC Isilon Modified: head/sys/x86/x86/ident

Re: svn commit: r347638 - in head: . etc lib/libc/gen

2019-05-16 Thread Conrad Meyer
Hi Brad, Can you revert this? It seems to break every config-management tool we have (mergemaster, etcupdate, beinstall ...). Additionally, I don't believe this move has been justified — the cons seem to outweigh the pros, if there are any. I skimmed the differential and it was not immediately

svn commit: r347828 - head/sys/dev/xdma

2019-05-16 Thread Conrad Meyer
Author: cem Date: Thu May 16 17:34:36 2019 New Revision: 347828 URL: https://svnweb.freebsd.org/changeset/base/347828 Log: xdma(4): Fix invalid pointer use (breaks arm.SOCFPGA build) In xdma_handle_mem_node(), vmem_size_t and vmem_addr_t pointers were passed to an FDT API that emits u_lon

svn commit: r347888 - in head/sys/mips: include mips

2019-05-16 Thread Conrad Meyer
Author: cem Date: Thu May 16 19:10:48 2019 New Revision: 347888 URL: https://svnweb.freebsd.org/changeset/base/347888 Log: mips: Implement basic pmap_kenter_device, pmap_kremove_device Unbreak mips.BERI_DE4_SDROOT build, which uses device xdma. Device xdma depends on the pmap_kenter_devic

svn commit: r347948 - in head: sbin/fdisk sys/sys/disk

2019-05-17 Thread Conrad Meyer
Author: cem Date: Sat May 18 00:22:28 2019 New Revision: 347948 URL: https://svnweb.freebsd.org/changeset/base/347948 Log: Add DragonFly's partition number to fdisk(8) and diskmbr.h This change doesn't make any attempt to add support for these slices to the relevent GEOM classes. Just re

svn commit: r347967 - head/share/man/man4

2019-05-18 Thread Conrad Meyer
Author: cem Date: Sun May 19 06:01:11 2019 New Revision: 347967 URL: https://svnweb.freebsd.org/changeset/base/347967 Log: nvd.4: Reference nda(4) Fix a totally minor typo in nvme.4 while here. Modified: head/share/man/man4/nvd.4 head/share/man/man4/nvme.4 Modified: head/share/man/man

svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra12...

2019-05-19 Thread Conrad Meyer
Author: cem Date: Mon May 20 00:38:23 2019 New Revision: 347984 URL: https://svnweb.freebsd.org/changeset/base/347984 Log: Extract eventfilter declarations to sys/_eventfilter.h This allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h" in other header files (e.g., sys/{

Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra1

2019-05-20 Thread Conrad Meyer
On Mon, May 20, 2019 at 12:21 PM Peter Jeremy wrote: > > On 2019-May-20 00:38:23 +, Conrad Meyer wrote: > >Author: cem > >Date: Mon May 20 00:38:23 2019 > >New Revision: 347984 > >URL: https://svnweb.freebsd.org/changeset/base/347984 > > > >Log: &g

svn commit: r348022 - in head/sys: dev/netmap netinet/netdump

2019-05-20 Thread Conrad Meyer
Author: cem Date: Tue May 21 00:04:19 2019 New Revision: 348022 URL: https://svnweb.freebsd.org/changeset/base/348022 Log: Add two missing eventhandler.h headers These are obviously missing from the .c files, but don't show up in any tinderbox configuration (due to latent header pollution

Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra1

2019-05-20 Thread Conrad Meyer
g the eventhandler header (and fixing that is trivial), but I'd like to better understand where the leak is so that other misses can be located. Thanks, Conrad On Mon, May 20, 2019 at 12:31 PM Conrad Meyer wrote: > > Hi Peter, > > Thanks for reporting this. I ran a full tinderbox

svn commit: r348026 - in head/sys: arm/allwinner arm/amlogic/aml8726 arm/freescale/imx arm/rockchip arm/ti/am335x compat/linuxkpi/common/src dev/drm2/ttm dev/fb dev/hdmi dev/iscsi_initiator dev/mlx...

2019-05-20 Thread Conrad Meyer
Author: cem Date: Tue May 21 01:18:43 2019 New Revision: 348026 URL: https://svnweb.freebsd.org/changeset/base/348026 Log: Include eventhandler.h in more compilation units This was enumerated with exhaustive search for sys/eventhandler.h includes, cross-referenced against EVENTHANDLER_* u

svn commit: r348064 - in head/sys: arm64/arm64 dev/acpica dev/ixgbe fs/unionfs kern mips/mips riscv/riscv ufs/ffs ufs/ufs vm

2019-05-21 Thread Conrad Meyer
Author: cem Date: Tue May 21 20:38:48 2019 New Revision: 348064 URL: https://svnweb.freebsd.org/changeset/base/348064 Log: Include ktr.h in more compilation units Similar to r348026, exhaustive search for uses of CTRn() and cross reference ktr.h includes. Where it was obvious that an OS

svn commit: r348067 - head/sys/kern

2019-05-21 Thread Conrad Meyer
Author: cem Date: Tue May 21 21:26:14 2019 New Revision: 348067 URL: https://svnweb.freebsd.org/changeset/base/348067 Log: mqueuefs: Do not allow manipulation of the pseudo-dirents "." and ".." "." and ".." names are not maintained in the mqueuefs dirent datastructure and cannot be opened

svn commit: r348070 - head/sys/sys

2019-05-21 Thread Conrad Meyer
Author: cem Date: Tue May 21 21:35:37 2019 New Revision: 348070 URL: https://svnweb.freebsd.org/changeset/base/348070 Log: sys/lockmgr.h: Update #error to point at correct _lock.h After r347984, these macros live in sys/_lock.h. No functional change. Sponsored by: Dell EMC Isilon Mod

svn commit: r348076 - head/sys/sys

2019-05-21 Thread Conrad Meyer
Author: cem Date: Wed May 22 00:21:42 2019 New Revision: 348076 URL: https://svnweb.freebsd.org/changeset/base/348076 Log: Revert r348070 Konstantin points out that lockmgr probably requires the whole lock.h anyway. Requested by: kib Modified: head/sys/sys/lockmgr.h Modified: head/

svn commit: r348078 - head/usr.sbin/pmc

2019-05-21 Thread Conrad Meyer
Author: cem Date: Wed May 22 01:22:33 2019 New Revision: 348078 URL: https://svnweb.freebsd.org/changeset/base/348078 Log: pmc: Fix stack std::string lifetime It's invalid to reference a C++ string's c_str() buffer after the object goes out of scope. Adjust the scope of the string to mat

Re: svn commit: r348109 - in head/sys/x86: include x86

2019-05-22 Thread Conrad Meyer
On Wed, May 22, 2019 at 11:06 AM Andriy Gapon wrote: > > On 22/05/2019 16:44, Andrew Gallatin wrote: > > This is needed for AMD SMCA processors, as SMCA uses different > > MSR address for access MCA banks. > > Just curious, what is SMCA? Scalable MCA. It's a set of AMD Fam17h MCA extensions.

Re: svn commit: r348109 - in head/sys/x86: include x86

2019-05-22 Thread Conrad Meyer
On Wed, May 22, 2019 at 12:59 PM John Baldwin wrote: > On 5/22/19 12:12 PM, Conrad Meyer wrote: > > On Wed, May 22, 2019 at 11:06 AM Andriy Gapon wrote: > >> > >> On 22/05/2019 16:44, Andrew Gallatin wrote: > >>> This is needed for AMD SMCA process

svn commit: r348122 - in head/libexec: rc/rc.d save-entropy

2019-05-22 Thread Conrad Meyer
Author: cem Date: Wed May 22 21:47:17 2019 New Revision: 348122 URL: https://svnweb.freebsd.org/changeset/base/348122 Log: save-entropy(8), rc.d/random: Set nodump flag Tag saved entropy files as "nodump," to signal that the files should not be backed up by dump(8) or other automated back

Re: svn commit: r347638 - in head: . etc lib/libc/gen

2019-05-22 Thread Conrad Meyer
Hi Brad, Ping. It's still broken. Can you revert this please? Thanks, Conrad On Thu, May 16, 2019 at 8:05 AM Conrad Meyer wrote: > > Hi Brad, > > Can you revert this? It seems to break every config-management tool > we have (mergemaster, etcupdate, beinstall ...). >

svn commit: r348130 - in head/sys/x86: include x86

2019-05-22 Thread Conrad Meyer
Author: cem Date: Wed May 22 23:22:36 2019 New Revision: 348130 URL: https://svnweb.freebsd.org/changeset/base/348130 Log: Decode and name additional x86 feature bits These are all enumerated in Intel's ISA extension reference, 37th ed. Sponsored by: Dell EMC Isilon Modified: head/s

svn commit: r348197 - in head: sbin/decryptcore sbin/dumpon sys/kern sys/sys

2019-05-23 Thread Conrad Meyer
Author: cem Date: Thu May 23 20:12:24 2019 New Revision: 348197 URL: https://svnweb.freebsd.org/changeset/base/348197 Log: EKCD: Add Chacha20 encryption mode Add Chacha20 mode to Encrypted Kernel Crash Dumps. Chacha20 does not require messages to be multiples of block size, so it is

svn commit: r348198 - head/sys/dev/uart

2019-05-23 Thread Conrad Meyer
Author: cem Date: Thu May 23 20:18:46 2019 New Revision: 348198 URL: https://svnweb.freebsd.org/changeset/base/348198 Log: uart_cpu_acpi: Fix GCC build break from r348195 extern declarations are redundant with those in uart_cpu.h, which this file includes. X-MFC-with: r348195 Modi

svn commit: r348199 - head/sys/dev/random

2019-05-23 Thread Conrad Meyer
Author: cem Date: Thu May 23 21:02:27 2019 New Revision: 348199 URL: https://svnweb.freebsd.org/changeset/base/348199 Log: random(4): deduplicate explicit_bzero() in harvest Pull the responsibility for zeroing events, which is general to any conceivable implementation of a random device a

Re: svn commit: r348241 - head

2019-05-24 Thread Conrad Meyer
On Fri, May 24, 2019 at 9:24 AM Andrew Gallatin wrote: > Dumb question about this: Will it update toolchains, or just use what > can find? -DMAKE_JUST_KERNELS doesn't touch toolchains. For that, there is the less memorable build step: export NCPU=$((1 * $(sysctl -n hw.ncpu) / 3)); make -sj${NCP

svn commit: r348255 - head/sys/kern

2019-05-24 Thread Conrad Meyer
Author: cem Date: Fri May 24 22:33:14 2019 New Revision: 348255 URL: https://svnweb.freebsd.org/changeset/base/348255 Log: Disable intr_storm_threshold mechanism by default The ixl.4 manual page has documented that the threshold falsely detects interrupt storms on 40Gbit NICs as long ago

svn commit: r348262 - head/sys/dev/virtio/pci

2019-05-24 Thread Conrad Meyer
Author: cem Date: Sat May 25 01:59:24 2019 New Revision: 348262 URL: https://svnweb.freebsd.org/changeset/base/348262 Log: virtio_pci(4): Fix typo in read_ivar method Prior to this revision, vtpci's BUS_READ_IVAR method on VIRTIO_IVAR_SUBVENDOR accidentally returned the PCI subdevice.

svn commit: r348292 - head/sys/sys

2019-05-26 Thread Conrad Meyer
Author: cem Date: Mon May 27 00:43:43 2019 New Revision: 348292 URL: https://svnweb.freebsd.org/changeset/base/348292 Log: sys/bufobj.h: Avoid using C++ reserved keyword 'private' No functional change (except for out-of-tree C++ kmods). Modified: head/sys/sys/bufobj.h Modified: head/sys

svn commit: r348293 - head/sys/crypto/aesni

2019-05-26 Thread Conrad Meyer
Author: cem Date: Mon May 27 00:47:51 2019 New Revision: 348293 URL: https://svnweb.freebsd.org/changeset/base/348293 Log: aesni(4): Fix trivial type typo This fixes the kernel build with xtoolchain-gcc (6.4.0). X-MFC-With: r348268 Modified: head/sys/crypto/aesni/aesni_ccm.c Modi

svn commit: r348294 - head/share/man/man4

2019-05-26 Thread Conrad Meyer
Author: cem Date: Mon May 27 00:51:27 2019 New Revision: 348294 URL: https://svnweb.freebsd.org/changeset/base/348294 Log: virtio.4: Add missing devices and Xr This page could probably use further improvement. Modified: head/share/man/man4/virtio.4 Modified: head/share/man/man4/virtio.4

svn commit: r348295 - head/sys/dev/virtio/random

2019-05-26 Thread Conrad Meyer
Author: cem Date: Mon May 27 00:55:46 2019 New Revision: 348295 URL: https://svnweb.freebsd.org/changeset/base/348295 Log: virtio_random(4): Remove unneeded reference to device The device_t always references the softc, so we can pass the device and obtain the softc instead of the other wa

svn commit: r348309 - head/usr.sbin/kldxref

2019-05-27 Thread Conrad Meyer
Author: cem Date: Mon May 27 17:33:20 2019 New Revision: 348309 URL: https://svnweb.freebsd.org/changeset/base/348309 Log: kldxref(8): Sort MDT_MODULE info first in linker.hints output MDT_MODULE info is required to be ordered before any other MDT metadata for a given kld because it serve

svn commit: r348337 - head/share/man/man9

2019-05-28 Thread Conrad Meyer
Author: cem Date: Tue May 28 20:44:23 2019 New Revision: 348337 URL: https://svnweb.freebsd.org/changeset/base/348337 Log: style.9: Correct usage's definition to match its declaration Suggested by: emaste Reviewed by: delphij, imp, rgrimes, vangyzen (earlier version) Sponsored by: Dell

svn commit: r348489 - in head/sys: conf dev/random dev/virtio/random

2019-05-31 Thread Conrad Meyer
Author: cem Date: Sat Jun 1 01:22:21 2019 New Revision: 348489 URL: https://svnweb.freebsd.org/changeset/base/348489 Log: random(4): Fix RANDOM_LOADABLE build I introduced an obvious compiler error in r346282, so this change fixes that. Unfortunately, RANDOM_LOADABLE isn't covered b

svn commit: r348594 - head/share/man/man9

2019-06-03 Thread Conrad Meyer
Author: cem Date: Mon Jun 3 23:57:29 2019 New Revision: 348594 URL: https://svnweb.freebsd.org/changeset/base/348594 Log: style.9: Codify tolerance for eliding blank lines Consensus seems to be that eliding blank lines for functions with no local variables is acceptable. Codify that exp

svn commit: r348595 - head/sys/dev/virtio/random

2019-06-03 Thread Conrad Meyer
Author: cem Date: Tue Jun 4 00:01:37 2019 New Revision: 348595 URL: https://svnweb.freebsd.org/changeset/base/348595 Log: virtio_random(4): Fix random(4) integration random(4) masks unregistered entropy sources. Prior to this revision, virtio_random(4) did not correctly register a rando

svn commit: r348598 - in head/sys/dev/virtio: . mmio pci

2019-06-03 Thread Conrad Meyer
Author: cem Date: Tue Jun 4 02:34:59 2019 New Revision: 348598 URL: https://svnweb.freebsd.org/changeset/base/348598 Log: virtio(4): Expose PNP metadata through newbus Expose the same fields and widths from both vtio buses, even though they don't quite line up; several virtio drivers can

svn commit: r348599 - in head/sys/dev/virtio: . balloon block console network random scsi

2019-06-03 Thread Conrad Meyer
Author: cem Date: Tue Jun 4 02:37:11 2019 New Revision: 348599 URL: https://svnweb.freebsd.org/changeset/base/348599 Log: virtio(4): Add PNP match metadata for virtio devices Register MODULE_PNP_INFO for virtio devices using the newbus PNP information provided by the previous commit. Ma

svn commit: r348629 - head/usr.sbin/daemon

2019-06-04 Thread Conrad Meyer
Author: cem Date: Tue Jun 4 16:07:01 2019 New Revision: 348629 URL: https://svnweb.freebsd.org/changeset/base/348629 Log: daemon(8): Don't block SIGTERM during restart delay I believe this was introduced in the original '-r' commit, r231911 (2012). At the time, the scope was limited to a

Re: svn commit: r348611 - in head/sys: conf kern

2019-06-04 Thread Conrad Meyer
On Tue, Jun 4, 2019 at 7:15 AM Shawn Webb wrote: > > On Tue, Jun 04, 2019 at 01:07:10PM +, Ed Maste wrote: > > Author: emaste > > Date: Tue Jun 4 13:07:10 2019 > > New Revision: 348611 > > URL: https://svnweb.freebsd.org/changeset/base/348611 > > > > Log: > > Expose the kernel's build-ID th

Re: svn commit: r348419 - in head: crypto/heimdal/lib/ipc share/man/man4 sys/compat/linux sys/kern sys/sys usr.sbin/mountd

2019-06-04 Thread Conrad Meyer
On Tue, Jun 4, 2019 at 6:31 PM Bruce Evans wrote: > On Tue, 4 Jun 2019, Gleb Smirnoff wrote: > > Why don't use C99 in 2019 instead of preprocessor define? Should be > > > > union { > > void*_cr_unused1; /* compatibility with old ucred */ > > pid_t cr_pid;

svn commit: r348854 - head/libexec/rc/rc.d

2019-06-10 Thread Conrad Meyer
Author: cem Date: Mon Jun 10 13:34:18 2019 New Revision: 348854 URL: https://svnweb.freebsd.org/changeset/base/348854 Log: /etc/rc.d/local: Fix typo in description PR: 238448 Submitted by: Marián Černý Modified: head/libexec/rc/rc.d/local Modified: head/libexec/rc/rc.d/loca

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote: > On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin > wrote: > > ... > > URL: https://svnweb.freebsd.org/changeset/base/348847 > > Log: > > Use C11 anonymous unions. > > > > Modified: head/sys/sys/ucred.h > ... > > Isn't this a userland

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
Hi Warner, That doesn't seem responsive to the question. On Mon, Jun 10, 2019 at 6:49 AM Warner Losh wrote: > > > > On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: >> >> On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote: >> > On Mon, 10 Jun 2

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
On Mon, Jun 10, 2019 at 9:17 AM Bruce Evans wrote: > Only headers and libraries should support -std=c89. has > lots of support for compilers and POSIX versions going back to K&R C, > and only the K&R parts are completely broken. Is this due to specific policy, or just inertia? (No one has both

svn commit: r349137 - in head: etc/mtree sys/dev/random tests/sys tests/sys/devrandom

2019-06-17 Thread Conrad Meyer
added) +++ head/tests/sys/devrandom/uint128_test.c Mon Jun 17 14:59:45 2019 (r349137) @@ -0,0 +1,225 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * + * Copyright (c) 2019 Conrad Meyer + * All rights reserved. + * + * Redistribution and use in source and binary forms, with

svn commit: r349138 - in head: sys/dev/random tests/sys/devrandom

2019-06-17 Thread Conrad Meyer
Author: cem Date: Mon Jun 17 15:09:12 2019 New Revision: 349138 URL: https://svnweb.freebsd.org/changeset/base/349138 Log: random(4): Generalize algorithm-independent APIs At a basic level, remove assumptions about the underlying algorithm (such as output block size and reseeding requirem

Re: svn commit: r301339 - in head: contrib/libucl/src contrib/libucl/uthash lib/libucl

2016-06-04 Thread Conrad Meyer
On Sat, Jun 4, 2016 at 7:57 AM, Baptiste Daroussin wrote: > Author: bapt > Date: Sat Jun 4 14:57:25 2016 > New Revision: 301339 > URL: https://svnweb.freebsd.org/changeset/base/301339 > > Log: > Import libucl snapshot 20160604 > > It replaces xxhash with mumhash Why was xxhash replaced with

Re: svn commit: r301741 - head/sys/cam

2016-06-09 Thread Conrad Meyer
i386 as well (although we are replying to the wrong commit, I think r301771 is what broke it): In file included from /usr/src/sbin/camcontrol/camcontrol.c:56: /usr/obj/usr/src/tmp/usr/include/cam/cam_ccb.h:44:10: fatal error: 'cam/nvme/nvme_all.h' file not found #include ^ Best, Conrad

Re: svn commit: r301959 - head/sys/kern

2016-06-16 Thread Conrad Meyer
On Thu, Jun 16, 2016 at 4:58 AM, Konstantin Belousov wrote: > --- head/sys/kern/kern_thread.c Thu Jun 16 11:55:24 2016(r301958) > +++ head/sys/kern/kern_thread.c Thu Jun 16 11:58:46 2016(r301959) > @@ -669,11 +669,6 @@ weed_inhib(int mode, struct thread *td2, >

Re: svn commit: r302550 - head/sys/rpc

2016-07-11 Thread Conrad Meyer
On Sun, Jul 10, 2016 at 11:58 PM, Garrett Cooper wrote: > Author: ngie > Date: Mon Jul 11 06:58:24 2016 > New Revision: 302550 > URL: https://svnweb.freebsd.org/changeset/base/302550 > > Log: ... > MFC after: 1 week > Reported by: Coverity > CID: 1007033, 1007344 > Sponsored by: EMC / Isil

Re: svn commit: r303033 - head/share/man/man7

2016-07-19 Thread Conrad Meyer
On Tue, Jul 19, 2016 at 10:46 AM, Ed Maste wrote: > Author: emaste > Date: Tue Jul 19 17:46:09 2016 > New Revision: 303033 > URL: https://svnweb.freebsd.org/changeset/base/303033 > > Log: > add an arch.7 man page with architecture-specific details > > Based on details collected on the wiki, at

Re: svn commit: r303033 - head/share/man/man7

2016-07-19 Thread Conrad Meyer
On Tue, Jul 19, 2016 at 12:51 PM, Ed Maste wrote: > On 19 July 2016 at 15:37, Conrad Meyer wrote: >> >> ILP32 was only added on CURRENT during the 11 timeframe (the r276479 >> 3.5.0 import), and can't be relied upon for stable/10 or 9, FWIW. >> (Not useful for

Re: svn commit: r303043 - in head: share/man/man4 sys/dev/vt sys/dev/vt/hw/fb

2016-07-20 Thread Conrad Meyer
On Wed, Jul 20, 2016 at 12:44 AM, Kubilay Kocak wrote: > On 20/07/2016 5:20 AM, Conrad E. Meyer wrote: >> Author: cem >> Date: Tue Jul 19 19:20:47 2016 >> New Revision: 303043 >> URL: https://svnweb.freebsd.org/changeset/base/303043 >> >> Log: >> Increase vt(4) framebuffer maximum size >> >> A

  1   2   3   4   5   6   7   8   9   10   >