svn commit: r212901 - head/contrib/bzip2 releng/6.4 releng/6.4/contrib/bzip2 releng/6.4/sys/conf releng/7.1 releng/7.1/contrib/bzip2 releng/7.1/sys/conf releng/7.3 releng/7.3/contrib/bzip2 releng/7...

2010-09-20 Thread Colin Percival
Author: cperciva Date: Mon Sep 20 14:58:08 2010 New Revision: 212901 URL: http://svn.freebsd.org/changeset/base/212901 Log: Fix an integer overflow in RLE length parsing when decompressing corrupt bzip2 data. Approved by: so (cperciva) Security: FreeBSD-SA-10:08.bzip2 Modified:

svn commit: r212901 - head/contrib/bzip2 releng/6.4 releng/6.4/contrib/bzip2 releng/6.4/sys/conf releng/7.1 releng/7.1/contrib/bzip2 releng/7.1/sys/conf releng/7.3 releng/7.3/contrib/bzip2 releng/7...

2010-09-20 Thread Colin Percival
Author: cperciva Date: Mon Sep 20 14:58:08 2010 New Revision: 212901 URL: http://svn.freebsd.org/changeset/base/212901 Log: Fix an integer overflow in RLE length parsing when decompressing corrupt bzip2 data. Approved by: so (cperciva) Security: FreeBSD-SA-10:08.bzip2 Modified:

svn commit: r212901 - head/contrib/bzip2 releng/6.4 releng/6.4/contrib/bzip2 releng/6.4/sys/conf releng/7.1 releng/7.1/contrib/bzip2 releng/7.1/sys/conf releng/7.3 releng/7.3/contrib/bzip2 releng/7...

2010-09-20 Thread Colin Percival
Author: cperciva Date: Mon Sep 20 14:58:08 2010 New Revision: 212901 URL: http://svn.freebsd.org/changeset/base/212901 Log: Fix an integer overflow in RLE length parsing when decompressing corrupt bzip2 data. Approved by: so (cperciva) Security: FreeBSD-SA-10:08.bzip2 Modified:

svn commit: r212901 - head/contrib/bzip2 releng/6.4 releng/6.4/contrib/bzip2 releng/6.4/sys/conf releng/7.1 releng/7.1/contrib/bzip2 releng/7.1/sys/conf releng/7.3 releng/7.3/contrib/bzip2 releng/7...

2010-09-20 Thread Colin Percival
Author: cperciva Date: Mon Sep 20 14:58:08 2010 New Revision: 212901 URL: http://svn.freebsd.org/changeset/base/212901 Log: Fix an integer overflow in RLE length parsing when decompressing corrupt bzip2 data. Approved by: so (cperciva) Security: FreeBSD-SA-10:08.bzip2 Modified:

svn commit: r212901 - head/contrib/bzip2 releng/6.4 releng/6.4/contrib/bzip2 releng/6.4/sys/conf releng/7.1 releng/7.1/contrib/bzip2 releng/7.1/sys/conf releng/7.3 releng/7.3/contrib/bzip2 releng/7...

2010-09-20 Thread Colin Percival
Author: cperciva Date: Mon Sep 20 14:58:08 2010 New Revision: 212901 URL: http://svn.freebsd.org/changeset/base/212901 Log: Fix an integer overflow in RLE length parsing when decompressing corrupt bzip2 data. Approved by: so (cperciva) Security: FreeBSD-SA-10:08.bzip2 Modified:

svn commit: r213287 - head/games/fortune/datfiles

2010-09-29 Thread Colin Percival
Author: cperciva Date: Wed Sep 29 23:47:06 2010 New Revision: 213287 URL: http://svn.freebsd.org/changeset/base/213287 Log: Add advice to new fathers from Thomas Ptacek. Suggested by: wilko Approved by: Thomas Ptacek Security: New parents often feel very insecure. Modified: head

Re: svn commit: r214307 - in stable/7: . bin/sh contrib/wpa_supplicant gnu/usr.bin/groff/tmac share/misc tools/regression/bin/sh/expansion tools/tools/nanobsd usr.sbin usr.sbin/makefs usr.sbin/makefs/

2010-10-24 Thread Colin Percival
ant to choose the source and target for the merge carefully to minimize property changes on unrelated directories." ? This commit should not have been merged into stable/7. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com |

svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexec...

2011-12-23 Thread Colin Percival
Author: cperciva Date: Fri Dec 23 15:00:37 2011 New Revision: 228843 URL: http://svn.freebsd.org/changeset/base/228843 Log: Fix a problem whereby a corrupt DNS record can cause named to crash. [11:06] Add an API for alerting internal libc routines to the presence of "unsafe" paths post-ch

svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexec...

2011-12-23 Thread Colin Percival
Author: cperciva Date: Fri Dec 23 15:00:37 2011 New Revision: 228843 URL: http://svn.freebsd.org/changeset/base/228843 Log: Fix a problem whereby a corrupt DNS record can cause named to crash. [11:06] Add an API for alerting internal libc routines to the presence of "unsafe" paths post-ch

svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexec...

2011-12-23 Thread Colin Percival
Author: cperciva Date: Fri Dec 23 15:00:37 2011 New Revision: 228843 URL: http://svn.freebsd.org/changeset/base/228843 Log: Fix a problem whereby a corrupt DNS record can cause named to crash. [11:06] Add an API for alerting internal libc routines to the presence of "unsafe" paths post-ch

svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexec...

2011-12-23 Thread Colin Percival
Author: cperciva Date: Fri Dec 23 15:00:37 2011 New Revision: 228843 URL: http://svn.freebsd.org/changeset/base/228843 Log: Fix a problem whereby a corrupt DNS record can cause named to crash. [11:06] Add an API for alerting internal libc routines to the presence of "unsafe" paths post-ch

svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexec...

2011-12-23 Thread Colin Percival
Author: cperciva Date: Fri Dec 23 15:00:37 2011 New Revision: 228843 URL: http://svn.freebsd.org/changeset/base/228843 Log: Fix a problem whereby a corrupt DNS record can cause named to crash. [11:06] Add an API for alerting internal libc routines to the presence of "unsafe" paths post-ch

Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm

2011-12-30 Thread Colin Percival
de that gives us up to 2048 chunks. >> >> Should be "11 bits", no? > > I'm not a native speaker, but I think "11 bit wide" is correct here. I am a native speaker, and it's "11 bits wide". English is an odd language: An "11 bit wide

svn commit: r215103 - in releng/7.1: . sys/conf sys/fs/pseudofs

2010-11-10 Thread Colin Percival
Author: cperciva Date: Wed Nov 10 23:36:13 2010 New Revision: 215103 URL: http://svn.freebsd.org/changeset/base/215103 Log: Don't unlock a mutex which wasn't locked. PR: kern/137310 Approved by: so (cperciva) Security: FreeBSD-SA-10:09.pseudofs Modified: releng/7.1/UPD

svn commit: r215105 - head/contrib/binutils/bfd

2010-11-10 Thread Colin Percival
Author: cperciva Date: Thu Nov 11 00:29:19 2010 New Revision: 215105 URL: http://svn.freebsd.org/changeset/base/215105 Log: Zero the buffer containing the .gnu_debuglink section before writing into it. Prior to this commit the .gnu_debuglink section can have up to 3 bytes of uninitialized g

svn commit: r215470 - head/sys/i386/xen

2010-11-18 Thread Colin Percival
Author: cperciva Date: Thu Nov 18 21:02:40 2010 New Revision: 215470 URL: http://svn.freebsd.org/changeset/base/215470 Log: Don't KASSERT in pmap_release that xpmap_ptom(VM_PAGE_TO_PHYS(m)) == (pmap->pm_pdpt[i] & PG_FRAME) for i = NPGPTD, since pmap->pm_pdpt[i] is only initialized for 0

svn commit: r215472 - head/sys/i386/xen

2010-11-18 Thread Colin Percival
Author: cperciva Date: Thu Nov 18 21:29:43 2010 New Revision: 215472 URL: http://svn.freebsd.org/changeset/base/215472 Log: Make pmap_release match pmap_pinit by invoking pmap_qremove(pmap->pm_pdpt) to match pmap_pinit's pmap_qenter(pmap->pm_pdpt) call in the case of PAE. Modified: head/sys

svn commit: r215525 - head/sys/i386/xen

2010-11-19 Thread Colin Percival
Author: cperciva Date: Fri Nov 19 15:12:19 2010 New Revision: 215525 URL: http://svn.freebsd.org/changeset/base/215525 Log: Make pmap_release consistent with pmap_pinit with respect to unpinning pages. The pinning of NPGPTD pages is #if 0ed out in pmap_pinit (I'm not quite sure why...) and

svn commit: r215587 - in head/sys/i386: include xen

2010-11-20 Thread Colin Percival
Author: cperciva Date: Sat Nov 20 20:04:29 2010 New Revision: 215587 URL: http://svn.freebsd.org/changeset/base/215587 Log: Add VTOM(va) macro as xpmap_ptom(VTOP(va)) to convert to machine addresses. Clean up the code by converting xpmap_ptom(VTOP(...)) to VTOM(...) and converting xpmap_p

svn commit: r215593 - head/sys/i386/xen

2010-11-20 Thread Colin Percival
Author: cperciva Date: Sat Nov 20 21:36:12 2010 New Revision: 215593 URL: http://svn.freebsd.org/changeset/base/215593 Log: Unifdef XEN. This file is only compiled with the XEN kernel option set, and the !XEN bits get in the way of understanding the code. Modified: head/sys/i386/xen/pmap.c

svn commit: r215663 - head/sys/i386/xen

2010-11-22 Thread Colin Percival
Author: cperciva Date: Mon Nov 22 09:04:29 2010 New Revision: 215663 URL: http://svn.freebsd.org/changeset/base/215663 Log: In xen_get_timecount, return the full ns-precision time rather than rounding to 1/HZ precision. I have no idea why the rounding was introduced in the first place, bu

svn commit: r215665 - head/sys/kern

2010-11-22 Thread Colin Percival
Author: cperciva Date: Mon Nov 22 09:13:25 2010 New Revision: 215665 URL: http://svn.freebsd.org/changeset/base/215665 Log: In tc_windup, handle the case where the previous call to tc_windup was more than 1s earlier. Prior to this commit, the computation of th_scale * delta (which produces

svn commit: r215732 - head/sys/kern

2010-11-22 Thread Colin Percival
Author: cperciva Date: Tue Nov 23 04:50:01 2010 New Revision: 215732 URL: http://svn.freebsd.org/changeset/base/215732 Log: Add parentheses for clarity. The parentheses around the two terms of the && are unnecessary but I'm leaving them in for the sake of avoiding confusion (I confuse easil

svn commit: r215813 - head/sys/i386/xen

2010-11-24 Thread Colin Percival
Author: cperciva Date: Thu Nov 25 04:45:31 2010 New Revision: 215813 URL: http://svn.freebsd.org/changeset/base/215813 Log: Remove vestigal debugging code which, in fork-heavy workloads, can cause a 30x slowdown. Modified: head/sys/i386/xen/xen_machdep.c Modified: head/sys/i386/xen/xen_mac

svn commit: r215818 - in head/sys/i386: include/xen xen

2010-11-25 Thread Colin Percival
Author: cperciva Date: Thu Nov 25 15:05:21 2010 New Revision: 215818 URL: http://svn.freebsd.org/changeset/base/215818 Log: Rename HYPERVISOR_multicall (which performs the multicall hypercall) to _HYPERVISOR_multicall, and create a new HYPERVISOR_multicall function which invokes _HYPERVISOR_

svn commit: r215819 - head/sys/i386/xen

2010-11-25 Thread Colin Percival
Author: cperciva Date: Thu Nov 25 15:41:34 2010 New Revision: 215819 URL: http://svn.freebsd.org/changeset/base/215819 Log: Work around paging bug. Somehow we seem to be ending up with entries in the TLB which don't correspond to ptes with PG_V set; prior to this commit I'm sometimes gettin

svn commit: r215844 - head/sys/i386/xen

2010-11-25 Thread Colin Percival
Author: cperciva Date: Thu Nov 25 22:06:07 2010 New Revision: 215844 URL: http://svn.freebsd.org/changeset/base/215844 Log: Revert r215819 and fix the bug properly. In pmap_qremove, paging table updates were being queued by pmap_kremove, but the queue wasn't being flushed; as a result, the

svn commit: r216008 - stable/8/sys/i386/conf

2010-11-28 Thread Colin Percival
Author: cperciva Date: Sun Nov 28 16:25:16 2010 New Revision: 216008 URL: http://svn.freebsd.org/changeset/base/216008 Log: MFC r204157: Remove atkbd and friends, since they cause the XEN kernel to panic. PR: kern/148262, kern/149853 Modified: stable/8/sys/i386/conf/XEN Direc

svn commit: r216015 - stable/8/sys/kern

2010-11-28 Thread Colin Percival
Author: cperciva Date: Sun Nov 28 18:59:52 2010 New Revision: 216015 URL: http://svn.freebsd.org/changeset/base/216015 Log: MFC r215665,r215732: Don't lose seconds to integer overflow if we go more than one second between calls to tc_windup. Modified: stable/8/sys/kern/kern_tc.c Directory P

svn commit: r216041 - head/sys/i386/i386

2010-11-28 Thread Colin Percival
Author: cperciva Date: Mon Nov 29 06:50:30 2010 New Revision: 216041 URL: http://svn.freebsd.org/changeset/base/216041 Log: Fix bug introduced by r194784: Under XEN, the page(s) allocated to dpcpu for CPU #0 weren't being properly reserved. Under VM pressure this would cause problems when t

svn commit: r216077 - head/usr.sbin/crashinfo

2010-11-30 Thread Colin Percival
Author: cperciva Date: Tue Nov 30 16:04:40 2010 New Revision: 216077 URL: http://svn.freebsd.org/changeset/base/216077 Log: Teach crashinfo(8) to look at the currently running kernel (based on the kern.bootfile sysctl). Prior to this commit, crashinfo(8) only looks at /boot/*/kernel; this i

svn commit: r216152 - stable/8/usr.sbin/crashinfo

2010-12-03 Thread Colin Percival
Author: cperciva Date: Fri Dec 3 16:21:12 2010 New Revision: 216152 URL: http://svn.freebsd.org/changeset/base/216152 Log: MFC r216077: Teach crashinfo(8) about the kern.bootfile sysctl. Approved by: re (bz) Modified: stable/8/usr.sbin/crashinfo/crashinfo.sh Directory Properties: sta

svn commit: r216153 - stable/7/usr.sbin/crashinfo

2010-12-03 Thread Colin Percival
Author: cperciva Date: Fri Dec 3 16:21:39 2010 New Revision: 216153 URL: http://svn.freebsd.org/changeset/base/216153 Log: MFC r216077: Teach crashinfo(8) about the kern.bootfile sysctl. Approved by: re (bz) Modified: stable/7/usr.sbin/crashinfo/crashinfo.sh Directory Properties: sta

svn commit: r216164 - stable/8/contrib/binutils/bfd

2010-12-03 Thread Colin Percival
Author: cperciva Date: Fri Dec 3 22:47:53 2010 New Revision: 216164 URL: http://svn.freebsd.org/changeset/base/216164 Log: MFC r215105: Uninitialized buffers considered harmful. Approved by: re (bz) Modified: stable/8/contrib/binutils/bfd/opncls.c Directory Properties: stable/8/contr

svn commit: r216165 - stable/7/contrib/binutils/bfd

2010-12-03 Thread Colin Percival
Author: cperciva Date: Fri Dec 3 22:48:15 2010 New Revision: 216165 URL: http://svn.freebsd.org/changeset/base/216165 Log: MFC r215105: Uninitialized buffers considered harmful. Approved by: re (bz) Modified: stable/7/contrib/binutils/bfd/opncls.c Directory Properties: stable/7/contr

svn commit: r216190 - head/sys/i386/i386

2010-12-04 Thread Colin Percival
Author: cperciva Date: Sat Dec 4 23:24:35 2010 New Revision: 216190 URL: http://svn.freebsd.org/changeset/base/216190 Log: Remove unnecessary #includes which seem to have been accidentally added as part of CVS r1.76 (in January 2006). Modified: head/sys/i386/i386/busdma_machdep.c Modified

svn commit: r216191 - head/sys/i386/i386

2010-12-04 Thread Colin Percival
Author: cperciva Date: Sat Dec 4 23:36:40 2010 New Revision: 216191 URL: http://svn.freebsd.org/changeset/base/216191 Log: Remove gratuitous i386/amd64 inconsistency in favour of the less verbose version of declaring a variable initialized to zero. Modified: head/sys/i386/i386/busdma_machd

svn commit: r216194 - head/sys/i386/i386

2010-12-04 Thread Colin Percival
Author: cperciva Date: Sun Dec 5 03:20:55 2010 New Revision: 216194 URL: http://svn.freebsd.org/changeset/base/216194 Log: MFamd64 r204214: Enforce stronger alignment semantics (require that the end of segments be aligned, not just the start of segments) in order to allow Xen's blkfront dri

svn commit: r216241 - head/sys/dev/xen/blkfront

2010-12-06 Thread Colin Percival
Author: cperciva Date: Mon Dec 6 20:40:15 2010 New Revision: 216241 URL: http://svn.freebsd.org/changeset/base/216241 Log: Set correct maximum I/O length. We can only handle I/O of up to max_request_segments * PAGE_SIZE if the I/O is page-aligned; the largest I/O we can guarantee will work

svn commit: r216280 - head/sys/xen/evtchn

2010-12-07 Thread Colin Percival
Author: cperciva Date: Tue Dec 7 23:33:20 2010 New Revision: 216280 URL: http://svn.freebsd.org/changeset/base/216280 Log: Postpone the unmasking of event channels (aka. interrupts) until after the interrupt handlers have been registered. NULL isn't a very good interrupt handler. Modified

Re: svn commit: r216280 - head/sys/xen/evtchn

2010-12-07 Thread Colin Percival
On 12/07/10 15:33, Colin Percival wrote: > Log: > Postpone the unmasking of event channels (aka. interrupts) until after > the interrupt handlers have been registered. NULL isn't a very good > interrupt handler. Forgot to add: While here, make bind_ipi_to_irq static, si

svn commit: r216304 - head/sys/amd64/amd64

2010-12-08 Thread Colin Percival
Author: cperciva Date: Wed Dec 8 19:42:21 2010 New Revision: 216304 URL: http://svn.freebsd.org/changeset/base/216304 Log: MFi386 r1.81, r1.82, r1.84: Reorganize code to reduce cache pressure and branch mispredictions. No objections from: scottl Modified: head/sys/amd64/amd64/busdma

svn commit: r216305 - stable/8/sys/i386/i386

2010-12-08 Thread Colin Percival
Author: cperciva Date: Wed Dec 8 19:48:29 2010 New Revision: 216305 URL: http://svn.freebsd.org/changeset/base/216305 Log: MFC r216194 / MFamd64 r206610: Enforce stronger alignment semantics in order to unbreak the Xen blkfront driver. Approved by: re (kib) Modified: stable/8/sys/i38

svn commit: r216306 - head/sys/amd64/amd64

2010-12-08 Thread Colin Percival
Author: cperciva Date: Wed Dec 8 19:52:04 2010 New Revision: 216306 URL: http://svn.freebsd.org/changeset/base/216306 Log: MFi386 r1.94: If XEN, make pmap_kextract = pmap_kextract_ma. This is a no-op currently, since FreeBSD/amd64 doesn't have (paravirtualized) Xen support, but if/when tha

svn commit: r216308 - in head/sys: amd64/amd64 i386/i386

2010-12-08 Thread Colin Percival
Author: cperciva Date: Wed Dec 8 20:20:10 2010 New Revision: 216308 URL: http://svn.freebsd.org/changeset/base/216308 Log: On amd64, we have (since r1.72, in December 2005) MAX_BPAGES=8192, while on i386 we have MAX_BPAGES=512. Implement this difference via '#ifdef __i386__'. With thi

svn commit: r216316 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-12-08 Thread Colin Percival
Author: cperciva Date: Thu Dec 9 06:41:50 2010 New Revision: 216316 URL: http://svn.freebsd.org/changeset/base/216316 Log: Replace i386/i386/busdma_machdep.c and amd64/amd64/busdma_machdep.c (which are identical) with a single x86/x86/busdma_machdep.c. Added: head/sys/x86/x86/busdma_machde

svn commit: r216382 - head/sys/i386/xen

2010-12-11 Thread Colin Percival
Author: cperciva Date: Sat Dec 11 20:12:42 2010 New Revision: 216382 URL: http://svn.freebsd.org/changeset/base/216382 Log: Make the machdep.independent_wallclock sysctl do what it says on the box. Modified: head/sys/i386/xen/clock.c Modified: head/sys/i386/xen/clock.c ==

svn commit: r216385 - head/sys/i386/xen

2010-12-11 Thread Colin Percival
Author: cperciva Date: Sat Dec 11 22:33:33 2010 New Revision: 216385 URL: http://svn.freebsd.org/changeset/base/216385 Log: Reduce the Xen timecounter from 1GHz to 2^-9 GHz, thereby increasing the timecounter period from 2^32 ns (~4.3s) to 2^41 ns (~36m39s). Some time sharing systems can sk

svn commit: r196558 - head/usr.bin/look

2009-08-25 Thread Colin Percival
Author: cperciva Date: Wed Aug 26 03:30:06 2009 New Revision: 196558 URL: http://svn.freebsd.org/changeset/base/196558 Log: Don't try to mmap the contents of empty files. This behaviour was harmless prior to r195693, since historical behaviour of mmap(2) was to silently ignore length-zero m

svn commit: r196695 - stable/8/usr.bin/look

2009-08-31 Thread Colin Percival
Author: cperciva Date: Mon Aug 31 13:02:21 2009 New Revision: 196695 URL: http://svn.freebsd.org/changeset/base/196695 Log: MFC r196558: Don't try to mmap the contents of empty files. This behaviour was harmless prior to r195693, when mmap(2) changed from silently ignoring requests for mapp

svn commit: r197552 - in head/etc/periodic: daily security

2009-09-27 Thread Colin Percival
Author: cperciva Date: Mon Sep 28 03:32:35 2009 New Revision: 197552 URL: http://svn.freebsd.org/changeset/base/197552 Log: Silence warning printed by getfsspec(3) when /etc/fstab does not exist fstab: /etc/fstab:0: No such file or directory and from dump(8) when setfsent(3) fails due to /

svn commit: r197618 - head/usr.sbin/freebsd-update

2009-09-29 Thread Colin Percival
Author: cperciva Date: Tue Sep 29 16:26:09 2009 New Revision: 197618 URL: http://svn.freebsd.org/changeset/base/197618 Log: Special-case "-r X" where X is [0-9.]+ to mean "-r X-RELEASE". Tripped over by: too many people to count MFC after:1 month Modified: head/usr.sbin/freebs

svn commit: r198477 - head/usr.sbin/sysinstall

2009-10-25 Thread Colin Percival
Author: cperciva Date: Mon Oct 26 06:51:20 2009 New Revision: 198477 URL: http://svn.freebsd.org/changeset/base/198477 Log: Eject CDROM after installation if used as source media. Submitted by: randi MFC after:1 month Modified: head/usr.sbin/sysinstall/cdrom.c Modified: head/usr.s

svn commit: r198503 - head/usr.sbin/sysinstall

2009-10-26 Thread Colin Percival
Author: cperciva Date: Mon Oct 26 23:24:59 2009 New Revision: 198503 URL: http://svn.freebsd.org/changeset/base/198503 Log: Don't leak a file descriptor when ejecting a CDROM. Submitted by: Ronald Klop, trhodes Note to self: don't do commits while half-asleep Modified: head/usr.sbin/sy

Re: svn commit: r198477 - head/usr.sbin/sysinstall

2009-10-26 Thread Colin Percival
Ronald Klop wrote: > I'm no committer, but isn't it nice to close the fd? Indeed -- I need to be more awake when I do commits in the future. :-) I've fixed this now; thanks for pointing it out. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serv

svn commit: r198671 - in head/usr.bin/bsdiff: bsdiff bspatch

2009-10-30 Thread Colin Percival
newfile +and compare against them before and after applying +.Ar patchfile . .Sh AUTHORS .An Colin Percival Aq cperc...@freebsd.org Modified: head/usr.bin/bsdiff/bspatch/bspatch.1 == --- head/usr.bin/bsdiff/bspatch/bspatch

svn commit: r198781 - head/lib/libc/sys

2009-11-01 Thread Colin Percival
Author: cperciva Date: Mon Nov 2 07:21:13 2009 New Revision: 198781 URL: http://svn.freebsd.org/changeset/base/198781 Log: Attempt to reduce accidental foot-shooting by pointing out that accept(2)ed sockets do not necessarily inherit O_NONBLOCK from listening sockets on non-FreeBSD platform

Re: svn commit: r198781 - head/lib/libc/sys

2009-11-02 Thread Colin Percival
Robert Watson wrote: > On Mon, 2 Nov 2009, Colin Percival wrote: >> Attempt to reduce accidental foot-shooting by pointing out that >> accept(2)ed sockets do not necessarily inherit O_NONBLOCK from >> listening sockets on non-FreeBSD platforms. > > I wonder how much

Re: svn commit: r225827 - head/sys/kern head/usr.bin/compress head/usr.bin/gzip releng/7.3 releng/7.3/sys/conf releng/7.3/sys/kern releng/7.3/usr.bin/compress releng/7.3/usr.bin/gzip releng/7.4 releng

2011-09-30 Thread Colin Percival
ill be coming soon. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/li

svn commit: r226023 - head/sys/compat/linux releng/7.3 releng/7.3/sys/compat/linux releng/7.3/sys/conf releng/7.4 releng/7.4/sys/compat/linux releng/7.4/sys/conf releng/8.1 releng/8.1/sys/compat/li...

2011-10-04 Thread Colin Percival
Author: cperciva Date: Tue Oct 4 19:07:38 2011 New Revision: 226023 URL: http://svn.freebsd.org/changeset/base/226023 Log: Fix a bug in UNIX socket handling in the linux emulator which was exposed by the security fix in FreeBSD-SA-11:05.unix. Approved by: so (cperciva) Approved by: r

svn commit: r226023 - head/sys/compat/linux releng/7.3 releng/7.3/sys/compat/linux releng/7.3/sys/conf releng/7.4 releng/7.4/sys/compat/linux releng/7.4/sys/conf releng/8.1 releng/8.1/sys/compat/li...

2011-10-04 Thread Colin Percival
Author: cperciva Date: Tue Oct 4 19:07:38 2011 New Revision: 226023 URL: http://svn.freebsd.org/changeset/base/226023 Log: Fix a bug in UNIX socket handling in the linux emulator which was exposed by the security fix in FreeBSD-SA-11:05.unix. Approved by: so (cperciva) Approved by: r

svn commit: r226023 - head/sys/compat/linux releng/7.3 releng/7.3/sys/compat/linux releng/7.3/sys/conf releng/7.4 releng/7.4/sys/compat/linux releng/7.4/sys/conf releng/8.1 releng/8.1/sys/compat/li...

2011-10-04 Thread Colin Percival
Author: cperciva Date: Tue Oct 4 19:07:38 2011 New Revision: 226023 URL: http://svn.freebsd.org/changeset/base/226023 Log: Fix a bug in UNIX socket handling in the linux emulator which was exposed by the security fix in FreeBSD-SA-11:05.unix. Approved by: so (cperciva) Approved by: r

svn commit: r226023 - head/sys/compat/linux releng/7.3 releng/7.3/sys/compat/linux releng/7.3/sys/conf releng/7.4 releng/7.4/sys/compat/linux releng/7.4/sys/conf releng/8.1 releng/8.1/sys/compat/li...

2011-10-04 Thread Colin Percival
Author: cperciva Date: Tue Oct 4 19:07:38 2011 New Revision: 226023 URL: http://svn.freebsd.org/changeset/base/226023 Log: Fix a bug in UNIX socket handling in the linux emulator which was exposed by the security fix in FreeBSD-SA-11:05.unix. Approved by: so (cperciva) Approved by: r

svn commit: r226023 - head/sys/compat/linux releng/7.3 releng/7.3/sys/compat/linux releng/7.3/sys/conf releng/7.4 releng/7.4/sys/compat/linux releng/7.4/sys/conf releng/8.1 releng/8.1/sys/compat/li...

2011-10-04 Thread Colin Percival
Author: cperciva Date: Tue Oct 4 19:07:38 2011 New Revision: 226023 URL: http://svn.freebsd.org/changeset/base/226023 Log: Fix a bug in UNIX socket handling in the linux emulator which was exposed by the security fix in FreeBSD-SA-11:05.unix. Approved by: so (cperciva) Approved by: r

svn commit: r226277 - head/etc

2011-10-11 Thread Colin Percival
Author: cperciva Date: Wed Oct 12 03:29:12 2011 New Revision: 226277 URL: http://svn.freebsd.org/changeset/base/226277 Log: Now that the portsnap buildbox is generating the raw bits for INDEX-9, add it to the set of INDEX files built by portsnap. Modified: head/etc/portsnap.conf Modified:

svn commit: r226322 - stable/9/etc

2011-10-12 Thread Colin Percival
Author: cperciva Date: Wed Oct 12 20:38:07 2011 New Revision: 226322 URL: http://svn.freebsd.org/changeset/base/226322 Log: MFC r226277: Add INDEX-9 to the set of INDEX files built by portsnap. Approved by: re (kib) Modified: stable/9/etc/portsnap.conf Directory Properties: stable/9/e

Re: svn commit: r226359 - head/usr.bin/look

2011-10-16 Thread Colin Percival
(1) build, but on a 64-bit machine it also makes look(1) fail with "File too large" whenever it's larger than (int64_t)(UINT64_MAX) = -1 bytes long. Please fix. :-) -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | ta

Re: svn commit: r226359 - head/usr.bin/look

2011-10-16 Thread Colin Percival
if ((uintmax_t)sb.st_size > (uintmax_t)SIZE_T_MAX) That should work. I've also solved this problem in the past with if ((sizeof(off_t) > sizeof(size_t)) && (sb.st_size > (off_t) -- Colin Percival Security Officer, FreeBSD | freebsd.org | T

svn commit: r226650 - head/usr.sbin/freebsd-update

2011-10-22 Thread Colin Percival
Author: cperciva Date: Sun Oct 23 06:23:11 2011 New Revision: 226650 URL: http://svn.freebsd.org/changeset/base/226650 Log: Add '%' and '@' to the set of characters which can appear in path names. Without this change, freebsd-update refuses to accept 9.0 metadata files. Modified: head/usr.s

svn commit: r226811 - stable/9/usr.sbin/freebsd-update

2011-10-26 Thread Colin Percival
Author: cperciva Date: Wed Oct 26 20:01:43 2011 New Revision: 226811 URL: http://svn.freebsd.org/changeset/base/226811 Log: MFC r226650: Make freebsd-update work with FreeBSD 9.0. Approved by: re (kib) Modified: stable/9/usr.sbin/freebsd-update/freebsd-update.sh Directory Properties:

svn commit: r226812 - stable/8/usr.sbin/freebsd-update

2011-10-26 Thread Colin Percival
Author: cperciva Date: Wed Oct 26 20:06:27 2011 New Revision: 226812 URL: http://svn.freebsd.org/changeset/base/226812 Log: MFC r226650: Make freebsd-update work with FreeBSD 9.0. (In particular, this will simplify upgrading from 8.3-RELEASE to 9.x.) Modified: stable/8/usr.sbin/freebsd-upd

svn commit: r226813 - stable/7/usr.sbin/freebsd-update

2011-10-26 Thread Colin Percival
Author: cperciva Date: Wed Oct 26 20:07:58 2011 New Revision: 226813 URL: http://svn.freebsd.org/changeset/base/226813 Log: MFC r226650: Make freebsd-update work with FreeBSD 9.0. (In the unlikely event that a 7.5-RELEASE happens, this should simplify upgrading from that to 9.x.) Modified:

svn commit: r216602 - in stable/8/sys: dev/xen/blkfront i386/i386 i386/xen xen/evtchn

2010-12-20 Thread Colin Percival
Author: cperciva Date: Mon Dec 20 20:39:49 2010 New Revision: 216602 URL: http://svn.freebsd.org/changeset/base/216602 Log: MFC Xen-related commits r215470, r215472, r215525, r215663, r215813, r215819, r215844, r216041, r216241, r216280, r216382, and r216385. * Make blkfront not advertise

svn commit: r216703 - head/sys/i386/xen

2010-12-26 Thread Colin Percival
Author: cperciva Date: Sun Dec 26 13:05:43 2010 New Revision: 216703 URL: http://svn.freebsd.org/changeset/base/216703 Log: Lock the vm page queue mutex in pmap_pte_release around the call to PMAP_SET_VA; this fixes a mutex-not-held panic when a process which called mlock(2) exits, and paral

svn commit: r216746 - head/sys/conf

2010-12-27 Thread Colin Percival
Author: cperciva Date: Mon Dec 27 23:52:40 2010 New Revision: 216746 URL: http://svn.freebsd.org/changeset/base/216746 Log: Make it possible to specify WITHOUT_MODULES in a kernel config file. MFC after:1 week Modified: head/sys/conf/kern.pre.mk Modified: head/sys/conf/kern.pre.mk =

svn commit: r216748 - head/sys/i386/conf

2010-12-27 Thread Colin Percival
Author: cperciva Date: Mon Dec 27 23:59:27 2010 New Revision: 216748 URL: http://svn.freebsd.org/changeset/base/216748 Log: Build the modules which can be built. The excluded modules fall into two categories: Those which can't build with PAE because they attempt to cast a pointer to a bus_a

Re: svn commit: r216746 - head/sys/conf

2010-12-27 Thread Colin Percival
On 12/27/10 17:59, Steve Kargl wrote: > On Mon, Dec 27, 2010 at 11:52:40PM +0000, Colin Percival wrote: >> Make it possible to specify WITHOUT_MODULES in a kernel config file. > > Can you explain how this differs from > makeoptions NO_MODULES > which has been able to do f

svn commit: r216762 - head/sys/i386/xen

2010-12-28 Thread Colin Percival
Author: cperciva Date: Tue Dec 28 14:36:32 2010 New Revision: 216762 URL: http://svn.freebsd.org/changeset/base/216762 Log: Remove a "not strictly correct" (and panic-inducing) workaround for a bug which doesn't seem to exist. PR: kern/141328 MFC after:3 days Modified:

svn commit: r216790 - head/sys/dev/xen/console

2010-12-28 Thread Colin Percival
Author: cperciva Date: Wed Dec 29 05:13:21 2010 New Revision: 216790 URL: http://svn.freebsd.org/changeset/base/216790 Log: A lack of console input is not the same thing as a byte of \0 input. Correctly return -1 from cngetc when no input is available to be read. This fixes the '(CTRL-C t

Re: svn commit: r216746 - head/sys/conf

2010-12-29 Thread Colin Percival
unds like a great idea. Feel free to hop in a time machine and go back 6 years to encourage Wes to use a different name when he added the option. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups

svn commit: r216811 - head/etc

2010-12-29 Thread Colin Percival
Author: cperciva Date: Thu Dec 30 01:13:42 2010 New Revision: 216811 URL: http://svn.freebsd.org/changeset/base/216811 Log: Remove INDEX-6 from the default portsnap configuration file; the 6.x index bits haven't been built since December 1st, although the mirrors are still distributing the b

svn commit: r216812 - head/sys/xen/evtchn

2010-12-29 Thread Colin Percival
Author: cperciva Date: Thu Dec 30 01:28:56 2010 New Revision: 216812 URL: http://svn.freebsd.org/changeset/base/216812 Log: Add xenpic_dynirq_disable_intr and set it as the .pic_disable_intr method for xenpic_dynirq_template. This fixes a panic when a virtual disk is removed, since that res

svn commit: r216843 - head/sys/i386/xen

2010-12-31 Thread Colin Percival
Author: cperciva Date: Fri Dec 31 17:39:31 2010 New Revision: 216843 URL: http://svn.freebsd.org/changeset/base/216843 Log: Make i386_set_ldt work on i386/XEN, step 1/5. Lock the vm page queue mutex around calls to pte_store. As with many other uses of the vm page queue mutex in i386/xen

svn commit: r216844 - head/sys/i386/include

2010-12-31 Thread Colin Percival
Author: cperciva Date: Fri Dec 31 17:39:58 2010 New Revision: 216844 URL: http://svn.freebsd.org/changeset/base/216844 Log: Make i386_set_ldt work on i386/XEN, step 2/5. Don't map physical to machine page numbers in pte_load_store, since it uses PT_SET_VA (which takes a physical page numb

svn commit: r216845 - head/sys/i386/i386

2010-12-31 Thread Colin Percival
Author: cperciva Date: Fri Dec 31 17:40:30 2010 New Revision: 216845 URL: http://svn.freebsd.org/changeset/base/216845 Log: Make i386_set_ldt work on i386/XEN, step 3/5. Synchronize reality with comment: The user_ldt_alloc function is supposed to return with dt_lock held. Due to broken l

svn commit: r216846 - head/sys/i386/i386

2010-12-31 Thread Colin Percival
Author: cperciva Date: Fri Dec 31 17:41:14 2010 New Revision: 216846 URL: http://svn.freebsd.org/changeset/base/216846 Log: Make i386_set_ldt work on i386/XEN, step 4/5. Use xen_update_descriptor to update the LDT rather than bcopy. Under Xen, pages used for holding LDTs must be read-onl

svn commit: r216847 - in head/sys/i386: i386 include

2010-12-31 Thread Colin Percival
Author: cperciva Date: Fri Dec 31 17:42:25 2010 New Revision: 216847 URL: http://svn.freebsd.org/changeset/base/216847 Log: Make i386_set_ldt work on i386/XEN, step 5/5. When cleaning up a thread, reset its LDT to the default LDT. Note: Casting the LDT pointer to an int and storing it

svn commit: r216944 - head/sys/i386/xen

2011-01-03 Thread Colin Percival
Author: cperciva Date: Tue Jan 4 00:16:38 2011 New Revision: 216944 URL: http://svn.freebsd.org/changeset/base/216944 Log: Adjust the critical section protecting _xen_flush_queue to cover the entire range where the page mapping request queue needs to be atomically examined and modified.

svn commit: r216960 - head/sys/i386/xen

2011-01-04 Thread Colin Percival
Author: cperciva Date: Tue Jan 4 15:55:15 2011 New Revision: 216960 URL: http://svn.freebsd.org/changeset/base/216960 Log: Add hamfisted locking to the Xen/PV pmap code: Only allow one thread to be in {pmap_pinit, pmap_copy, pmap_release} at a time. This reduces the rate of panics when r

Re: svn commit: r216944 - head/sys/i386/xen

2011-01-04 Thread Colin Percival
On 01/04/11 05:00, John Baldwin wrote: > On Monday, January 03, 2011 7:16:38 pm Colin Percival wrote: >> +#ifdef INVARIANTS >> if (__predict_true(gdtset)) >> -critical_enter(); >> +KASSERT(curthread->td_critnest > 0, >> +

svn commit: r216963 - head/sys/i386/xen

2011-01-04 Thread Colin Percival
Author: cperciva Date: Tue Jan 4 16:29:07 2011 New Revision: 216963 URL: http://svn.freebsd.org/changeset/base/216963 Log: Spell CRITICAL_ASSERT correctly. Submitted by: jhb MFC with: r216944 Modified: head/sys/i386/xen/xen_machdep.c Modified: head/sys/i386/xen/xen_machdep.c

svn commit: r217050 - in stable/8/sys/i386: i386 xen

2011-01-06 Thread Colin Percival
Author: cperciva Date: Thu Jan 6 12:34:18 2011 New Revision: 217050 URL: http://svn.freebsd.org/changeset/base/217050 Log: MFC r200288, r200346, r200352: Make minidump work on i386/XEN. Note that r200288 and r200346 touched i386/i386/dump_machdep.c, but in that file r200346 was a back-o

Re: svn commit: r217048 - head/share/man/man9

2011-01-06 Thread Colin Percival
return rather than breaking. I'd prefer to see the remark stay in style(9) with an added "in cases where this isn't immediately obvious from the surrounding code" clause. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve F

svn commit: r217051 - stable/8/sys/i386/xen

2011-01-06 Thread Colin Percival
Author: cperciva Date: Thu Jan 6 13:02:29 2011 New Revision: 217051 URL: http://svn.freebsd.org/changeset/base/217051 Log: MFC r216703: Make i386/XEN not panic when mlock(2) is used. Modified: stable/8/sys/i386/xen/pmap.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys

svn commit: r217052 - stable/8/sys/i386/xen

2011-01-06 Thread Colin Percival
Author: cperciva Date: Thu Jan 6 13:09:02 2011 New Revision: 217052 URL: http://svn.freebsd.org/changeset/base/217052 Log: MFC r216762: Don't panic when exiting gstat or 'mdconfig -l' Modified: stable/8/sys/i386/xen/pmap.c Directory Properties: stable/8/sys/ (props changed) stable/8/sy

svn commit: r217053 - stable/8/sys/dev/xen/console

2011-01-06 Thread Colin Percival
Author: cperciva Date: Thu Jan 6 13:21:38 2011 New Revision: 217053 URL: http://svn.freebsd.org/changeset/base/217053 Log: MFC r216790: Fix Xen console spew: "no input to read" != an infinite supply of \0 bytes. Modified: stable/8/sys/dev/xen/console/console.c Directory Properties: stabl

svn commit: r217055 - stable/8/sys/xen/evtchn

2011-01-06 Thread Colin Percival
Author: cperciva Date: Thu Jan 6 14:19:29 2011 New Revision: 217055 URL: http://svn.freebsd.org/changeset/base/217055 Log: MFC r216812: Implement xenpic_dynirq_disable_intr and thereby avoid a kernel panic when a disk is detached from a XEN system. Modified: stable/8/sys/xen/evtchn/evtchn.

svn commit: r217056 - in stable/8/sys/i386: i386 include xen

2011-01-06 Thread Colin Percival
Author: cperciva Date: Thu Jan 6 15:26:06 2011 New Revision: 217056 URL: http://svn.freebsd.org/changeset/base/217056 Log: MFC r216843-216847: Fix i386_set_ldt on i386/XEN. Modified: stable/8/sys/i386/i386/sys_machdep.c stable/8/sys/i386/include/pmap.h stable/8/sys/i386/include/segments.

svn commit: r217080 - releng/8.2/sys/i386/xen

2011-01-06 Thread Colin Percival
Author: cperciva Date: Thu Jan 6 22:52:52 2011 New Revision: 217080 URL: http://svn.freebsd.org/changeset/base/217080 Log: MFS r217051: Fix panic when mlock(2) is used on i386/XEN. PR: kern/140313 Approved by: re (rwatson) Modified: releng/8.2/sys/i386/xen/pmap.c Directory

svn commit: r217081 - releng/8.2/sys/i386/xen

2011-01-06 Thread Colin Percival
Author: cperciva Date: Thu Jan 6 22:53:55 2011 New Revision: 217081 URL: http://svn.freebsd.org/changeset/base/217081 Log: MFS r217052: Fix a panic when gstat exits or when 'mdconfig -l' is run, on i386/XEN. PR: kern/141328 Approved by: re (rwatson) Modified: releng/8.2/s

  1   2   3   4   5   6   >