Re: svn commit: r268491 - head/usr.bin/users

2014-07-12 Thread David Chisnall
On 11 Jul 2014, at 22:26, John Baldwin wrote: >> For things that live in the base system, there's not much danger of boost >> conflicts. 'using namespace std' is mostly a problem when it's in headers >> (especially > library headers), because it can break large amounts of code. In a tiny >

svn commit: r268565 - head/share/mk

2014-07-12 Thread Rui Paulo
Author: rpaulo Date: Sat Jul 12 07:46:18 2014 New Revision: 268565 URL: http://svnweb.freebsd.org/changeset/base/268565 Log: Remove bsd.dtrace.mk. MFC after:3 weeks Modified: head/share/mk/Makefile Modified: head/share/mk/Makefile

svn commit: r268566 - head/usr.bin/users

2014-07-12 Thread David Chisnall
Author: theraven Date: Sat Jul 12 07:47:50 2014 New Revision: 268566 URL: http://svnweb.freebsd.org/changeset/base/268566 Log: Turn off exceptions and rtti when building the c++ version of users. Neither is used in the program and this saves us 10KB (around 40%) in binary size. Modified:

Re: svn commit: r268491 - head/usr.bin/users

2014-07-12 Thread David Chisnall
On 10 Jul 2014, at 16:29, Ed Schouten wrote: > With the patch above, the binary shrinks to 15640 bytes, so my > concerns are somewhat addressed. :-) I wasn't seeing that saving, but I've now committed a tweak to the Makefile that turns off exceptions and RTTI. This shrinks the binary to 15569

svn commit: r268567 - head/sbin/ifconfig

2014-07-12 Thread Jeremie Le Hen
Author: jlh Date: Sat Jul 12 10:18:33 2014 New Revision: 268567 URL: http://svnweb.freebsd.org/changeset/base/268567 Log: Make the description of the "no_prefer_iface" flag easier to understand. Reviewed by: Silence on -net@ and from ume@ Modified: head/sbin/ifconfig/ifconfig.8 Modifie

svn commit: r268568 - in head/bin/sh: . tests/parameters

2014-07-12 Thread Jilles Tjoelker
Author: jilles Date: Sat Jul 12 10:27:30 2014 New Revision: 268568 URL: http://svnweb.freebsd.org/changeset/base/268568 Log: sh: Consistently treat ${01} like $1. Leading zeroes were ignored when checking whether a positional parameter is set, but not when expanding its value. Ignore lead

Re: svn commit: r268566 - head/usr.bin/users

2014-07-12 Thread Bruce Evans
On Sat, 12 Jul 2014, David Chisnall wrote: Log: Turn off exceptions and rtti when building the c++ version of users. Neither is used in the program and this saves us 10KB (around 40%) in binary size. This joke is bad. The C++ version is worse in every way. Source code: It becomes smaller

Re: svn commit: r268566 - head/usr.bin/users

2014-07-12 Thread Bruce Simpson
On 12/07/2014 12:34, Bruce Evans wrote: This joke is bad. The C++ version is worse in every way. I concur with everything you have said in your message. Moral of story: it is very, very easy to introduce bloat using C++, and using a higher level language does not automatically lead to bette

Re: svn commit: r268543 - in head/sys: dev/drm2 dev/drm2/i915 dev/drm2/radeon dev/etherswitch/arswitch dev/etherswitch/rtl8366 dev/iicbus sys

2014-07-12 Thread Ian Lepore
On Fri, 2014-07-11 at 18:48 -0700, Rui Paulo wrote: > On Jul 11, 2014, at 18:42, Ian Lepore wrote: > > > On Sat, 2014-07-12 at 01:04 +, Rui Paulo wrote: > >> Author: rpaulo > >> Date: Sat Jul 12 01:04:10 2014 > >> New Revision: 268543 > >> URL: http://svnweb.freebsd.org/changeset/base/268543

Re: svn commit: r268566 - head/usr.bin/users

2014-07-12 Thread Alexey Dokuchaev
On Sat, Jul 12, 2014 at 01:37:49PM +0100, Bruce Simpson wrote: > On 12/07/2014 12:34, Bruce Evans wrote: > >This joke is bad. The C++ version is worse in every way. > > I concur with everything you have said in your message. Moral of story: it > is very, very easy to introduce bloat using C++, an

svn commit: r268569 - head/lib/libc/stdlib

2014-07-12 Thread Pedro F. Giffuni
Author: pfg Date: Sat Jul 12 15:19:30 2014 New Revision: 268569 URL: http://svnweb.freebsd.org/changeset/base/268569 Log: strfmon: reduce unnecessary snprintf. No need for the snprintf/asprintf dance; use fixed width formats. Obtained from:NetBSD (CVS rev. 1.8) MFC after:

Re: svn commit: r268566 - head/usr.bin/users

2014-07-12 Thread Ian Lepore
On Sat, 2014-07-12 at 13:27 +, Alexey Dokuchaev wrote: > On Sat, Jul 12, 2014 at 01:37:49PM +0100, Bruce Simpson wrote: > > On 12/07/2014 12:34, Bruce Evans wrote: > > >This joke is bad. The C++ version is worse in every way. > > > > I concur with everything you have said in your message. Mor

svn commit: r268570 - head/sys/kern

2014-07-12 Thread Mateusz Guzik
Author: mjg Date: Sat Jul 12 15:35:04 2014 New Revision: 268570 URL: http://svnweb.freebsd.org/changeset/base/268570 Log: Clear nonblock and async on devctl close instaed of open. This is a purely cosmetic change. Modified: head/sys/kern/subr_bus.c Modified: head/sys/kern/subr_bus.c ===

Re: svn commit: r268566 - head/usr.bin/users

2014-07-12 Thread Steve Kargl
On Sat, Jul 12, 2014 at 09:31:23AM -0600, Ian Lepore wrote: > On Sat, 2014-07-12 at 13:27 +, Alexey Dokuchaev wrote: > > On Sat, Jul 12, 2014 at 01:37:49PM +0100, Bruce Simpson wrote: > > > On 12/07/2014 12:34, Bruce Evans wrote: > > > >This joke is bad. The C++ version is worse in every way.

Re: svn commit: r268570 - head/sys/kern

2014-07-12 Thread Konstantin Belousov
On Sat, Jul 12, 2014 at 03:35:04PM +, Mateusz Guzik wrote: > Author: mjg > Date: Sat Jul 12 15:35:04 2014 > New Revision: 268570 > URL: http://svnweb.freebsd.org/changeset/base/268570 > > Log: > Clear nonblock and async on devctl close instaed of open. > > This is a purely cosmetic chan

Re: svn commit: r268566 - head/usr.bin/users

2014-07-12 Thread Bruce Simpson
On 12/07/2014 16:31, Ian Lepore wrote: It is in no way established that any kind of "mess" exists. On the contrary, the metrics and analysis which bde@ has presented seem pretty clear to me. All we have is some people who appear to hate C++ expressing their opinions about how they hate C++

Re: svn commit: r268570 - head/sys/kern

2014-07-12 Thread Mateusz Guzik
On Sat, Jul 12, 2014 at 07:18:01PM +0300, Konstantin Belousov wrote: > On Sat, Jul 12, 2014 at 03:35:04PM +, Mateusz Guzik wrote: > > Author: mjg > > Date: Sat Jul 12 15:35:04 2014 > > New Revision: 268570 > > URL: http://svnweb.freebsd.org/changeset/base/268570 > > > > Log: > > Clear nonblo

Re: svn commit: r268570 - head/sys/kern

2014-07-12 Thread Konstantin Belousov
On Sat, Jul 12, 2014 at 06:53:47PM +0200, Mateusz Guzik wrote: > On Sat, Jul 12, 2014 at 07:18:01PM +0300, Konstantin Belousov wrote: > > On Sat, Jul 12, 2014 at 03:35:04PM +, Mateusz Guzik wrote: > > > Author: mjg > > > Date: Sat Jul 12 15:35:04 2014 > > > New Revision: 268570 > > > URL: http:

svn commit: r268571 - stable/10/lib/libc/locale

2014-07-12 Thread Pedro F. Giffuni
Author: pfg Date: Sat Jul 12 17:39:13 2014 New Revision: 268571 URL: http://svnweb.freebsd.org/changeset/base/268571 Log: MFC r268272: minor perf enhancement for UTF-8 Reduce some duplicate code. Reference: https://www.illumos.org/issues/628 Obtained from:Illumos

svn commit: r268572 - in stable/10/sys/cddl/contrib/opensolaris/uts/common: dtrace sys

2014-07-12 Thread Pedro F. Giffuni
Author: pfg Date: Sat Jul 12 18:23:35 2014 New Revision: 268572 URL: http://svnweb.freebsd.org/changeset/base/268572 Log: MFC r268130, r268224, r268230, r268231: Various DTrace Merges from OpenSolaris/Illumos: 15-Sep-2008: 6735480 race between probe enabling and provider registrati

svn commit: r268573 - stable/9/lib/libc/locale

2014-07-12 Thread Pedro F. Giffuni
Author: pfg Date: Sat Jul 12 18:30:35 2014 New Revision: 268573 URL: http://svnweb.freebsd.org/changeset/base/268573 Log: MFC r268272: minor perf enhancement for UTF-8 Reduce some duplicate code. Reference: https://www.illumos.org/issues/628 Obtained from:Illumos

svn commit: r268574 - stable/9/lib/libc/stdtime

2014-07-12 Thread Pedro F. Giffuni
Author: pfg Date: Sat Jul 12 18:44:47 2014 New Revision: 268574 URL: http://svnweb.freebsd.org/changeset/base/268574 Log: MFC r267627: strptime: add support for %t and %n Posix strptime() requires support for %t and %n, which were added to the illumos port. Curiously we were skipping

Re: svn commit: r268491 - head/usr.bin/users

2014-07-12 Thread Dimitry Andric
On 10 Jul 2014, at 17:29, Ed Schouten wrote: > On 10 July 2014 17:23, Pietro Cerutti wrote: >> It's because of the standard library. Examples: >> >> /usr/include/c++/v1/memory:1454:47: error: unused parameter '__a' >> [-Werror,-Wunused-parameter] >>static void construct(allocator_type& _

Re: svn commit: r268566 - head/usr.bin/users

2014-07-12 Thread Tim Kientzle
On Jul 12, 2014, at 8:31 AM, Ian Lepore wrote: > It is in no way established that any kind of "mess" exists. All we have > is some people who appear to hate C++ expressing their opinions about > how they hate C++. All the whining about how many more bytes the > compiled code is or many millise

svn commit: r268575 - head

2014-07-12 Thread Rui Paulo
== --- head/ObsoleteFiles.inc Sat Jul 12 18:44:47 2014(r268574) +++ head/ObsoleteFiles.inc Sat Jul 12 21:24:28 2014(r268575) @@ -38,6 +38,8 @@ # xargs -n1 | sort | uniq -d; # done +# 20140712: Removal of bsd.dtrace.mk

Re: svn commit: r268491 - head/usr.bin/users

2014-07-12 Thread Jilles Tjoelker
On Sat, Jul 12, 2014 at 11:06:33PM +0200, Dimitry Andric wrote: > On 10 Jul 2014, at 17:29, Ed Schouten wrote: > > On 10 July 2014 17:23, Pietro Cerutti wrote: > >> It's because of the standard library. Examples: > >> /usr/include/c++/v1/memory:1454:47: error: unused parameter '__a' > >> [-Werro

svn commit: r268576 - in head/bin/sh: . tests/parameters

2014-07-12 Thread Jilles Tjoelker
Author: jilles Date: Sat Jul 12 21:54:11 2014 New Revision: 268576 URL: http://svnweb.freebsd.org/changeset/base/268576 Log: sh: Correctly handle positional parameters beyond INT_MAX on 64-bit systems. Currently, there can be no more than INT_MAX positional parameters. Make sure to treat

svn commit: r268579 - stable/9/sys/fs/nfsclient

2014-07-12 Thread Rick Macklem
Author: rmacklem Date: Sat Jul 12 23:27:38 2014 New Revision: 268579 URL: http://svnweb.freebsd.org/changeset/base/268579 Log: MFC: r268008 There might be a potential race condition for the NFSv4 client when a newly created file has another open done on it that update the open mode. This p

svn commit: r268580 - stable/10/sys/fs/nfsclient

2014-07-12 Thread Rick Macklem
Author: rmacklem Date: Sun Jul 13 00:19:39 2014 New Revision: 268580 URL: http://svnweb.freebsd.org/changeset/base/268580 Log: MFC: r268008 There might be a potential race condition for the NFSv4 client when a newly created file has another open done on it that update the open mode. This p

svn commit: r268581 - head/sys/cam/ctl

2014-07-12 Thread Alexander Motin
Author: mav Date: Sun Jul 13 06:01:23 2014 New Revision: 268581 URL: http://svnweb.freebsd.org/changeset/base/268581 Log: Merge several equal serialization indexes. Modified: head/sys/cam/ctl/ctl_cmd_table.c head/sys/cam/ctl/ctl_private.h head/sys/cam/ctl/ctl_ser_table.c Modified: head/s