Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Doug Rabson
On 12 May 2009, at 06:03, Kip Macy wrote: Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit for xdr whereas in the kernel, Solaris is not. I thought that XDR 'long' types were 32 bit regardless of whether the platform was 32 or 64 bit. I'll have to read the code again. __

svn commit: r192011 - head/sys/netinet

2009-05-12 Thread Qing Li
Author: qingli Date: Tue May 12 07:41:20 2009 New Revision: 192011 URL: http://svn.freebsd.org/changeset/base/192011 Log: This patch adds a host route to an interface address (that is assigned to a non loopback/ppp link types) through the loopback interface. Prior to the new L2/L3 rewrite, t

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Kip Macy
On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: > > On 12 May 2009, at 06:03, Kip Macy wrote: > >> Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit for xdr >> whereas in the kernel, Solaris is not. > > I thought that XDR 'long' types were 32 bit regardless of whether the > platf

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Doug Rabson
On 12 May 2009, at 09:16, Kip Macy wrote: On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: On 12 May 2009, at 06:03, Kip Macy wrote: Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit for xdr whereas in the kernel, Solaris is not. I thought that XDR 'long' types were 32

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Frank Behrens
On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: > > I thought that XDR 'long' types were 32 bit regardless of whether the > > platform was 32 or 64 bit. I'll have to read the code again. XDR is defined in RFC 4506. It should be independent from architecture. "An XDR {signed,unsigned} inte

svn commit: r192012 - head/sys/fs/fdescfs

2009-05-12 Thread Konstantin Belousov
Author: kib Date: Tue May 12 09:22:33 2009 New Revision: 192012 URL: http://svn.freebsd.org/changeset/base/192012 Log: Return controlled EINVAL when the fdescfs lookup routine is given string representing too large integer, instead of overflowing and possibly returning a random but valid vno

svn commit: r192013 - head/sys/fs/fdescfs

2009-05-12 Thread Konstantin Belousov
Author: kib Date: Tue May 12 09:28:45 2009 New Revision: 192013 URL: http://svn.freebsd.org/changeset/base/192013 Log: Report all fdescfs vnodes as VCHR for stat(2). Fake the unique major/minor numbers of the devices. Pretending that the vnodes are character devices prevents file tree w

svn commit: r192015 - head/sys/cam/scsi

2009-05-12 Thread Edward Tomasz Napierala
Author: trasz Date: Tue May 12 15:03:47 2009 New Revision: 192015 URL: http://svn.freebsd.org/changeset/base/192015 Log: Add missing 'break' statements. Found with: Coverity Prevent(tm) CID: 3936, 3937 Reviewed by: scottl@ Modified: head/sys/cam/scsi/scsi_sg.c Modified:

svn commit: r192016 - head/sys/cam

2009-05-12 Thread Edward Tomasz Napierala
Author: trasz Date: Tue May 12 15:14:37 2009 New Revision: 192016 URL: http://svn.freebsd.org/changeset/base/192016 Log: Add missing free(9) in error case. Found with: Coverity Prevent(tm) CID: 4224 Modified: head/sys/cam/cam_periph.c Modified: head/sys/cam/cam_periph.c ===

svn commit: r192017 - head/sys/fs/nfsserver

2009-05-12 Thread Rick Macklem
Author: rmacklem Date: Tue May 12 16:04:51 2009 New Revision: 192017 URL: http://svn.freebsd.org/changeset/base/192017 Log: Modify the experimental nfs server to use the new nfsd_nfsd_args structure for nfsd. Includes a change that clarifies the use of an empty principal name string to indic

svn commit: r192018 - head/sys/arm/at91

2009-05-12 Thread Stanislav Sedov
Author: stas Date: Tue May 12 16:07:08 2009 New Revision: 192018 URL: http://svn.freebsd.org/changeset/base/192018 Log: - Implement detach path. - Release memory and DMA resources on stop. - Unload the associated DMA maps after transmit is complete. Modified: head/sys/arm/at91/if_ate.c M

svn commit: r192019 - head/sys/cam/scsi

2009-05-12 Thread Edward Tomasz Napierala
Author: trasz Date: Tue May 12 16:38:32 2009 New Revision: 192019 URL: http://svn.freebsd.org/changeset/base/192019 Log: Remove dead code. Found with: Coverity Prevent(tm) CID: 3667 Modified: head/sys/cam/scsi/scsi_pass.c Modified: head/sys/cam/scsi/scsi_pass.c

svn commit: r192020 - head/sys/dev/ata

2009-05-12 Thread Edward Tomasz Napierala
Author: trasz Date: Tue May 12 16:39:43 2009 New Revision: 192020 URL: http://svn.freebsd.org/changeset/base/192020 Log: Remove dead code. Found with: Coverity Prevent(tm) CID: 556 Modified: head/sys/dev/ata/atapi-cam.c Modified: head/sys/dev/ata/atapi-cam.c ===

svn commit: r192021 - head/sys/geom/concat

2009-05-12 Thread Edward Tomasz Napierala
Author: trasz Date: Tue May 12 16:59:50 2009 New Revision: 192021 URL: http://svn.freebsd.org/changeset/base/192021 Log: Check return value of gctl_get_asciiparam(). Found with: Coverity Prevent(tm) CID: 1118 Modified: head/sys/geom/concat/g_concat.c Modified: head/sys/geom

svn commit: r192022 - head/sys/kern

2009-05-12 Thread Edward Tomasz Napierala
Author: trasz Date: Tue May 12 17:05:40 2009 New Revision: 192022 URL: http://svn.freebsd.org/changeset/base/192022 Log: Add missing 'break' statement. Found with: Coverity Prevent(tm) CID: 3919 Modified: head/sys/kern/kern_lock.c Modified: head/sys/kern/kern_lock.c ===

Re: svn commit: r192011 - head/sys/netinet

2009-05-12 Thread Dimitry Andric
On 2009-05-12 09:41, Qing Li wrote: > Author: qingli > Date: Tue May 12 07:41:20 2009 > New Revision: 192011 > URL: http://svn.freebsd.org/changeset/base/192011 > > Log: > This patch adds a host route to an interface address (that is assigned > to a non loopback/ppp link types) through the loo

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Kip Macy
On Tue, May 12, 2009 at 2:13 AM, Frank Behrens wrote: > On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: >> > I thought that XDR 'long' types were 32 bit regardless of whether the >> > platform was 32 or 64 bit. I'll have to read the code again. > > XDR is defined in RFC 4506. It should be in

Re: svn commit: r192018 - head/sys/arm/at91

2009-05-12 Thread John Baldwin
On Tuesday 12 May 2009 12:07:08 pm Stanislav Sedov wrote: > Author: stas > Date: Tue May 12 16:07:08 2009 > New Revision: 192018 > URL: http://svn.freebsd.org/changeset/base/192018 > > Log: > - Implement detach path. > - Release memory and DMA resources on stop. > - Unload the associated DMA

Re: svn commit: r192018 - head/sys/arm/at91

2009-05-12 Thread Stanislav Sedov
On Tue, 12 May 2009 12:17:05 -0400 John Baldwin mentioned: > On Tuesday 12 May 2009 12:07:08 pm Stanislav Sedov wrote: > > Author: stas > > Date: Tue May 12 16:07:08 2009 > > New Revision: 192018 > > URL: http://svn.freebsd.org/changeset/base/192018 > > > > Log: > > - Implement detach path. >

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Jung-uk Kim
On Tuesday 12 May 2009 04:18 am, Doug Rabson wrote: > On 12 May 2009, at 09:16, Kip Macy wrote: > > On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: > >> On 12 May 2009, at 06:03, Kip Macy wrote: > >>> Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit > >>> for xdr > >>> whereas

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Doug Rabson
On 12 May 2009, at 20:16, Jung-uk Kim wrote: On Tuesday 12 May 2009 04:18 am, Doug Rabson wrote: On 12 May 2009, at 09:16, Kip Macy wrote: On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: On 12 May 2009, at 06:03, Kip Macy wrote: Here is the problem, FreeBSD is sloppy about 32-bit vs.

svn commit: r192023 - head/sys/dev/vge

2009-05-12 Thread Christian Brueffer
Author: brueffer Date: Tue May 12 19:30:46 2009 New Revision: 192023 URL: http://svn.freebsd.org/changeset/base/192023 Log: Remove unused variable. Found with: Coverity Prevent(tm) CID: 550 Modified: head/sys/dev/vge/if_vge.c Modified: head/sys/dev/vge/if_vge.c

svn commit: r192024 - head/sys/dev/lge

2009-05-12 Thread Christian Brueffer
Author: brueffer Date: Tue May 12 19:33:36 2009 New Revision: 192024 URL: http://svn.freebsd.org/changeset/base/192024 Log: Remove unused variable. Found with: Coverity Prevent(tm) CID: 549 Modified: head/sys/dev/lge/if_lge.c Modified: head/sys/dev/lge/if_lge.c

svn commit: r192025 - head/usr.bin/truss

2009-05-12 Thread Diomidis Spinellis
Author: dds Date: Tue May 12 20:42:12 2009 New Revision: 192025 URL: http://svn.freebsd.org/changeset/base/192025 Log: Add -c option to summarize number of calls, errors, and system time. Reviewed by: alfred Modified: head/usr.bin/truss/amd64-fbsd.c head/usr.bin/truss/amd64-fbsd32.c

svn commit: r192026 - head/share/man/man9

2009-05-12 Thread Marius Strobl
Author: marius Date: Tue May 12 20:56:34 2009 New Revision: 192026 URL: http://svn.freebsd.org/changeset/base/192026 Log: Correct r190283 (partially reverting it) as on sparc64 BUS_DMA_NOCACHE actually is only valid for bus_dmamap_load(). MFC after:3 days Modified: head/share/man/m

svn commit: r192027 - head/sys/arm/at91

2009-05-12 Thread Stanislav Sedov
Author: stas Date: Tue May 12 21:14:36 2009 New Revision: 192027 URL: http://svn.freebsd.org/changeset/base/192027 Log: - Eliminate extra register reads by using a variable to store registers contents. - Use memory barriers to preserve the order of buffer space operations. This might b

Re: svn commit: r192026 - head/share/man/man9

2009-05-12 Thread Marius Strobl
On Tue, May 12, 2009 at 04:13:06PM -0500, Robert Noland wrote: > On Tue, 2009-05-12 at 20:56 +, Marius Strobl wrote: > > Author: marius > > Date: Tue May 12 20:56:34 2009 > > New Revision: 192026 > > URL: http://svn.freebsd.org/changeset/base/192026 > > > > Log: > > Correct r190283 (partiall

svn commit: r192028 - head/sys/arm/at91

2009-05-12 Thread Stanislav Sedov
Author: stas Date: Tue May 12 21:28:41 2009 New Revision: 192028 URL: http://svn.freebsd.org/changeset/base/192028 Log: - Resurrect the debug printf message I accidentally dropped in the previous commit. - Use device_printf instead of printf. - Put all printfs in the interrupt handler un

Re: svn commit: r192026 - head/share/man/man9

2009-05-12 Thread Robert Noland
On Tue, 2009-05-12 at 20:56 +, Marius Strobl wrote: > Author: marius > Date: Tue May 12 20:56:34 2009 > New Revision: 192026 > URL: http://svn.freebsd.org/changeset/base/192026 > > Log: > Correct r190283 (partially reverting it) as on sparc64 BUS_DMA_NOCACHE > actually is only valid for bu

svn commit: r192029 - head/sys/i386/cpufreq

2009-05-12 Thread Christian Brueffer
Author: brueffer Date: Tue May 12 22:11:02 2009 New Revision: 192029 URL: http://svn.freebsd.org/changeset/base/192029 Log: Remove unused variables. Found with: Coverity Prevent(tm) CID: 4285, 4286 Modified: head/sys/i386/cpufreq/hwpstate.c Modified: head/sys/i386/cpufreq/h

svn commit: r192030 - head/sys/dev/acpi_support

2009-05-12 Thread Christian Brueffer
Author: brueffer Date: Tue May 12 23:22:58 2009 New Revision: 192030 URL: http://svn.freebsd.org/changeset/base/192030 Log: Remove unused variables. Found with: Coverity Prevent(tm) CID: 544, 545 Modified: head/sys/dev/acpi_support/acpi_ibm.c head/sys/dev/acpi_support/acpi

svn commit: r192031 - head/lib/libarchive

2009-05-12 Thread Tim Kientzle
Author: kientzle Date: Wed May 13 00:04:08 2009 New Revision: 192031 URL: http://svn.freebsd.org/changeset/base/192031 Log: Eliminate duplicate error messages from "tar c". Reported by: pav@ Modified: head/lib/libarchive/archive_read_disk_entry_from_file.c Modified: head/lib/libarchive

svn commit: r192032 - head/sys/netgraph/netflow

2009-05-12 Thread Alexander Motin
Author: mav Date: Wed May 13 02:26:34 2009 New Revision: 192032 URL: http://svn.freebsd.org/changeset/base/192032 Log: Fix copy-paste bug in NGM_NETFLOW_SETCONFIG argument size verification. PR: kern/134220 Submitted by: Eugene Mychlo MFC after:1 week Modified: head/sys

svn commit: r192033 - stable/7/sys/dev/ata

2009-05-12 Thread Alexander Motin
Author: mav Date: Wed May 13 02:55:21 2009 New Revision: 192033 URL: http://svn.freebsd.org/changeset/base/192033 Log: Make vendor-specific drivers prefered over the generic AHCI one. This fixes some controllers, like JMicron ones, which provide also PATA via PCI function that declared as AH

svn commit: r192034 - in head/sys: kern vm

2009-05-12 Thread Alan Cox
Author: alc Date: Wed May 13 05:39:39 2009 New Revision: 192034 URL: http://svn.freebsd.org/changeset/base/192034 Log: Eliminate page queues locking from bufdone_finish() through the following changes: Rename vfs_page_set_valid() to vfs_page_set_validclean() to reflect what this functio