svn commit: r189060 - head/sys/kern

Author: ed Date: Thu Feb 26 10:14:10 2009 New Revision: 189060 URL: http://svn.freebsd.org/changeset/base/189060 Log: Don't use PTY name as format string, even though it isn't insecure here. It's guaranteed that the `name' variable always contains a string of the form pty[l‐sL‐S][0‐9a‐v],

svn commit: r189061 - head/sys/kern

Author: ed Date: Thu Feb 26 10:28:32 2009 New Revision: 189061 URL: http://svn.freebsd.org/changeset/base/189061 Log: Use unsigned longs for the TTY's sysctl stats. Spotted by: clang Modified: head/sys/kern/tty_inq.c head/sys/kern/tty_outq.c head/sys/kern/tty_ttydisc.c Modified: h

svn commit: r189062 - head/sys/kern

Author: ed Date: Thu Feb 26 10:38:19 2009 New Revision: 189062 URL: http://svn.freebsd.org/changeset/base/189062 Log: Silence compiler warning inside our ^T handler. It turns out we're casting fixpt_t* to int*. Spotted by: clang Modified: head/sys/kern/tty_info.c Modified: head/s

svn commit: r189063 - head/sys/kern

Author: rwatson Date: Thu Feb 26 10:56:13 2009 New Revision: 189063 URL: http://svn.freebsd.org/changeset/base/189063 Log: Add static tracing for privilege checking: priv:kernel:priv_check:priv_ok fires for granted privileges priv:kernel:priv_check:priv_errr fires for denied privilege

Re: svn commit: r189063 - head/sys/kern

On Thu, 26 Feb 2009, Robert Watson wrote: Log: Add static tracing for privilege checking: priv:kernel:priv_check:priv_ok fires for granted privileges priv:kernel:priv_check:priv_errr fires for denied privileges The first argument is the requested privilege number. The naming conventi

svn commit: r189064 - head/sys/dev/syscons

Author: ed Date: Thu Feb 26 12:02:38 2009 New Revision: 189064 URL: http://svn.freebsd.org/changeset/base/189064 Log: Remove unneeded variable assignment. The ts variable is always initialized a few lines below. Found by: LLVM scan-build Modified: head/sys/dev/syscons/scterm-tek

svn commit: r189065 - head/sys/libkern

Author: ed Date: Thu Feb 26 12:06:46 2009 New Revision: 189065 URL: http://svn.freebsd.org/changeset/base/189065 Log: Remove redundant assignment of `s'. The variable is already initialized to `nptr'. Found by: LLVM's scan-build Modified: head/sys/libkern/strtouq.c Modified: he

svn commit: r189066 - head/sys/kern

Author: ed Date: Thu Feb 26 12:12:34 2009 New Revision: 189066 URL: http://svn.freebsd.org/changeset/base/189066 Log: Remove redundant assignment of `p'. `p' is already initialized with `td->td_proc'. Because td is always curthread, it is safe to initialize it without any locks. Foun

svn commit: r189067 - head/sys/fs/udf

Author: avg Date: Thu Feb 26 12:33:02 2009 New Revision: 189067 URL: http://svn.freebsd.org/changeset/base/189067 Log: udf_strategy: tiny optimization of logic, calculations; extra diagnostics Use bit-shift instead of division/multiplication. Act on error as soon as it is detected. Repo

svn commit: r189068 - head/sys/fs/udf

Author: avg Date: Thu Feb 26 12:33:12 2009 New Revision: 189068 URL: http://svn.freebsd.org/changeset/base/189068 Log: udf_read: correctly read data from files with data embedded into fentry, ... as opposed to files with data in extents. Some UDF authoring tools produce this type of file

svn commit: r189069 - head/sys/fs/udf

Author: avg Date: Thu Feb 26 12:33:17 2009 New Revision: 189069 URL: http://svn.freebsd.org/changeset/base/189069 Log: udf_map: return proper error code instead of leaking an internal one Incidentally this also allows for small files with data embedded into fentry to be mmap-ed. Appr

svn commit: r189070 - head/sys/fs/udf

Author: avg Date: Thu Feb 26 12:33:22 2009 New Revision: 189070 URL: http://svn.freebsd.org/changeset/base/189070 Log: udf: add read-ahead support modeled after cd9660 Reviewed by: scottl Approved by: jhb (mentor) Modified: head/sys/fs/udf/udf_vfsops.c head/sys/fs/udf/udf_vnops.c Mo

Re: svn commit: r189063 - head/sys/kern

Quoting Robert Watson (from Thu, 26 Feb 2009 10:57:13 + (GMT)): On Thu, 26 Feb 2009, Robert Watson wrote: Log: Add static tracing for privilege checking: priv:kernel:priv_check:priv_ok fires for granted privileges priv:kernel:priv_check:priv_errr fires for denied privileges The fi

svn commit: r189071 - head/sys/kern

Author: ed Date: Thu Feb 26 13:00:13 2009 New Revision: 189071 URL: http://svn.freebsd.org/changeset/base/189071 Log: Remove unused variables `p' and unneeded assignments of `rval'. Found by: LLVM's scan-build Modified: head/sys/kern/kern_condvar.c Modified: head/sys/kern/kern_condv

svn commit: r189072 - head/sys/kern

Author: ed Date: Thu Feb 26 13:01:45 2009 New Revision: 189072 URL: http://svn.freebsd.org/changeset/base/189072 Log: Remove unneeded variable `ocn_mute'. Found by: LLVM's scan-build Modified: head/sys/kern/kern_cons.c Modified: head/sys/kern/kern_cons.c

Re: svn commit: r189063 - head/sys/kern

On Thu, 26 Feb 2009, Alexander Leidinger wrote: A typical tracing command might be: dtrace -n 'priv:::priv_ok { trace(execname); trace(arg0);}' arg0 requires manual interpretation using /usr/include/sys/priv.h. Theoretically it is possible to write a little script which takes priv.h and g

svn commit: r189073 - head/sys/dev/pci

Author: jhb Date: Thu Feb 26 14:32:14 2009 New Revision: 189073 URL: http://svn.freebsd.org/changeset/base/189073 Log: Don't throw away upper 32-bits of the HT MSI address window. In practice this is harmless since the address window for MSI on x86 is in the lower 4 GB. Submitted by: m

Re: svn commit: r188018 - in head: sys/dev/pci usr.sbin/pciconf

Robert Noland wrote: ... This is tested on PowerPC and amd64 running -CURRENT, and is in addition to the patch currently applied by ports. It *should* gracefully use the old pathway if the new ioctl isn't available. And now I have working X on PPC! Nifty, I hadn't thought of using the i

Re: svn commit: r189063 - head/sys/kern

Quoting Robert Watson (from Thu, 26 Feb 2009 13:33:18 + (GMT)): On Thu, 26 Feb 2009, Alexander Leidinger wrote: A typical tracing command might be: dtrace -n 'priv:::priv_ok { trace(execname); trace(arg0);}' arg0 requires manual interpretation using /usr/include/sys/priv.h. Theoret

svn commit: r189075 - in stable/7: lib/libc lib/libc/string lib/libc/sys share/man/man9 sys sys/amd64/amd64 sys/amd64/include sys/arm/arm sys/arm/include sys/conf sys/contrib/pf sys/dev/ath/ath_hal...

Author: jhb Date: Thu Feb 26 15:59:22 2009 New Revision: 189075 URL: http://svn.freebsd.org/changeset/base/189075 Log: MFC: Add support for "superpages" on amd64 and i386. This includes adding the superpage reservation system to the machine-independent VM system as well as changes to the pm

svn commit: r189074 - head/sys/kern

Author: ed Date: Thu Feb 26 15:51:54 2009 New Revision: 189074 URL: http://svn.freebsd.org/changeset/base/189074 Log: Remove even more unneeded variable assignments. kern_time.c: - Unused variable `p'. kern_thr.c: - Variable `error' is always caught immediately, so no reason to

svn commit: r189076 - head/sys/kern

Author: ed Date: Thu Feb 26 16:32:48 2009 New Revision: 189076 URL: http://svn.freebsd.org/changeset/base/189076 Log: Remove unneeded pointer `ndp'. Inside do_execve(), we have a pointer `ndp', which always points to `&nd'. I can imagine a primitive (non-optimizing) compiler to really r

svn commit: r189077 - head/lib/libcompat/4.3

Author: rdivacky Date: Thu Feb 26 17:46:54 2009 New Revision: 189077 URL: http://svn.freebsd.org/changeset/base/189077 Log: Add a missing parameter to ruserpass(). According to C99 6.9.1p7 K&R function is not a prototype but this is a bad style. GCC accepts this other compilers warn or rejec

svn commit: r189078 - head/bin/ps

Author: attilio Date: Thu Feb 26 18:01:07 2009 New Revision: 189078 URL: http://svn.freebsd.org/changeset/base/189078 Log: [1] When showing threads, the thread name just appears if the comm label is choosen as last printout (ucomm suffers of this such bug too). That bug is cau

Re: svn commit: r189044 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb kern

On 2009-Feb-25 11:28:46 -0500, Andrew Gallatin wrote: > Just picking a commit at random, but is there any way > to clean up the props on pf, ath and cxgb: > >> stable/7/sys/contrib/pf/ (props changed) >> stable/7/sys/dev/ath/ath_hal/ (props changed) >> stable/7/sys/dev/cxgb/ (props cha

svn commit: r189079 - stable/7/usr.sbin/pciconf

Author: jhb Date: Thu Feb 26 18:46:22 2009 New Revision: 189079 URL: http://svn.freebsd.org/changeset/base/189079 Log: MFC: Sort getopt options alphabetically. Modified: stable/7/usr.sbin/pciconf/ (props changed) stable/7/usr.sbin/pciconf/pciconf.c Modified: stable/7/usr.sbin/pciconf/pci

svn commit: r189080 - in stable/7: sys sys/contrib/pf sys/dev/ath/ath_hal sys/dev/cardbus sys/dev/cxgb sys/dev/pci sys/sys usr.sbin/pciconf

Author: jhb Date: Thu Feb 26 18:54:24 2009 New Revision: 189080 URL: http://svn.freebsd.org/changeset/base/189080 Log: MFC: Add a new ioctl to fetch details about an individual BAR of a device and add support for displaying BAR details via a new pciconf flag. Modified: stable/7/sys/ (prop

svn commit: r189081 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb nfsclient

Author: jhb Date: Thu Feb 26 18:55:55 2009 New Revision: 189081 URL: http://svn.freebsd.org/changeset/base/189081 Log: MFC: Don't clear the attribute cache of a file when it is closed. Modified: stable/7/sys/ (props changed) stable/7/sys/contrib/pf/ (props changed) stable/7/sys/dev/at

svn commit: r189082 - head/sys/fs/udf

Author: avg Date: Thu Feb 26 18:58:41 2009 New Revision: 189082 URL: http://svn.freebsd.org/changeset/base/189082 Log: udf_readatoffset: read through directory vnode, do not read > MAXBSIZE Currently bread()-ing through device vnode with (1) VMIO enabled, (2) bo_bsize != DEV_BSIZE (3)

svn commit: r189083 - in stable/6/sys: . contrib/pf dev/cxgb nfsclient

Author: jhb Date: Thu Feb 26 19:08:24 2009 New Revision: 189083 URL: http://svn.freebsd.org/changeset/base/189083 Log: MFC: Don't clear the attribute cache of a file when it is closed. Modified: stable/6/sys/ (props changed) stable/6/sys/contrib/pf/ (props changed) stable/6/sys/dev/cx

svn commit: r189084 - head/tools/tools/nanobsd/gateworks/Files/root

Author: sam Date: Thu Feb 26 19:44:52 2009 New Revision: 189084 URL: http://svn.freebsd.org/changeset/base/189084 Log: add updatep[12] that grok the partitioning we use and use gpart instead of boot0cfg to switch the active partition Added: head/tools/tools/nanobsd/gateworks/Files/root/upda

svn commit: r189085 - head/tools/tools/nanobsd/gateworks

Author: sam Date: Thu Feb 26 19:47:11 2009 New Revision: 189085 URL: http://svn.freebsd.org/changeset/base/189085 Log: use mii instead of miibus to not pull in useless phy code Modified: head/tools/tools/nanobsd/gateworks/G2358 Modified: head/tools/tools/nanobsd/gateworks/G2358 =

svn commit: r189086 - head/sys/dev/sound/pci/hda

Author: mav Date: Thu Feb 26 20:00:14 2009 New Revision: 189086 URL: http://svn.freebsd.org/changeset/base/189086 Log: Add MSI blacklisting support. Disable MSI for nVidia MCP51 controller. Enabling MSI there leads to unexpected errors and timeouts, that should not happen even if interrup

Re: svn commit: r189086 - head/sys/dev/sound/pci/hda

Alexander Motin wrote: Author: mav Date: Thu Feb 26 20:00:14 2009 New Revision: 189086 URL: http://svn.freebsd.org/changeset/base/189086 Log: Add MSI blacklisting support. Disable MSI for nVidia MCP51 controller. Enabling MSI there leads to unexpected errors and timeouts, that should n

svn commit: r189087 - head/lib/librpcsvc

Author: ed Date: Thu Feb 26 20:32:11 2009 New Revision: 189087 URL: http://svn.freebsd.org/changeset/base/189087 Log: Use ANSI function declarations in librpcsvc. When compiling librpcsvc with LLVM, we get a compiler error, because hexval() uses an ANSI prototype, but a K&R declaration. I

svn commit: r189088 - in stable/7/sys: . arm/arm contrib/pf dev/ath/ath_hal dev/cxgb ia64/ia64 powerpc/powerpc sparc64/sparc64 sun4v/sun4v

Author: jhb Date: Thu Feb 26 20:38:37 2009 New Revision: 189088 URL: http://svn.freebsd.org/changeset/base/189088 Log: MFC: Add a stub for pmap_align_superpage() on machines that don't (yet) implement pmap-level support for superpages. Pointy hat to:jhb Modified: stable/7/sys/

Re: svn commit: r189044 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb kern

On Thursday 26 February 2009 1:14:00 pm Peter Jeremy wrote: > On 2009-Feb-25 11:28:46 -0500, Andrew Gallatin wrote: > > Just picking a commit at random, but is there any way > > to clean up the props on pf, ath and cxgb: > > > >> stable/7/sys/contrib/pf/ (props changed) > >> stable/7/sys/dev

svn commit: r189089 - head/sys/conf

Author: thompsa Date: Thu Feb 26 20:54:43 2009 New Revision: 189089 URL: http://svn.freebsd.org/changeset/base/189089 Log: Allow the old usb stack to compile by adding the appropriate -I foo, this must go before the standard -I$S to have the search happen before /sys/. Make this condition

svn commit: r189090 - in head/usr.sbin: makefs/ffs pppd timed/timed timed/timedc trpt

Author: ed Date: Thu Feb 26 20:59:05 2009 New Revision: 189090 URL: http://svn.freebsd.org/changeset/base/189090 Log: Fix LLVM compiler errors related to K&R declarations with ANSI prototypes. Submitted by: Pawel Worach Modified: head/usr.sbin/makefs/ffs/ufs_bswap.h head/usr.sbin/pppd

svn commit: r189091 - head/sys/dev/ata

Author: mav Date: Thu Feb 26 21:33:48 2009 New Revision: 189091 URL: http://svn.freebsd.org/changeset/base/189091 Log: Remove direct ata_completed() call options from ata_finish(), except for the kernel dumping case. ata_completed() may initiate ata_reinit() on error, that may lead to dri

Re: svn commit: r189091 - head/sys/dev/ata

Alexander Motin wrote: Author: mav Date: Thu Feb 26 21:33:48 2009 New Revision: 189091 URL: http://svn.freebsd.org/changeset/base/189091 Log: Remove direct ata_completed() call options from ata_finish(), except for the kernel dumping case. ata_completed() may initiate ata_reinit() on er

svn commit: r189092 - in head: . contrib/telnet/libtelnet lib/libmp lib/libtelnet sys/sys tools/regression/lib/libmp usr.bin/chkey usr.bin/newkey usr.sbin/keyserv

soleteFiles.inc == --- head/ObsoleteFiles.inc Thu Feb 26 21:33:48 2009(r189091) +++ head/ObsoleteFiles.inc Thu Feb 26 21:43:15 2009(r189092) @@ -14,6 +14,8 @@ # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last.

svn commit: r189093 - head/sys/dev/ata

Author: mav Date: Thu Feb 26 22:26:07 2009 New Revision: 189093 URL: http://svn.freebsd.org/changeset/base/189093 Log: Restore mtx_lock() call on ata_timeout(), dropped (I think accidentally) during commit 3 years ago. Modified: head/sys/dev/ata/ata-queue.c Modified: head/sys/dev/ata/ata-q

svn commit: r189094 - head/sys/dev/ata

Author: mav Date: Thu Feb 26 23:07:40 2009 New Revision: 189094 URL: http://svn.freebsd.org/changeset/base/189094 Log: Unhide IDENTIFY command timeouts when verbose messages enabled. I think it should be suitable for debugging. Modified: head/sys/dev/ata/ata-all.c Modified: head/sys/dev/at

svn commit: r189095 - head/sys/dev/ata

Author: mav Date: Thu Feb 26 23:21:32 2009 New Revision: 189095 URL: http://svn.freebsd.org/changeset/base/189095 Log: Rollback rev. 189093. mtx_lock() is not needed there as callout initialized with callout_init_mtx(). Sorry. Submitted by: Ian Dowse Modified: head/sys/dev/ata/ata

Re: svn commit: r189066 - head/sys/kern

On Thu, 26 Feb 2009, Ed Schouten wrote: Author: ed Date: Thu Feb 26 12:12:34 2009 New Revision: 189066 URL: http://svn.freebsd.org/changeset/base/189066 Log: Remove redundant assignment of `p'. `p' is already initialized with `td->td_proc'. Because td is always curthread, it is safe to init

svn commit: r189096 - head/sbin/ifconfig

Author: rpaulo Date: Fri Feb 27 00:31:34 2009 New Revision: 189096 URL: http://svn.freebsd.org/changeset/base/189096 Log: Replace clone_setcallback() with a new function clone_setdefcallback() that selects a callback from an interface prefix name. This allows us to report a meaningful error

svn commit: r189097 - head/tools/tools/ath/athregs

Author: sam Date: Fri Feb 27 05:22:00 2009 New Revision: 189097 URL: http://svn.freebsd.org/changeset/base/189097 Log: fix build Modified: head/tools/tools/ath/athregs/dumpregs_5416.c Modified: head/tools/tools/ath/athregs/dumpregs_5416.c =

svn commit: r189098 - head/tools/tools/ath

Author: sam Date: Fri Feb 27 05:22:11 2009 New Revision: 189098 URL: http://svn.freebsd.org/changeset/base/189098 Log: fix build Modified: head/tools/tools/ath/Makefile.inc Modified: head/tools/tools/ath/Makefile.inc ===

svn commit: r189099 - head/sys/dev/drm

Author: rnoland Date: Fri Feb 27 06:01:42 2009 New Revision: 189099 URL: http://svn.freebsd.org/changeset/base/189099 Log: Fix up some ioctl permissions issues long overlooked. Submitted by: jkim@ MFC after:2 weeks Modified: head/sys/dev/drm/drmP.h head/sys/dev/drm/drm_bufs.c h

Re: svn commit: r189066 - head/sys/kern

On Thu, 26 Feb 2009, Bjoern A. Zeeb wrote: On Thu, 26 Feb 2009, Ed Schouten wrote: Log: Remove redundant assignment of `p'. `p' is already initialized with `td->td_proc'. Because td is always curthread, it is safe to initialize it without any locks. Found by: LLVM's scan-build Modif

Re: svn commit: r189066 - head/sys/kern

On Fri, 27 Feb 2009, I wrote: On Thu, 26 Feb 2009, Bjoern A. Zeeb wrote: On Thu, 26 Feb 2009, Ed Schouten wrote: Log: Remove redundant assignment of `p'. `p' is already initialized with `td->td_proc'. Because td is always curthread, it is safe to initialize it without any locks. Found b