Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Brandon Bergren
On Sat, Oct 31, 2020, at 4:56 PM, Warner Losh wrote: > Go for it. > > Warner > Done in r367235. I did an additional 32 bit build fix in r367238 (to readelf.c) that should fix the tree the rest of the way. (Could use a sanity check on that one fwiw, I have a vague suspicion that there should

Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Warner Losh
Go for it. Warner On Sat, Oct 31, 2020, 2:57 PM Mateusz Guzik wrote: > I agree. Please commit. > > On 10/31/20, Brandon Bergren wrote: > > Yeah, that is what was happening. The minimal implementation needed for > > libsa was missing. > > > > On Sat, Oct 31, 2020, at 3:33 PM, Brandon Bergren w

Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Mateusz Guzik
I agree. Please commit. On 10/31/20, Brandon Bergren wrote: > Yeah, that is what was happening. The minimal implementation needed for > libsa was missing. > > On Sat, Oct 31, 2020, at 3:33 PM, Brandon Bergren wrote: >> Maybe this is it?: >> >> Index: sys/contrib/openzfs/include/os/freebsd/spl/sys

Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Brandon Bergren
Yeah, that is what was happening. The minimal implementation needed for libsa was missing. On Sat, Oct 31, 2020, at 3:33 PM, Brandon Bergren wrote: > Maybe this is it?: > > Index: sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h > ==

Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Brandon Bergren
Maybe this is it?: Index: sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h === --- sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (revision 367230) +++ sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (

Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Brandon Bergren
Actually, looking at it again, it looks like the spl header is doing it wrong and not providing a fallback for atomic_sub_64, it's just defining it to atomic_subtract_64 and assuming that exists. On Sat, Oct 31, 2020, at 3:23 PM, Mateusz Guzik wrote: > Yep, jenkins told me. Working on it. > > O

Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Mateusz Guzik
Yep, jenkins told me. Working on it. On 10/31/20, Brandon Bergren wrote: > This doesn't compile on platforms such as powerpc without pulling in the > opensolaris atomics header from the spl that does locking emulation of 64 > bit atomics, as platforms that don't have native 64 bit atomics do not

Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Brandon Bergren
This doesn't compile on platforms such as powerpc without pulling in the opensolaris atomics header from the spl that does locking emulation of 64 bit atomics, as platforms that don't have native 64 bit atomics do not provide them in the system header. On Sat, Oct 31, 2020, at 2:07 PM, Mateusz

svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Mateusz Guzik
Author: mjg Date: Sat Oct 31 19:07:32 2020 New Revision: 367229 URL: https://svnweb.freebsd.org/changeset/base/367229 Log: zfs: zstd: track allocator statistics This applies: commit c4ede65bdfca11b532403620bbf0d6e33f0c1c1d Author: Mateusz Guzik Date: Fri Oct 30 23:26:10 2020 +0100