Re: svn commit: r337535 - head/sbin/init

2018-08-12 Thread Conrad Meyer
Then maybe don’t keep bringing it up? Especially when it’s totally irrelevant, like here. FreeBSD has certain assumptions of supported platforms beyond the guarantees of standard C that have nothing whatsoever to do with the boogeyman of a patched compiler. On Thu, Aug 9, 2018 at 2:42 PM Benjamin

Re: svn commit: r337535 - head/sbin/init

2018-08-09 Thread Warner Losh
On Thu, Aug 9, 2018 at 3:41 PM, Benjamin Kaduk wrote: > On Thu, Aug 9, 2018 at 11:03 AM, Conrad Meyer wrote: > >> On Thu, Aug 9, 2018 at 5:52 AM, Benjamin Kaduk wrote: >> > On Thu, Aug 9, 2018 at 7:17 AM, Edward Tomasz Napierala < >> tr...@freebsd.org> >> > wrote: >> >> Use NULLs instead of c

Re: svn commit: r337535 - head/sbin/init

2018-08-09 Thread Benjamin Kaduk
On Thu, Aug 9, 2018 at 11:03 AM, Conrad Meyer wrote: > On Thu, Aug 9, 2018 at 5:52 AM, Benjamin Kaduk wrote: > > On Thu, Aug 9, 2018 at 7:17 AM, Edward Tomasz Napierala < > tr...@freebsd.org> > > wrote: > >> Use NULLs instead of casted zeroes, for consistency. > > > > It's probably helpful to

Re: svn commit: r337535 - head/sbin/init

2018-08-09 Thread Conrad Meyer
On Thu, Aug 9, 2018 at 5:52 AM, Benjamin Kaduk wrote: > On Thu, Aug 9, 2018 at 7:17 AM, Edward Tomasz Napierala > wrote: >> Use NULLs instead of casted zeroes, for consistency. > > It's probably helpful to note explicitly that these are not in arguments to > varargs functions, I don't think it

Re: svn commit: r337535 - head/sbin/init

2018-08-09 Thread Benjamin Kaduk
On Thu, Aug 9, 2018 at 7:17 AM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Thu Aug 9 12:17:03 2018 > New Revision: 337535 > URL: https://svnweb.freebsd.org/changeset/base/337535 > > Log: > Use NULLs instead of casted zeroes, for consistency. > It's probably helpful to note explici

svn commit: r337535 - head/sbin/init

2018-08-09 Thread Edward Tomasz Napierala
Author: trasz Date: Thu Aug 9 12:17:03 2018 New Revision: 337535 URL: https://svnweb.freebsd.org/changeset/base/337535 Log: Use NULLs instead of casted zeroes, for consistency. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/sbin/init/init.c Modified: head/sbin/init/in