Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread Konstantin Belousov
On Sat, Aug 04, 2018 at 09:00:18AM -0700, Jim Harris wrote: > On Sat, Aug 4, 2018 at 7:47 AM Konstantin Belousov > wrote: > > > > > > Yes, if something special is needed, it should happen in > > platform-specific > > > > busdma code. > > > > > > > > Also, if wmb() is needed, then it is not a su

Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread Jim Harris
On Sat, Aug 4, 2018 at 7:47 AM Konstantin Belousov wrote: > > Yes, if something special is needed, it should happen in > platform-specific > > > busdma code. > > > > > > Also, if wmb() is needed, then it is not a supposed semantic or > > > wmb(), but a specific side-effects of one of the instru

Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread Justin Hibbits
On Sat, Aug 4, 2018, 10:11 Ian Lepore wrote: > On Sat, 2018-08-04 at 08:29 -0500, Justin Hibbits wrote: > > On Sat, Aug 4, 2018, 08:03 Konstantin Belousov > wrote: > > > > > > > > On Sat, Aug 04, 2018 at 05:14:31AM -0700, John Baldwin wrote: > > > > > > > > On 8/4/18 1:08 AM, Konstantin Belousov

Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread Ian Lepore
On Sat, 2018-08-04 at 08:29 -0500, Justin Hibbits wrote: > On Sat, Aug 4, 2018, 08:03 Konstantin Belousov wrote: > > > > > On Sat, Aug 04, 2018 at 05:14:31AM -0700, John Baldwin wrote: > > > > > > On 8/4/18 1:08 AM, Konstantin Belousov wrote: > > > > > > > > On Fri, Aug 03, 2018 at 08:04:06PM

Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread Konstantin Belousov
On Sat, Aug 04, 2018 at 08:29:47AM -0500, Justin Hibbits wrote: > On Sat, Aug 4, 2018, 08:03 Konstantin Belousov wrote: > > > On Sat, Aug 04, 2018 at 05:14:31AM -0700, John Baldwin wrote: > > > On 8/4/18 1:08 AM, Konstantin Belousov wrote: > > > > On Fri, Aug 03, 2018 at 08:04:06PM +, Justin

Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread Justin Hibbits
On Sat, Aug 4, 2018, 08:03 Konstantin Belousov wrote: > On Sat, Aug 04, 2018 at 05:14:31AM -0700, John Baldwin wrote: > > On 8/4/18 1:08 AM, Konstantin Belousov wrote: > > > On Fri, Aug 03, 2018 at 08:04:06PM +, Justin Hibbits wrote: > > >> Author: jhibbits > > >> Date: Fri Aug 3 20:04:06 20

Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread Konstantin Belousov
On Sat, Aug 04, 2018 at 05:14:31AM -0700, John Baldwin wrote: > On 8/4/18 1:08 AM, Konstantin Belousov wrote: > > On Fri, Aug 03, 2018 at 08:04:06PM +, Justin Hibbits wrote: > >> Author: jhibbits > >> Date: Fri Aug 3 20:04:06 2018 > >> New Revision: 337273 > >> URL: https://svnweb.freebsd.org/

Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread John Baldwin
On 8/4/18 1:08 AM, Konstantin Belousov wrote: > On Fri, Aug 03, 2018 at 08:04:06PM +, Justin Hibbits wrote: >> Author: jhibbits >> Date: Fri Aug 3 20:04:06 2018 >> New Revision: 337273 >> URL: https://svnweb.freebsd.org/changeset/base/337273 >> >> Log: >> nvme(4): Add bus_dmamap_sync() at th

Re: svn commit: r337273 - head/sys/dev/nvme

2018-08-04 Thread Konstantin Belousov
On Fri, Aug 03, 2018 at 08:04:06PM +, Justin Hibbits wrote: > Author: jhibbits > Date: Fri Aug 3 20:04:06 2018 > New Revision: 337273 > URL: https://svnweb.freebsd.org/changeset/base/337273 > > Log: > nvme(4): Add bus_dmamap_sync() at the end of the request path > > Summary: > Some a

svn commit: r337273 - head/sys/dev/nvme

2018-08-03 Thread Justin Hibbits
Author: jhibbits Date: Fri Aug 3 20:04:06 2018 New Revision: 337273 URL: https://svnweb.freebsd.org/changeset/base/337273 Log: nvme(4): Add bus_dmamap_sync() at the end of the request path Summary: Some architectures, in this case powerpc64, need explicit synchronization barriers vs de