Re: svn commit: r335916 - head/sys/conf

> On Sat, Jul 7, 2018 at 7:06 PM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > On Sat, Jul 7, 2018, 5:40 PM Eugene Grosbein wrote: > > > > > > > 08.07.2018 4:38, Warner Losh wrote: > > > > > > > > > On Sat, Jul 7, 2018, 4:14 PM Eugene Grosbein > > >

Re: svn commit: r335916 - head/sys/conf

On Sat, Jul 07, 2018 at 10:46:24PM -0600, Warner Losh wrote: > On Sat, Jul 7, 2018 at 7:06 PM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > On Sat, Jul 7, 2018, 5:40 PM Eugene Grosbein wrote: > > > > > > > 08.07.2018 4:38, Warner Losh wrote: > > > > > > > > > On Sat, Jul 7,

Re: svn commit: r335916 - head/sys/conf

On Sat, Jul 7, 2018 at 7:06 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > On Sat, Jul 7, 2018, 5:40 PM Eugene Grosbein wrote: > > > > > 08.07.2018 4:38, Warner Losh wrote: > > > > > > > On Sat, Jul 7, 2018, 4:14 PM Eugene Grosbein > > > wrote: > > >

Re: svn commit: r335916 - head/sys/conf

> On Sat, Jul 7, 2018, 5:40 PM Eugene Grosbein wrote: > > > 08.07.2018 4:38, Warner Losh wrote: > > > > > On Sat, Jul 7, 2018, 4:14 PM Eugene Grosbein > > wrote: > > > > > > 07.07.2018 22:02, Andrew Gallatin wrote: > > > > > > > One thing that was tangentially

Re: svn commit: r335916 - head/sys/conf

08.07.2018 7:33, Warner Losh wrote: > > We already have all headers in /usr/include, don't we? > > Not really. We have a subset of the kernel headers that might not match > the running kernel, nor be enough to build modules. > They should match running kernel definitely as we do n

Re: svn commit: r335916 - head/sys/conf

On Sat, Jul 7, 2018, 5:40 PM Eugene Grosbein wrote: > 08.07.2018 4:38, Warner Losh wrote: > > > On Sat, Jul 7, 2018, 4:14 PM Eugene Grosbein > wrote: > > > > 07.07.2018 22:02, Andrew Gallatin wrote: > > > > > One thing that was tangentially brought up is that t

Re: svn commit: r335916 - head/sys/conf

08.07.2018 4:38, Warner Losh wrote: > On Sat, Jul 7, 2018, 4:14 PM Eugene Grosbein > wrote: > > 07.07.2018 22:02, Andrew Gallatin wrote: > > > One thing that was tangentially brought up is that the ability > > to compile out-of-tree modules requires keepin

Re: svn commit: r335916 - head/sys/conf

On Sat, Jul 7, 2018, 4:14 PM Eugene Grosbein wrote: > 07.07.2018 22:02, Andrew Gallatin wrote: > > > One thing that was tangentially brought up is that the ability > > to compile out-of-tree modules requires keeping the kernel-headers > > around. So we may need to identify all the headers that a

Re: svn commit: r335916 - head/sys/conf

07.07.2018 22:02, Andrew Gallatin wrote: > One thing that was tangentially brought up is that the ability > to compile out-of-tree modules requires keeping the kernel-headers > around. So we may need to identify all the headers that a module might > need, and install them in /boot/$KERNEL/sys or

Re: svn commit: r335916 - head/sys/conf

On 07/05/18 19:59, John Baldwin wrote: You misunderstand. /usr/local/sys/modules would hold module sources so that they can be recompiled when building a kernel without having to rebuild the package or reinstall the package. Binary modules would continue to be installed in /boot/modules. Th

Re: svn commit: r335916 - head/sys/conf

[ Charset UTF-8 unsupported, converting... ] > On 7/5/18 5:13 PM, Eugene Grosbein wrote: > > 06.07.2018 6:59, John Baldwin wrote: > > > >>> I'm not sure I understand the topic quite right, but please do not drop > >>> MODULES_WITH_WORLD support at it allows us to quickly rebuild the kernel > >>> i

Re: svn commit: r335916 - head/sys/conf

> On 7/5/18 4:17 PM, Eugene Grosbein wrote: > > 06.07.2018 1:21, John Baldwin wrote: > > > >> Yes, this is a change though I find it the logical outcome of the original > >> change > >> to move away from MODULES_WITH_WORLD. And to be clear, Matt certainly only > >> intended to use MODULE_TIED in

Re: svn commit: r335916 - head/sys/conf

06.07.2018 7:20, John Baldwin wrote: >> And what's profit of such restriction? There were several cases >> when I was forced to extract somemodule.ko from FreeBSD distribution files >> and upload it to some customized installation such as FreeNAS or NAS4Free >> or another one running custom kernel

Re: svn commit: r335916 - head/sys/conf

06.07.2018 7:20, John Baldwin wrote: >>> This would not drop it, but it would mean that you can't necessarily kldload >>> /boot/kernel.GENERIC/foo.ko while running some other kernel. >> >> And what's profit of such restriction? There were several cases >> when I was forced to extract somemodule.ko

Re: svn commit: r335916 - head/sys/conf

On 7/5/18 5:13 PM, Eugene Grosbein wrote: > 06.07.2018 6:59, John Baldwin wrote: > >>> I'm not sure I understand the topic quite right, but please do not drop >>> MODULES_WITH_WORLD support at it allows us to quickly rebuild the kernel >>> in case of slight changes of its config file not changing

Re: svn commit: r335916 - head/sys/conf

06.07.2018 6:59, John Baldwin wrote: >> I'm not sure I understand the topic quite right, but please do not drop >> MODULES_WITH_WORLD support at it allows us to quickly rebuild the kernel >> in case of slight changes of its config file not changing ABI and/or >> similar source changes without HUGE

Re: svn commit: r335916 - head/sys/conf

On 7/5/18 4:17 PM, Eugene Grosbein wrote: > 06.07.2018 1:21, John Baldwin wrote: > >> Yes, this is a change though I find it the logical outcome of the original >> change >> to move away from MODULES_WITH_WORLD. And to be clear, Matt certainly only >> intended to use MODULE_TIED in a few places,

Re: svn commit: r335916 - head/sys/conf

06.07.2018 1:21, John Baldwin wrote: > Yes, this is a change though I find it the logical outcome of the original > change > to move away from MODULES_WITH_WORLD. And to be clear, Matt certainly only > intended to use MODULE_TIED in a few places, but I think tagging all those > places will be cu

Re: svn commit: r335916 - head/sys/conf

On 7/5/18 11:39 AM, Konstantin Belousov wrote: > On Thu, Jul 05, 2018 at 11:21:28AM -0700, John Baldwin wrote: >> On 7/5/18 8:54 AM, Konstantin Belousov wrote: >>> On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote: On 7/4/18 7:22 AM, Konstantin Belousov wrote: > On Tue, Jul 03,

Re: svn commit: r335916 - head/sys/conf

On Thu, Jul 05, 2018 at 11:21:28AM -0700, John Baldwin wrote: > On 7/5/18 8:54 AM, Konstantin Belousov wrote: > > On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote: > >> On 7/4/18 7:22 AM, Konstantin Belousov wrote: > >>> On Tue, Jul 03, 2018 at 11:05:42PM +, Matt Macy wrote: >

Re: svn commit: r335916 - head/sys/conf

On 7/5/18 8:54 AM, Konstantin Belousov wrote: > On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote: >> On 7/4/18 7:22 AM, Konstantin Belousov wrote: >>> On Tue, Jul 03, 2018 at 11:05:42PM +, Matt Macy wrote: Author: mmacy Date: Tue Jul 3 23:05:42 2018 New Revision: 335

Re: svn commit: r335916 - head/sys/conf

On Thu, Jul 5, 2018 at 8:54 AM, Konstantin Belousov wrote: > On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote: >> On 7/4/18 7:22 AM, Konstantin Belousov wrote: >> > On Tue, Jul 03, 2018 at 11:05:42PM +, Matt Macy wrote: >> >> Author: mmacy >> >> Date: Tue Jul 3 23:05:42 2018 >> >>

Re: svn commit: r335916 - head/sys/conf

On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote: > On 7/4/18 7:22 AM, Konstantin Belousov wrote: > > On Tue, Jul 03, 2018 at 11:05:42PM +, Matt Macy wrote: > >> Author: mmacy > >> Date: Tue Jul 3 23:05:42 2018 > >> New Revision: 335916 > >> URL: https://svnweb.freebsd.org/changese

Re: svn commit: r335916 - head/sys/conf

On 7/4/18 7:22 AM, Konstantin Belousov wrote: > On Tue, Jul 03, 2018 at 11:05:42PM +, Matt Macy wrote: >> Author: mmacy >> Date: Tue Jul 3 23:05:42 2018 >> New Revision: 335916 >> URL: https://svnweb.freebsd.org/changeset/base/335916 >> >> Log: >> Enable MODULE_TIED by default for modules co

Re: svn commit: r335916 - head/sys/conf

On Tue, Jul 03, 2018 at 11:05:42PM +, Matt Macy wrote: > Author: mmacy > Date: Tue Jul 3 23:05:42 2018 > New Revision: 335916 > URL: https://svnweb.freebsd.org/changeset/base/335916 > > Log: > Enable MODULE_TIED by default for modules compiled with the kernel But why ? > > Requested b

Re: svn commit: r335916 - head/sys/conf

I didn't want it to be global. Note that I did _exactly_ what John told me to. I don't believe the tone or word choice is justified. -M On Tue, Jul 3, 2018 at 17:32 Warner Losh wrote: > And this is why I wanted it to conform to the current build paradigm in my > review... I'll mop it up once Br

Re: svn commit: r335916 - head/sys/conf

And this is why I wanted it to conform to the current build paradigm in my review... I'll mop it up once Bryan is done... Warner On Tue, Jul 3, 2018, 6:05 PM Matt Macy wrote: > Author: mmacy > Date: Tue Jul 3 23:05:42 2018 > New Revision: 335916 > URL: https://svnweb.freebsd.org/changeset/base

svn commit: r335916 - head/sys/conf

Author: mmacy Date: Tue Jul 3 23:05:42 2018 New Revision: 335916 URL: https://svnweb.freebsd.org/changeset/base/335916 Log: Enable MODULE_TIED by default for modules compiled with the kernel Requested by: jhb Modified: head/sys/conf/kern.post.mk Modified: head/sys/conf/kern.post.mk ===