Sorry guys I didn't spot it was just a revert as it was tagged on to the
end of the description, I would have expected that to be in the subject.
What do others think, is there an recommend style for revert commit
messages?
Regards
Steve
On 02/07/2018 17:30, Rodney W. Grimes wrote:
[ Charset UTF-8 unsupported, converting... ]
> On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland <
> steven.hartl...@multiplay.co.uk> wrote:
> >
> > You have M_WAITOK and a null check in this change
>
> And, that's the same as the way it was before his commits. So, he did
> exactly what he said he w
In message
, "Jonathan T. Looney" writes:
> On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland <
> steven.hartl...@multiplay.co.uk> wrote:
> >
> > You have M_WAITOK and a null check in this change
>
> And, that's the same as the way it was before his commits. So, he did
> exactly what he said he was
On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland <
steven.hartl...@multiplay.co.uk> wrote:
>
> You have M_WAITOK and a null check in this change
And, that's the same as the way it was before his commits. So, he did
exactly what he said he was doing and reverted his commits. I don't think
it is good
You have M_WAITOK and a null check in this change
On Mon, 2 Jul 2018 at 06:20, Matt Macy wrote:
> Author: mmacy
> Date: Mon Jul 2 05:19:44 2018
> New Revision: 335856
> URL: https://svnweb.freebsd.org/changeset/base/335856
>
> Log:
> inpcb: don't gratuitously defer frees
>
> Don't defer fre
Author: mmacy
Date: Mon Jul 2 05:19:44 2018
New Revision: 335856
URL: https://svnweb.freebsd.org/changeset/base/335856
Log:
inpcb: don't gratuitously defer frees
Don't defer frees in sysctl handlers. It isn't necessary
and it just confuses things.
revert: r333911, r334104, and r334125