On Tue, 5 Jun 2018, Eric van Gyzen wrote:
On 06/05/2018 15:53, Ian Lepore wrote:
On Tue, 2018-06-05 at 20:34 +, Eric van Gyzen wrote:
Author: vangyzen
Date: Tue Jun\xc2\xa0\xc2\xa05 20:34:11 2018
New Revision: 334669
URL: https://svnweb.freebsd.org/changeset/base/334669
Log:
\xc2\xa0 Make
On 06/06/2018 00:07, Eric van Gyzen wrote:
> On 06/05/2018 15:53, Ian Lepore wrote:
>> This is a sad sad thing. Treating (bits & flagconstants) as boolean has
>> a long long history in C. Surely there are literally thousand of
>> occurrances in freebsd code already, so why did this one get flagged?
On 06/05/2018 15:53, Ian Lepore wrote:
> On Tue, 2018-06-05 at 20:34 +, Eric van Gyzen wrote:
>> Author: vangyzen
>> Date: Tue Jun 5 20:34:11 2018
>> New Revision: 334669
>> URL: https://svnweb.freebsd.org/changeset/base/334669
>>
>> Log:
>> Make Coverity more happy with r334545
>>
>> C
In message <1528232004.63685.25.ca...@freebsd.org>, Ian Lepore writes:
>On Tue, 2018-06-05 at 20:34 +, Eric van Gyzen wrote:
>> (((flags) & M_WAITOK) || _malloc_item != NULL)
>
>This is a sad sad thing. Treating (bits & flagconstants) as boolean has
>a long long history in C. Surely
On Tue, 2018-06-05 at 20:34 +, Eric van Gyzen wrote:
> Author: vangyzen
> Date: Tue Jun 5 20:34:11 2018
> New Revision: 334669
> URL: https://svnweb.freebsd.org/changeset/base/334669
>
> Log:
> Make Coverity more happy with r334545
>
> Coverity complains about:
>
> if (((flags
Author: vangyzen
Date: Tue Jun 5 20:34:11 2018
New Revision: 334669
URL: https://svnweb.freebsd.org/changeset/base/334669
Log:
Make Coverity more happy with r334545
Coverity complains about:
if (((flags) & M_WAITOK) || _malloc_item != NULL)
saying:
The expression
