Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-31 Thread Maxim Sobolev
Fair enough. If you want I have the patch against 11-stable, we have this feature merged in our private 11.x tree. -Max On Thu, Aug 31, 2017 at 7:26 AM, Ian Lepore wrote: > Unfortunately, I'm not in a position to test those changes. My setup > that uses mdconfig in a 32-bit jail runs on freebs

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-31 Thread Ian Lepore
Unfortunately, I'm not in a position to test those changes.  My setup that uses mdconfig in a 32-bit jail runs on freebsd 10-stable and 11- stable systems.  I don't have any 64-bit hardware available to run -current. -- Ian On Wed, 2017-08-30 at 10:10 -0700, Maxim Sobolev wrote: > Hi Ian, I've co

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-30 Thread Maxim Sobolev
Hi Ian, I've committed support for the md_label into 32-bit-to-64-bit ioctl translation later and tested it for a bit here. It would be nice if you give it a go as well so if there are any bugs I'd like to iron them out before I MFC this piece in few weeks. Interestingly enough, I found mdconfig -l

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread Bruce Evans
On Tue, 29 Aug 2017, John Baldwin wrote: On Tuesday, August 29, 2017 12:18:18 PM Maxim Sobolev wrote: John, OK, maybe you are right and the current status quo was just an accident. I am curious what do you and other people think about expressing expected structure size and padding more explicit

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread John Baldwin
On Tuesday, August 29, 2017 12:18:18 PM Maxim Sobolev wrote: > John, OK, maybe you are right and the current status quo was just an > accident. I am curious what do you and other people think about expressing > expected structure size and padding more explicitly instead of trying to > accommodate f

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread Justin Hibbits
On Aug 29, 2017 14:18, "Maxim Sobolev" wrote: John, OK, maybe you are right and the current status quo was just an accident. I am curious what do you and other people think about expressing expected structure size and padding more explicitly instead of trying to accommodate for sometimes intricat

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread Maxim Sobolev
John, OK, maybe you are right and the current status quo was just an accident. I am curious what do you and other people think about expressing expected structure size and padding more explicitly instead of trying to accommodate for sometimes intricate play between alignment and type size with some

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread Maxim Sobolev
Ian, yes, you are right, there appears to be md_ioctl wrapper in the FREEBSD32 layer, which I've completely missed it turns out. I add the label support into that as well. Thanks for bringing it up, I'll follow-up with the patch to make 32-bit code fully functional WRT labels. It's not broken at th

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread Warner Losh
On Tue, Aug 29, 2017 at 8:30 AM, John Baldwin wrote: > On Monday, August 28, 2017 04:40:49 PM Maxim Sobolev wrote: > > John, well, this depends on how you look at it. The padding element size > is > > "int", which when you account for the alignment has the nice property on > > both 32 and 64-bit

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread John Baldwin
On Monday, August 28, 2017 04:40:49 PM Maxim Sobolev wrote: > John, well, this depends on how you look at it. The padding element size is > "int", which when you account for the alignment has the nice property on > both 32 and 64-bit arches that no matter what kind of element you add > (char, short

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread Ian Lepore
On Mon, 2017-08-28 at 16:40 -0700, Maxim Sobolev wrote: > John, well, this depends on how you look at it. The padding element size is > "int", which when you account for the alignment has the nice property on > both 32 and 64-bit arches that no matter what kind of element you add > (char, short, in

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Bruce Evans
On Mon, 28 Aug 2017, Ryan Libby wrote: On Mon, Aug 28, 2017 at 11:24 AM, Maxim Sobolev wrote: Hi John, Thanks for your feedback! To address the points that you've raised: 1. I've tested on both 32 and 64 bit platforms, it seems not to be the case. See imp's comment and my reply here https://

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Maxim Sobolev
John, well, this depends on how you look at it. The padding element size is "int", which when you account for the alignment has the nice property on both 32 and 64-bit arches that no matter what kind of element you add (char, short, int or void *), you only need to bring down MDNPAD by 1 to keep th

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread John Baldwin
On Monday, August 28, 2017 12:46:48 PM Ryan Libby wrote: > On Mon, Aug 28, 2017 at 11:24 AM, Maxim Sobolev wrote: > > Hi John, > > > > Thanks for your feedback! To address the points that you've raised: > > > > 1. I've tested on both 32 and 64 bit platforms, it seems not to be the > > case. See im

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Ryan Libby
On Mon, Aug 28, 2017 at 11:24 AM, Maxim Sobolev wrote: > Hi John, > > Thanks for your feedback! To address the points that you've raised: > > 1. I've tested on both 32 and 64 bit platforms, it seems not to be the > case. See imp's comment and my reply here > https://reviews.freebsd.org/D10457#2168

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Maxim Sobolev
Hi John, Thanks for your feedback! To address the points that you've raised: 1. I've tested on both 32 and 64 bit platforms, it seems not to be the case. See imp's comment and my reply here https://reviews.freebsd.org/D10457#216855 . Did I miss something? Can you post piece of C code that produce

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread John Baldwin
On Monday, August 28, 2017 03:54:08 PM Maxim Sobolev wrote: > Author: sobomax > Date: Mon Aug 28 15:54:07 2017 > New Revision: 322969 > URL: https://svnweb.freebsd.org/changeset/base/322969 > > Log: > Add ability to label md(4) devices. > > This feature comes from the fact that we rely memo

svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Maxim Sobolev
Author: sobomax Date: Mon Aug 28 15:54:07 2017 New Revision: 322969 URL: https://svnweb.freebsd.org/changeset/base/322969 Log: Add ability to label md(4) devices. This feature comes from the fact that we rely memory-backed md(4) in our build process heavily. However, if the build goes hay