Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-22 Thread Bruce Evans
On Fri, 21 Jul 2017, Konstantin Belousov wrote: On Thu, Jul 20, 2017 at 04:02:02PM -0700, Ryan Libby wrote: On Thu, Jul 20, 2017 at 3:33 AM, Konstantin Belousov wrote: On Thu, Jul 20, 2017 at 02:08:30AM -0700, Ryan Libby wrote: On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans wrote: [...] Thi

Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Konstantin Belousov
On Thu, Jul 20, 2017 at 04:02:02PM -0700, Ryan Libby wrote: > On Thu, Jul 20, 2017 at 3:33 AM, Konstantin Belousov > wrote: > > On Thu, Jul 20, 2017 at 02:08:30AM -0700, Ryan Libby wrote: > >> On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans wrote: > [...] > >> > This bug is not very common. There s

Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Ryan Libby
On Thu, Jul 20, 2017 at 3:33 AM, Konstantin Belousov wrote: > On Thu, Jul 20, 2017 at 02:08:30AM -0700, Ryan Libby wrote: >> On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans wrote: [...] >> > This bug is not very common. There seem to be no instances of it in >> > (only sys/cdefs.h uses __attribute

Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Konstantin Belousov
On Thu, Jul 20, 2017 at 02:08:30AM -0700, Ryan Libby wrote: > On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans wrote: > > On Thu, 20 Jul 2017, Ryan Libby wrote: > >> Modified: head/sys/amd64/include/efi.h > >> > >> == > >> ---

Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Bruce Evans
On Thu, 20 Jul 2017, Ryan Libby wrote: On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans wrote: On Thu, 20 Jul 2017, Ryan Libby wrote: Modified: head/sys/amd64/include/efi.h == --- head/sys/amd64/include/efi.hThu

Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Ryan Libby
On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans wrote: > On Thu, 20 Jul 2017, Ryan Libby wrote: >> Modified: head/sys/amd64/include/efi.h >> >> == >> --- head/sys/amd64/include/efi.hThu Jul 20 05:43:48 2017 >> (r32128

Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Bruce Evans
On Thu, 20 Jul 2017, Ryan Libby wrote: Log: efi: restrict visibility of EFIABI_ATTR-declared functions In-tree gcc (4.2) doesn't understand __attribute__((ms_abi)) (EFIABI_ATTR). Avoid declaring functions with that attribute when the compiler is detected to be gcc < 4.4. Thanks. I used

svn commit: r321284 - in head/sys: amd64/include sys

2017-07-19 Thread Ryan Libby
Author: rlibby Date: Thu Jul 20 06:47:06 2017 New Revision: 321284 URL: https://svnweb.freebsd.org/changeset/base/321284 Log: efi: restrict visibility of EFIABI_ATTR-declared functions In-tree gcc (4.2) doesn't understand __attribute__((ms_abi)) (EFIABI_ATTR). Avoid declaring functions w