Re: svn commit: r302577 - head/sys/dev/drm2

2016-07-14 Thread Ngie Cooper (yaneurabeya)
> On Jul 13, 2016, at 16:56, Ngie Cooper wrote: > > On Wed, Jul 13, 2016 at 4:54 AM, Robert Watson wrote: >> On Mon, 11 Jul 2016, Garrett Cooper wrote: >> >>> Add missing default case to capable(..) function definition >>> >>> By definition (enum __drm_capabilities), cases other than CAP_SYS_

Re: svn commit: r302577 - head/sys/dev/drm2

2016-07-13 Thread Ngie Cooper
On Wed, Jul 13, 2016 at 4:54 AM, Robert Watson wrote: > On Mon, 11 Jul 2016, Garrett Cooper wrote: > >> Add missing default case to capable(..) function definition >> >> By definition (enum __drm_capabilities), cases other than CAP_SYS_ADMIN >> aren't possible. Add in a KASSERT safety belt and

Re: svn commit: r302577 - head/sys/dev/drm2

2016-07-13 Thread Robert Watson
On Mon, 11 Jul 2016, Garrett Cooper wrote: Add missing default case to capable(..) function definition By definition (enum __drm_capabilities), cases other than CAP_SYS_ADMIN aren't possible. Add in a KASSERT safety belt and return false in !INVARIANTS case if an invalid value is passed in,

svn commit: r302577 - head/sys/dev/drm2

2016-07-11 Thread Garrett Cooper
Author: ngie Date: Mon Jul 11 17:01:07 2016 New Revision: 302577 URL: https://svnweb.freebsd.org/changeset/base/302577 Log: Add missing default case to capable(..) function definition By definition (enum __drm_capabilities), cases other than CAP_SYS_ADMIN aren't possible. Add in a KASSERT