Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Pedro Giffuni
On 21/04/2016 13:25, Pedro Giffuni wrote: On 21/04/2016 13:12, Hans Petter Selasky wrote: On 04/21/16 19:59, Pedro Giffuni wrote: On 21/04/2016 12:52, Juli Mallett wrote: On Thu, Apr 21, 2016 at 10:22 AM, Hans Petter Selasky wrote: On 04/21/16 19:12, Ngie Cooper wrote: Hi, Then the

Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Pedro Giffuni via svn-src-all
On 21/04/2016 13:25, Pedro Giffuni wrote: On 21/04/2016 13:12, Hans Petter Selasky wrote: On 04/21/16 19:59, Pedro Giffuni wrote: On 21/04/2016 12:52, Juli Mallett wrote: On Thu, Apr 21, 2016 at 10:22 AM, Hans Petter Selasky wrote: On 04/21/16 19:12, Ngie Cooper wrote: Hi, Then the

Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Pedro Giffuni
On 21/04/2016 13:12, Hans Petter Selasky wrote: On 04/21/16 19:59, Pedro Giffuni wrote: On 21/04/2016 12:52, Juli Mallett wrote: On Thu, Apr 21, 2016 at 10:22 AM, Hans Petter Selasky wrote: On 04/21/16 19:12, Ngie Cooper wrote: Hi, Then there should be an assertion or something else o

Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Pedro Giffuni
On 21/04/2016 12:52, Juli Mallett wrote: On Thu, Apr 21, 2016 at 10:22 AM, Hans Petter Selasky wrote: On 04/21/16 19:12, Ngie Cooper wrote: Please put the "deadcode" back. It will crash now if it's given an invalid address family (or none are configured in the kernel) when it tries to do the

Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Hans Petter Selasky
On 04/21/16 19:59, Pedro Giffuni wrote: On 21/04/2016 12:52, Juli Mallett wrote: On Thu, Apr 21, 2016 at 10:22 AM, Hans Petter Selasky wrote: On 04/21/16 19:12, Ngie Cooper wrote: Hi, Then there should be an assertion or something else of that sort (I forget if we have a __builtin_unreac

Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Juli Mallett
On Thu, Apr 21, 2016 at 10:22 AM, Hans Petter Selasky wrote: > On 04/21/16 19:12, Ngie Cooper wrote: >> >> Please put the "deadcode" back. It will crash now if it's given an >> invalid address family (or none are configured in the kernel) when it >> tries to do the memcpy below. > > > If you look

Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Hans Petter Selasky
On 04/21/16 19:12, Ngie Cooper wrote: Please put the "deadcode" back. It will crash now if it's given an invalid address family (or none are configured in the kernel) when it tries to do the memcpy below. If you look a few lines up in the file, not the patch, you'll see that there already is a

Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Ngie Cooper
On Thu, Apr 21, 2016 at 9:04 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Apr 21 16:04:58 2016 > New Revision: 298412 > URL: https://svnweb.freebsd.org/changeset/base/298412 > > Log: > Fix for resolving mac address when the destination address is a gateway. > Remove some dead

svn commit: r298412 - head/sys/ofed/drivers/infiniband/core

2016-04-21 Thread Hans Petter Selasky
Author: hselasky Date: Thu Apr 21 16:04:58 2016 New Revision: 298412 URL: https://svnweb.freebsd.org/changeset/base/298412 Log: Fix for resolving mac address when the destination address is a gateway. Remove some dead code while at it. Sponsored by: Mellanox Technologies MFC after:1