Re: svn commit: r293775 - head/sys/boot/uboot/lib

2016-01-12 Thread Ian Lepore
On Wed, 2016-01-13 at 01:03 +, Brooks Davis wrote: > On Wed, Jan 13, 2016 at 12:41:41AM +, Steven Hartland wrote: > > Was this meant to be a full revert as you now have: > > > > subldr = rounddown2((uintptr_t)_start, KERN_ALIGN); > > > > vs the original: > > > > subldr = rounddown2((uint

Re: svn commit: r293775 - head/sys/boot/uboot/lib

2016-01-12 Thread Brooks Davis
On Wed, Jan 13, 2016 at 12:41:41AM +, Steven Hartland wrote: > Was this meant to be a full revert as you now have: > > subldr = rounddown2((uintptr_t)_start, KERN_ALIGN); > > vs the original: > > subldr = rounddown2((uint64_t)(uintptr_t)_start, KERN_ALIGN); > > i.e. missing the final conver

Re: svn commit: r293775 - head/sys/boot/uboot/lib

2016-01-12 Thread Ian Lepore
On Wed, 2016-01-13 at 00:41 +, Steven Hartland wrote: > Was this meant to be a full revert as you now have: > > subldr = rounddown2((uintptr_t)_start, KERN_ALIGN); > > vs the original: > > subldr = rounddown2((uint64_t)(uintptr_t)_start, KERN_ALIGN); > > i.e. missing the final conversion to

Re: svn commit: r293775 - head/sys/boot/uboot/lib

2016-01-12 Thread Steven Hartland
Was this meant to be a full revert as you now have: subldr = rounddown2((uintptr_t)_start, KERN_ALIGN); vs the original: subldr = rounddown2((uint64_t)(uintptr_t)_start, KERN_ALIGN); i.e. missing the final conversion to uint64_t? On 13/01/2016 00:25, Ian Lepore wrote: On Tue, 2016-01-12 at

Re: svn commit: r293775 - head/sys/boot/uboot/lib

2016-01-12 Thread Ian Lepore
On Tue, 2016-01-12 at 22:49 +, Steven Hartland wrote: > I think this breaks arm arches: > /usr/home/smh/freebsd/base/head1/sys/boot/uboot/lib/copy.c:103:24: > error: use of undeclared identifier 'uintfptr_t' > subldr = rounddown2((uintfptr_t)_start, KERN_ALIGN); >

Re: svn commit: r293775 - head/sys/boot/uboot/lib

2016-01-12 Thread Steven Hartland
I think this breaks arm arches: /usr/home/smh/freebsd/base/head1/sys/boot/uboot/lib/copy.c:103:24: error: use of undeclared identifier 'uintfptr_t' subldr = rounddown2((uintfptr_t)_start, KERN_ALIGN); ^ /usr/home/smh/freebsd/base/head1/sys/boo

svn commit: r293775 - head/sys/boot/uboot/lib

2016-01-12 Thread Ian Lepore
Author: ian Date: Tue Jan 12 16:31:07 2016 New Revision: 293775 URL: https://svnweb.freebsd.org/changeset/base/293775 Log: Cast using uintfptr_t and eliminate the cast to uint64_t which is uneeded because rounding down cannot increase the number of bits needed to express the result. I h