Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Bryan Drewery
On 10/8/15 5:51 AM, Andriy Gapon wrote: > On 08/10/2015 14:42, Craig Rodrigues wrote: >> Author: rodrigc >> Date: Thu Oct 8 11:42:15 2015 >> New Revision: 289027 >> URL: https://svnweb.freebsd.org/changeset/base/289027 >> >> Log: >> Merge: >> commit 400ecf36bb0b73f6390f9641e6cb8bbfb91a5cfd

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread David Chisnall
On 8 Oct 2015, at 13:51, Andriy Gapon wrote: > > What if one day github disappears but FreeBSD is still going? > The full commit message would be lost. That’s not the only thing that is bad about this commit message. Why ‘Assume C89?’ We compile libc as C99 + GNU extensions and are likely to

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Conrad Meyer
On Thu, Oct 8, 2015 at 9:06 AM, Andriy Gapon wrote: > This commit seems to set a precedent of "merging" a github pull request into > the > tree. That's why I decided to comment. I did so as well in r288238, for example. :-) Upstreams (for tz or libcxxrt), hosted at Github or elsewhere, may dis

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Andriy Gapon
On 08/10/2015 18:26, Conrad Meyer wrote: > On Thu, Oct 8, 2015 at 5:51 AM, Andriy Gapon wrote: >> On 08/10/2015 14:42, Craig Rodrigues wrote: >>> Assume C89. >>> >>> >>> https://github.com/eggert/tz/commit/400ecf36bb0b73f6390f9641e6cb8bbfb91a5cfd >> >> What if one day github disappears but

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Benjamin Kaduk
On Thu, Oct 8, 2015 at 10:26 AM, Conrad Meyer wrote: > On Thu, Oct 8, 2015 at 5:51 AM, Andriy Gapon wrote: > > On 08/10/2015 14:42, Craig Rodrigues wrote: > >> Assume C89. > >> > >> > https://github.com/eggert/tz/commit/400ecf36bb0b73f6390f9641e6cb8bbfb91a5cfd > > > > What if one day github

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Conrad Meyer
On Thu, Oct 8, 2015 at 5:51 AM, Andriy Gapon wrote: > On 08/10/2015 14:42, Craig Rodrigues wrote: >> Assume C89. >> >> >> https://github.com/eggert/tz/commit/400ecf36bb0b73f6390f9641e6cb8bbfb91a5cfd > > What if one day github disappears but FreeBSD is still going? > The full commit message

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Baptiste Daroussin
On Thu, Oct 08, 2015 at 03:51:26PM +0300, Andriy Gapon wrote: > On 08/10/2015 14:42, Craig Rodrigues wrote: > > Author: rodrigc > > Date: Thu Oct 8 11:42:15 2015 > > New Revision: 289027 > > URL: https://svnweb.freebsd.org/changeset/base/289027 > > > > Log: > > Merge: > > commit 400ecf36bb

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Andriy Gapon
On 08/10/2015 14:42, Craig Rodrigues wrote: > Author: rodrigc > Date: Thu Oct 8 11:42:15 2015 > New Revision: 289027 > URL: https://svnweb.freebsd.org/changeset/base/289027 > > Log: > Merge: > commit 400ecf36bb0b73f6390f9641e6cb8bbfb91a5cfd > Author: Paul Eggert > Date: Fri Oc

svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Craig Rodrigues
Author: rodrigc Date: Thu Oct 8 11:42:15 2015 New Revision: 289027 URL: https://svnweb.freebsd.org/changeset/base/289027 Log: Merge: commit 400ecf36bb0b73f6390f9641e6cb8bbfb91a5cfd Author: Paul Eggert Date: Fri Oct 12 07:53:12 2012 -0700 Assume C89. https://github