Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-18 Thread Hans Petter Selasky
Hi Konstantin, On 01/18/15 12:31, Konstantin Belousov wrote: On Sun, Jan 18, 2015 at 12:08:26PM +0100, Hans Petter Selasky wrote: Hi Konstantin, On 01/18/15 11:54, Konstantin Belousov wrote: On Fri, Jan 16, 2015 at 10:00:11AM +0100, Hans Petter Selasky wrote: Hi Konstantin, What about ev

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-18 Thread Konstantin Belousov
On Sun, Jan 18, 2015 at 12:08:26PM +0100, Hans Petter Selasky wrote: > Hi Konstantin, > > On 01/18/15 11:54, Konstantin Belousov wrote: > > On Fri, Jan 16, 2015 at 10:00:11AM +0100, Hans Petter Selasky wrote: > >> Hi Konstantin, > >> > >> On 01/16/15 09:03, Konstantin Belousov wrote: > >>> My opin

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-18 Thread Hans Petter Selasky
Hi Konstantin, On 01/18/15 11:54, Konstantin Belousov wrote: On Fri, Jan 16, 2015 at 10:00:11AM +0100, Hans Petter Selasky wrote: Hi Konstantin, On 01/16/15 09:03, Konstantin Belousov wrote: My opinion is that you should have tried to handle the issue at the driver level, instead of making th

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-18 Thread Konstantin Belousov
On Fri, Jan 16, 2015 at 10:00:11AM +0100, Hans Petter Selasky wrote: > Hi Konstantin, > > On 01/16/15 09:03, Konstantin Belousov wrote: > > My opinion is that you should have tried to handle the issue at the driver > > level, instead of making this devfs issue. I.e., if you already have > > cdev

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-16 Thread Hans Petter Selasky
Hi Konstantin, On 01/16/15 09:03, Konstantin Belousov wrote: On Thu, Jan 15, 2015 at 01:14:39PM +0100, Hans Petter Selasky wrote: On 01/15/15 12:51, Konstantin Belousov wrote: On Thu, Jan 15, 2015 at 11:49:09AM +0100, Hans Petter Selasky wrote: I see no leakage in that case either! Because

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-16 Thread Konstantin Belousov
On Thu, Jan 15, 2015 at 01:14:39PM +0100, Hans Petter Selasky wrote: > On 01/15/15 12:51, Konstantin Belousov wrote: > > On Thu, Jan 15, 2015 at 11:49:09AM +0100, Hans Petter Selasky wrote: > >> > >> I see no leakage in that case either! > > Because these cases come through destroy_dev(). > > > >>

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-15 Thread Hans Petter Selasky
On 01/15/15 12:51, Konstantin Belousov wrote: On Thu, Jan 15, 2015 at 11:49:09AM +0100, Hans Petter Selasky wrote: I see no leakage in that case either! Because these cases come through destroy_dev(). Are there more cases which I don't see? You are breaking existig devfs KPI by your hack.

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-15 Thread Konstantin Belousov
On Thu, Jan 15, 2015 at 11:49:09AM +0100, Hans Petter Selasky wrote: > On 01/15/15 10:38, Konstantin Belousov wrote: > > On Thu, Jan 15, 2015 at 08:41:31AM +0100, Hans Petter Selasky wrote: > >> On 01/15/15 04:31, Konstantin Belousov wrote: > >>> On Wed, Jan 14, 2015 at 10:07:13PM +, Hans Pette

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-15 Thread Hans Petter Selasky
On 01/15/15 10:38, Konstantin Belousov wrote: On Thu, Jan 15, 2015 at 08:41:31AM +0100, Hans Petter Selasky wrote: On 01/15/15 04:31, Konstantin Belousov wrote: On Wed, Jan 14, 2015 at 10:07:13PM +, Hans Petter Selasky wrote: Author: hselasky Date: Wed Jan 14 22:07:13 2015 New Revision: 27

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-15 Thread Konstantin Belousov
On Thu, Jan 15, 2015 at 08:41:31AM +0100, Hans Petter Selasky wrote: > On 01/15/15 04:31, Konstantin Belousov wrote: > > On Wed, Jan 14, 2015 at 10:07:13PM +, Hans Petter Selasky wrote: > >> Author: hselasky > >> Date: Wed Jan 14 22:07:13 2015 > >> New Revision: 277199 > >> URL: https://svnweb.

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-15 Thread Hans Petter Selasky
Hi, On 01/15/15 04:31, Konstantin Belousov wrote: Please do not commit (to devfs) without seeking for the review first. I was a bit stuck this time either having the choice to back out a USB patch fixing no problems or to fix the kernel devfs to support what I needed. Actually "devfs" is n

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-14 Thread Hans Petter Selasky
On 01/15/15 04:31, Konstantin Belousov wrote: On Wed, Jan 14, 2015 at 10:07:13PM +, Hans Petter Selasky wrote: Author: hselasky Date: Wed Jan 14 22:07:13 2015 New Revision: 277199 URL: https://svnweb.freebsd.org/changeset/base/277199 Log: Avoid race with "dev_rel()" when using the recent

Re: svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-14 Thread Konstantin Belousov
On Wed, Jan 14, 2015 at 10:07:13PM +, Hans Petter Selasky wrote: > Author: hselasky > Date: Wed Jan 14 22:07:13 2015 > New Revision: 277199 > URL: https://svnweb.freebsd.org/changeset/base/277199 > > Log: > Avoid race with "dev_rel()" when using the recently added > "delist_dev()" function

svn commit: r277199 - in head/sys: fs/devfs kern

2015-01-14 Thread Hans Petter Selasky
Author: hselasky Date: Wed Jan 14 22:07:13 2015 New Revision: 277199 URL: https://svnweb.freebsd.org/changeset/base/277199 Log: Avoid race with "dev_rel()" when using the recently added "delist_dev()" function. Make sure the character device structure doesn't go away until the end of the "de