Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus

2014-12-15 Thread Ed Maste
>> Also, not removing temporary files upon failure >> makes things easier to debug. > > +100 In general I agree completely. In this case though such a change would just create an empty temporary file upon failure, which provides no additional help in tracking down the failure over the "gperf: no

Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus

2014-12-15 Thread Alfred Perlstein
On 12/15/14 1:44 PM, Craig Rodrigues wrote: On Mon, Dec 15, 2014 at 1:38 PM, Ed Maste > wrote: > cfns.h: cfns.gperf > gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \ >${.ALLSRC} > ${.TARGET}_temp >

Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus

2014-12-15 Thread Craig Rodrigues
On Mon, Dec 15, 2014 at 1:38 PM, Ed Maste wrote: > > > > cfns.h: cfns.gperf > > gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \ > >${.ALLSRC} > ${.TARGET}_temp > >mv ${.TARGET}_temp ${.TARGET} > > Yeah. There are already examples of both approaches

Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus

2014-12-15 Thread Ed Maste
On 15 December 2014 at 16:04, Craig Rodrigues wrote: > > > On Mon, Dec 15, 2014 at 6:25 AM, Ed Maste wrote: >> >> cfns.h: cfns.gperf >> gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \ >> - ${.ALLSRC} > ${.TARGET} >> + ${.ALLSRC} > ${.TARGET} || (rm -f $

Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus

2014-12-15 Thread Craig Rodrigues
On Mon, Dec 15, 2014 at 6:25 AM, Ed Maste wrote: > > cfns.h: cfns.gperf > gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \ > - ${.ALLSRC} > ${.TARGET} > + ${.ALLSRC} > ${.TARGET} || (rm -f ${.TARGET}; false) > > Instead of removing the target you could ha

Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus

2014-12-15 Thread Ed Maste
On 15 December 2014 at 09:25, Ed Maste wrote: > Author: emaste > Date: Mon Dec 15 14:25:42 2014 > New Revision: 275804 > URL: https://svnweb.freebsd.org/changeset/base/275804 > > Log: > Remove empty generated file upon gperf failure >... > - ${.ALLSRC} > ${.TARGET} > + ${.ALL

svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus

2014-12-15 Thread Ed Maste
Author: emaste Date: Mon Dec 15 14:25:42 2014 New Revision: 275804 URL: https://svnweb.freebsd.org/changeset/base/275804 Log: Remove empty generated file upon gperf failure Prior to this change the build could fail as follows, if gperf is not available (or fails): - make(1) stops d