Re: svn commit: r275431 - in head/sys/dev: e1000 ixgbe

2014-12-02 Thread Alfred Perlstein
Thanks Jack. I do appreciate you reviewing the change and reconsidering the implementation. A few things to note please: 1) The work was submitted for approval, please check your inbox from ~3 weeks ago. I've attached the message for reference. 2) Regarding #2, in FreeBSD past silence, es

Re: svn commit: r275431 - in head/sys/dev: e1000 ixgbe

2014-12-02 Thread Jack Vogel
Just to make it clear, I am not opposed to what this code was trying to do, in fact I think its a pretty cool idea, but I think it can be implemented more cleanly. Eric and myself will be discussing the details. Jack On Tue, Dec 2, 2014 at 3:02 PM, Jack F Vogel wrote: > Author: jfv > Date: Tu

svn commit: r275431 - in head/sys/dev: e1000 ixgbe

2014-12-02 Thread Jack F Vogel
Author: jfv Date: Tue Dec 2 23:02:57 2014 New Revision: 275431 URL: https://svnweb.freebsd.org/changeset/base/275431 Log: Revert r275136, it was not approved, it was sloppy, if a feature like this is needed please resubmit for Intel's approval. Modified: head/sys/dev/e1000/if_igb.c head/