Re: svn commit: r273487 - head/sys/kern

2014-10-23 Thread Colin Percival
On 10/23/14 05:49, Jean-Sébastien Pédron wrote: > The following change triggers a kernel trap 12 when env is NULL: > >> @@ -260,8 +262,10 @@ void >> freeenv(char *env) >> { >> >> -if (dynamic_kenv) >> +if (dynamic_kenv) { >> +memset(env, 0, strlen(env)); >> fre

Re: svn commit: r273487 - head/sys/kern

2014-10-23 Thread Jean-Sébastien Pédron
Hi! The following change triggers a kernel trap 12 when env is NULL: > @@ -260,8 +262,10 @@ void > freeenv(char *env) > { > > - if (dynamic_kenv) > + if (dynamic_kenv) { > + memset(env, 0, strlen(env)); > free(env, M_KENV); > + } > } This happens very e

Re: svn commit: r273487 - head/sys/kern

2014-10-22 Thread Colin Percival
On 10/22/14 16:35, Colin Percival wrote: > Author: cperciva > Date: Wed Oct 22 23:35:32 2014 > New Revision: 273487 > URL: https://svnweb.freebsd.org/changeset/base/273487 > > Log: > Avoid leaking data from the kernel environment: When we convert the > initial static environment to a dynamic o

svn commit: r273487 - head/sys/kern

2014-10-22 Thread Colin Percival
Author: cperciva Date: Wed Oct 22 23:35:32 2014 New Revision: 273487 URL: https://svnweb.freebsd.org/changeset/base/273487 Log: Avoid leaking data from the kernel environment: When we convert the initial static environment to a dynamic one, zero the static environment buffer, and zero indivi