Re: svn commit: r258930 - head/sys/dev/drm2

2013-12-09 Thread Jean-Sébastien Pédron
Le 09/12/2013 22:46, John Baldwin a écrit : Ok, after looking at the original version of this function in Linux, it does read the capabilities from the parent bridge of the slot, not from the card itself, so your change is correct. Thank you for the review! -- Jean-Sébastien Pédron ___

Re: svn commit: r258930 - head/sys/dev/drm2

2013-12-09 Thread John Baldwin
On Friday, December 06, 2013 7:07:43 pm Jean-Sébastien Pédron wrote: > Le 05/12/2013 16:05, John Baldwin a écrit : > >>> Eh, vgapci is the right place to read this. The LINK_CAP here is telling > >>> you the width of the slot you are plugged into, not the width of the card > >>> that is plugged

Re: svn commit: r258930 - head/sys/dev/drm2

2013-12-06 Thread Jean-Sébastien Pédron
Le 05/12/2013 16:05, John Baldwin a écrit : Eh, vgapci is the right place to read this. The LINK_CAP here is telling you the width of the slot you are plugged into, not the width of the card that is plugged into the slot. I'm sorry, my knowledge of PCI is very limited (still learning) and I do

Re: svn commit: r258930 - head/sys/dev/drm2

2013-12-05 Thread John Baldwin
On Thursday, December 05, 2013 4:53:50 am Jean-Sébastien Pédron wrote: > On 04.12.2013 21:18, John Baldwin wrote: > > On Wednesday, December 04, 2013 2:04:57 pm Jean-Sebastien Pedron wrote: > >> Author: dumbbell > >> Date: Wed Dec 4 19:04:56 2013 > >> New Revision: 258930 > >> URL: http://svnweb.f

Re: svn commit: r258930 - head/sys/dev/drm2

2013-12-05 Thread Jean-Sébastien Pédron
On 04.12.2013 21:18, John Baldwin wrote: > On Wednesday, December 04, 2013 2:04:57 pm Jean-Sebastien Pedron wrote: >> Author: dumbbell >> Date: Wed Dec 4 19:04:56 2013 >> New Revision: 258930 >> URL: http://svnweb.freebsd.org/changeset/base/258930 >> >> Log: >> drm: Read PCIER_LINK_CAP/PCIER_LIN

Re: svn commit: r258930 - head/sys/dev/drm2

2013-12-04 Thread John Baldwin
On Wednesday, December 04, 2013 2:04:57 pm Jean-Sebastien Pedron wrote: > Author: dumbbell > Date: Wed Dec 4 19:04:56 2013 > New Revision: 258930 > URL: http://svnweb.freebsd.org/changeset/base/258930 > > Log: > drm: Read PCIER_LINK_CAP/PCIER_LINK_CAP2 from the PCI bridge > > Before this f

svn commit: r258930 - head/sys/dev/drm2

2013-12-04 Thread Jean-Sebastien Pedron
Author: dumbbell Date: Wed Dec 4 19:04:56 2013 New Revision: 258930 URL: http://svnweb.freebsd.org/changeset/base/258930 Log: drm: Read PCIER_LINK_CAP/PCIER_LINK_CAP2 from the PCI bridge Before this fix, capabilities were read from vgapci and were incorrect. Modified: head/sys/dev/drm2/