Re: svn commit: r256066 - head/sys/dev/virtio/network

2013-10-07 Thread Gleb Smirnoff
On Sun, Oct 06, 2013 at 01:12:06AM +0400, Alexander V. Chernikov wrote: A> On 05.10.2013 22:07, Bryan Venteicher wrote: A> > Author: bryanv A> > Date: Sat Oct 5 18:07:24 2013 A> > New Revision: 256066 A> > URL: http://svnweb.freebsd.org/changeset/base/256066 A> > A> > Log: A> > Do not hold the

Re: svn commit: r256066 - head/sys/dev/virtio/network

2013-10-06 Thread Bryan Venteicher
On Sun, Oct 6, 2013 at 7:23 AM, Kubilay Kocak wrote: > On 6/10/2013 5:07 AM, Bryan Venteicher wrote: > > Author: bryanv > > Date: Sat Oct 5 18:07:24 2013 > > New Revision: 256066 > > URL: http://svnweb.freebsd.org/changeset/base/256066 > > > > Log: > > Do not hold the vtnet Rx queue lock when c

Re: svn commit: r256066 - head/sys/dev/virtio/network

2013-10-06 Thread Bryan Venteicher
On Sat, Oct 5, 2013 at 4:12 PM, Alexander V. Chernikov wrote: > On 05.10.2013 22:07, Bryan Venteicher wrote: > > Author: bryanv > > Date: Sat Oct 5 18:07:24 2013 > > New Revision: 256066 > > URL: http://svnweb.freebsd.org/changeset/base/256066 > > > > Log: > > Do not hold the vtnet Rx queue lo

Re: svn commit: r256066 - head/sys/dev/virtio/network

2013-10-06 Thread Kubilay Kocak
On 6/10/2013 5:07 AM, Bryan Venteicher wrote: > Author: bryanv > Date: Sat Oct 5 18:07:24 2013 > New Revision: 256066 > URL: http://svnweb.freebsd.org/changeset/base/256066 > > Log: > Do not hold the vtnet Rx queue lock when calling up into the stack > > This matches other similar drivers

Re: svn commit: r256066 - head/sys/dev/virtio/network

2013-10-05 Thread Alexander V. Chernikov
On 05.10.2013 22:07, Bryan Venteicher wrote: > Author: bryanv > Date: Sat Oct 5 18:07:24 2013 > New Revision: 256066 > URL: http://svnweb.freebsd.org/changeset/base/256066 > > Log: > Do not hold the vtnet Rx queue lock when calling up into the stack Do you measure performance penalty for this?

svn commit: r256066 - head/sys/dev/virtio/network

2013-10-05 Thread Bryan Venteicher
Author: bryanv Date: Sat Oct 5 18:07:24 2013 New Revision: 256066 URL: http://svnweb.freebsd.org/changeset/base/256066 Log: Do not hold the vtnet Rx queue lock when calling up into the stack This matches other similar drivers and avoids various LOR warnings. Approved by: re (marius)