Re: svn commit: r254275 - head/sys/geom/raid

2013-08-13 Thread Poul-Henning Kamp
In message <5209f968.4090...@freebsd.org>, Alexander Motin writes: >On 13.08.2013 11:48, Andriy Gapon wrote: >> I'd like to stir a small (hopefully) discussion (again, hopefully): is EROFS >> appropriate here or would ENODEV be better? >> >> EROFSRead-only filesystem >> ENODEV Operat

Re: svn commit: r254275 - head/sys/geom/raid

2013-08-13 Thread Alexander Motin
On 13.08.2013 11:48, Andriy Gapon wrote: on 13/08/2013 10:56 Alexander Motin said the following: + /* Deny write opens for read-only volumes. */ + if (vol->v_read_only && acw > 0) { + error = EROFS; + goto out; + } I'd like to stir a small (hopeful

Re: svn commit: r254275 - head/sys/geom/raid

2013-08-13 Thread Andriy Gapon
on 13/08/2013 10:56 Alexander Motin said the following: > + /* Deny write opens for read-only volumes. */ > + if (vol->v_read_only && acw > 0) { > + error = EROFS; > + goto out; > + } I'd like to stir a small (hopefully) discussion (again, hopefully): is EROFS a

Re: svn commit: r254275 - head/sys/geom/raid

2013-08-13 Thread Peter Wemm
On Tue, Aug 13, 2013 at 12:56 AM, Alexander Motin wrote: > Log: > Return error when opening read-only volumes (like RAID4/5/...) for writing. > Previously opens succeeded, but actual write operations returned errors. > > Requested by: peter > MFC after:2 weeks Thanks! The read-only l

svn commit: r254275 - head/sys/geom/raid

2013-08-13 Thread Alexander Motin
Author: mav Date: Tue Aug 13 07:56:40 2013 New Revision: 254275 URL: http://svnweb.freebsd.org/changeset/base/254275 Log: Return error when opening read-only volumes (like RAID4/5/...) for writing. Previously opens succeeded, but actual write operations returned errors. Requested by: pete