Re: svn commit: r253210 - in head/sys: conf netinet

2013-07-15 Thread Andre Oppermann
On 15.07.2013 20:38, Mikolaj Golub wrote: On Mon, Jul 15, 2013 at 11:36:16AM +0200, Ulrich Spörlein wrote: Hey Andre, I don't see why this commit triggers it, but Coverity Scan found a new resource leak in this file. syncache_expand() will leak *s when line 1071 is reached. The "failed:" case b

Re: svn commit: r253210 - in head/sys: conf netinet

2013-07-15 Thread Mikolaj Golub
On Mon, Jul 15, 2013 at 11:36:16AM +0200, Ulrich Spörlein wrote: > Hey Andre, > > I don't see why this commit triggers it, but Coverity Scan found a new > resource leak in this file. syncache_expand() will leak *s when line > 1071 is reached. The "failed:" case below correctly frees the resources.

Re: svn commit: r253210 - in head/sys: conf netinet

2013-07-15 Thread Ulrich Spörlein
Hey Andre, I don't see why this commit triggers it, but Coverity Scan found a new resource leak in this file. syncache_expand() will leak *s when line 1071 is reached. The "failed:" case below correctly frees the resources. 1068/* how do we find the inp for the new socket? */ 22. Conditio

Re: svn commit: r253210 - in head/sys: conf netinet

2013-07-11 Thread Mikolaj Golub
Hi, Andre On Thu, Jul 11, 2013 at 03:29:25PM +, Andre Oppermann wrote: > Author: andre > Date: Thu Jul 11 15:29:25 2013 > New Revision: 253210 > URL: http://svnweb.freebsd.org/changeset/base/253210 > > Log: > Improve SYN cookies by encoding the MSS, WSCALE (window scaling) and SACK > info

svn commit: r253210 - in head/sys: conf netinet

2013-07-11 Thread Andre Oppermann
Author: andre Date: Thu Jul 11 15:29:25 2013 New Revision: 253210 URL: http://svnweb.freebsd.org/changeset/base/253210 Log: Improve SYN cookies by encoding the MSS, WSCALE (window scaling) and SACK information into the ISN (initial sequence number) without the additional use of timestamp bit