Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-09 Thread Bruce Evans
On Tue, 9 Jul 2013, Jim Harris wrote: On Sat, Jul 6, 2013 at 7:26 PM, Bruce Evans wrote: On Sat, 6 Jul 2013, Jilles Tjoelker wrote: On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote: [>]* ... Bruce, until sysexits(3) doesn't explicitly say it shouldn't be used, please

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-09 Thread Jim Harris
On Sat, Jul 6, 2013 at 7:26 PM, Bruce Evans wrote: > On Sat, 6 Jul 2013, Jilles Tjoelker wrote: > > On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote: >> >>> On Thu, Jul 04, 2013 at 11:44:28AM +1000, Bruce Evans wrote: >>> Many style bugs are visible in this patch: >>

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-07 Thread Bruce Evans
One minor interjection and I'll butt out of the discussion... In another thread involving Pawel, phk campaigns against errno and asks for error strings (even if they are only in English). Using perror() did this long ago for program termination, and using the err() family does it better

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-06 Thread Garrett Cooper
One minor interjection and I'll butt out of the discussion... Sent from my iPhone On Jul 6, 2013, at 7:26 PM, Bruce Evans wrote: > On Sat, 6 Jul 2013, Jilles Tjoelker wrote: > >> On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote: >>> On Thu, Jul 04, 2013 at 11:44:28AM +1000,

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-06 Thread Bruce Evans
On Sat, 6 Jul 2013, Jilles Tjoelker wrote: On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote: On Thu, Jul 04, 2013 at 11:44:28AM +1000, Bruce Evans wrote: Many style bugs are visible in this patch: [...] - sysexits.h is used [...] Bruce, until sysexits(3) doesn't explic

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-06 Thread Pawel Jakub Dawidek
On Sat, Jul 06, 2013 at 09:51:08PM +0200, Jilles Tjoelker wrote: > [...] Firstly, in some application areas like mail delivery, it is > conventional and documented to use and interpret sysexits codes. (So if > HAST uses sysexits, it should document that fact.) [...] The hastd daemon checks for EX_

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-06 Thread Jilles Tjoelker
On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote: > On Thu, Jul 04, 2013 at 11:44:28AM +1000, Bruce Evans wrote: > > Many style bugs are visible in this patch: > [...] > > - sysexits.h is used > [...] > Bruce, until sysexits(3) doesn't explicitly say it shouldn't be used, > plea

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-06 Thread Pawel Jakub Dawidek
On Thu, Jul 04, 2013 at 11:44:28AM +1000, Bruce Evans wrote: > Many style bugs are visible in this patch: [...] > - sysexits.h is used [...] Bruce, until sysexits(3) doesn't explicitly say it shouldn't be used, please stop calling this a bug, because you are just confusing people. At this point sy

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-03 Thread Bruce Evans
On Thu, 4 Jul 2013, Jim Harris wrote: Log: Fix printf argument mismatch reported by gcc on i386. This just substitutes one printf format with another. Modified: head/sbin/nvmecontrol/firmware.c == --- head/sbin/nvme

Re: svn commit: r252672 - head/sbin/nvmecontrol

2013-07-03 Thread Steve Kargl
On Thu, Jul 04, 2013 at 12:26:24AM +, Jim Harris wrote: > Author: jimharris > Date: Thu Jul 4 00:26:24 2013 > New Revision: 252672 > URL: http://svnweb.freebsd.org/changeset/base/252672 > > Log: > Fix printf argument mismatch reported by gcc on i386. > > Reported by: kargl > Thanks.

svn commit: r252672 - head/sbin/nvmecontrol

2013-07-03 Thread Jim Harris
Author: jimharris Date: Thu Jul 4 00:26:24 2013 New Revision: 252672 URL: http://svnweb.freebsd.org/changeset/base/252672 Log: Fix printf argument mismatch reported by gcc on i386. Reported by: kargl Modified: head/sbin/nvmecontrol/firmware.c Modified: head/sbin/nvmecontrol/firmware.c