Re: svn commit: r244732 - head/sys/sys

2012-12-28 Thread Gleb Smirnoff
On Fri, Dec 28, 2012 at 01:53:35PM +0100, Attilio Rao wrote: A> Did you also rewview the second patch I sent? I did. I just don't have anything to comment on it. I guess it is correct, and you should go forward with it. However, benchmarking of overall changes to the buf_ring is important. -- T

Re: svn commit: r244732 - head/sys/sys

2012-12-28 Thread Attilio Rao
On Fri, Dec 28, 2012 at 9:20 AM, Gleb Smirnoff wrote: > On Thu, Dec 27, 2012 at 08:37:24AM -0800, Attilio Rao wrote: > A> > Speaking of which, as you are here, I just found out that r241037 > A> > breaks the alignment of the structure. > A> > Infact the padding member is not updated accordingly. >

Re: svn commit: r244732 - head/sys/sys

2012-12-28 Thread Gleb Smirnoff
On Thu, Dec 27, 2012 at 08:37:24AM -0800, Attilio Rao wrote: A> > Speaking of which, as you are here, I just found out that r241037 A> > breaks the alignment of the structure. A> > Infact the padding member is not updated accordingly. A> > A> > We don't have a param to control L2 caches, but I thin

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 8:37 AM, Attilio Rao wrote: > On Thu, Dec 27, 2012 at 7:26 AM, Attilio Rao wrote: >> On Thu, Dec 27, 2012 at 5:53 AM, Attilio Rao wrote: >>> On Thu, Dec 27, 2012 at 5:25 AM, Gleb Smirnoff wrote: On Thu, Dec 27, 2012 at 04:55:22AM -0800, Attilio Rao wrote: A> On

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 7:26 AM, Attilio Rao wrote: > On Thu, Dec 27, 2012 at 5:53 AM, Attilio Rao wrote: >> On Thu, Dec 27, 2012 at 5:25 AM, Gleb Smirnoff wrote: >>> On Thu, Dec 27, 2012 at 04:55:22AM -0800, Attilio Rao wrote: >>> A> On Thu, Dec 27, 2012 at 4:46 AM, Gleb Smirnoff >>> wrote: >

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 5:53 AM, Attilio Rao wrote: > On Thu, Dec 27, 2012 at 5:25 AM, Gleb Smirnoff wrote: >> On Thu, Dec 27, 2012 at 04:55:22AM -0800, Attilio Rao wrote: >> A> On Thu, Dec 27, 2012 at 4:46 AM, Gleb Smirnoff >> wrote: >> A> > Attilio, >> A> > >> A> > On Thu, Dec 27, 2012 at 1

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 5:25 AM, Gleb Smirnoff wrote: > On Thu, Dec 27, 2012 at 04:55:22AM -0800, Attilio Rao wrote: > A> On Thu, Dec 27, 2012 at 4:46 AM, Gleb Smirnoff wrote: > A> > Attilio, > A> > > A> > On Thu, Dec 27, 2012 at 12:36:58PM +, Attilio Rao wrote: > A> > A> Author: attilio >

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Gleb Smirnoff
On Thu, Dec 27, 2012 at 04:55:22AM -0800, Attilio Rao wrote: A> On Thu, Dec 27, 2012 at 4:46 AM, Gleb Smirnoff wrote: A> > Attilio, A> > A> > On Thu, Dec 27, 2012 at 12:36:58PM +, Attilio Rao wrote: A> > A> Author: attilio A> > A> Date: Thu Dec 27 12:36:58 2012 A> > A> New Revision: 244732 A

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 4:46 AM, Gleb Smirnoff wrote: > Attilio, > > On Thu, Dec 27, 2012 at 12:36:58PM +, Attilio Rao wrote: > A> Author: attilio > A> Date: Thu Dec 27 12:36:58 2012 > A> New Revision: 244732 > A> URL: http://svnweb.freebsd.org/changeset/base/244732 > A> > A> Log: > A> br_

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Gleb Smirnoff
Attilio, On Thu, Dec 27, 2012 at 12:36:58PM +, Attilio Rao wrote: A> Author: attilio A> Date: Thu Dec 27 12:36:58 2012 A> New Revision: 244732 A> URL: http://svnweb.freebsd.org/changeset/base/244732 A> A> Log: A> br_prod_tail and br_cons_tail members are used as barrier to A> signal bug

svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
Author: attilio Date: Thu Dec 27 12:36:58 2012 New Revision: 244732 URL: http://svnweb.freebsd.org/changeset/base/244732 Log: br_prod_tail and br_cons_tail members are used as barrier to signal bug_ring ownership. However, instructions can be reordered around members write leading to stale v