Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-11 Thread Jaakko Heinonen
On 2013-01-09, Warner Losh wrote: > > I do not object, but IMHO having names with the spaces in /dev is weird > > and possibly problematic. I agree and my my preference was also to disallow spaces. However I expected that someone might complain. > > This was the reason of my initial request to >

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-09 Thread Warner Losh
On Jan 9, 2013, at 4:45 PM, Konstantin Belousov wrote: > On Wed, Jan 09, 2013 at 02:17:37PM -0500, John Baldwin wrote: >> On Tuesday, January 08, 2013 2:31:47 pm Jaakko Heinonen wrote: >>> On 2013-01-07, John Baldwin wrote: I think if it isn't hard to do so, we should aim to preserve labels

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-09 Thread Konstantin Belousov
On Wed, Jan 09, 2013 at 02:17:37PM -0500, John Baldwin wrote: > On Tuesday, January 08, 2013 2:31:47 pm Jaakko Heinonen wrote: > > On 2013-01-07, John Baldwin wrote: > > > I think if it isn't hard to do so, we should aim to preserve labels as > > > they > > > are generally intended to be human re

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-09 Thread John Baldwin
On Tuesday, January 08, 2013 2:31:47 pm Jaakko Heinonen wrote: > On 2013-01-07, John Baldwin wrote: > > I think if it isn't hard to do so, we should aim to preserve labels as they > > are generally intended to be human readable as-is. Just preserving spaces > > is > > probably sufficient for th

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-08 Thread Jaakko Heinonen
On 2013-01-07, John Baldwin wrote: > I think if it isn't hard to do so, we should aim to preserve labels as they > are generally intended to be human readable as-is. Just preserving spaces is > probably sufficient for this as they are probably the most commonly used > character in labels affect

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-07 Thread John Baldwin
On Saturday, January 05, 2013 04:22:52 AM Jaakko Heinonen wrote: > On 2013-01-04, John Baldwin wrote: > > > New Revision: 244585 > > > > > > Log: > > > Mangle label names containing spaces, non-printable characters '%' or > > > '"'. Mangling is only done for label names read from file system

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-05 Thread Pawel Jakub Dawidek
On Fri, Jan 04, 2013 at 12:24:03PM -0500, Nathan Whitehorn wrote: > On 01/04/13 12:18, John Baldwin wrote: > > On Saturday, December 22, 2012 08:43:12 AM Jaakko Heinonen wrote: > >> Author: jh > >> Date: Sat Dec 22 13:43:12 2012 > >> New Revision: 244585 > >> URL: http://svnweb.freebsd.org/changese

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-05 Thread Jaakko Heinonen
On 2013-01-04, John Baldwin wrote: > > New Revision: 244585 > > Log: > > Mangle label names containing spaces, non-printable characters '%' or > > '"'. Mangling is only done for label names read from file system > > metadata. Encoding resembles URL encoding. For example, the space > > char

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-04 Thread Nathan Whitehorn
On 01/04/13 12:18, John Baldwin wrote: > On Saturday, December 22, 2012 08:43:12 AM Jaakko Heinonen wrote: >> Author: jh >> Date: Sat Dec 22 13:43:12 2012 >> New Revision: 244585 >> URL: http://svnweb.freebsd.org/changeset/base/244585 >> >> Log: >> Mangle label names containing spaces, non-printa

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-04 Thread John Baldwin
On Saturday, December 22, 2012 08:43:12 AM Jaakko Heinonen wrote: > Author: jh > Date: Sat Dec 22 13:43:12 2012 > New Revision: 244585 > URL: http://svnweb.freebsd.org/changeset/base/244585 > > Log: > Mangle label names containing spaces, non-printable characters '%' or > '"'. Mangling is onl

svn commit: r244585 - in head: . sys/geom/label

2012-12-22 Thread Jaakko Heinonen
Author: jh Date: Sat Dec 22 13:43:12 2012 New Revision: 244585 URL: http://svnweb.freebsd.org/changeset/base/244585 Log: Mangle label names containing spaces, non-printable characters '%' or '"'. Mangling is only done for label names read from file system metadata. Encoding resembles URL en