Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Gleb Smirnoff
On Fri, Jul 27, 2012 at 11:30:58PM +1000, Bruce Evans wrote: B> > On Fri, Jul 27, 2012 at 10:32:55PM +1000, Bruce Evans wrote: B> > B> I just noticed that there is a technical problem -- the count is read B> > B> unlocked in the KASSERT. And since the comparision is for equality, B> > B> if you lo

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread David Xu
On 2012/7/27 21:30, Bruce Evans wrote: On Fri, 27 Jul 2012, Gleb Smirnoff wrote: On Fri, Jul 27, 2012 at 10:32:55PM +1000, Bruce Evans wrote: B> I just noticed that there is a technical problem -- the count is read B> unlocked in the KASSERT. And since the comparision is for equality, B> if yo

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Bruce Evans
On Fri, 27 Jul 2012, Gleb Smirnoff wrote: On Fri, Jul 27, 2012 at 10:32:55PM +1000, Bruce Evans wrote: B> I just noticed that there is a technical problem -- the count is read B> unlocked in the KASSERT. And since the comparision is for equality, B> if you lose the race reading the count when i

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Konstantin Belousov
On Fri, Jul 27, 2012 at 10:32:55PM +1000, Bruce Evans wrote: > On Fri, 27 Jul 2012, Gleb Smirnoff wrote: > > >On Fri, Jul 27, 2012 at 02:12:37PM +0300, Konstantin Belousov wrote: > >K> On Fri, Jul 27, 2012 at 09:16:48AM +, Gleb Smirnoff wrote: > >K> > ... > >K> > Log: > >K> > Add assertion f

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Gleb Smirnoff
On Fri, Jul 27, 2012 at 10:32:55PM +1000, Bruce Evans wrote: B> > On Fri, Jul 27, 2012 at 02:12:37PM +0300, Konstantin Belousov wrote: B> > K> On Fri, Jul 27, 2012 at 09:16:48AM +, Gleb Smirnoff wrote: B> > K> > ... B> > K> > Log: B> > K> > Add assertion for refcount overflow. B> > K> > B> >

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Bruce Evans
On Fri, 27 Jul 2012, Gleb Smirnoff wrote: On Fri, Jul 27, 2012 at 02:12:37PM +0300, Konstantin Belousov wrote: K> On Fri, Jul 27, 2012 at 09:16:48AM +, Gleb Smirnoff wrote: K> > ... K> > Log: K> > Add assertion for refcount overflow. K> > K> > Submitted by: Andrey Zonov K> > Revi

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Gleb Smirnoff
On Fri, Jul 27, 2012 at 02:12:37PM +0300, Konstantin Belousov wrote: K> On Fri, Jul 27, 2012 at 09:16:48AM +, Gleb Smirnoff wrote: K> > Author: glebius K> > Date: Fri Jul 27 09:16:48 2012 K> > New Revision: 238828 K> > URL: http://svn.freebsd.org/changeset/base/238828 K> > K> > Log: K> > Add

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Konstantin Belousov
On Fri, Jul 27, 2012 at 09:16:48AM +, Gleb Smirnoff wrote: > Author: glebius > Date: Fri Jul 27 09:16:48 2012 > New Revision: 238828 > URL: http://svn.freebsd.org/changeset/base/238828 > > Log: > Add assertion for refcount overflow. > > Submitted by: Andrey Zonov > Reviewed by:

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Bruce Evans
On Fri, 27 Jul 2012, Gleb Smirnoff wrote: Log: Add assertion for refcount overflow. Submitted by: Andrey Zonov Reviewed by: kib Modified: head/sys/sys/refcount.h Modified: head/sys/sys/refcount.h == --- head/s

svn commit: r238828 - head/sys/sys

2012-07-27 Thread Gleb Smirnoff
Author: glebius Date: Fri Jul 27 09:16:48 2012 New Revision: 238828 URL: http://svn.freebsd.org/changeset/base/238828 Log: Add assertion for refcount overflow. Submitted by: Andrey Zonov Reviewed by: kib Modified: head/sys/sys/refcount.h Modified: head/sys/sys/refcount.h ===