Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread Bruce Evans
On Wed, 23 May 2012, David O'Brien wrote: On Wed, May 23, 2012 at 01:49:45PM +0200, Dimitry Andric wrote: On 2012-05-22 20:18, David E. O'Brien wrote: Log: Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit platforms. ... Until all the additional warnings this causes hav

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread David O'Brien
On Tue, May 22, 2012 at 02:07:22PM -0700, m...@freebsd.org wrote: > We run with the following at Isilon, which is somewhat bogus because > it allows a bit of sloppiness in types, but is also terribly > convenient since it means no casting on printf arguments is needed: ... > If there's no objectio

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread David O'Brien
On Wed, May 23, 2012 at 01:49:45PM +0200, Dimitry Andric wrote: > On 2012-05-22 20:18, David E. O'Brien wrote: > > Log: > > Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit > > platforms. ... > Until all the additional warnings this causes have been fixed, can this > commit p

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread Dimitry Andric
On 2012-05-22 20:18, David E. O'Brien wrote: > Author: obrien > Date: Tue May 22 18:18:06 2012 > New Revision: 235797 > URL: http://svn.freebsd.org/changeset/base/235797 > > Log: > Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit > platforms. > > Modified: > head/contrib/

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread Bruce Evans
On Wed, 23 May 2012, Garrett Cooper wrote: On May 22, 2012, at 11:41 PM, Dimitry Andric wrote: On 2012-05-22 23:07, m...@freebsd.org wrote: ... We run with the following at Isilon, which is somewhat bogus because it allows a bit of sloppiness in types, but is also terribly convenient since i

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread Bruce Evans
On Tue, 22 May 2012, Marcel Moolenaar wrote: On May 22, 2012, at 2:07 PM, m...@freebsd.org wrote: On Tue, May 22, 2012 at 1:05 PM, Bruce Evans wrote: On Tue, 22 May 2012, David E. O'Brien wrote: Log: Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit platforms. I think

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread Bruce Evans
On Tue, 22 May 2012 g...@freebsd.org wrote: At Wed, 23 May 2012 06:05:06 +1000 (EST), Bruce Evans wrote: [... excessive quoting deleted] Now I prefer the old way, after fixing the bugs found by switching. It finds more bugs under FreeBSD, and is bug for bug compatible with distribution gcc a

Re: svn commit: r235797 - head/contrib/gcc

2012-05-23 Thread Garrett Cooper
On May 22, 2012, at 11:41 PM, Dimitry Andric wrote: > On 2012-05-22 23:07, m...@freebsd.org wrote: > ... >> We run with the following at Isilon, which is somewhat bogus because >> it allows a bit of sloppiness in types, but is also terribly >> convenient since it means no casting on printf argume

Re: svn commit: r235797 - head/contrib/gcc

2012-05-22 Thread Dimitry Andric
On 2012-05-22 23:07, m...@freebsd.org wrote: ... > We run with the following at Isilon, which is somewhat bogus because > it allows a bit of sloppiness in types, but is also terribly > convenient since it means no casting on printf arguments is needed: Please don't. If you want to write portable

Re: svn commit: r235797 - head/contrib/gcc

2012-05-22 Thread Marcel Moolenaar
On May 22, 2012, at 2:07 PM, m...@freebsd.org wrote: > On Tue, May 22, 2012 at 1:05 PM, Bruce Evans wrote: >> On Tue, 22 May 2012, David E. O'Brien wrote: >> >>> Log: >>> Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit >>> platforms. >> >> >> I think I like this, since i

Re: svn commit: r235797 - head/contrib/gcc

2012-05-22 Thread mdf
On Tue, May 22, 2012 at 1:05 PM, Bruce Evans wrote: > On Tue, 22 May 2012, David E. O'Brien wrote: > >> Log: >>  Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit >> platforms. > > > I think I like this, since it is technically correct, and will find a > different set of type mi

Re: svn commit: r235797 - head/contrib/gcc

2012-05-22 Thread gnn
At Wed, 23 May 2012 06:05:06 +1000 (EST), Bruce Evans wrote: > > On Tue, 22 May 2012, David E. O'Brien wrote: > > > Log: > > Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit > > platforms. > > I think I like this, since it is technically correct, and will find a > different

Re: svn commit: r235797 - head/contrib/gcc

2012-05-22 Thread Bruce Evans
On Tue, 22 May 2012, David E. O'Brien wrote: Log: Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit platforms. I think I like this, since it is technically correct, and will find a different set of type mismatches. Modified: head/contrib/gcc/c-format.c ===

svn commit: r235797 - head/contrib/gcc

2012-05-22 Thread David E. O'Brien
Author: obrien Date: Tue May 22 18:18:06 2012 New Revision: 235797 URL: http://svn.freebsd.org/changeset/base/235797 Log: Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit platforms. Modified: head/contrib/gcc/c-format.c Modified: head/contrib/gcc/c-format.c =