Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-04-14 Thread Mikolaj Golub
On Fri, 13 Apr 2012 09:11:39 +0300 Jaakko Heinonen wrote: JH> On 2012-01-23, Mikolaj Golub wrote: >> I see two issues with this patch: JH> What do you think about this patch? I think it is much better than we have currently :-). JH> %%% JH> Index: sys/fs/tmpfs/tmpfs.h JH> ===

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-04-12 Thread Jaakko Heinonen
On 2012-01-23, Mikolaj Golub wrote: > I see two issues with this patch: What do you think about this patch? %%% Index: sys/fs/tmpfs/tmpfs.h === --- sys/fs/tmpfs/tmpfs.h(revision 234201) +++ sys/fs/tmpfs/tmpfs.h(workin

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-24 Thread Jaakko Heinonen
On 2012-01-23, Mikolaj Golub wrote: > JH> Yes, the patch below does that. I suspect that flipping the MNT_RDONLY > JH> flag may be enough for tmpfs but I am not sure. > > I see two issues with this patch: > > 1) 'mount -u -o rw /mnt' does not upgrade to rw, although it returns success. Argh, t

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-24 Thread Kostik Belousov
On Mon, Jan 23, 2012 at 11:05:42PM +0200, Mikolaj Golub wrote: > > On Mon, 23 Jan 2012 17:34:57 +0200 Jaakko Heinonen wrote: > > JH> On 2012-01-22, Mikolaj Golub wrote: > >> Also, may be we should allow remounting ro (and may be some othe options) > for > >> tmpfs? > > JH> Yes, the patch be

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-23 Thread Mikolaj Golub
On Mon, 23 Jan 2012 17:34:57 +0200 Jaakko Heinonen wrote: JH> On 2012-01-22, Mikolaj Golub wrote: >> Also, may be we should allow remounting ro (and may be some othe options) >> for >> tmpfs? JH> Yes, the patch below does that. I suspect that flipping the MNT_RDONLY JH> flag may be enough

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-23 Thread Jaakko Heinonen
On 2012-01-22, Mikolaj Golub wrote: > Also, may be we should allow remounting ro (and may be some othe options) for > tmpfs? Yes, the patch below does that. I suspect that flipping the MNT_RDONLY flag may be enough for tmpfs but I am not sure. > JH> %%% > JH> Index: sys/fs/tmpfs/tmpfs_vfsops.c

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-22 Thread Mikolaj Golub
On Sun, 22 Jan 2012 15:42:18 +0200 Jaakko Heinonen wrote: JH> Hi, JH> On 2012-01-22, Mikolaj Golub wrote: >> JH> # mount -u -o ro /mnt >> JH> mount: tmpfs : Operation not supported >> JH> # mount -u -o ro,export /mnt >> JH> # >> >> There is no error but ro is still ignored, so this

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-22 Thread Kevin Lo
Jaakko Heinonen wrote: > Hi, Hi Jaakko, > On 2012-01-22, Mikolaj Golub wrote: > > JH> # mount -u -o ro /mnt > > JH> mount: tmpfs : Operation not supported > > JH> # mount -u -o ro,export /mnt > > JH> # > > > > There is no error but ro is still ignored, so this is only the issue with > > repo

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-22 Thread Jaakko Heinonen
Hi, On 2012-01-22, Mikolaj Golub wrote: > JH> # mount -u -o ro /mnt > JH> mount: tmpfs : Operation not supported > JH> # mount -u -o ro,export /mnt > JH> # > > There is no error but ro is still ignored, so this is only the issue with > reporting. Note, the code for nullfs (as an example) loo

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-22 Thread Mikolaj Golub
On Tue, 17 Jan 2012 19:10:31 +0200 Jaakko Heinonen wrote: JH> On 2012-01-17, Kevin Lo wrote: >> Return EOPNOTSUPP since we only support update mounts for NFS export. >> >> @@ -150,8 +150,12 @@ tmpfs_mount(struct mount *mp) >> return (EINVAL); >> >> if (mp->

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-17 Thread Jaakko Heinonen
On 2012-01-17, Kevin Lo wrote: > Return EOPNOTSUPP since we only support update mounts for NFS export. > > @@ -150,8 +150,12 @@ tmpfs_mount(struct mount *mp) > return (EINVAL); > > if (mp->mnt_flag & MNT_UPDATE) { > + /* > + * Only support update

svn commit: r230252 - head/sys/fs/tmpfs

2012-01-16 Thread Kevin Lo
Author: kevlo Date: Tue Jan 17 01:25:53 2012 New Revision: 230252 URL: http://svn.freebsd.org/changeset/base/230252 Log: Return EOPNOTSUPP since we only support update mounts for NFS export. Spotted by: trociny Modified: head/sys/fs/tmpfs/tmpfs_vfsops.c Modified: head/sys/fs/tmpfs/tmp