Re: svn commit: r229466 - head/usr.sbin/mptable

2012-01-07 Thread Pawel Jakub Dawidek
On Sat, Jan 07, 2012 at 02:58:34PM +0100, Ronald Klop wrote: > I don't know much about this code, but is chmod 0666 really wat is wanted > here (and in the commits following this one)? It makes the file world > writable. And that smells funny. :-) File permission during creation is always ANDe

Re: svn commit: r229466 - head/usr.sbin/mptable

2012-01-07 Thread Ronald Klop
I don't know much about this code, but is chmod 0666 really wat is wanted here (and in the commits following this one)? It makes the file world writable. And that smells funny. :-) Ronald. On Wed, 04 Jan 2012 08:04:44 +0100, Pawel Jakub Dawidek wrote: Author: pjd Date: Wed Jan 4 07:04

svn commit: r229466 - head/usr.sbin/mptable

2012-01-03 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Jan 4 07:04:43 2012 New Revision: 229466 URL: http://svn.freebsd.org/changeset/base/229466 Log: Add an missing argument to open(2). If O_CREAT flag is specified, file permission has to be specified as well. Modified: head/usr.sbin/mptable/mptable.c Modified: head/usr