PS: (review of the actual patch)
On Sun, 18 Dec 2011, Dimitry Andric wrote:
A better fix is to add explicit casts to the __bswap macros, as per
attached patch, which I'm running through a make universe now.
% diff --git a/sys/amd64/include/endian.h b/sys/amd64/include/endian.h
% index de22c8b
On Sun, 18 Dec 2011, Dimitry Andric wrote:
On 2011-12-18 02:39, David Schultz wrote:
...
Log:
Revert r228650, and work around the clang false positive with printf
formats in usr.bin/netstat/atalk.c by conditionally adding NO_WFORMAT to
the Makefile instead.
...
Have you been keeping tra
On 2011-12-18 02:41, David Schultz wrote:
...
> Sorry, one more: In less(1), you cast away a bunch of const qualifiers
> to fix some warnings, but that seems like a step in the wrong
> direction. The warnings were complaining about genuinely bad code.
> Disabling the warnings with casts doesn't m
On 2011-12-18 02:39, David Schultz wrote:
...
>>> Log:
>>> Revert r228650, and work around the clang false positive with printf
>>> formats in usr.bin/netstat/atalk.c by conditionally adding NO_WFORMAT to
>>> the Makefile instead.
...
> Have you been keeping track of the other hacks you've b
On Sat, Dec 17, 2011, David Schultz wrote:
> On Sat, Dec 17, 2011, Dimitry Andric wrote:
> > On 2011-12-17 23:32, Dimitry Andric wrote:
> > > Author: dim
> > > Date: Sat Dec 17 22:32:00 2011
> > > New Revision: 228668
> > > URL: http://svn.freebsd.org/changeset/base/228668
> > >
> > > Log:
> > >
On Sat, Dec 17, 2011, Dimitry Andric wrote:
> On 2011-12-17 23:32, Dimitry Andric wrote:
> > Author: dim
> > Date: Sat Dec 17 22:32:00 2011
> > New Revision: 228668
> > URL: http://svn.freebsd.org/changeset/base/228668
> >
> > Log:
> > Revert r228650, and work around the clang false positive wit
On 2011-12-17 23:32, Dimitry Andric wrote:
> Author: dim
> Date: Sat Dec 17 22:32:00 2011
> New Revision: 228668
> URL: http://svn.freebsd.org/changeset/base/228668
>
> Log:
> Revert r228650, and work around the clang false positive with printf
> formats in usr.bin/netstat/atalk.c by condition
Author: dim
Date: Sat Dec 17 22:32:00 2011
New Revision: 228668
URL: http://svn.freebsd.org/changeset/base/228668
Log:
Revert r228650, and work around the clang false positive with printf
formats in usr.bin/netstat/atalk.c by conditionally adding NO_WFORMAT to
the Makefile instead.
MFC
