Re: svn commit: r228625 - head/usr.bin/csup

2011-12-18 Thread Bruce Evans
On Sun, 18 Dec 2011, Dimitry Andric wrote: On 2011-12-18 00:49, m...@freebsd.org wrote: ... Also, long long is a bit of a hack that came in before C99 standardized on a few wider types, and the PRIu64 macros are really hideous. I agree they're ugly, but C99 should simply have defined length m

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Bruce Evans
On Sat, 17 Dec 2011 m...@freebsd.org wrote: On Sat, Dec 17, 2011 at 1:54 PM, Dimitry Andric wrote: On 2011-12-17 22:32, m...@freebsd.org wrote: ... ?In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the ?shared secret, and use long long format to snprintf a time_t. If casti

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Dimitry Andric
On 2011-12-18 00:49, m...@freebsd.org wrote: ... > Also, long long is a bit of a hack that came in before C99 > standardized on a few wider types, and the PRIu64 macros are really > hideous. I agree they're ugly, but C99 should simply have defined length modifiers for int64_t and friends, then the

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread mdf
On Sat, Dec 17, 2011 at 1:54 PM, Dimitry Andric wrote: > On 2011-12-17 22:32, m...@freebsd.org wrote: > ... >>>  In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the >>>  shared secret, and use long long format to snprintf a time_t. >> If casting is necessary, style prefers intm

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Bjoern A. Zeeb
On 17. Dec 2011, at 21:56 , Bjoern A. Zeeb wrote: > > On 17. Dec 2011, at 21:54 , Dimitry Andric wrote: > >> On 2011-12-17 22:32, m...@freebsd.org wrote: >> ... In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the shared secret, and use long long format to snprintf

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Bjoern A. Zeeb
On 17. Dec 2011, at 21:54 , Dimitry Andric wrote: > On 2011-12-17 22:32, m...@freebsd.org wrote: > ... >>> In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the >>> shared secret, and use long long format to snprintf a time_t. >> If casting is necessary, style prefers intmax_t o

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Dimitry Andric
On 2011-12-17 22:32, m...@freebsd.org wrote: ... >> In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the >> shared secret, and use long long format to snprintf a time_t. > If casting is necessary, style prefers intmax_t or uintmax_t, since > those are always wide enough. I don

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread mdf
On Sat, Dec 17, 2011 at 5:14 AM, Dimitry Andric wrote: > Author: dim > Date: Sat Dec 17 13:14:44 2011 > New Revision: 228625 > URL: http://svn.freebsd.org/changeset/base/228625 > > Log: >  In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the >  shared secret, and use long long f

svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 13:14:44 2011 New Revision: 228625 URL: http://svn.freebsd.org/changeset/base/228625 Log: In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the shared secret, and use long long format to snprintf a time_t. MFC after:1 week Modified: he