Re: svn commit: r227808 - head/lib/libc/string

2011-11-22 Thread Bruce Evans
On Tue, 22 Nov 2011, Eitan Adler wrote: Log: - add check for pointer equality prior to performing the O(n) pass This seems like a negative optimization. The pointers are unequal in the usual case. More seriously, it gives worse undefined behaviour when the pointers are invalid. E.g., strcm

svn commit: r227808 - head/lib/libc/string

2011-11-21 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Nov 22 00:07:53 2011 New Revision: 227808 URL: http://svn.freebsd.org/changeset/base/227808 Log: - add check for pointer equality prior to performing the O(n) pass - while here change 's' to 's1' in strcoll Submitted by: eadler@ Reviewed by: t