Re: svn commit: r226552 - head/sys/boot/zfs

2011-10-20 Thread Andriy Gapon
on 20/10/2011 12:35 Pawel Jakub Dawidek said the following: > On Thu, Oct 20, 2011 at 10:15:09AM +0300, Andriy Gapon wrote: >> I believe that this commit is incorrect. >> It does appear to do the right thing for raidz, but I believe that it breaks >> the >> simple case when v_read is vdev_read_phy

Re: svn commit: r226552 - head/sys/boot/zfs

2011-10-20 Thread Pawel Jakub Dawidek
On Thu, Oct 20, 2011 at 10:15:09AM +0300, Andriy Gapon wrote: > I believe that this commit is incorrect. > It does appear to do the right thing for raidz, but I believe that it breaks > the > simple case when v_read is vdev_read_phys. Now because the bp argument is not > NULL, the latter will try

Re: svn commit: r226552 - head/sys/boot/zfs

2011-10-20 Thread Andriy Gapon
on 20/10/2011 02:40 Pawel Jakub Dawidek said the following: > Author: pjd > Date: Wed Oct 19 23:40:37 2011 > New Revision: 226552 > URL: http://svn.freebsd.org/changeset/base/226552 > > Log: > Never pass NULL block pointer when reading. This is neither expected nor > handled by lower layers li

svn commit: r226552 - head/sys/boot/zfs

2011-10-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Oct 19 23:40:37 2011 New Revision: 226552 URL: http://svn.freebsd.org/changeset/base/226552 Log: Never pass NULL block pointer when reading. This is neither expected nor handled by lower layers like vdev_raidz, which uses bp for checksum verification. This bug could lea