Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-21 Thread Dag-Erling Smørgrav
Garrett Cooper writes: > This commit broke truss by changing the ioctlname API signature. Example: I didn't realize truss used code from kdump... Thanks for the patch. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-21 Thread Garrett Cooper
On Sat, Oct 8, 2011 at 5:47 AM, Dag-Erling Smorgrav wrote: > Author: des > Date: Sat Oct  8 12:47:00 2011 > New Revision: 226157 > URL: http://svn.freebsd.org/changeset/base/226157 > > Log: >  Bring ioctlname() in line with all the other *name() functions, which >  actually print the name (or the

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Garrett Cooper
2011/10/11 Dag-Erling Smørgrav : > Garrett Cooper writes: >> Seeing that you've committed quite a bit to kdump recently, could >> you please take a look at >> http://www.freebsd.org/cgi/query-pr.cgi?pr=161478 ? > > Hmm, did you run across this while testing your patch? > > % make > cc -O2 -pipe  -

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Garrett Cooper writes: > Seeing that you've committed quite a bit to kdump recently, could > you please take a look at > http://www.freebsd.org/cgi/query-pr.cgi?pr=161478 ? Hmm, did you run across this while testing your patch? % make cc -O2 -pipe -I/usr/src/usr.bin/kdump/../ktrace -I/usr/src/u

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Would you mind reviewing the attached patch, which cleans up ktrace(1)? DES -- Dag-Erling Smørgrav - d...@des.no Index: usr.bin/ktrace/ktrace.c === --- usr.bin/ktrace/ktrace.c (revision 226262) +++ usr.bin/ktrace/ktrace.c (working c

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Garrett Cooper
2011/10/11 Dag-Erling Smørgrav : > Garrett Cooper writes: >> Awesome! If you can find out where capname was at, I don't have an >> issue with re-adding that portion of the patch. The issue is that the >> compile fails with WARNS > 0 because it can't find the identifier in >> any of the included he

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Garrett Cooper writes: > Awesome! If you can find out where capname was at, I don't have an > issue with re-adding that portion of the patch. The issue is that the > compile fails with WARNS > 0 because it can't find the identifier in > any of the included headers (and it's new code because I had

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Garrett Cooper
2011/10/11 Dag-Erling Smørgrav : > Garrett Cooper writes: >>     Seeing that you've committed quite a bit to kdump recently, could >> you please take a look at >> http://www.freebsd.org/cgi/query-pr.cgi?pr=161478 ? > > Hmm, that patch actually removes code, but if the point is "make ktrace > and k

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Garrett Cooper writes: > Seeing that you've committed quite a bit to kdump recently, could > you please take a look at > http://www.freebsd.org/cgi/query-pr.cgi?pr=161478 ? Hmm, that patch actually removes code, but if the point is "make ktrace and kdump build at WARNS level 6", I'll take car

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Garrett Cooper
On Sat, Oct 8, 2011 at 5:47 AM, Dag-Erling Smorgrav wrote: > Author: des > Date: Sat Oct  8 12:47:00 2011 > New Revision: 226157 > URL: http://svn.freebsd.org/changeset/base/226157 > > Log: >  Bring ioctlname() in line with all the other *name() functions, which >  actually print the name (or the

svn commit: r226157 - head/usr.bin/kdump

2011-10-08 Thread Dag-Erling Smorgrav
Author: des Date: Sat Oct 8 12:47:00 2011 New Revision: 226157 URL: http://svn.freebsd.org/changeset/base/226157 Log: Bring ioctlname() in line with all the other *name() functions, which actually print the name (or the numeric value, if they can't figure out the correct name) instead of ju