Re: svn commit: r225947 - head/sys/netinet

2011-10-10 Thread Bjoern A. Zeeb
On 10. Oct 2011, at 08:44 , Qing Li wrote: Hey, > Okay, now I know what's confusing you ... it's that bug I introduced :-) > > The 2nd "if()" check on the RTF_GATEWAY flag should have been > an "else if()". > > In a nutshell, the logic is any indirect route should fail the check, > except for t

Re: svn commit: r225947 - head/sys/netinet

2011-10-10 Thread Qing Li
Okay, now I know what's confusing you ... it's that bug I introduced :-) The 2nd "if()" check on the RTF_GATEWAY flag should have been an "else if()". In a nutshell, the logic is any indirect route should fail the check, except for that special host route. Attached is the rework of that part of

Re: svn commit: r225947 - head/sys/netinet

2011-10-09 Thread Gleb Smirnoff
On Sun, Oct 09, 2011 at 10:11:56PM -0700, Qing Li wrote: Q> >  What confuses me most, is that in lines 1435-1445 you are Q> > assigning error to a positive value, BUT proceeding further Q> > with function. Q> Q>This is what was there before (meaning returning error immediately), Q>but I gu

Re: svn commit: r225947 - head/sys/netinet

2011-10-09 Thread Qing Li
Hi Gleb, > > On Mon, Oct 03, 2011 at 07:51:19PM +, Qing Li wrote: > Q> Author: qingli > Q> Date: Mon Oct  3 19:51:18 2011 > Q> New Revision: 225947 > Q> URL: http://svn.freebsd.org/changeset/base/225947 > Q> > Q> Log: > Q>   A system may have multiple physical interfaces, all of which are on t

Re: svn commit: r225947 - head/sys/netinet

2011-10-09 Thread Gleb Smirnoff
Qing, [cced Bjoern as reviewer] On Mon, Oct 03, 2011 at 07:51:19PM +, Qing Li wrote: Q> Author: qingli Q> Date: Mon Oct 3 19:51:18 2011 Q> New Revision: 225947 Q> URL: http://svn.freebsd.org/changeset/base/225947 Q> Q> Log: Q> A system may have multiple physical interfaces, all of whi

svn commit: r225947 - head/sys/netinet

2011-10-03 Thread Qing Li
Author: qingli Date: Mon Oct 3 19:51:18 2011 New Revision: 225947 URL: http://svn.freebsd.org/changeset/base/225947 Log: A system may have multiple physical interfaces, all of which are on the same prefix. Since a single route entry is installed for the prefix (without RADIX_MPATH), incomin