Re: svn commit: r223854 - head/lib/libstand

2011-07-10 Thread Warner Losh
On Jul 9, 2011, at 11:50 PM, Doug Barton wrote: > On 07/09/2011 22:25, Warner Losh wrote: >> Having the low WARNS= today motivates people to fix stuff... > > I see absolutely no evidence of that, but it's clear that your opinion > is not likely to change, so I'll leave it alone. As someone who

Re: svn commit: r223854 - head/lib/libstand

2011-07-09 Thread Doug Barton
On 07/09/2011 22:25, Warner Losh wrote: > Having the low WARNS= today motivates people to fix stuff... I see absolutely no evidence of that, but it's clear that your opinion is not likely to change, so I'll leave it alone. -- Nothin' ever doesn't change, but nothin' changes much.

Re: svn commit: r223854 - head/lib/libstand

2011-07-09 Thread Warner Losh
On Jul 9, 2011, at 11:01 PM, Doug Barton wrote: > On 07/08/2011 15:29, Warner Losh wrote: >> >> On Jul 8, 2011, at 2:25 AM, Craig Rodrigues wrote: >> >>> Hi, >>> >>> While not ideal, would it be possible consider setting WARNS to set >>> different levels >>> depending on what the value of ${MA

Re: svn commit: r223854 - head/lib/libstand

2011-07-09 Thread Doug Barton
On 07/08/2011 15:29, Warner Losh wrote: > > On Jul 8, 2011, at 2:25 AM, Craig Rodrigues wrote: > >> Hi, >> >> While not ideal, would it be possible consider setting WARNS to set >> different levels >> depending on what the value of ${MACHINE_ARCH} is? >> >> Something like: >> >> .if ${MACHINE_ARC

Re: svn commit: r223854 - head/lib/libstand

2011-07-08 Thread Warner Losh
On Jul 8, 2011, at 2:25 AM, Craig Rodrigues wrote: > Hi, > > While not ideal, would it be possible consider setting WARNS to set different > levels > depending on what the value of ${MACHINE_ARCH} is? > > Something like: > > .if ${MACHINE_ARCH} != "sparc64" (or whatever the correct value is)

Re: svn commit: r223854 - head/lib/libstand

2011-07-08 Thread Craig Rodrigues
Hi, While not ideal, would it be possible consider setting WARNS to set different levels depending on what the value of ${MACHINE_ARCH} is? Something like: .if ${MACHINE_ARCH} != "sparc64" (or whatever the correct value is) WARNS ?= 0 .else WARNS ?= 2 .endif This would at least be an attempt t

svn commit: r223854 - head/lib/libstand

2011-07-07 Thread Tai-hwa Liang
Author: avatar Date: Fri Jul 8 01:35:33 2011 New Revision: 223854 URL: http://svn.freebsd.org/changeset/base/223854 Log: Fixing building bustage on 32 bits platforms when WARNS >= 2. Note that this fix only applies to zalloc.c, the other part of libstand such like qdivrem.c still gives com