Re: svn commit: r223356 - head/sbin/geom/class/part

2011-06-21 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/20/11 23:23, Andrey V. Elsukov wrote: > On 21.06.2011 10:04, Xin LI wrote: Mod the offset padding by alignment. Without this change we may pad too much when underlying GEOM object have a zero stripesize. >> >>> No. In any way off

Re: svn commit: r223356 - head/sbin/geom/class/part

2011-06-20 Thread Andrey V. Elsukov
On 21.06.2011 10:04, Xin LI wrote: >>> Mod the offset padding by alignment. Without this change we may >>> pad too much when underlying GEOM object have a zero stripesize. > >> No. In any way offset value could not be greater than mediasize. > I don't think this changeset do anything with med

Re: svn commit: r223356 - head/sbin/geom/class/part

2011-06-20 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/20/11 22:03, Andrey V. Elsukov wrote: > On 21.06.2011 8:46, Xin LI wrote: >> Author: delphij >> Date: Tue Jun 21 04:46:00 2011 >> New Revision: 223356 >> URL: http://svn.freebsd.org/changeset/base/223356 >> >> Log: >> Mod the offset padding b

Re: svn commit: r223356 - head/sbin/geom/class/part

2011-06-20 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/20/11 22:03, Andrey V. Elsukov wrote: I don't think this changeset do anything with mediasize? No, an alignment value of 1 makes offset = 0, which is the intended behavior. Or did I misunderstood the code? Thanks in advance! - -- Xi

Re: svn commit: r223356 - head/sbin/geom/class/part

2011-06-20 Thread Andrey V. Elsukov
On 21.06.2011 8:46, Xin LI wrote: > Author: delphij > Date: Tue Jun 21 04:46:00 2011 > New Revision: 223356 > URL: http://svn.freebsd.org/changeset/base/223356 > > Log: > Mod the offset padding by alignment. Without this change we may > pad too much when underlying GEOM object have a zero str

svn commit: r223356 - head/sbin/geom/class/part

2011-06-20 Thread Xin LI
Author: delphij Date: Tue Jun 21 04:46:00 2011 New Revision: 223356 URL: http://svn.freebsd.org/changeset/base/223356 Log: Mod the offset padding by alignment. Without this change we may pad too much when underlying GEOM object have a zero stripesize. MFC after:1 month Modified: h