Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-15 Thread mdf
On Sat, Jan 15, 2011 at 7:06 PM, Bruce Evans wrote: > On Sat, 15 Jan 2011 m...@freebsd.org wrote: >> On Sat, Jan 15, 2011 at 6:55 AM, Bruce Evans wrote: > >> The printing is done entirely in user-space, so it's not too bad.  I >> had figured to upcast everything to [u]intmax_t anyways, and what t

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-15 Thread Bruce Evans
On Sat, 15 Jan 2011 m...@freebsd.org wrote: On Sat, Jan 15, 2011 at 6:55 AM, Bruce Evans wrote: SYSCTL_I() works even better that I first thought. ?It automatically gives support for all typedefed integral types. ?No SYSCTL_FOO_T()s ... Grrr, my sentence breaks of 2 spaces are being echoed

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-15 Thread mdf
On Sat, Jan 15, 2011 at 6:55 AM, Bruce Evans wrote: > On Sat, 15 Jan 2011, Garrett Cooper wrote: > >> On Fri, Jan 14, 2011 at 10:27 PM, Bruce Evans >> wrote: >>> >>> On Fri, 14 Jan 2011, Garrett Cooper wrote: >>> On Fri, Jan 14, 2011 at 6:42 PM, Bruce Evans wrote: > > ... > Oop

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-15 Thread Bruce Evans
On Sat, 15 Jan 2011, Garrett Cooper wrote: On Fri, Jan 14, 2011 at 10:27 PM, Bruce Evans wrote: On Fri, 14 Jan 2011, Garrett Cooper wrote: On Fri, Jan 14, 2011 at 6:42 PM, Bruce Evans wrote: ... Oops. ?I think sizeof() and issigned() can be used to determine the type well enough in funct

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-15 Thread Garrett Cooper
On Fri, Jan 14, 2011 at 10:27 PM, Bruce Evans wrote: > On Fri, 14 Jan 2011, Garrett Cooper wrote: > >> On Fri, Jan 14, 2011 at 6:42 PM, Bruce Evans wrote: >>> >>> On Fri, 14 Jan 2011 m...@freebsd.org wrote: >>> On Thu, Jan 13, 2011 at 10:50 PM, Bruce Evans wrote: > > On Thu, 13

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-14 Thread Bruce Evans
On Fri, 14 Jan 2011, Garrett Cooper wrote: On Fri, Jan 14, 2011 at 6:42 PM, Bruce Evans wrote: On Fri, 14 Jan 2011 m...@freebsd.org wrote: On Thu, Jan 13, 2011 at 10:50 PM, Bruce Evans wrote: On Thu, 13 Jan 2011 m...@freebsd.org wrote: There appear to be 330 uses of SYSCTL and QUAD on t

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-14 Thread Bruce Evans
On Fri, 14 Jan 2011 m...@freebsd.org wrote: On Thu, Jan 13, 2011 at 9:56 PM, Bruce Evans wrote: Now with stricter type checking, even formats for integers are redundant. The CTLTYPE now always matches the type, and the format should always match the type. ?The space wasted for the format is 1

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-14 Thread Garrett Cooper
On Fri, Jan 14, 2011 at 6:42 PM, Bruce Evans wrote: > On Fri, 14 Jan 2011 m...@freebsd.org wrote: > >> On Thu, Jan 13, 2011 at 10:50 PM, Bruce Evans >> wrote: >>> >>> On Thu, 13 Jan 2011 m...@freebsd.org wrote: >>> There appear to be 330 uses of SYSCTL and QUAD on the same line in CURRE

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-14 Thread Bruce Evans
On Fri, 14 Jan 2011 m...@freebsd.org wrote: On Thu, Jan 13, 2011 at 10:50 PM, Bruce Evans wrote: On Thu, 13 Jan 2011 m...@freebsd.org wrote: There appear to be 330 uses of SYSCTL and QUAD on the same line in CURRENT. ?This seems reasonable to change them to S64, U64 and X64 so they correctly

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-14 Thread mdf
On Thu, Jan 13, 2011 at 9:56 PM, Bruce Evans wrote: > On Thu, 13 Jan 2011, Matthew D Fleming wrote: > >> Log: >>  Add a 64-bit hex-printed sysctl(9) since there is at least one place in >>  the code that wanted it.  It is named X64 rather than XQUAD since the >>  quad name is a historical abominat

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-14 Thread mdf
On Thu, Jan 13, 2011 at 10:50 PM, Bruce Evans wrote: > On Thu, 13 Jan 2011 m...@freebsd.org wrote: > >> There appear to be 330 uses of SYSCTL and QUAD on the same line in >> CURRENT.  This seems reasonable to change them to S64, U64 and X64 so >> they correctly reflect the size they operate upon.

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-13 Thread Bruce Evans
On Thu, 13 Jan 2011 m...@freebsd.org wrote: There appear to be 330 uses of SYSCTL and QUAD on the same line in CURRENT. This seems reasonable to change them to S64, U64 and X64 so they correctly reflect the size they operate upon. What do y'all think? Now I suggest delaying this until they c

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-13 Thread Bruce Evans
On Thu, 13 Jan 2011, Matthew D Fleming wrote: Log: Add a 64-bit hex-printed sysctl(9) since there is at least one place in the code that wanted it. It is named X64 rather than XQUAD since the quad name is a historical abomination that should not be perpetuated. :-). It is only long long t

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-13 Thread mdf
There appear to be 330 uses of SYSCTL and QUAD on the same line in CURRENT. This seems reasonable to change them to S64, U64 and X64 so they correctly reflect the size they operate upon. What do y'all think? Thanks, matthew On Thu, Jan 13, 2011 at 10:20 AM, Matthew D Fleming wrote: > Author: m

svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-13 Thread Matthew D Fleming
Author: mdf Date: Thu Jan 13 18:20:33 2011 New Revision: 217369 URL: http://svn.freebsd.org/changeset/base/217369 Log: Add a 64-bit hex-printed sysctl(9) since there is at least one place in the code that wanted it. It is named X64 rather than XQUAD since the quad name is a historical abomi