Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Anonymous
Garrett Cooper writes: > On Jan 6, 2011, at 2:41 PM, Alexander Best wrote: > >> On Fri Jan 7 11, Anonymous wrote: >>> Alexander Best writes: >>> On Thu Jan 6 11, John Baldwin wrote: > Note that that usage is rather pointless since it means you apply rtprio > to > the 'rtpri

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Garrett Cooper
On Jan 6, 2011, at 2:41 PM, Alexander Best wrote: > On Fri Jan 7 11, Anonymous wrote: >> Alexander Best writes: >> >>> On Thu Jan 6 11, John Baldwin wrote: Note that that usage is rather pointless since it means you apply rtprio to the 'rtprio' process that is about to exit. :

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Alexander Best
On Fri Jan 7 11, Anonymous wrote: > Alexander Best writes: > > > On Thu Jan 6 11, John Baldwin wrote: > >> Note that that usage is rather pointless since it means you apply rtprio > >> to > >> the 'rtprio' process that is about to exit. :) > > > > yeah but at least it makes the usage of -X co

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Anonymous
Alexander Best writes: > On Thu Jan 6 11, John Baldwin wrote: >> Note that that usage is rather pointless since it means you apply rtprio to >> the 'rtprio' process that is about to exit. :) > > yeah but at least it makes the usage of -X consistent. ;) also consider the > following: the current

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Alexander Best
On Thu Jan 6 11, Alexander Best wrote: > On Tue Jan 4 11, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Jan 4 14:13:09 2011 > > New Revision: 216955 > > URL: http://svn.freebsd.org/changeset/base/216955 > > > > Log: > > Make the parsing of the integer arguments for rtprio(1)/idprio

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Alexander Best
On Tue Jan 4 11, Konstantin Belousov wrote: > Author: kib > Date: Tue Jan 4 14:13:09 2011 > New Revision: 216955 > URL: http://svn.freebsd.org/changeset/base/216955 > > Log: > Make the parsing of the integer arguments for rtprio(1)/idprio(1) stricter. > Style. here's a patch with some chang

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Alexander Best
On Thu Jan 6 11, John Baldwin wrote: > On Thursday, January 06, 2011 4:10:17 pm Alexander Best wrote: > > On Thu Jan 6 11, Garrett Cooper wrote: > > > On Thu, Jan 6, 2011 at 12:41 PM, Alexander Best > wrote: > > > > > > ... > > > > > > > this causes problems when pid is -0: > > > > > > > > [i

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread John Baldwin
On Thursday, January 06, 2011 4:10:17 pm Alexander Best wrote: > On Thu Jan 6 11, Garrett Cooper wrote: > > On Thu, Jan 6, 2011 at 12:41 PM, Alexander Best wrote: > > > > ... > > > > > this causes problems when pid is -0: > > > > > > [id|rt]prio -t -0 and [id|rt]prio 10 -0 will try to run "0"

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Alexander Best
On Thu Jan 6 11, Alexander Best wrote: > On Thu Jan 6 11, Garrett Cooper wrote: > > On Thu, Jan 6, 2011 at 12:41 PM, Alexander Best wrote: > > > > ... > > > > > this causes problems when pid is -0: > > > > > > [id|rt]prio -t -0 and [id|rt]prio 10 -0 will try to run "0" via execvp(). > > > befo

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Garrett Cooper
On Thu, Jan 6, 2011 at 1:10 PM, Alexander Best wrote: > On Thu Jan  6 11, Garrett Cooper wrote: >> On Thu, Jan 6, 2011 at 12:41 PM, Alexander Best wrote: >> >> ... >> >> > this causes problems when pid is -0: >> > >> > [id|rt]prio -t -0 and [id|rt]prio 10 -0 will try to run "0" via execvp(). >> >

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Alexander Best
On Thu Jan 6 11, Alexander Best wrote: > On Tue Jan 4 11, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Jan 4 14:13:09 2011 > > New Revision: 216955 > > URL: http://svn.freebsd.org/changeset/base/216955 > > > > Log: > > Make the parsing of the integer arguments for rtprio(1)/idprio

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Alexander Best
On Thu Jan 6 11, Garrett Cooper wrote: > On Thu, Jan 6, 2011 at 12:41 PM, Alexander Best wrote: > > ... > > > this causes problems when pid is -0: > > > > [id|rt]prio -t -0 and [id|rt]prio 10 -0 will try to run "0" via execvp(). > > beforehand however this will also trigger rtprio(). > > > > a

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Garrett Cooper
On Thu, Jan 6, 2011 at 12:41 PM, Alexander Best wrote: ... > this causes problems when pid is -0: > > [id|rt]prio -t -0 and [id|rt]prio 10 -0 will try to run "0" via execvp(). > beforehand however this will also trigger rtprio(). > > a better solution would be to do: > >                if (argv[

Re: svn commit: r216955 - head/usr.sbin/rtprio

2011-01-06 Thread Alexander Best
On Tue Jan 4 11, Konstantin Belousov wrote: > Author: kib > Date: Tue Jan 4 14:13:09 2011 > New Revision: 216955 > URL: http://svn.freebsd.org/changeset/base/216955 > > Log: > Make the parsing of the integer arguments for rtprio(1)/idprio(1) stricter. > Style. > > Based on submission by

svn commit: r216955 - head/usr.sbin/rtprio

2011-01-04 Thread Konstantin Belousov
Author: kib Date: Tue Jan 4 14:13:09 2011 New Revision: 216955 URL: http://svn.freebsd.org/changeset/base/216955 Log: Make the parsing of the integer arguments for rtprio(1)/idprio(1) stricter. Style. Based on submission by: Eitan Adler , keramida Reviewed by: jhb, keramida MF