Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread Dag-Erling Smørgrav
Kostik Belousov writes: > This is easy to fix, isn't it ? But there seems to be much more nits. > > First, allocating 512 * sizeof(char *)-byte object on the stack is not > good. > > Second, the initialization of iov_len for reading the array > of string pointers misses '* sizeof(char *)'. > > And

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread John Baldwin
On Friday, September 24, 2010 9:32:15 am Kostik Belousov wrote: > On Fri, Sep 24, 2010 at 08:34:16AM -0400, John Baldwin wrote: > > On Friday, September 24, 2010 7:53:11 am Kostik Belousov wrote: > > > On Fri, Sep 24, 2010 at 02:17:29PM +0400, pluknet wrote: > > > > On 16 September 2010 11:56, Dag-

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread Kostik Belousov
On Fri, Sep 24, 2010 at 08:34:16AM -0400, John Baldwin wrote: > On Friday, September 24, 2010 7:53:11 am Kostik Belousov wrote: > > On Fri, Sep 24, 2010 at 02:17:29PM +0400, pluknet wrote: > > > On 16 September 2010 11:56, Dag-Erling Smorgrav wrote: > > > > Author: des > > > > Date: Thu Sep 16 07:

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread John Baldwin
On Friday, September 24, 2010 7:53:11 am Kostik Belousov wrote: > On Fri, Sep 24, 2010 at 02:17:29PM +0400, pluknet wrote: > > On 16 September 2010 11:56, Dag-Erling Smorgrav wrote: > > > Author: des > > > Date: Thu Sep 16 07:56:34 2010 > > > New Revision: 212723 > > > URL: http://svn.freebsd.org/

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread Kostik Belousov
On Fri, Sep 24, 2010 at 04:24:18PM +0400, pluknet wrote: > 2010/9/24 Kostik Belousov : > > On Fri, Sep 24, 2010 at 02:17:29PM +0400, pluknet wrote: > >> On 16 September 2010 11:56, Dag-Erling Smorgrav wrote: > >> > Author: des > >> > Date: Thu Sep 16 07:56:34 2010 > >> > New Revision: 212723 > >>

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread pluknet
2010/9/24 Kostik Belousov : > On Fri, Sep 24, 2010 at 02:17:29PM +0400, pluknet wrote: >> On 16 September 2010 11:56, Dag-Erling Smorgrav wrote: >> > Author: des >> > Date: Thu Sep 16 07:56:34 2010 >> > New Revision: 212723 >> > URL: http://svn.freebsd.org/changeset/base/212723 >> > >> > Log: >> >

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread Kostik Belousov
On Fri, Sep 24, 2010 at 02:17:29PM +0400, pluknet wrote: > On 16 September 2010 11:56, Dag-Erling Smorgrav wrote: > > Author: des > > Date: Thu Sep 16 07:56:34 2010 > > New Revision: 212723 > > URL: http://svn.freebsd.org/changeset/base/212723 > > > > Log: > >  Implement proc/$$/environment. > > >

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread pluknet
On 16 September 2010 11:56, Dag-Erling Smorgrav wrote: > Author: des > Date: Thu Sep 16 07:56:34 2010 > New Revision: 212723 > URL: http://svn.freebsd.org/changeset/base/212723 > > Log: >  Implement proc/$$/environment. > [...] >  /* >  * Filler function for proc/pid/environ >  */ >  static int >

svn commit: r212723 - head/sys/compat/linprocfs

2010-09-16 Thread Dag-Erling Smorgrav
Author: des Date: Thu Sep 16 07:56:34 2010 New Revision: 212723 URL: http://svn.freebsd.org/changeset/base/212723 Log: Implement proc/$$/environment. Submitted by: Fernando Apesteguía MFC after:3 weeks Modified: head/sys/compat/linprocfs/linprocfs.c Modified: head/sys/compat/linp